samples/damon: a typo in the kconfig - sameple
Subsystems (2)
PATCH 1/1 samples/damon: a typo in the kconfig - sameple
---
Hi SeongJae Park,
I found a trivial typo in the Kconfig file of the damon sample module while I was trying to do some experiments with sample codes.
The word "sameple" should be "sample", I believe. Please find the diff below.
Since the title should follow the format of the project, I sent a new email to the mailing list. Sorry for the inconvenience.
Thanks for the interesting project! DAMON will be very useful for many projects.
Thanks,
Ps: I found I didn't change the subject! Sorry this is my very first communication with the project.
samples/damon/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
samples/damon/Kconfig +2 -2
@@ -3,7 +3,7 @@ menu "DAMON Samples" config SAMPLE_DAMON_WSSE - bool "DAMON sameple module for working set size estimation" + bool "DAMON sample module for working set size estimation" depends on DAMON && DAMON_VADDR help This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE If unsure, say N. config SAMPLE_DAMON_PRCL - bool "DAMON sameple module for access-aware proactive reclamation" + bool "DAMON sample module for access-aware proactive reclamation" depends on DAMON && DAMON_VADDR help This builds DAMON sample module for access-aware proactive
Signature · 1 line
2.47.2
Hi bus710,
Quoted 1 line · On Mon, 24 Feb 2025 10:07:09 -0800 bus710 <[email protected]> wrote:
Signed-off-by bus710 <[email protected]>
Thank you for this fix!
Quoted 6 lines
---
Hi SeongJae Park,I found a trivial typo in the
Kconfigfile of the damon sample module while I was trying to do some experiments with sample codes.
The word "sameple" should be "sample", I believe. Please find the diff below.
I think the above sentence is better to be added to the "Explanation Body"[1] part of this patch. This shouldn't be a blocker of this patch though, since it is very simple. Please consider doing so if you have a chance to send another patch in future, though.
Quoted 11 lines
Since the title should follow the format of the project, I sent a new email to the mailing list. Sorry for the inconvenience.
Thanks for the interesting project! DAMON will be very useful for many projects.
Thanks,
Ps: I found I didn't change the subject! Sorry this is my very first communication with the project.
No worry, everyone makes mistakes, like I made the typo! ;) Thank you for finding and fixing mine!
[1] https://docs.kernel.org/process/submitting-patches.html#explanation-body
Thanks,
SJ
Quoted 29 lines
samples/damon/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)samples/damon/Kconfig +2
-2@@ -3,7 +3,7 @@ menu "DAMON Samples" config SAMPLE_DAMON_WSSE - bool "DAMON sameple module for working set size estimation" + bool "DAMON sample module for working set size estimation" depends on DAMON && DAMON_VADDR help This builds DAMON sample module for working set size estimation.@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE If unsure, say N. config SAMPLE_DAMON_PRCL - bool "DAMON sameple module for access-aware proactive reclamation" + bool "DAMON sample module for access-aware proactive reclamation" depends on DAMON && DAMON_VADDR help This builds DAMON sample module for access-aware proactiveSignature · 1 line
2.47.2
PATCH 1/1 samples/damon: a typo in the kconfig - sameple
Hi SeongJae Park,
I found a trivial typo in the Kconfig file of the damon sample module while I was trying to do some experiments with sample codes. The word "sameple" should be "sample", I believe.
Please find the diff below.
Since the title should follow the format of the project, I sent a new email to the mailing list. Sorry for the inconvenience.
Thanks for the interesting project! DAMON will be very useful for many projects.
Thanks,
Ps: I found I didn't change the subject! Sorry this is my very first communication with the project.
Ps2: I see. It should go over my signature. Good to know for future.
---
samples/damon/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
samples/damon/Kconfig +2 -2
@@ -3,7 +3,7 @@ menu "DAMON Samples" config SAMPLE_DAMON_WSSE - bool "DAMON sameple module for working set size estimation" + bool "DAMON sample module for working set size estimation" depends on DAMON && DAMON_VADDR help This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE If unsure, say N. config SAMPLE_DAMON_PRCL - bool "DAMON sameple module for access-aware proactive reclamation" + bool "DAMON sample module for access-aware proactive reclamation" depends on DAMON && DAMON_VADDR help This builds DAMON sample module for access-aware proactive
Signature · 1 line
2.47.2
SeongJae Park
maintainerHi bus710,
Thank you again for your nice patch, but I think you're not very used to the normal process of Linux kernel development. Let me give you some comments about that.
Firstly, if you post a new version of a patch, please add the version number on the subject[1].
Quoted 7 lines · On Mon, 24 Feb 2025 12:06:55 -0800 bus710 <[email protected]> wrote:
Hi SeongJae Park,
I found a trivial typo in the
Kconfigfile of the damon sample module while I was trying to do some experiments with sample codes. The word "sameple" should be "sample", I believe.
Please find the diff below.
Quoted 7 lines
Since the title should follow the format of the project, I sent a new email to the mailing list. Sorry for the inconvenience.
Thanks for the interesting project! DAMON will be very useful for many projects.
Thanks,
You are using explanation body as a mixture of the two different parts. Please refer to the documentation[2] about "explanation body" and "commentary" parts of patches for more details about what to put on where.
Quoted 6 lines
Ps: I found I didn't change the subject! Sorry this is my very first communication with the project.
Ps2: I see. It should go over my signature. Good to know for future.
If you want to reply to some of my comments, please reply as a normal email with inline commenting style, not as a new version of a patch having Ps sections.
Quoted 2 lines
Signed-off-by bus710 <[email protected]>
Finally, please collect 'Reviewed-by:' like tags you received from the previous version of the patch if possible.
Because I already gave you my Reviewed-by: tag, I don't think you need to continue revising this patch.
I'd also highly recommend you the entire documentation of patches submission.
[1] https://docs.kernel.org/process/submitting-patches.html#subject-line
[2] https://docs.kernel.org/process/submitting-patches.html#explanation-body
[3] https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Thanks,
SJ
[...]
SeongJae Park
maintainerOn Mon, 24 Feb 2025 13:35:23 -0800 SeongJae Park <[email protected]> wrote:
[...]
Quoted 3 lines
If you want to reply to some of my comments, please reply as a normal email with inline commenting style, not as a new version of a patch having Ps sections.
Btw, sometimes sending patches is easier than sending a reply mail, due to lack of tools or some environmental restrictions. If you're having the tool issue, please feel free to try hkml[1].
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#mailing-tool
Thanks,
SJ
[...]