Skip to contentSkip to conversation

VRAM Self Refresh

RFC In review Anshuman Gupta 7 participants 28 messages Feb 24, 2025 – Apr 1, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover VRAM Self Refresh

Enabling VRAM Self Refresh on Intel BMG GPU. VRAM Self Refresh feature requires XeKMD
to request for D3Cold Aux Power Limit and PERST Assertion Delay by calling _DSM 10 and _DSM 11 method.

Reference: PCI Firmware Specification Section {4.6.10, 4.6.11}.

Anshuman Gupta (5):
PCI/ACPI: Implement PCI FW _DSM method drm/xe/vrsr: Detect vrsr capability drm/xe/vrsr: Refactor d3cold.allowed to a enum drm/xe/pm: D3Cold target state drm/xe/vrsr: Enable VRSR

Badal Nilawar (1):
drm/xe/vrsr: Apis to init and enable VRSR feature

 drivers/gpu/drm/xe/display/xe_display.c |  22 +++
 drivers/gpu/drm/xe/display/xe_display.h |   1 +
 drivers/gpu/drm/xe/regs/xe_regs.h       |   3 +
 drivers/gpu/drm/xe/xe_device_types.h    |  10 +-
 drivers/gpu/drm/xe/xe_pci.c             |   4 +-
 drivers/gpu/drm/xe/xe_pcode_api.h       |   8 +
 drivers/gpu/drm/xe/xe_pm.c              | 185 ++++++++++++++++++++++--
 drivers/gpu/drm/xe/xe_pm.h              |   9 ++
 drivers/pci/pci-acpi.c                  | 123 ++++++++++++++++
 include/linux/pci-acpi.h                |  13 ++
 10 files changed, 358 insertions(+), 20 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

RFC 1/6 PCI/ACPI: Implement PCI FW _DSM method

Implement _DSM method 10 and _DSM Method 11 as per PCI firmware specs section 4.6.10 and 4.6.11.

Current assumption is only one PCIe Endpoint driver (XeKMD for Battlemage GPU) will request for Aux Power Limit under a given Root Port but theoretically it is possible that other Non-Intel GPU or Non-GPU PCIe Endpoint driver can also request for Aux Power Limit and request to block the core power removal under same Root Port.
That will disrupt the Battlemage GPU VRAM Self Refresh.

One possible mitigation would be only allowing only first PCIe Non-Bridge Endpoint Function 0 driver to call_DSM method 10.

---
 drivers/pci/pci-acpi.c   | 123 +++++++++++++++++++++++++++++++++++++++
 include/linux/pci-acpi.h |  13 +++++
 2 files changed, 136 insertions(+)
drivers/pci/pci-acpi.c +123 -0
index af370628e583..806f6d19f46c 100644
@@ -1421,6 +1421,129 @@ static void pci_acpi_optimize_delay(struct pci_dev *pdev,
 	ACPI_FREE(obj);
 }
 
+/**
+ * pci_acpi_request_d3cold_aux_power - Request D3cold auxiliary power via ACPI DSM
+ * @dev: PCI device instance
+ * @requested_power: Requested auxiliary power in milliwatts
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM Function 9 to grant
+ * the required D3Cold Auxiliary power for the specified PCI device.
+ * It evaluates the _DSM (Device Specific Method) to request the Auxiliary power and
+ * handles the response accordingly.
+ *
+ * This function shall be only called by 1st non-bridge Endpoint driver on Function 0.
+ * For a Multi-Function Device, the driver for Function 0 is required to report an
+ * aggregate power requirement covering all functions contained within the device.
+ *
+ * Return: Returns 0 on success and errno on failure.
+ */
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
+{
+	union acpi_object in_obj = {
+		.integer.type = ACPI_TYPE_INTEGER,
+		.integer.value = requested_power,
+	};
+
+	union acpi_object *out_obj;
+	acpi_handle handle;
+	int result, ret = -EINVAL;
+
+	if (!dev || !ACPI_HANDLE(&dev->dev))
+		return -EINVAL;
+
+	handle = ACPI_HANDLE(&dev->dev);
+
+	out_obj = acpi_evaluate_dsm_typed(handle,
+					  &pci_acpi_dsm_guid,
+					  4,
+					  DSM_PCI_D3COLD_AUX_POWER_LIMIT,
+					  &in_obj,
+					  ACPI_TYPE_INTEGER);
+	if (!out_obj)
+		return -EINVAL;
+
+	result = out_obj->integer.value;
+
+	switch (result) {
+	case 0x0:
+		dev_dbg(&dev->dev, "D3cold Aux Power request denied.\n");
+		break;
+	case 0x1:
+		dev_info(&dev->dev, "D3cold Aux Power request granted: %u mW.\n", requested_power);
+		ret = 0;
+		break;
+	case 0x2:
+		dev_info(&dev->dev, "D3cold Aux Power: Main power will not be removed.\n");
+		ret = -EBUSY;
+		break;
+	default:
+		if (result >= 0x11 && result <= 0x1F) {
+			int retry_interval = result & 0xF;
+
+			dev_warn(&dev->dev,
+				 "D3cold Aux Power request needs retry. Interval: %d seconds.\n", retry_interval);
+			msleep(retry_interval * 1000);
+			ret = -EAGAIN;
+		} else {
+			dev_err(&dev->dev, "D3cold Aux Power: Reserved or unsupported response: 0x%x.\n", result);
+		}
+		break;
+	}
+
+	ACPI_FREE(out_obj);
+	return ret;
+}
+EXPORT_SYMBOL(pci_acpi_request_d3cold_aux_power);
+
+/**
+ * pci_acpi_add_perst_assertion_delay - Request PERST delay via ACPI DSM
+ * @dev: PCI device instance
+ * @delay_us: Requested delay_us
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM to grant the required
+ * PERST dealy for the specified PCI device. It evaluates the _DSM (Device
+ * Specific Method) to request the PERST delay and handles the response accordingly.
+ *
+ * Return: returns 0 on success and errno on failure.
+ */
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
+{
+	union acpi_object in_obj = {
+		.integer.type = ACPI_TYPE_INTEGER,
+		.integer.value = delay_us,
+	};
+
+	union acpi_object *out_obj;
+	acpi_handle handle;
+	int result, ret = -EINVAL;
+
+	if (!dev || !ACPI_HANDLE(&dev->dev))
+		return -EINVAL;
+
+	handle = ACPI_HANDLE(&dev->dev);
+
+	out_obj = acpi_evaluate_dsm_typed(handle, &pci_acpi_dsm_guid, 4,
+					  DSM_PCI_PERST_ASSERTION_DELAY, &in_obj, ACPI_TYPE_INTEGER);
+	if (!out_obj)
+		return -EINVAL;
+
+	result = out_obj->integer.value;
+
+	if (result == delay_us) {
+		dev_info(&dev->dev, "PERST# Assertion Delay set to %u microseconds.\n", delay_us);
+		ret = 0;
+	} else if (result == 0) {
+		dev_warn(&dev->dev, "PERST# Assertion Delay request failed, no previous valid request.\n");
+	} else {
+		dev_warn(&dev->dev,
+			 "PERST# Assertion Delay request failed. Previous valid delay: %u microseconds.\n", result);
+	}
+
+	ACPI_FREE(out_obj);
+	return ret;
+}
+EXPORT_SYMBOL(pci_acpi_add_perst_assertion_delay);
+
 static void pci_acpi_set_external_facing(struct pci_dev *dev)
 {
 	u8 val;
include/linux/pci-acpi.h +13 -0
index 078225b514d4..4b7373f91a9a 100644
@@ -121,6 +121,8 @@ extern const guid_t pci_acpi_dsm_guid;
 #define DSM_PCI_DEVICE_NAME			0x07
 #define DSM_PCI_POWER_ON_RESET_DELAY		0x08
 #define DSM_PCI_DEVICE_READINESS_DURATIONS	0x09
+#define DSM_PCI_D3COLD_AUX_POWER_LIMIT		0x0A
+#define DSM_PCI_PERST_ASSERTION_DELAY		0x0B
 
 #ifdef CONFIG_PCIE_EDR
 void pci_acpi_add_edr_notifier(struct pci_dev *pdev);
@@ -132,10 +134,21 @@ static inline void pci_acpi_remove_edr_notifier(struct pci_dev *pdev) { }
 
 int pci_acpi_set_companion_lookup_hook(struct acpi_device *(*func)(struct pci_dev *));
 void pci_acpi_clear_companion_lookup_hook(void);
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power);
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us);
 
 #else	/* CONFIG_ACPI */
 static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
 static inline void acpi_pci_remove_bus(struct pci_bus *bus) { }
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
+{
+	return -EOPNOTSUPP;
+}
+
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
+{
+	return -EOPNOTSUPP;
+}
 #endif	/* CONFIG_ACPI */
 
 #endif	/* _PCI_ACPI_H_ */
Signature · 1 line
2.34.1
#2 lore raw

Re: [RFC 1/6] PCI/ACPI: Implement PCI FW _DSM method

Quoted 2 lines · Anshuman Gupta

Implement _DSM method 10 and _DSM Method 11 as per PCI firmware specs section 4.6.10 and 4.6.11.

Please split into two patches, one for each _DSM. Include spec citations, e.g., PCI Firmware r3.3, sec 4.6.10. Section numbers are not guaranteed to stay consistent across spec revisions, so we need both the revision and section number.

Include some descriptive words about the DSM in each subject line, e.g., "D3cold Aux Power Limit", "PERST# Assertion Delay".

Quoted 6 lines

Current assumption is only one PCIe Endpoint driver (XeKMD for Battlemage GPU) will request for Aux Power Limit under a given Root Port but theoretically it is possible that other Non-Intel GPU or Non-GPU PCIe Endpoint driver can also request for Aux Power Limit and request to block the core power removal under same Root Port.
That will disrupt the Battlemage GPU VRAM Self Refresh.

I guess this is sort of an acknowledgement of the r3.3, sec 4.6.10 spec text about system software being responsible for tracking and aggregating requests when there are multiple functions below the Downstream Port?

If so, remove the Battlemage-specific language and just say something about the fact that this implementation doesn't do any of that tracking and aggregation.

Quoted 2 lines

One possible mitigation would be only allowing only first PCIe Non-Bridge Endpoint Function 0 driver to call_DSM method 10.

Wrap to fill 75 columns in commit logs. Add blank lines between paragraphs.

Quoted 19 lines
---
 drivers/pci/pci-acpi.c   | 123 +++++++++++++++++++++++++++++++++++++++
 include/linux/pci-acpi.h |  13 +++++
 2 files changed, 136 insertions(+)
drivers/pci/pci-acpi.c +3 -0
index af370628e583..806f6d19f46c 100644
@@ -1421,6 +1421,129 @@ static void pci_acpi_optimize_delay(struct pci_dev *pdev,
 	ACPI_FREE(obj);
 }
 
+/**
+ * pci_acpi_request_d3cold_aux_power - Request D3cold auxiliary power via ACPI DSM
+ * @dev: PCI device instance

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1436

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+ * @requested_power: Requested auxiliary power in milliwatts
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM Function 9 to grant
+ * the required D3Cold Auxiliary power for the specified PCI device.
+ * It evaluates the _DSM (Device Specific Method) to request the Auxiliary power and
+ * handles the response accordingly.
+ *
+ * This function shall be only called by 1st non-bridge Endpoint driver on Function 0.
+ * For a Multi-Function Device, the driver for Function 0 is required to report an
+ * aggregate power requirement covering all functions contained within the device.

Wrap to fit in 80 columns like the rest of the file.

Quoted 14 lines
drivers/pci/pci-acpi.c +14 -0
+ * Return: Returns 0 on success and errno on failure.
+ */
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
+{
+	union acpi_object in_obj = {
+		.integer.type = ACPI_TYPE_INTEGER,
+		.integer.value = requested_power,
+	};
+
+	union acpi_object *out_obj;
+	acpi_handle handle;
+	int result, ret = -EINVAL;
+
+	if (!dev || !ACPI_HANDLE(&dev->dev))

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1461

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+		return -EINVAL;
+
+	handle = ACPI_HANDLE(&dev->dev);
+
+	out_obj = acpi_evaluate_dsm_typed(handle,
+					  &pci_acpi_dsm_guid,
+					  4,
+					  DSM_PCI_D3COLD_AUX_POWER_LIMIT,
+					  &in_obj,
+					  ACPI_TYPE_INTEGER);

Wrap to fill 78-80 columns.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1469

Quoted 8 lines
drivers/pci/pci-acpi.c +8 -0
+	if (!out_obj)
+		return -EINVAL;
+
+	result = out_obj->integer.value;
+
+	switch (result) {
+	case 0x0:
+		dev_dbg(&dev->dev, "D3cold Aux Power request denied.\n");

Include requested_power here too, for debugging purposes.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1476

Quoted 7 lines
drivers/pci/pci-acpi.c +7 -0
+		break;
+	case 0x1:
+		dev_info(&dev->dev, "D3cold Aux Power request granted: %u mW.\n", requested_power);
+		ret = 0;
+		break;
+	case 0x2:
+		dev_info(&dev->dev, "D3cold Aux Power: Main power will not be removed.\n");

No periods at end of messages.

Quoted 19 lines
drivers/pci/pci-acpi.c +19 -0
+		ret = -EBUSY;
+		break;
+	default:
+		if (result >= 0x11 && result <= 0x1F) {
+			int retry_interval = result & 0xF;
+
+			dev_warn(&dev->dev,
+				 "D3cold Aux Power request needs retry. Interval: %d seconds.\n", retry_interval);
+			msleep(retry_interval * 1000);
+			ret = -EAGAIN;
+		} else {
+			dev_err(&dev->dev, "D3cold Aux Power: Reserved or unsupported response: 0x%x.\n", result);
+		}
+		break;
+	}
+
+	ACPI_FREE(out_obj);
+	return ret;
+}

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1505

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+EXPORT_SYMBOL(pci_acpi_request_d3cold_aux_power);
+
+/**
+ * pci_acpi_add_perst_assertion_delay - Request PERST delay via ACPI DSM
+ * @dev: PCI device instance
+ * @delay_us: Requested delay_us
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM to grant the required
+ * PERST dealy for the specified PCI device. It evaluates the _DSM (Device
+ * Specific Method) to request the PERST delay and handles the response accordingly.

s/PERST/PERST#/
s/dealy/delay/

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+ * Return: returns 0 on success and errno on failure.
+ */
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
+{
+	union acpi_object in_obj = {
+		.integer.type = ACPI_TYPE_INTEGER,
+		.integer.value = delay_us,
+	};
+
+	union acpi_object *out_obj;

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1526

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+	acpi_handle handle;
+	int result, ret = -EINVAL;
+
+	if (!dev || !ACPI_HANDLE(&dev->dev))
+		return -EINVAL;
+
+	handle = ACPI_HANDLE(&dev->dev);
+
+	out_obj = acpi_evaluate_dsm_typed(handle, &pci_acpi_dsm_guid, 4,
+					  DSM_PCI_PERST_ASSERTION_DELAY, &in_obj, ACPI_TYPE_INTEGER);

Wrap to fit in 78-80 columns.

Quoted 61 lines
drivers/pci/pci-acpi.c +20 -0
+	if (!out_obj)
+		return -EINVAL;
+
+	result = out_obj->integer.value;
+
+	if (result == delay_us) {
+		dev_info(&dev->dev, "PERST# Assertion Delay set to %u microseconds.\n", delay_us);
+		ret = 0;
+	} else if (result == 0) {
+		dev_warn(&dev->dev, "PERST# Assertion Delay request failed, no previous valid request.\n");
+	} else {
+		dev_warn(&dev->dev,
+			 "PERST# Assertion Delay request failed. Previous valid delay: %u microseconds.\n", result);
+	}
+
+	ACPI_FREE(out_obj);
+	return ret;
+}
+EXPORT_SYMBOL(pci_acpi_add_perst_assertion_delay);
+
 static void pci_acpi_set_external_facing(struct pci_dev *dev)
 {
 	u8 val;
include/linux/pci-acpi.h +13 -0
index 078225b514d4..4b7373f91a9a 100644
@@ -121,6 +121,8 @@ extern const guid_t pci_acpi_dsm_guid;
 #define DSM_PCI_DEVICE_NAME			0x07
 #define DSM_PCI_POWER_ON_RESET_DELAY		0x08
 #define DSM_PCI_DEVICE_READINESS_DURATIONS	0x09
+#define DSM_PCI_D3COLD_AUX_POWER_LIMIT		0x0A
+#define DSM_PCI_PERST_ASSERTION_DELAY		0x0B
 
 #ifdef CONFIG_PCIE_EDR
 void pci_acpi_add_edr_notifier(struct pci_dev *pdev);
@@ -132,10 +134,21 @@ static inline void pci_acpi_remove_edr_notifier(struct pci_dev *pdev) { }
 
 int pci_acpi_set_companion_lookup_hook(struct acpi_device *(*func)(struct pci_dev *));
 void pci_acpi_clear_companion_lookup_hook(void);
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power);
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us);
 
 #else	/* CONFIG_ACPI */
 static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
 static inline void acpi_pci_remove_bus(struct pci_bus *bus) { }
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
+{
+	return -EOPNOTSUPP;
+}
+
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
+{
+	return -EOPNOTSUPP;
+}
 #endif	/* CONFIG_ACPI */
 
 #endif	/* _PCI_ACPI_H_ */
Signature · 1 line
2.34.1
#3 lore raw

RE: [RFC 1/6] PCI/ACPI: Implement PCI FW _DSM method

Quoted 34 lines

-----Original Message-----
From: Bjorn Helgaas <[email protected]>
Sent: Tuesday, February 25, 2025 1:11 AM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; De Marchi, Lucas <[email protected]>; Vivi, Rodrigo <[email protected]>; Nilawar, Badal <[email protected]>; Nasim, Kam <[email protected]>; Gupta, Varun <[email protected]>
Subject: Re: [RFC 1/6] PCI/ACPI: Implement PCI FW _DSM method

Quoted 1 line · Anshuman Gupta

Implement _DSM method 10 and _DSM Method 11 as per PCI firmware

specs

Quoted 1 line

section 4.6.10 and 4.6.11.

Please split into two patches, one for each _DSM. Include spec citations, e.g., PCI Firmware r3.3, sec 4.6.10. Section numbers are not guaranteed to stay consistent across spec revisions, so we need both the revision and section number.

Include some descriptive words about the DSM in each subject line, e.g., "D3cold Aux Power Limit", "PERST# Assertion Delay".

Quoted 6 lines

Current assumption is only one PCIe Endpoint driver (XeKMD for Battlemage GPU) will request for Aux Power Limit under a given Root Port but theoretically it is possible that other Non-Intel GPU or Non-GPU PCIe Endpoint driver can also request for Aux Power Limit and request to block the core power removal under same Root Port. That will disrupt the Battlemage GPU VRAM Self Refresh.

Quoted 3 lines

I guess this is sort of an acknowledgement of the r3.3, sec 4.6.10 spec text about system software being responsible for tracking and aggregating requests when there are multiple functions below the Downstream Port?

Thanks for review comment.
AFAIU apart from multiple function below the Downstream Port (from same PCIe Card), there can be possibility of another PCie card connected via a switch to same root port like below topology.

			                 |-> PCIe PCIe Downstream Port -> End Point Device 	
Root Port -> PCIe Upstream Port   |-> PCIe PCIe Downstream Port -> End Point Device	
			                 |-> PCIe PCIe Downstream Port -> PCIe Upstream Port ->  PCIe Downstream Port -> *EndPoint Device 	

*Endpoint Device from different PCIe card can also request to block the core power removal under same Root Port ?
How to document such limitation ?

Thanks,
Anshuman

Quoted 231 lines

If so, remove the Battlemage-specific language and just say something about the fact that this implementation doesn't do any of that tracking and aggregation.

Quoted 2 lines

One possible mitigation would be only allowing only first PCIe Non-Bridge Endpoint Function 0 driver to call_DSM method 10.

Wrap to fill 75 columns in commit logs. Add blank lines between paragraphs.

Quoted 5 lines
---
 drivers/pci/pci-acpi.c   | 123

+++++++++++++++++++++++++++++++++++++++

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct

Quoted 8 lines
 include/linux/pci-acpi.h |  13 +++++
 2 files changed, 136 insertions(+)
drivers/pci/pci-acpi.c index renamed from drivers/pci/pci-acpi.c +0 -0

af370628e583..806f6d19f46c 100644

drivers/pci/pci-acpi.c +0 -0
@@ -1421,6 +1421,129 @@ static void pci_acpi_optimize_delay(struct

pci_dev *pdev,

Quoted 7 lines
drivers/pci/pci-acpi.c +4 -0
 	ACPI_FREE(obj);
 }
 
+/**
+ * pci_acpi_request_d3cold_aux_power - Request D3cold auxiliary power
+via ACPI DSM
+ * @dev: PCI device instance

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+ * @requested_power: Requested auxiliary power in milliwatts
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM
+Function 9 to grant
+ * the required D3Cold Auxiliary power for the specified PCI device.
+ * It evaluates the _DSM (Device Specific Method) to request the
+Auxiliary power and
+ * handles the response accordingly.
+ *
+ * This function shall be only called by 1st non-bridge Endpoint driver on

Function 0.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct · line 1440

Quoted 3 lines
drivers/pci/pci-acpi.c +3 -0
+ * For a Multi-Function Device, the driver for Function 0 is required
+to report an
+ * aggregate power requirement covering all functions contained within the

device.

Wrap to fit in 80 columns like the rest of the file.

Quoted 12 lines
drivers/pci/pci-acpi.c +12 -0
+ * Return: Returns 0 on success and errno on failure.
+ */
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32
+requested_power) {
+	union acpi_object in_obj = {
+		.integer.type = ACPI_TYPE_INTEGER,
+		.integer.value = requested_power,
+	};
+
+	union acpi_object *out_obj;
+	acpi_handle handle;
+	int result, ret = -EINVAL;

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1464

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+
+	if (!dev || !ACPI_HANDLE(&dev->dev))
+		return -EINVAL;
+
+	handle = ACPI_HANDLE(&dev->dev);
+
+	out_obj = acpi_evaluate_dsm_typed(handle,
+					  &pci_acpi_dsm_guid,
+					  4,
+

DSM_PCI_D3COLD_AUX_POWER_LIMIT,

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1461

Quoted 2 lines
drivers/pci/pci-acpi.c +2 -0
+					  &in_obj,
+					  ACPI_TYPE_INTEGER);

Wrap to fill 78-80 columns.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev, · line 1469

Quoted 8 lines
drivers/pci/pci-acpi.c +8 -0
+	if (!out_obj)
+		return -EINVAL;
+
+	result = out_obj->integer.value;
+
+	switch (result) {
+	case 0x0:
+		dev_dbg(&dev->dev, "D3cold Aux Power request denied.\n");

Include requested_power here too, for debugging purposes.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 3 lines
drivers/pci/pci-acpi.c +3 -0
+		break;
+	case 0x1:
+		dev_info(&dev->dev, "D3cold Aux Power request granted: %u

mW.\n", requested_power);

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 4 lines
drivers/pci/pci-acpi.c +4 -0
+		ret = 0;
+		break;
+	case 0x2:
+		dev_info(&dev->dev, "D3cold Aux Power: Main power will not

be

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct · line 1480

Quoted 1 line
drivers/pci/pci-acpi.c +1 -0
+removed.\n");

No periods at end of messages.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 8 lines
drivers/pci/pci-acpi.c +8 -0
+		ret = -EBUSY;
+		break;
+	default:
+		if (result >= 0x11 && result <= 0x1F) {
+			int retry_interval = result & 0xF;
+
+			dev_warn(&dev->dev,
+				 "D3cold Aux Power request needs retry.

Interval: %d seconds.\n", retry_interval);

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 4 lines
drivers/pci/pci-acpi.c +4 -0
+			msleep(retry_interval * 1000);
+			ret = -EAGAIN;
+		} else {
+			dev_err(&dev->dev, "D3cold Aux Power: Reserved or

unsupported response: 0x%x.\n", result);

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+		}
+		break;
+	}
+
+	ACPI_FREE(out_obj);
+	return ret;
+}
+EXPORT_SYMBOL(pci_acpi_request_d3cold_aux_power);
+
+/**

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+ * pci_acpi_add_perst_assertion_delay - Request PERST delay via ACPI
+DSM
+ * @dev: PCI device instance
+ * @delay_us: Requested delay_us
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM to
+grant the required
+ * PERST dealy for the specified PCI device. It evaluates the _DSM
+(Device
+ * Specific Method) to request the PERST delay and handles the response

accordingly.

s/PERST/PERST#/
s/dealy/delay/

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+ * Return: returns 0 on success and errno on failure.
+ */
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32
+delay_us) {
+	union acpi_object in_obj = {
+		.integer.type = ACPI_TYPE_INTEGER,
+		.integer.value = delay_us,
+	};
+
+	union acpi_object *out_obj;

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 10 lines
drivers/pci/pci-acpi.c +10 -0
+	acpi_handle handle;
+	int result, ret = -EINVAL;
+
+	if (!dev || !ACPI_HANDLE(&dev->dev))
+		return -EINVAL;
+
+	handle = ACPI_HANDLE(&dev->dev);
+
+	out_obj = acpi_evaluate_dsm_typed(handle, &pci_acpi_dsm_guid, 4,
+					  DSM_PCI_PERST_ASSERTION_DELAY,

&in_obj, ACPI_TYPE_INTEGER);

Wrap to fit in 78-80 columns.

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 7 lines
drivers/pci/pci-acpi.c +7 -0
+	if (!out_obj)
+		return -EINVAL;
+
+	result = out_obj->integer.value;
+
+	if (result == delay_us) {
+		dev_info(&dev->dev, "PERST# Assertion Delay set to %u

microseconds.\n", delay_us);

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 3 lines
drivers/pci/pci-acpi.c +3 -0
+		ret = 0;
+	} else if (result == 0) {
+		dev_warn(&dev->dev, "PERST# Assertion Delay request failed,

no previous valid request.\n");

drivers/pci/pci-acpi.c static void pci_acpi_optimize_delay(struct pci_dev *pdev,

Quoted 3 lines
drivers/pci/pci-acpi.c +3 -0
+	} else {
+		dev_warn(&dev->dev,
+			 "PERST# Assertion Delay request failed. Previous valid

delay: %u microseconds.\n", result);

Quoted 50 lines
drivers/pci/pci-acpi.c +7 -0
+	}
+
+	ACPI_FREE(out_obj);
+	return ret;
+}
+EXPORT_SYMBOL(pci_acpi_add_perst_assertion_delay);
+
 static void pci_acpi_set_external_facing(struct pci_dev *dev)  {
 	u8 val;
include/linux/pci-acpi.h index renamed from include/linux/pci-acpi.h +0 -0

078225b514d4..4b7373f91a9a 100644

include/linux/pci-acpi.h +3 -0
@@ -121,6 +121,8 @@ extern const guid_t pci_acpi_dsm_guid;
 #define DSM_PCI_DEVICE_NAME			0x07
 #define DSM_PCI_POWER_ON_RESET_DELAY		0x08
 #define DSM_PCI_DEVICE_READINESS_DURATIONS	0x09
+#define DSM_PCI_D3COLD_AUX_POWER_LIMIT		0x0A
+#define DSM_PCI_PERST_ASSERTION_DELAY		0x0B
 
 #ifdef CONFIG_PCIE_EDR
 void pci_acpi_add_edr_notifier(struct pci_dev *pdev); @@ -132,10
+134,21 @@ static inline void pci_acpi_remove_edr_notifier(struct

pci_dev *pdev) { }

int pci_acpi_set_companion_lookup_hook(struct acpi_device
*(*func)(struct pci_dev *)); void pci_acpi_clear_companion_lookup_hook(void);

include/linux/pci-acpi.h +3 -0
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32
+requested_power); int pci_acpi_add_perst_assertion_delay(struct
+pci_dev *dev, u32 delay_us);
 
 #else	/* CONFIG_ACPI */
 static inline void acpi_pci_add_bus(struct pci_bus *bus) { }  static

inline void acpi_pci_remove_bus(struct pci_bus *bus) { }

include/linux/pci-acpi.h +9 -1
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32
+requested_power) {
+	return -EOPNOTSUPP;
+}
+
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32
+delay_us) {
+	return -EOPNOTSUPP;
+}
 #endif	/* CONFIG_ACPI */
 
 #endif	/* _PCI_ACPI_H_ */
--

2.34.1

#4 lore raw

Re: [RFC 1/6] PCI/ACPI: Implement PCI FW _DSM method

Quoted 32 lines · Anshuman
Quoted 2 lines

-----Original Message-----
From: Bjorn Helgaas <[email protected]>

... redundant headers snipped

Quoted 20 lines · Anshuman Gupta
Quoted 1 line

Implement _DSM method 10 and _DSM Method 11 as per PCI firmware

specs

Quoted 1 line

section 4.6.10 and 4.6.11.

Please split into two patches, one for each _DSM. Include spec citations, e.g., PCI Firmware r3.3, sec 4.6.10. Section numbers are not guaranteed to stay consistent across spec revisions, so we need both the revision and section number.

Include some descriptive words about the DSM in each subject line, e.g., "D3cold Aux Power Limit", "PERST# Assertion Delay".

Quoted 6 lines

Current assumption is only one PCIe Endpoint driver (XeKMD for Battlemage GPU) will request for Aux Power Limit under a given Root Port but theoretically it is possible that other Non-Intel GPU or Non-GPU PCIe Endpoint driver can also request for Aux Power Limit and request to block the core power removal under same Root Port. That will disrupt the Battlemage GPU VRAM Self Refresh.

Quoted 3 lines

I guess this is sort of an acknowledgement of the r3.3, sec 4.6.10 spec text about system software being responsible for tracking and aggregating requests when there are multiple functions below the Downstream Port?

AFAIU apart from multiple function below the Downstream Port (from same PCIe Card), there can be possibility of another PCie card connected via a switch to same root port like below topology.

Quoted 5 lines
			                 |-> PCIe PCIe Downstream Port -> End Point Device 	
Root Port -> PCIe Upstream Port   |-> PCIe PCIe Downstream Port -> End Point Device	
			                 |-> PCIe PCIe Downstream Port -> PCIe Upstream Port ->  PCIe Downstream Port -> *EndPoint Device 	

*Endpoint Device from different PCIe card can also request to block the core power removal under same Root Port ?

Of course.

Quoted 5 lines

How to document such limitation ?

Quoted 3 lines

If so, remove the Battlemage-specific language and just say something about the fact that this implementation doesn't do any of that tracking and aggregation.

^^ Here's a hint about how to document this. My point is that this has nothing to do with Battlemage in particular, so the text about Battlemage-specific things is a distraction from the real point, which IIUC is this:

Note that this implementation assumes only a single device below the Downstream Port because it does not track and aggregate requests from all child devices below the Downstream Port as required by sec 4.6.10.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

One possible mitigation would be only allowing only first PCIe Non-Bridge Endpoint Function 0 driver to call_DSM method 10.

#5 lore raw

Re: [RFC 1/6] PCI/ACPI: Implement PCI FW _DSM method

In reply to Anshuman Gupta
kernel test robot noticed the following build warnings:

Hi Anshuman,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-xe/drm-xe-next]
[also build test WARNING on rafael-pm/linux-next rafael-pm/bleeding-edge pci/next pci/for-linus linus/master v6.14-rc4 next-20250224] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Gupta/PCI-ACPI-Implement-PCI-FW-_DSM-method/20250225-005537
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20250224164849.3746751-2-anshuman.gupta%40intel.com
patch subject: [RFC 1/6] PCI/ACPI: Implement PCI FW _DSM method
config: arm64-randconfig-003-20250225 (https://download.01.org/0day-ci/archive/20250225/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250225/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

In file included from drivers/pci/controller/pci-xgene.c:19:

>> include/linux/pci-acpi.h:143:5: warning: no previous prototype for function 'pci_acpi_request_d3cold_aux_power' [-Wmissing-prototypes]
   int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
       ^
   include/linux/pci-acpi.h:143:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
   ^
   static 
>> include/linux/pci-acpi.h:148:5: warning: no previous prototype for function 'pci_acpi_add_perst_assertion_delay' [-Wmissing-prototypes]
   int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
       ^

include/linux/pci-acpi.h:148:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
^
static
2 warnings generated.

vim +/pci_acpi_request_d3cold_aux_power +143 include/linux/pci-acpi.h

139
140 #else /* CONFIG_ACPI */
141 static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
142 static inline void acpi_pci_remove_bus(struct pci_bus *bus) { }

 > 143	int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
   144	{
   145		return -EOPNOTSUPP;
   146	}
   147	
 > 148	int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)

149 {
150 return -EOPNOTSUPP;
151 }
152 #endif /* CONFIG_ACPI */
153

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#6 lore raw

RFC 2/6 drm/xe/vrsr: Detect vrsr capability

In reply to Anshuman Gupta

Detect VRAM Self Refresh(vrsr) Capability.

---
 drivers/gpu/drm/xe/regs/xe_regs.h    |  3 +++
 drivers/gpu/drm/xe/xe_device_types.h |  4 ++++
 drivers/gpu/drm/xe/xe_pm.c           | 27 +++++++++++++++++++++++++++
 3 files changed, 34 insertions(+)
drivers/gpu/drm/xe/regs/xe_regs.h +3 -0
index 6cf282618836..21563e9d958b 100644
@@ -57,6 +57,9 @@
 #define MTL_MPE_FREQUENCY			XE_REG(0x13802c)
 #define   MTL_RPE_MASK				REG_GENMASK(8, 0)
 
+#define VRAM_CAPABILITY                         XE_REG(0x138144)
+#define   VRAM_SUPPORTED                        REG_BIT(0)
+
 #define VF_CAP_REG				XE_REG(0x1901f8, XE_REG_OPTION_VF)
 #define   VF_CAP				REG_BIT(0)
 
drivers/gpu/drm/xe/xe_device_types.h +4 -0
index 4656305dd45a..c2ab2c91c968 100644
@@ -490,6 +490,9 @@ struct xe_device {
 		/** @d3cold.allowed: Indicates if d3cold is a valid device state */
 		bool allowed;
 
+		/** @d3cold.vrsr_capable: Indicates if d3cold VRAM Self Refresh is supported */
+		bool vrsr_capable;
+
 		/**
 		 * @d3cold.vram_threshold:
 		 *
@@ -500,6 +503,7 @@ struct xe_device {
 		 * Default threshold value is 300mb.
 		 */
 		u32 vram_threshold;
+
 		/** @d3cold.lock: protect vram_threshold */
 		struct mutex lock;
 	} d3cold;
drivers/gpu/drm/xe/xe_pm.c +27 -0
index 12200be7b43d..dead236355d8 100644
@@ -17,12 +17,15 @@
 #include "xe_bo_evict.h"
 #include "xe_device.h"
 #include "xe_device_sysfs.h"
+#include "xe_force_wake.h"
 #include "xe_ggtt.h"
 #include "xe_gt.h"
 #include "xe_guc.h"
 #include "xe_irq.h"
+#include "xe_mmio.h"
 #include "xe_pcode.h"
 #include "xe_pxp.h"
+#include "regs/xe_regs.h"
 #include "xe_trace.h"
 #include "xe_wa.h"
 
@@ -236,6 +239,28 @@ static bool xe_pm_pci_d3cold_capable(struct xe_device *xe)
 	return true;
 }
 
+static bool xe_pm_vrsr_capable(struct xe_device *xe)
+{
+	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
+	unsigned int fw_ref;
+	struct xe_gt *gt;
+	u32 val;
+
+	gt = xe_root_mmio_gt(xe);
+
+	if (!xe->info.probe_display)
+		return false;
+
+	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
+	if (!fw_ref)
+		return false;
+
+	val = xe_mmio_read32(mmio, VRAM_CAPABILITY);
+	xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL);
+
+	return val & VRAM_SUPPORTED;
+}
+
 static void xe_pm_runtime_init(struct xe_device *xe)
 {
 	struct device *dev = xe->drm.dev;
@@ -303,6 +328,8 @@ int xe_pm_init(struct xe_device *xe)
 		err = xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
 		if (err)
 			return err;
+
+		xe->d3cold.vrsr_capable = xe_pm_vrsr_capable(xe);
 	}
 
 	xe_pm_runtime_init(xe);
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 2/6
#7 lore raw

Re: [RFC 2/6] drm/xe/vrsr: Detect vrsr capability

Quoted 14 lines · Anshuman Gupta

Detect VRAM Self Refresh(vrsr) Capability.

---
 drivers/gpu/drm/xe/regs/xe_regs.h    |  3 +++
 drivers/gpu/drm/xe/xe_device_types.h |  4 ++++
 drivers/gpu/drm/xe/xe_pm.c           | 27 +++++++++++++++++++++++++++
 3 files changed, 34 insertions(+)
drivers/gpu/drm/xe/regs/xe_regs.h +0 -0
index 6cf282618836..21563e9d958b 100644

drivers/gpu/drm/xe/regs/xe_regs.h line 61

Quoted 5 lines
drivers/gpu/drm/xe/regs/xe_regs.h +2 -0
@@ -57,6 +57,9 @@
 #define MTL_MPE_FREQUENCY			XE_REG(0x13802c)
 #define   MTL_RPE_MASK				REG_GENMASK(8, 0)
 
+#define VRAM_CAPABILITY                         XE_REG(0x138144)
+#define   VRAM_SUPPORTED                        REG_BIT(0)

I'm missing a 'SR' mention here.

I know the register name is VRAM_CAPABILITY what looks horrible, but let's live with it, but we could then use same or similar terminology from BSPec:

VRAM_SR_CAP

or VRAM_SR_CAP_SUPPORTED

or VRAM_SR_SUPPORTED at least?

with some mention to SR here:

Quoted 87 lines
drivers/gpu/drm/xe/regs/xe_regs.h +1 -0
+
 #define VF_CAP_REG				XE_REG(0x1901f8, XE_REG_OPTION_VF)
 #define   VF_CAP				REG_BIT(0)
 
drivers/gpu/drm/xe/xe_device_types.h +4 -0
index 4656305dd45a..c2ab2c91c968 100644
@@ -490,6 +490,9 @@ struct xe_device {
 		/** @d3cold.allowed: Indicates if d3cold is a valid device state */
 		bool allowed;
 
+		/** @d3cold.vrsr_capable: Indicates if d3cold VRAM Self Refresh is supported */
+		bool vrsr_capable;
+
 		/**
 		 * @d3cold.vram_threshold:
 		 *
@@ -500,6 +503,7 @@ struct xe_device {
 		 * Default threshold value is 300mb.
 		 */
 		u32 vram_threshold;
+
 		/** @d3cold.lock: protect vram_threshold */
 		struct mutex lock;
 	} d3cold;
drivers/gpu/drm/xe/xe_pm.c +27 -0
index 12200be7b43d..dead236355d8 100644
@@ -17,12 +17,15 @@
 #include "xe_bo_evict.h"
 #include "xe_device.h"
 #include "xe_device_sysfs.h"
+#include "xe_force_wake.h"
 #include "xe_ggtt.h"
 #include "xe_gt.h"
 #include "xe_guc.h"
 #include "xe_irq.h"
+#include "xe_mmio.h"
 #include "xe_pcode.h"
 #include "xe_pxp.h"
+#include "regs/xe_regs.h"
 #include "xe_trace.h"
 #include "xe_wa.h"
 
@@ -236,6 +239,28 @@ static bool xe_pm_pci_d3cold_capable(struct xe_device *xe)
 	return true;
 }
 
+static bool xe_pm_vrsr_capable(struct xe_device *xe)
+{
+	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
+	unsigned int fw_ref;
+	struct xe_gt *gt;
+	u32 val;
+
+	gt = xe_root_mmio_gt(xe);
+
+	if (!xe->info.probe_display)
+		return false;
+
+	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
+	if (!fw_ref)
+		return false;
+
+	val = xe_mmio_read32(mmio, VRAM_CAPABILITY);
+	xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL);
+
+	return val & VRAM_SUPPORTED;
+}
+
 static void xe_pm_runtime_init(struct xe_device *xe)
 {
 	struct device *dev = xe->drm.dev;
@@ -303,6 +328,8 @@ int xe_pm_init(struct xe_device *xe)
 		err = xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
 		if (err)
 			return err;
+
+		xe->d3cold.vrsr_capable = xe_pm_vrsr_capable(xe);
 	}
 
 	xe_pm_runtime_init(xe);
Signature · 1 line
2.34.1
#8 lore raw

RFC 3/6 drm/xe/vrsr: Apis to init and enable VRSR feature

In reply to Anshuman Gupta

From: Badal Nilawar <[email protected]>

APIs to enable and initialize VRSR feature.

---
 drivers/gpu/drm/xe/xe_device_types.h |  1 +
 drivers/gpu/drm/xe/xe_pcode_api.h    |  8 +++
 drivers/gpu/drm/xe/xe_pm.c           | 91 ++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_pm.h           |  3 +
 4 files changed, 103 insertions(+)
drivers/gpu/drm/xe/xe_device_types.h +1 -0
index c2ab2c91c968..da7946b75cd5 100644
@@ -7,6 +7,7 @@
 #define _XE_DEVICE_TYPES_H_
 
 #include <linux/pci.h>
+#include <linux/pci-acpi.h>
 
 #include <drm/drm_device.h>
 #include <drm/drm_file.h>
drivers/gpu/drm/xe/xe_pcode_api.h +8 -0
index 2bae9afdbd35..17a90b2c6737 100644
@@ -42,6 +42,14 @@
 #define	    POWER_SETUP_I1_SHIFT		6	/* 10.6 fixed point format */
 #define	    POWER_SETUP_I1_DATA_MASK		REG_GENMASK(15, 0)
 
+#define	  PCODE_D3_VRAM_SELF_REFRESH	0x71
+#define	    PCODE_D3_VRSR_SC_DISABLE	0x0
+#define	    PCODE_D3_VRSR_SC_ENABLE	0x1
+#define     PCODE_D3_VRSR_SC_AUX_PL_AND_PERST_DELAY	0x2
+#define     PCODE_D3_VRSR_PERST_SHIFT	16
+#define	    POWER_D3_VRSR_PSERST_MASK	REG_GENMASK(31, 16)
+#define	    POWER_D3_VRSR_AUX_PL_MASK	REG_GENMASK(15, 0)
+
 #define   PCODE_FREQUENCY_CONFIG		0x6e
 /* Frequency Config Sub Commands (param1) */
 #define     PCODE_MBOX_FC_SC_READ_FUSED_P0	0x0
drivers/gpu/drm/xe/xe_pm.c +91 -0

109 lines not on this page · raw message

drivers/gpu/drm/xe/xe_pm.h +3 -0
index 998d1ed64556..c9f176912b46 100644
@@ -35,4 +35,7 @@ bool xe_rpm_reclaim_safe(const struct xe_device *xe);
 struct task_struct *xe_pm_read_callback_task(struct xe_device *xe);
 int xe_pm_module_init(void);
 
+int xe_pm_init_vrsr(struct xe_device *xe);
+int xe_pm_enable_vrsr(struct xe_device *xe, bool enable);
+
 #endif
Signature · 1 line
2.34.1
#9 lore raw

Re: [RFC 3/6] drm/xe/vrsr: Apis to init and enable VRSR feature

s/Apis/APIs/ in subject to match common usage and use below.

Also perhaps s/Detect vrsr/Detect VRSR/ in previous patch subject to match this one.

Quoted 3 lines · Anshuman Gupta

From: Badal Nilawar <[email protected]>

APIs to enable and initialize VRSR feature.

I always think it's nice when the commit log includes the actual names of the APIs being added so we don't have to grub that out of the patch.

#10 lore raw

Re: [RFC 3/6] drm/xe/vrsr: Apis to init and enable VRSR feature

In reply to Anshuman Gupta
kernel test robot noticed the following build errors:

Hi Anshuman,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on next-20250225]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge pci/next pci/for-linus linus/master v6.14-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Gupta/PCI-ACPI-Implement-PCI-FW-_DSM-method/20250225-005537
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20250224164849.3746751-4-anshuman.gupta%40intel.com
patch subject: [RFC 3/6] drm/xe/vrsr: Apis to init and enable VRSR feature
config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20250226/[email protected]/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250226/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

hppa-linux-ld: drivers/gpu/drm/xe/xe_bo.o: in function `pci_acpi_request_d3cold_aux_power':

>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_bo.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_bo_evict.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_bo_evict.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_devcoredump.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_devcoredump.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_device.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_device.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_device_sysfs.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_device_sysfs.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_dma_buf.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_dma_buf.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_drm_client.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_drm_client.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_exec.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_exec.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_exec_queue.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_exec_queue.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_execlist.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/xe_execlist.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here

hppa-linux-ld: drivers/gpu/drm/xe/xe_force_wake.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_force_wake.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_ggtt.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_ggtt.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc_debugfs.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc_debugfs.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc_proxy.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc_proxy.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc_submit.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gsc_submit.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_ccs_mode.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_ccs_mode.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_clock.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_clock.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_freq.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_freq.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_idle.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_idle.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_mcr.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_mcr.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_pagefault.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_pagefault.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_sysfs.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_sysfs.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_throttle.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_throttle.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_tlb_invalidation.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_tlb_invalidation.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_topology.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_gt_topology.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_ads.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_ads.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_buf.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_buf.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_capture.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_capture.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_ct.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_ct.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_db_mgr.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_db_mgr.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_hwconfig.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_hwconfig.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_id_mgr.o: in function `pci_acpi_request_d3cold_aux_power':
(.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
hppa-linux-ld: drivers/gpu/drm/xe/xe_guc_id_mgr.o: in function `pci_acpi_add_perst_assertion_delay':
(.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
--
hppa-linux-ld: drivers/gpu/drm/xe/tests/xe_rtp_test.o: in function `pci_acpi_request_d3cold_aux_power':

>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/tests/xe_pci_test.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/tests/xe_rtp_test.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/tests/xe_pci_test.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/tests/xe_wa_test.o: in function `pci_acpi_request_d3cold_aux_power':
>> (.text.pci_acpi_request_d3cold_aux_power+0x10): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/tests/xe_pci_test.o:(.text.pci_acpi_request_d3cold_aux_power+0x10): first defined here
   hppa-linux-ld: drivers/gpu/drm/xe/tests/xe_wa_test.o: in function `pci_acpi_add_perst_assertion_delay':
>> (.text.pci_acpi_add_perst_assertion_delay+0x10): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/tests/xe_pci_test.o:(.text.pci_acpi_add_perst_assertion_delay+0x10): first defined here
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#11 lore raw

Re: [RFC 3/6] drm/xe/vrsr: Apis to init and enable VRSR feature

In reply to Anshuman Gupta
kernel test robot noticed the following build errors:

Hi Anshuman,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on next-20250226]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge pci/next pci/for-linus linus/master v6.14-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Gupta/PCI-ACPI-Implement-PCI-FW-_DSM-method/20250225-005537
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20250224164849.3746751-4-anshuman.gupta%40intel.com
patch subject: [RFC 3/6] drm/xe/vrsr: Apis to init and enable VRSR feature
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20250226/[email protected]/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250226/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

sparc64-linux-ld: drivers/gpu/drm/xe/xe_bo.o: in function `pci_acpi_request_d3cold_aux_power':

>> xe_bo.c:(.text+0x25a0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
   sparc64-linux-ld: drivers/gpu/drm/xe/xe_bo.o: in function `pci_acpi_add_perst_assertion_delay':
>> xe_bo.c:(.text+0x25c0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here

sparc64-linux-ld: drivers/gpu/drm/xe/xe_bo_evict.o: in function `pci_acpi_request_d3cold_aux_power':
xe_bo_evict.c:(.text+0x0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_bo_evict.o: in function `pci_acpi_add_perst_assertion_delay':
xe_bo_evict.c:(.text+0x20): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_devcoredump.o: in function `pci_acpi_request_d3cold_aux_power':
xe_devcoredump.c:(.text+0x7e0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_devcoredump.o: in function `pci_acpi_add_perst_assertion_delay':
xe_devcoredump.c:(.text+0x800): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_device.o: in function `pci_acpi_request_d3cold_aux_power':
xe_device.c:(.text+0x1300): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_device.o: in function `pci_acpi_add_perst_assertion_delay':
xe_device.c:(.text+0x1320): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_device_sysfs.o: in function `pci_acpi_request_d3cold_aux_power':
xe_device_sysfs.c:(.text+0x1c0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_device_sysfs.o: in function `pci_acpi_add_perst_assertion_delay':
xe_device_sysfs.c:(.text+0x1e0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_dma_buf.o: in function `pci_acpi_request_d3cold_aux_power':
xe_dma_buf.c:(.text+0x600): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_dma_buf.o: in function `pci_acpi_add_perst_assertion_delay':
xe_dma_buf.c:(.text+0x620): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_drm_client.o: in function `pci_acpi_request_d3cold_aux_power':
xe_drm_client.c:(.text+0xac0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_drm_client.o: in function `pci_acpi_add_perst_assertion_delay':
xe_drm_client.c:(.text+0xae0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_exec.o: in function `pci_acpi_request_d3cold_aux_power':
xe_exec.c:(.text+0x40): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_exec.o: in function `pci_acpi_add_perst_assertion_delay':
xe_exec.c:(.text+0x60): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_exec_queue.o: in function `pci_acpi_request_d3cold_aux_power':
xe_exec_queue.c:(.text+0xf20): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_exec_queue.o: in function `pci_acpi_add_perst_assertion_delay':
xe_exec_queue.c:(.text+0xf40): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_execlist.o: in function `pci_acpi_request_d3cold_aux_power':
xe_execlist.c:(.text+0xbc0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_execlist.o: in function `pci_acpi_add_perst_assertion_delay':
xe_execlist.c:(.text+0xbe0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_force_wake.o: in function `pci_acpi_request_d3cold_aux_power':
xe_force_wake.c:(.text+0x160): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_force_wake.o: in function `pci_acpi_add_perst_assertion_delay':
xe_force_wake.c:(.text+0x180): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_ggtt.o: in function `pci_acpi_request_d3cold_aux_power':
xe_ggtt.c:(.text+0x580): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_ggtt.o: in function `pci_acpi_add_perst_assertion_delay':
xe_ggtt.c:(.text+0x5a0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gsc.c:(.text+0xea0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gsc.c:(.text+0xec0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc_debugfs.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gsc_debugfs.c:(.text+0xa0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc_debugfs.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gsc_debugfs.c:(.text+0xc0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc_proxy.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gsc_proxy.c:(.text+0x8e0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc_proxy.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gsc_proxy.c:(.text+0x900): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc_submit.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gsc_submit.c:(.text+0x0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gsc_submit.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gsc_submit.c:(.text+0x20): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt.c:(.text+0xa40): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt.c:(.text+0xa60): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_ccs_mode.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_ccs_mode.c:(.text+0x520): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_ccs_mode.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_ccs_mode.c:(.text+0x540): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_clock.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_clock.c:(.text+0x0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_clock.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_clock.c:(.text+0x20): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_freq.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_freq.c:(.text+0x5c0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_freq.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_freq.c:(.text+0x5e0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_idle.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_idle.c:(.text+0x140): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_idle.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_idle.c:(.text+0x160): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_mcr.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_mcr.c:(.text+0x6c0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_mcr.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_mcr.c:(.text+0x6e0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_pagefault.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_pagefault.c:(.text+0x14e0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_pagefault.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_pagefault.c:(.text+0x1500): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_sysfs.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_sysfs.c:(.text+0x80): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_sysfs.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_sysfs.c:(.text+0xa0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_throttle.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_throttle.c:(.text+0x40): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_throttle.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_throttle.c:(.text+0x60): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_tlb_invalidation.o: in function `pci_acpi_request_d3cold_aux_power':
xe_gt_tlb_invalidation.c:(.text+0xba0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xa0): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/xe_gt_tlb_invalidation.o: in function `pci_acpi_add_perst_assertion_delay':
xe_gt_tlb_invalidation.c:(.text+0xbc0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/xe_bb.o:xe_bb.c:(.text+0xc0): first defined here
--
sparc64-linux-ld: drivers/gpu/drm/xe/tests/xe_rtp_test.o: in function `pci_acpi_request_d3cold_aux_power':

>> xe_rtp_test.c:(.text+0x800): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/tests/xe_pci_test.o:xe_pci_test.c:(.text+0x200): first defined here
   sparc64-linux-ld: drivers/gpu/drm/xe/tests/xe_rtp_test.o: in function `pci_acpi_add_perst_assertion_delay':
>> xe_rtp_test.c:(.text+0x820): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/tests/xe_pci_test.o:xe_pci_test.c:(.text+0x220): first defined here

sparc64-linux-ld: drivers/gpu/drm/xe/tests/xe_wa_test.o: in function `pci_acpi_request_d3cold_aux_power':
xe_wa_test.c:(.text+0x5c0): multiple definition of `pci_acpi_request_d3cold_aux_power'; drivers/gpu/drm/xe/tests/xe_pci_test.o:xe_pci_test.c:(.text+0x200): first defined here
sparc64-linux-ld: drivers/gpu/drm/xe/tests/xe_wa_test.o: in function `pci_acpi_add_perst_assertion_delay':
xe_wa_test.c:(.text+0x5e0): multiple definition of `pci_acpi_add_perst_assertion_delay'; drivers/gpu/drm/xe/tests/xe_pci_test.o:xe_pci_test.c:(.text+0x220): first defined here

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
maintainer
#12 lore raw

Re: [RFC 3/6] drm/xe/vrsr: Apis to init and enable VRSR feature

In reply to Anshuman Gupta
Quoted 61 lines · Anshuman Gupta

From: Badal Nilawar <[email protected]>

APIs to enable and initialize VRSR feature.

---
 drivers/gpu/drm/xe/xe_device_types.h |  1 +
 drivers/gpu/drm/xe/xe_pcode_api.h    |  8 +++
 drivers/gpu/drm/xe/xe_pm.c           | 91 ++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_pm.h           |  3 +
 4 files changed, 103 insertions(+)
drivers/gpu/drm/xe/xe_device_types.h +1 -0
index c2ab2c91c968..da7946b75cd5 100644
@@ -7,6 +7,7 @@
 #define _XE_DEVICE_TYPES_H_
 
 #include <linux/pci.h>
+#include <linux/pci-acpi.h>
 
 #include <drm/drm_device.h>
 #include <drm/drm_file.h>
drivers/gpu/drm/xe/xe_pcode_api.h +8 -0
index 2bae9afdbd35..17a90b2c6737 100644
@@ -42,6 +42,14 @@
 #define	    POWER_SETUP_I1_SHIFT		6	/* 10.6 fixed point format */
 #define	    POWER_SETUP_I1_DATA_MASK		REG_GENMASK(15, 0)
 
+#define	  PCODE_D3_VRAM_SELF_REFRESH	0x71
+#define	    PCODE_D3_VRSR_SC_DISABLE	0x0
+#define	    PCODE_D3_VRSR_SC_ENABLE	0x1
+#define     PCODE_D3_VRSR_SC_AUX_PL_AND_PERST_DELAY	0x2
+#define     PCODE_D3_VRSR_PERST_SHIFT	16
+#define	    POWER_D3_VRSR_PSERST_MASK	REG_GENMASK(31, 16)
+#define	    POWER_D3_VRSR_AUX_PL_MASK	REG_GENMASK(15, 0)
+
 #define   PCODE_FREQUENCY_CONFIG		0x6e
 /* Frequency Config Sub Commands (param1) */
 #define     PCODE_MBOX_FC_SC_READ_FUSED_P0	0x0
drivers/gpu/drm/xe/xe_pm.c +2 -0
index dead236355d8..32583651988f 100644
@@ -23,6 +23,7 @@
 #include "xe_guc.h"
 #include "xe_irq.h"
 #include "xe_mmio.h"
+#include "xe_pcode_api.h"
 #include "xe_pcode.h"
 #include "xe_pxp.h"
 #include "regs/xe_regs.h"
@@ -85,6 +86,92 @@ static struct lockdep_map xe_pm_runtime_nod3cold_map = {
 };
 #endif
 
+/**

drivers/gpu/drm/xe/xe_pm.c static struct lockdep_map xe_pm_runtime_nod3cold_map = { · line 99

Quoted 10 lines
drivers/gpu/drm/xe/xe_pm.c +10 -0
+ * xe_pm_init_vrsr - Initialize VRAM self refresh
+ * @xe: The xe device
+ *
+ * This function reads the AUX power and PERST assertion delay from pcode.
+ * Then request host BIOS via ACPI _DSM to grant required AUX power and PERST
+ * assertion delay.
+ *
+ * Return: returns 0 on success and errno on failure
+ */
+int

why not void?
we are not checking it anyway...

drivers/gpu/drm/xe/xe_pm.c static struct lockdep_map xe_pm_runtime_nod3cold_map = { · line 100

Quoted 1 line
drivers/gpu/drm/xe/xe_pm.c +0 -0
 xe_pm_init_vrsr(struct xe_device *xe)

perhaps xe_pm_d3cold_vrsr_init()

Quoted 6 lines
drivers/gpu/drm/xe/xe_pm.c +6 -0
+{
+	struct xe_tile *root_tile = xe_device_get_root_tile(xe);
+	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
+	struct pci_dev *root_pdev;
+	int ret;
+	u32 uval;

drivers/gpu/drm/xe/xe_pm.c static struct lockdep_map xe_pm_runtime_nod3cold_map = { · line 115

Quoted 10 lines
drivers/gpu/drm/xe/xe_pm.c +10 -0
+	u32 aux_pwr_limit;
+	u32 perst_delay;
+
+	root_pdev = pcie_find_root_port(pdev);
+	if (!root_pdev)
+		return -EINVAL;
+
+	/* Avoid Illegal Subcommand error */
+	if (xe->info.platform != XE_BATTLEMAGE)
+		return -ENXIO;

I wonder if we should do a has_d3cold_vrsr flag for this, or at least move this check earlier.

Quoted 63 lines
drivers/gpu/drm/xe/xe_pm.c +59 -0
+
+	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_D3_VRAM_SELF_REFRESH,
+			    PCODE_D3_VRSR_SC_AUX_PL_AND_PERST_DELAY, 0),
+			    &uval, NULL);
+
+	if (ret)
+		return ret;
+
+	aux_pwr_limit = REG_FIELD_GET(POWER_D3_VRSR_AUX_PL_MASK, uval);
+	perst_delay = REG_FIELD_GET(POWER_D3_VRSR_PSERST_MASK, uval);
+
+	drm_dbg(&xe->drm, "AUX POWER LIMIT =%d\n", aux_pwr_limit);
+	drm_dbg(&xe->drm, "PERST Assertion delay =%d\n", perst_delay);
+
+	ret = pci_acpi_request_d3cold_aux_power(root_pdev, aux_pwr_limit);
+	if (ret)
+		goto vrsr;
+
+	ret = pci_acpi_add_perst_assertion_delay(root_pdev, perst_delay);
+	if (ret)
+		goto vrsr;
+
+	return ret;
+
+vrsr:
+	drm_err(&xe->drm, "ACPI DSM failed, VRSR is not capable\n");
+	xe->d3cold.vrsr_capable = false;
+	return ret;
+}
+
+/**
+ * xe_pm_enable_vrsr - Enable VRAM self refresh
+ * @xe: The xe device.
+ * @enable: true: Enable, false: Disable
+ *
+ * This function enables the VRSR feature in D3Cold path.
+ *
+ * Return: It returns 0 on success and errno on failure.
+ */
+int xe_pm_enable_vrsr(struct xe_device *xe, bool enable)
+{
+	struct xe_tile *root_tile = xe_device_get_root_tile(xe);
+	int ret;
+	u32 uval = 0;
+
+	/* Avoid Illegal Subcommand error */
+	if (xe->info.platform != XE_BATTLEMAGE)
+		return -ENXIO;
+
+	if (enable)
+		ret = xe_pcode_write(root_tile, PCODE_MBOX(PCODE_D3_VRAM_SELF_REFRESH,
+				     PCODE_D3_VRSR_SC_ENABLE, 0), uval);
+	else
+		ret = xe_pcode_write(root_tile, PCODE_MBOX(PCODE_D3_VRAM_SELF_REFRESH,
+				     PCODE_D3_VRSR_SC_DISABLE, 0), uval);
+
+	return ret;
+}
+
 /**
  * xe_rpm_reclaim_safe() - Whether runtime resume can be done from reclaim context

* @xe: The xe device.

drivers/gpu/drm/xe/xe_pm.c int xe_pm_init(struct xe_device *xe) · line 423

Quoted 7 lines
drivers/gpu/drm/xe/xe_pm.c +4 -0
@@ -330,6 +417,10 @@ int xe_pm_init(struct xe_device *xe)
 			return err;
 
 		xe->d3cold.vrsr_capable = xe_pm_vrsr_capable(xe);
+		if (xe->d3cold.vrsr_capable) {
+			drm_dbg(&xe->drm, "vram sr capable\n");
+			xe_pm_init_vrsr(xe);
+		}

perhaps move this piece of code entirely to the init function itself?

Quoted 18 lines
drivers/gpu/drm/xe/xe_pm.c +0 -0
 	}
 
 	xe_pm_runtime_init(xe);
drivers/gpu/drm/xe/xe_pm.h +3 -0
index 998d1ed64556..c9f176912b46 100644
@@ -35,4 +35,7 @@ bool xe_rpm_reclaim_safe(const struct xe_device *xe);
 struct task_struct *xe_pm_read_callback_task(struct xe_device *xe);
 int xe_pm_module_init(void);
 
+int xe_pm_init_vrsr(struct xe_device *xe);
+int xe_pm_enable_vrsr(struct xe_device *xe, bool enable);
+
 #endif
Signature · 1 line
2.34.1
#13 lore raw

RFC 4/6 drm/xe/vrsr: Refactor d3cold.allowed to a enum

In reply to Anshuman Gupta

Add xe_d3_state enum to add support for VRAM Self Refresh d3cold state.

---
 drivers/gpu/drm/xe/xe_device_types.h | 5 +++--
 drivers/gpu/drm/xe/xe_pm.c           | 6 +++---
 drivers/gpu/drm/xe/xe_pm.h           | 6 ++++++
 3 files changed, 12 insertions(+), 5 deletions(-)
drivers/gpu/drm/xe/xe_device_types.h +3 -2
index da7946b75cd5..937461939ecc 100644
@@ -19,6 +19,7 @@
 #include "xe_memirq_types.h"
 #include "xe_oa_types.h"
 #include "xe_platform_types.h"
+#include "xe_pm.h"
 #include "xe_pmu_types.h"
 #include "xe_pt_types.h"
 #include "xe_sriov_types.h"
@@ -488,8 +489,8 @@ struct xe_device {
 		/** @d3cold.capable: Indicates if root port is d3cold capable */
 		bool capable;
 
-		/** @d3cold.allowed: Indicates if d3cold is a valid device state */
-		bool allowed;
+		/** @d3cold.allowed: Indicates d3cold target state */
+		enum xe_d3_state allowed;
 
 		/** @d3cold.vrsr_capable: Indicates if d3cold VRAM Self Refresh is supported */
 		bool vrsr_capable;
drivers/gpu/drm/xe/xe_pm.c +3 -3
index 32583651988f..81e67b5693dc 100644
@@ -859,7 +859,7 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
 	int i;
 
 	if (!xe->d3cold.capable) {
-		xe->d3cold.allowed = false;
+		xe->d3cold.allowed = XE_D3HOT;
 		return;
 	}
 
@@ -874,9 +874,9 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
 	mutex_lock(&xe->d3cold.lock);
 
 	if (total_vram_used_mb < xe->d3cold.vram_threshold)
-		xe->d3cold.allowed = true;
+		xe->d3cold.allowed = XE_D3COLD_OFF;
 	else
-		xe->d3cold.allowed = false;
+		xe->d3cold.allowed = XE_D3HOT;
 
 	mutex_unlock(&xe->d3cold.lock);
 }
drivers/gpu/drm/xe/xe_pm.h +6 -0
index c9f176912b46..b7b74757ce21 100644
@@ -12,6 +12,12 @@
 
 struct xe_device;
 
+enum xe_d3_state {
+	XE_D3HOT = 0,
+	XE_D3COLD_OFF,
+	XE_D3COLD_VRSR,
+};
+
 int xe_pm_suspend(struct xe_device *xe);
 int xe_pm_resume(struct xe_device *xe);
 
Signature · 1 line
2.34.1
maintainer
#14 lore raw

Re: [RFC 4/6] drm/xe/vrsr: Refactor d3cold.allowed to a enum

Quoted 23 lines · Anshuman Gupta

Add xe_d3_state enum to add support for VRAM Self Refresh d3cold state.

---
 drivers/gpu/drm/xe/xe_device_types.h | 5 +++--
 drivers/gpu/drm/xe/xe_pm.c           | 6 +++---
 drivers/gpu/drm/xe/xe_pm.h           | 6 ++++++
 3 files changed, 12 insertions(+), 5 deletions(-)
drivers/gpu/drm/xe/xe_device_types.h +1 -0
index da7946b75cd5..937461939ecc 100644
@@ -19,6 +19,7 @@
 #include "xe_memirq_types.h"
 #include "xe_oa_types.h"
 #include "xe_platform_types.h"
+#include "xe_pm.h"
 #include "xe_pmu_types.h"
 #include "xe_pt_types.h"
 #include "xe_sriov_types.h"

drivers/gpu/drm/xe/xe_device_types.h struct xe_device { · line 493

Quoted 7 lines
drivers/gpu/drm/xe/xe_device_types.h +2 -2
@@ -488,8 +489,8 @@ struct xe_device {
 		/** @d3cold.capable: Indicates if root port is d3cold capable */
 		bool capable;
 
-		/** @d3cold.allowed: Indicates if d3cold is a valid device state */
-		bool allowed;
+		/** @d3cold.allowed: Indicates d3cold target state */
+		enum xe_d3_state allowed;

let's also rename the variable name to 'target_state'

or xe->d3cold.allowed = XE_D3HOT //becomes strange

xe->d3.target_state = XE_D3HOT sounds better imho

Quoted 48 lines
drivers/gpu/drm/xe/xe_device_types.h +0 -0
 		/** @d3cold.vrsr_capable: Indicates if d3cold VRAM Self Refresh is supported */
 		bool vrsr_capable;
drivers/gpu/drm/xe/xe_pm.c +3 -3
index 32583651988f..81e67b5693dc 100644
@@ -859,7 +859,7 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
 	int i;
 
 	if (!xe->d3cold.capable) {
-		xe->d3cold.allowed = false;
+		xe->d3cold.allowed = XE_D3HOT;
 		return;
 	}
 
@@ -874,9 +874,9 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
 	mutex_lock(&xe->d3cold.lock);
 
 	if (total_vram_used_mb < xe->d3cold.vram_threshold)
-		xe->d3cold.allowed = true;
+		xe->d3cold.allowed = XE_D3COLD_OFF;
 	else
-		xe->d3cold.allowed = false;
+		xe->d3cold.allowed = XE_D3HOT;
 
 	mutex_unlock(&xe->d3cold.lock);
 }
drivers/gpu/drm/xe/xe_pm.h +6 -0
index c9f176912b46..b7b74757ce21 100644
@@ -12,6 +12,12 @@
 
 struct xe_device;
 
+enum xe_d3_state {
+	XE_D3HOT = 0,
+	XE_D3COLD_OFF,
+	XE_D3COLD_VRSR,
+};
+
 int xe_pm_suspend(struct xe_device *xe);
 int xe_pm_resume(struct xe_device *xe);
 
Signature · 1 line
2.34.1
#15 lore raw

Re: [RFC 4/6] drm/xe/vrsr: Refactor d3cold.allowed to a enum

Quoted 71 lines · Rodrigo Vivi
Quoted 23 lines · Anshuman Gupta

Add xe_d3_state enum to add support for VRAM Self Refresh d3cold state.

---
  drivers/gpu/drm/xe/xe_device_types.h | 5 +++--
  drivers/gpu/drm/xe/xe_pm.c           | 6 +++---
  drivers/gpu/drm/xe/xe_pm.h           | 6 ++++++
  3 files changed, 12 insertions(+), 5 deletions(-)
drivers/gpu/drm/xe/xe_device_types.h +1 -0
index da7946b75cd5..937461939ecc 100644
@@ -19,6 +19,7 @@
  #include "xe_memirq_types.h"
  #include "xe_oa_types.h"
  #include "xe_platform_types.h"
+#include "xe_pm.h"
  #include "xe_pmu_types.h"
  #include "xe_pt_types.h"
  #include "xe_sriov_types.h"

drivers/gpu/drm/xe/xe_device_types.h struct xe_device { · line 493

Quoted 7 lines
drivers/gpu/drm/xe/xe_device_types.h +2 -2
@@ -488,8 +489,8 @@ struct xe_device {
  		/** @d3cold.capable: Indicates if root port is d3cold capable */
  		bool capable;
 
-		/** @d3cold.allowed: Indicates if d3cold is a valid device state */
-		bool allowed;
+		/** @d3cold.allowed: Indicates d3cold target state */
+		enum xe_d3_state allowed;

let's also rename the variable name to 'target_state'

or xe->d3cold.allowed = XE_D3HOT //becomes strange

xe->d3.target_state = XE_D3HOT sounds better imho

Quoted 34 lines
drivers/gpu/drm/xe/xe_device_types.h +0 -0
  		/** @d3cold.vrsr_capable: Indicates if d3cold VRAM Self Refresh is supported */
  		bool vrsr_capable;
drivers/gpu/drm/xe/xe_pm.c +3 -3
index 32583651988f..81e67b5693dc 100644
@@ -859,7 +859,7 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
  	int i;
 
  	if (!xe->d3cold.capable) {
-		xe->d3cold.allowed = false;
+		xe->d3cold.allowed = XE_D3HOT;
  		return;
  	}
 
@@ -874,9 +874,9 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
  	mutex_lock(&xe->d3cold.lock);
 
  	if (total_vram_used_mb < xe->d3cold.vram_threshold)
-		xe->d3cold.allowed = true;
+		xe->d3cold.allowed = XE_D3COLD_OFF;
  	else
-		xe->d3cold.allowed = false;
+		xe->d3cold.allowed = XE_D3HOT;
 
  	mutex_unlock(&xe->d3cold.lock);
  }
drivers/gpu/drm/xe/xe_pm.h +0 -0
index c9f176912b46..b7b74757ce21 100644
@@ -12,6 +12,12 @@
 
Quoted 7 lines

drivers/gpu/drm/xe/xe_pm.h line 19

Quoted 7 lines
drivers/gpu/drm/xe/xe_pm.h +5 -0
  struct xe_device;
 
+enum xe_d3_state {
+	XE_D3HOT = 0,
+	XE_D3COLD_OFF,
+	XE_D3COLD_VRSR,
+};

Could you please reorder the enum based on the level of power consumption as shown below ?

+enum xe_d3_state {
+    XE_D3HOT = 0,
+    XE_D3COLD_VRSR,
+    XE_D3COLD_OFF,
+};

Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/xe/xe_pm.h +1 -0
+
  int xe_pm_suspend(struct xe_device *xe);
  int xe_pm_resume(struct xe_device *xe);
 
Signature · 1 line
2.34.1
#16 lore raw

RFC 5/6 drm/xe/pm: D3Cold target state

In reply to Anshuman Gupta

Trade-off D3Cold target state based upon current vram usages. if vram usages is greater then vram_d3cold_threshold and GPU has display connected then target D3Cold state is D3Cold-VRSR otherwise target state is D3COLD-Off.

---
 drivers/gpu/drm/xe/display/xe_display.c | 22 ++++++++++++++++++++++
 drivers/gpu/drm/xe/display/xe_display.h |  1 +
 drivers/gpu/drm/xe/xe_pm.c              | 12 ++++++++++++
 3 files changed, 35 insertions(+)
drivers/gpu/drm/xe/display/xe_display.c +22 -0
index 02a413a07382..140a43d6b1b6 100644
@@ -548,3 +548,25 @@ int xe_display_probe(struct xe_device *xe)
 	unset_display_features(xe);
 	return 0;
 }
+
+bool xe_display_connected(struct xe_device *xe)
+{
+	struct drm_connector *list_connector;
+	struct drm_connector_list_iter iter;
+	bool ret = false;
+
+	mutex_lock(&xe->drm.mode_config.mutex);
+	drm_connector_list_iter_begin(&xe->drm, &iter);
+
+	drm_for_each_connector_iter(list_connector, &iter) {
+		if (list_connector->status == connector_status_connected) {
+			ret = true;
+			break;
+		}
+	}
+
+	drm_connector_list_iter_end(&iter);
+	mutex_unlock(&xe->drm.mode_config.mutex);
+
+	return ret;
+}
drivers/gpu/drm/xe/display/xe_display.h +1 -0
index 685dc74402fb..c6bc54323084 100644
@@ -40,6 +40,7 @@ void xe_display_pm_resume(struct xe_device *xe);
 void xe_display_pm_runtime_suspend(struct xe_device *xe);
 void xe_display_pm_runtime_suspend_late(struct xe_device *xe);
 void xe_display_pm_runtime_resume(struct xe_device *xe);
+bool xe_display_connected(struct xe_device *xe);
 
 #else
 
drivers/gpu/drm/xe/xe_pm.c +12 -0
index 81e67b5693dc..6d28aedcb062 100644
@@ -198,6 +198,14 @@ static void xe_rpm_lockmap_release(const struct xe_device *xe)
 			 &xe_pm_runtime_d3cold_map);
 }
 
+static void xe_pm_suspend_prepare(struct xe_device *xe)
+{
+	if (pm_suspend_target_state == PM_SUSPEND_TO_IDLE)
+		xe_pm_d3cold_allowed_toggle(xe);
+	else
+		xe->d3cold.allowed = XE_D3COLD_OFF;
+}
+
 /**
  * xe_pm_suspend - Helper for System suspend, i.e. S0->S3 / S0->S2idle
  * @xe: xe device instance
@@ -213,6 +221,8 @@ int xe_pm_suspend(struct xe_device *xe)
 	drm_dbg(&xe->drm, "Suspending device\n");
 	trace_xe_pm_suspend(xe, __builtin_return_address(0));
 
+	xe_pm_suspend_prepare(xe);
+
 	err = xe_pxp_pm_suspend(xe->pxp);
 	if (err)
 		goto err;
@@ -875,6 +885,8 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
 
 	if (total_vram_used_mb < xe->d3cold.vram_threshold)
 		xe->d3cold.allowed = XE_D3COLD_OFF;
+	else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
+		xe->d3cold.allowed = XE_D3COLD_VRSR;
 	else
 		xe->d3cold.allowed = XE_D3HOT;
 
Signature · 1 line
2.34.1
#17 lore raw

Re: [RFC 5/6] drm/xe/pm: D3Cold target state

Could the subject line say something about what this patch does?

Quoted 4 lines · Anshuman Gupta

Trade-off D3Cold target state based upon current vram usages. if vram usages is greater then vram_d3cold_threshold and GPU has display connected then target D3Cold state is D3Cold-VRSR otherwise target state is D3COLD-Off.

s/if vram usages/If vram usage/ (capitalize sentence and fix "usages")

I dunno what "D3Cold-VRSR" means. I suppose GPU folks do.

#18 lore raw

Re: [RFC 5/6] drm/xe/pm: D3Cold target state

In reply to Anshuman Gupta
kernel test robot noticed the following build errors:

Hi Anshuman,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on next-20250224]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge pci/next pci/for-linus linus/master v6.14-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Gupta/PCI-ACPI-Implement-PCI-FW-_DSM-method/20250225-005537
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20250224164849.3746751-6-anshuman.gupta%40intel.com
patch subject: [RFC 5/6] drm/xe/pm: D3Cold target state
config: riscv-randconfig-001-20250225 (https://download.01.org/0day-ci/archive/20250225/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250225/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/xe/xe_pm.c:888:38: error: call to undeclared function 'xe_display_connected'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
           else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
                                               ^
   drivers/gpu/drm/xe/xe_pm.c:888:38: note: did you mean 'xe_display_create'?
   drivers/gpu/drm/xe/display/xe_display.h:51:19: note: 'xe_display_create' declared here
   static inline int xe_display_create(struct xe_device *xe) { return 0; }
                     ^

1 error generated.

vim +/xe_display_connected +888 drivers/gpu/drm/xe/xe_pm.c

856
857 /**
858 * xe_pm_d3cold_allowed_toggle - Check conditions to toggle d3cold.allowed
859 * @xe: xe device instance
860 *
861 * To be called during runtime_pm idle callback.
862 * Check for all the D3Cold conditions ahead of runtime suspend.
863 */
864 void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
865 {
866 struct ttm_resource_manager *man;
867 u32 total_vram_used_mb = 0;
868 u64 vram_used;
869 int i;
870
871 if (!xe->d3cold.capable) {
872 xe->d3cold.allowed = XE_D3HOT;
873 return;
874 }
875
876 for (i = XE_PL_VRAM0; i <= XE_PL_VRAM1; ++i) {
877 man = ttm_manager_type(&xe->ttm, i);
878 if (man) {
879 vram_used = ttm_resource_manager_usage(man);
880 total_vram_used_mb += DIV_ROUND_UP_ULL(vram_used, 1024 * 1024);
881 }
882 }
883
884 mutex_lock(&xe->d3cold.lock);
885
886 if (total_vram_used_mb < xe->d3cold.vram_threshold)
887 xe->d3cold.allowed = XE_D3COLD_OFF;

 > 888		else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))

889 xe->d3cold.allowed = XE_D3COLD_VRSR;
890 else
891 xe->d3cold.allowed = XE_D3HOT;
892
893 mutex_unlock(&xe->d3cold.lock);
894 }
895

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#19 lore raw

Re: [RFC 5/6] drm/xe/pm: D3Cold target state

In reply to Anshuman Gupta
kernel test robot noticed the following build errors:

Hi Anshuman,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on next-20250224]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge pci/next pci/for-linus linus/master v6.14-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Gupta/PCI-ACPI-Implement-PCI-FW-_DSM-method/20250225-005537
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20250224164849.3746751-6-anshuman.gupta%40intel.com
patch subject: [RFC 5/6] drm/xe/pm: D3Cold target state
config: arm-randconfig-001-20250225 (https://download.01.org/0day-ci/archive/20250225/[email protected]/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250225/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

In file included from drivers/gpu/drm/xe/xe_device_types.h:10,

                    from drivers/gpu/drm/xe/xe_device.h:11,
                    from drivers/gpu/drm/xe/display/xe_display.h:9,
                    from drivers/gpu/drm/xe/xe_pm.c:15:
   include/linux/pci-acpi.h:143:5: warning: no previous prototype for 'pci_acpi_request_d3cold_aux_power' [-Wmissing-prototypes]
     143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/pci-acpi.h:148:5: warning: no previous prototype for 'pci_acpi_add_perst_assertion_delay' [-Wmissing-prototypes]
     148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/xe/xe_pm.c: In function 'xe_pm_d3cold_allowed_toggle':
>> drivers/gpu/drm/xe/xe_pm.c:888:45: error: implicit declaration of function 'xe_display_connected'; did you mean 'xe_display_create'? [-Wimplicit-function-declaration]
     888 |         else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
         |                                             ^~~~~~~~~~~~~~~~~~~~
         |                                             xe_display_create

vim +888 drivers/gpu/drm/xe/xe_pm.c

856
857 /**
858 * xe_pm_d3cold_allowed_toggle - Check conditions to toggle d3cold.allowed
859 * @xe: xe device instance
860 *
861 * To be called during runtime_pm idle callback.
862 * Check for all the D3Cold conditions ahead of runtime suspend.
863 */
864 void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
865 {
866 struct ttm_resource_manager *man;
867 u32 total_vram_used_mb = 0;
868 u64 vram_used;
869 int i;
870
871 if (!xe->d3cold.capable) {
872 xe->d3cold.allowed = XE_D3HOT;
873 return;
874 }
875
876 for (i = XE_PL_VRAM0; i <= XE_PL_VRAM1; ++i) {
877 man = ttm_manager_type(&xe->ttm, i);
878 if (man) {
879 vram_used = ttm_resource_manager_usage(man);
880 total_vram_used_mb += DIV_ROUND_UP_ULL(vram_used, 1024 * 1024);
881 }
882 }
883
884 mutex_lock(&xe->d3cold.lock);
885
886 if (total_vram_used_mb < xe->d3cold.vram_threshold)
887 xe->d3cold.allowed = XE_D3COLD_OFF;

 > 888		else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))

889 xe->d3cold.allowed = XE_D3COLD_VRSR;
890 else
891 xe->d3cold.allowed = XE_D3HOT;
892
893 mutex_unlock(&xe->d3cold.lock);
894 }
895

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#20 lore raw

Re: [RFC 5/6] drm/xe/pm: D3Cold target state

In reply to Anshuman Gupta
Quoted 3 lines · Anshuman Gupta

Trade-off D3Cold target state based upon current vram usages. if vram usages is greater then vram_d3cold_threshold and GPU has display connected

Why would anyone care about displays being connected or not?

Quoted 91 lines

then target D3Cold state is D3Cold-VRSR
otherwise target state is D3COLD-Off.

---
 drivers/gpu/drm/xe/display/xe_display.c | 22 ++++++++++++++++++++++
 drivers/gpu/drm/xe/display/xe_display.h |  1 +
 drivers/gpu/drm/xe/xe_pm.c              | 12 ++++++++++++
 3 files changed, 35 insertions(+)
drivers/gpu/drm/xe/display/xe_display.c +22 -0
index 02a413a07382..140a43d6b1b6 100644
@@ -548,3 +548,25 @@ int xe_display_probe(struct xe_device *xe)
 	unset_display_features(xe);
 	return 0;
 }
+
+bool xe_display_connected(struct xe_device *xe)
+{
+	struct drm_connector *list_connector;
+	struct drm_connector_list_iter iter;
+	bool ret = false;
+
+	mutex_lock(&xe->drm.mode_config.mutex);
+	drm_connector_list_iter_begin(&xe->drm, &iter);
+
+	drm_for_each_connector_iter(list_connector, &iter) {
+		if (list_connector->status == connector_status_connected) {
+			ret = true;
+			break;
+		}
+	}
+
+	drm_connector_list_iter_end(&iter);
+	mutex_unlock(&xe->drm.mode_config.mutex);
+
+	return ret;
+}
drivers/gpu/drm/xe/display/xe_display.h +1 -0
index 685dc74402fb..c6bc54323084 100644
@@ -40,6 +40,7 @@ void xe_display_pm_resume(struct xe_device *xe);
 void xe_display_pm_runtime_suspend(struct xe_device *xe);
 void xe_display_pm_runtime_suspend_late(struct xe_device *xe);
 void xe_display_pm_runtime_resume(struct xe_device *xe);
+bool xe_display_connected(struct xe_device *xe);
 
 #else
 
drivers/gpu/drm/xe/xe_pm.c +12 -0
index 81e67b5693dc..6d28aedcb062 100644
@@ -198,6 +198,14 @@ static void xe_rpm_lockmap_release(const struct xe_device *xe)
 			 &xe_pm_runtime_d3cold_map);
 }
 
+static void xe_pm_suspend_prepare(struct xe_device *xe)
+{
+	if (pm_suspend_target_state == PM_SUSPEND_TO_IDLE)
+		xe_pm_d3cold_allowed_toggle(xe);
+	else
+		xe->d3cold.allowed = XE_D3COLD_OFF;
+}
+
 /**
  * xe_pm_suspend - Helper for System suspend, i.e. S0->S3 / S0->S2idle
  * @xe: xe device instance
@@ -213,6 +221,8 @@ int xe_pm_suspend(struct xe_device *xe)
 	drm_dbg(&xe->drm, "Suspending device\n");
 	trace_xe_pm_suspend(xe, __builtin_return_address(0));
 
+	xe_pm_suspend_prepare(xe);
+
 	err = xe_pxp_pm_suspend(xe->pxp);
 	if (err)
 		goto err;
@@ -875,6 +885,8 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
 
 	if (total_vram_used_mb < xe->d3cold.vram_threshold)
 		xe->d3cold.allowed = XE_D3COLD_OFF;
+	else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
+		xe->d3cold.allowed = XE_D3COLD_VRSR;
 	else
 		xe->d3cold.allowed = XE_D3HOT;
 
Signature · 1 line
2.34.1
Signature · 2 lines
Ville Syrjälä
Intel
#21 lore raw

RE: [RFC 5/6] drm/xe/pm: D3Cold target state

Quoted 13 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Tuesday, February 25, 2025 11:20 PM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; De Marchi, Lucas <[email protected]>; Vivi, Rodrigo <[email protected]>; Nilawar, Badal <[email protected]>; Nasim, Kam <[email protected]>
Subject: Re: [RFC 5/6] drm/xe/pm: D3Cold target state

Quoted 6 lines
Quoted 3 lines · Anshuman Gupta

Trade-off D3Cold target state based upon current vram usages. if vram usages is greater than vram_d3cold_threshold and GPU has display connected

Why would anyone care about displays being connected or not?

As per specs we got to enable vrsr only when there is display connected,
We can check that in probe but a drm connector status can change after completion of probe. That is the reason to put a check for display connected in idle callback. Thanks,
Anshuman

Quoted 98 lines

drivers/gpu/drm/xe/xe_pm.c static void xe_rpm_lockmap_release(const struct

Quoted 59 lines

then target D3Cold state is D3Cold-VRSR otherwise target state is D3COLD-Off.

---
 drivers/gpu/drm/xe/display/xe_display.c | 22 ++++++++++++++++++++++
drivers/gpu/drm/xe/display/xe_display.h |  1 +
 drivers/gpu/drm/xe/xe_pm.c              | 12 ++++++++++++
 3 files changed, 35 insertions(+)
drivers/gpu/drm/xe/display/xe_display.c +21 -0
index 02a413a07382..140a43d6b1b6 100644
@@ -548,3 +548,25 @@ int xe_display_probe(struct xe_device *xe)
 	unset_display_features(xe);
 	return 0;
 }
+
+bool xe_display_connected(struct xe_device *xe) {
+	struct drm_connector *list_connector;
+	struct drm_connector_list_iter iter;
+	bool ret = false;
+
+	mutex_lock(&xe->drm.mode_config.mutex);
+	drm_connector_list_iter_begin(&xe->drm, &iter);
+
+	drm_for_each_connector_iter(list_connector, &iter) {
+		if (list_connector->status == connector_status_connected) {
+			ret = true;
+			break;
+		}
+	}
+
+	drm_connector_list_iter_end(&iter);
+	mutex_unlock(&xe->drm.mode_config.mutex);
+
+	return ret;
+}
drivers/gpu/drm/xe/display/xe_display.h +0 -0
index 685dc74402fb..c6bc54323084 100644
@@ -40,6 +40,7 @@ void xe_display_pm_resume(struct xe_device *xe);

void xe_display_pm_runtime_suspend(struct xe_device *xe); void xe_display_pm_runtime_suspend_late(struct xe_device *xe); void xe_display_pm_runtime_resume(struct xe_device *xe);

drivers/gpu/drm/xe/display/xe_display.h +1 -0
+bool xe_display_connected(struct xe_device *xe);
 
 #else
drivers/gpu/drm/xe/xe_pm.c +0 -0
index 81e67b5693dc..6d28aedcb062 100644
@@ -198,6 +198,14 @@ static void xe_rpm_lockmap_release(const struct

xe_device *xe)

drivers/gpu/drm/xe/xe_pm.c void xe_pm_d3cold_allowed_toggle(struct

Quoted 22 lines
drivers/gpu/drm/xe/xe_pm.c +8 -0
 			 &xe_pm_runtime_d3cold_map);
 }
 
+static void xe_pm_suspend_prepare(struct xe_device *xe) {
+	if (pm_suspend_target_state == PM_SUSPEND_TO_IDLE)
+		xe_pm_d3cold_allowed_toggle(xe);
+	else
+		xe->d3cold.allowed = XE_D3COLD_OFF; }
+
 /**
  * xe_pm_suspend - Helper for System suspend, i.e. S0->S3 / S0->S2idle
  * @xe: xe device instance
@@ -213,6 +221,8 @@ int xe_pm_suspend(struct xe_device *xe)
 	drm_dbg(&xe->drm, "Suspending device\n");
 	trace_xe_pm_suspend(xe, __builtin_return_address(0));
 
+	xe_pm_suspend_prepare(xe);
+
 	err = xe_pxp_pm_suspend(xe->pxp);
 	if (err)
 		goto err;
@@ -875,6 +885,8 @@ void xe_pm_d3cold_allowed_toggle(struct

xe_device

Quoted 11 lines
drivers/gpu/drm/xe/xe_pm.c +2 -1
 *xe)
 
 	if (total_vram_used_mb < xe->d3cold.vram_threshold)
 		xe->d3cold.allowed = XE_D3COLD_OFF;
+	else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
+		xe->d3cold.allowed = XE_D3COLD_VRSR;
 	else
 		xe->d3cold.allowed = XE_D3HOT;
 
--

2.34.1

--
Ville Syrjälä
Intel

#22 lore raw

Re: [RFC 5/6] drm/xe/pm: D3Cold target state

Quoted 13 lines · Anshuman
Quoted 13 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Tuesday, February 25, 2025 11:20 PM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; De Marchi, Lucas <[email protected]>; Vivi, Rodrigo <[email protected]>; Nilawar, Badal <[email protected]>; Nasim, Kam <[email protected]>
Subject: Re: [RFC 5/6] drm/xe/pm: D3Cold target state

Quoted 7 lines
Quoted 6 lines · Anshuman Gupta
Quoted 3 lines

Trade-off D3Cold target state based upon current vram usages. if vram usages is greater than vram_d3cold_threshold and GPU has display connected

Why would anyone care about displays being connected or not?

As per specs we got to enable vrsr only when there is display connected,

What specs? And why do they say connected displays should be a factor here?

I think the only thing that makes any sense for this kind of stuff would be sysfs power/ knobs that allow the system administrator to tune the behaviour for their specific use case. And if no such knobs exist currently then perhaps they should be added.

Quoted 101 lines

We can check that in probe but a drm connector status can change after completion of probe. That is the reason to put a check for display connected in idle callback. Thanks,
Anshuman

Quoted 98 lines

drivers/gpu/drm/xe/xe_pm.c static void xe_rpm_lockmap_release(const struct

Quoted 59 lines

then target D3Cold state is D3Cold-VRSR otherwise target state is D3COLD-Off.

---
 drivers/gpu/drm/xe/display/xe_display.c | 22 ++++++++++++++++++++++
drivers/gpu/drm/xe/display/xe_display.h |  1 +
 drivers/gpu/drm/xe/xe_pm.c              | 12 ++++++++++++
 3 files changed, 35 insertions(+)
drivers/gpu/drm/xe/display/xe_display.c +21 -0
index 02a413a07382..140a43d6b1b6 100644
@@ -548,3 +548,25 @@ int xe_display_probe(struct xe_device *xe)
 	unset_display_features(xe);
 	return 0;
 }
+
+bool xe_display_connected(struct xe_device *xe) {
+	struct drm_connector *list_connector;
+	struct drm_connector_list_iter iter;
+	bool ret = false;
+
+	mutex_lock(&xe->drm.mode_config.mutex);
+	drm_connector_list_iter_begin(&xe->drm, &iter);
+
+	drm_for_each_connector_iter(list_connector, &iter) {
+		if (list_connector->status == connector_status_connected) {
+			ret = true;
+			break;
+		}
+	}
+
+	drm_connector_list_iter_end(&iter);
+	mutex_unlock(&xe->drm.mode_config.mutex);
+
+	return ret;
+}
drivers/gpu/drm/xe/display/xe_display.h +0 -0
index 685dc74402fb..c6bc54323084 100644
@@ -40,6 +40,7 @@ void xe_display_pm_resume(struct xe_device *xe);

void xe_display_pm_runtime_suspend(struct xe_device *xe); void xe_display_pm_runtime_suspend_late(struct xe_device *xe); void xe_display_pm_runtime_resume(struct xe_device *xe);

drivers/gpu/drm/xe/display/xe_display.h +1 -0
+bool xe_display_connected(struct xe_device *xe);
 
 #else
drivers/gpu/drm/xe/xe_pm.c +0 -0
index 81e67b5693dc..6d28aedcb062 100644
@@ -198,6 +198,14 @@ static void xe_rpm_lockmap_release(const struct

xe_device *xe)

drivers/gpu/drm/xe/xe_pm.c void xe_pm_d3cold_allowed_toggle(struct

Quoted 22 lines
drivers/gpu/drm/xe/xe_pm.c +8 -0
 			 &xe_pm_runtime_d3cold_map);
 }
 
+static void xe_pm_suspend_prepare(struct xe_device *xe) {
+	if (pm_suspend_target_state == PM_SUSPEND_TO_IDLE)
+		xe_pm_d3cold_allowed_toggle(xe);
+	else
+		xe->d3cold.allowed = XE_D3COLD_OFF; }
+
 /**
  * xe_pm_suspend - Helper for System suspend, i.e. S0->S3 / S0->S2idle
  * @xe: xe device instance
@@ -213,6 +221,8 @@ int xe_pm_suspend(struct xe_device *xe)
 	drm_dbg(&xe->drm, "Suspending device\n");
 	trace_xe_pm_suspend(xe, __builtin_return_address(0));
 
+	xe_pm_suspend_prepare(xe);
+
 	err = xe_pxp_pm_suspend(xe->pxp);
 	if (err)
 		goto err;
@@ -875,6 +885,8 @@ void xe_pm_d3cold_allowed_toggle(struct

xe_device

Quoted 11 lines
drivers/gpu/drm/xe/xe_pm.c +2 -1
 *xe)
 
 	if (total_vram_used_mb < xe->d3cold.vram_threshold)
 		xe->d3cold.allowed = XE_D3COLD_OFF;
+	else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
+		xe->d3cold.allowed = XE_D3COLD_VRSR;
 	else
 		xe->d3cold.allowed = XE_D3HOT;
 
--

2.34.1

--
Ville Syrjälä
Intel

Signature · 2 lines
Ville Syrjälä
Intel
#23 lore raw

RFC 6/6 drm/xe/vrsr: Enable VRSR

In reply to Anshuman Gupta

Enabling VRSR in runtime suspend and also in System wide suspend. Also fix couple of typo in xe_pm.c.

---
 drivers/gpu/drm/xe/xe_pci.c |  4 +--
 drivers/gpu/drm/xe/xe_pm.c  | 49 +++++++++++++++++++++++++++----------
 2 files changed, 38 insertions(+), 15 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +2 -2
index 70b697fde5b9..55b42b3a10d2 100644
@@ -967,7 +967,7 @@ static int xe_pci_suspend(struct device *dev)
 
 	/*
 	 * Enabling D3Cold is needed for S2Idle/S0ix.
-	 * It is save to allow here since xe_pm_suspend has evicted
+	 * It is safe to allow here since xe_pm_suspend has evicted
 	 * the local memory and the direct complete optimization is disabled.
 	 */
 	d3cold_toggle(pdev, D3COLD_ENABLE);
@@ -983,7 +983,7 @@ static int xe_pci_resume(struct device *dev)
 	struct pci_dev *pdev = to_pci_dev(dev);
 	int err;
 
-	/* Give back the D3Cold decision to the runtime P M*/
+	/* Give back the D3Cold decision to the runtime PM */
 	d3cold_toggle(pdev, D3COLD_DISABLE);
 
 	err = pci_set_power_state(pdev, PCI_D0);
drivers/gpu/drm/xe/xe_pm.c +36 -13

103 lines not on this page · raw message

Signature · 1 line
2.34.1
Acked-by on v1 6/6
#24 lore raw

Re: [RFC,6/6] drm/xe/vrsr: Enable VRSR

Quoted 140 lines · Anshuman Gupta

Enabling VRSR in runtime suspend and also in System wide suspend. Also fix couple of typo in xe_pm.c.

---
  drivers/gpu/drm/xe/xe_pci.c |  4 +--
  drivers/gpu/drm/xe/xe_pm.c  | 49 +++++++++++++++++++++++++++----------
  2 files changed, 38 insertions(+), 15 deletions(-)
drivers/gpu/drm/xe/xe_pci.c +2 -2
index 70b697fde5b9..55b42b3a10d2 100644
@@ -967,7 +967,7 @@ static int xe_pci_suspend(struct device *dev)
 
  	/*
  	 * Enabling D3Cold is needed for S2Idle/S0ix.
-	 * It is save to allow here since xe_pm_suspend has evicted
+	 * It is safe to allow here since xe_pm_suspend has evicted
  	 * the local memory and the direct complete optimization is disabled.
  	 */
  	d3cold_toggle(pdev, D3COLD_ENABLE);
@@ -983,7 +983,7 @@ static int xe_pci_resume(struct device *dev)
  	struct pci_dev *pdev = to_pci_dev(dev);
  	int err;
 
-	/* Give back the D3Cold decision to the runtime P M*/
+	/* Give back the D3Cold decision to the runtime PM */
  	d3cold_toggle(pdev, D3COLD_DISABLE);
 
  	err = pci_set_power_state(pdev, PCI_D0);
drivers/gpu/drm/xe/xe_pm.c +35 -12
index 6d28aedcb062..5c96f8629a87 100644
@@ -232,10 +232,12 @@ int xe_pm_suspend(struct xe_device *xe)
 
  	xe_display_pm_suspend(xe);
 
-	/* FIXME: Super racey... */
-	err = xe_bo_evict_all(xe);
-	if (err)
-		goto err_pxp;
+	if (xe->d3cold.allowed == XE_D3COLD_OFF) {
+		/* FIXME: Super racey... */
+		err = xe_bo_evict_all(xe);
+		if (err)
+			goto err_pxp;
+	}
 
  	for_each_gt(gt, xe, id) {
  		err = xe_gt_suspend(gt);
@@ -247,6 +249,12 @@ int xe_pm_suspend(struct xe_device *xe)
 
  	xe_display_pm_suspend_late(xe);
 
+	if (xe->d3cold.allowed == XE_D3COLD_VRSR) {
+		err = xe_pm_enable_vrsr(xe, true);
+			if (err)
+				goto err_display;
+	}
+
  	drm_dbg(&xe->drm, "Device suspended\n");
  	return 0;
 
@@ -288,9 +296,11 @@ int xe_pm_resume(struct xe_device *xe)
  	 * This only restores pinned memory which is the memory required for the
  	 * GT(s) to resume.
  	 */
-	err = xe_bo_restore_kernel(xe);
-	if (err)
-		goto err;
+	if (xe->d3cold.allowed == XE_D3COLD_OFF) {
+		err = xe_bo_restore_kernel(xe);
+		if (err)
+			goto err;
+	}
 
  	xe_irq_resume(xe);
 
@@ -299,9 +309,11 @@ int xe_pm_resume(struct xe_device *xe)
 
  	xe_display_pm_resume(xe);
 
-	err = xe_bo_restore_user(xe);
-	if (err)
-		goto err;
+	if (xe->d3cold.allowed == XE_D3COLD_OFF) {
+		err = xe_bo_restore_user(xe);
+		if (err)
+			goto err;
+	}
 
  	xe_pxp_pm_resume(xe->pxp);
 
@@ -543,7 +555,7 @@ int xe_pm_runtime_suspend(struct xe_device *xe)
 
  	xe_display_pm_runtime_suspend(xe);
 
-	if (xe->d3cold.allowed) {
+	if (xe->d3cold.allowed == XE_D3COLD_OFF) {
  		err = xe_bo_evict_all(xe);
  		if (err)
  			goto out_resume;
@@ -559,6 +571,14 @@ int xe_pm_runtime_suspend(struct xe_device *xe)
 
  	xe_display_pm_runtime_suspend_late(xe);
 
+	if (xe->d3cold.allowed == XE_D3COLD_VRSR) {
+		err = xe_pm_enable_vrsr(xe, true);
+			if (err) {
+				drm_err(&xe->drm, "Failed to enable VRSR: %d\n", err);
+				goto out_resume;
+			}
+	}
+
  	xe_rpm_lockmap_release(xe);
  	xe_pm_write_callback_task(xe, NULL);
  	return 0;
@@ -590,7 +610,7 @@ int xe_pm_runtime_resume(struct xe_device *xe)
 
  	xe_rpm_lockmap_acquire(xe);
 
-	if (xe->d3cold.allowed) {
+	if (xe->d3cold.allowed == XE_D3COLD_OFF) {
  		err = xe_pcode_ready(xe, true);
  		if (err)
  			goto out;
@@ -606,6 +626,9 @@ int xe_pm_runtime_resume(struct xe_device *xe)
  			goto out;
  	}
 
+	if (xe->d3cold.allowed == XE_D3COLD_VRSR)
+		xe_display_pm_resume_early(xe);
+
  	xe_irq_resume(xe);
 
  	for_each_gt(gt, xe, id)

drivers/gpu/drm/xe/xe_pm.c int xe_pm_runtime_resume(struct xe_device *xe) · line 642

Quoted 8 lines
drivers/gpu/drm/xe/xe_pm.c +1 -1
@@ -613,7 +636,7 @@ int xe_pm_runtime_resume(struct xe_device *xe)
 
  	xe_display_pm_runtime_resume(xe);
 
-	if (xe->d3cold.allowed) {
+	if (xe->d3cold.allowed == XE_D3COLD_OFF) {
  		err = xe_bo_restore_user(xe);
  		if (err)
  			goto out;

LGTM.

#25 lore raw

✓ CI.Patch_applied: success for VRAM Self Refresh

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: VRAM Self Refresh
URL : https://patchwork.freedesktop.org/series/145342/
State : success

== Summary ==

=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 0bd853a9790b drm-tip: 2025y-02m-24d-21h-45m-35s UTC integration manifest === git am output follows ===
Applying: PCI/ACPI: Implement PCI FW _DSM method
Applying: drm/xe/vrsr: Detect vrsr capability
Applying: drm/xe/vrsr: Apis to init and enable VRSR feature
Applying: drm/xe/vrsr: Refactor d3cold.allowed to a enum
Applying: drm/xe/pm: D3Cold target state
Applying: drm/xe/vrsr: Enable VRSR

#26 lore raw

✗ CI.checkpatch: warning for VRAM Self Refresh

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: VRAM Self Refresh
URL : https://patchwork.freedesktop.org/series/145342/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 85df9e260df2e80b85847f9127dffd1fd9006312

Author: Anshuman Gupta <[email protected]>
Date:   Mon Feb 24 22:18:49 2025 +0530

drm/xe/vrsr: Enable VRSR

Enabling VRSR in runtime suspend and also in System wide suspend. Also fix couple of typo in xe_pm.c.

+ /mt/dim checkpatch 0bd853a9790bbe9c4ccf3bf2c521958d1df41d54 drm-intel
9b0cd6391d03 PCI/ACPI: Implement PCI FW _DSM method
-:9: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #9:
Current assumption is only one PCIe Endpoint driver (XeKMD for Battlemage GPU)

-:91: WARNING:LONG_LINE: line length of 114 exceeds 100 columns #91: FILE: drivers/pci/pci-acpi.c:1484:
+ "D3cold Aux Power request needs retry. Interval: %d seconds.\n", retry_interval);

-:95: WARNING:LONG_LINE: line length of 114 exceeds 100 columns #95: FILE: drivers/pci/pci-acpi.c:1488:
+ dev_err(&dev->dev, "D3cold Aux Power: Reserved or unsupported response: 0x%x.\n", result);

-:133: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #133: FILE: drivers/pci/pci-acpi.c:1526:
+ DSM_PCI_PERST_ASSERTION_DELAY, &in_obj, ACPI_TYPE_INTEGER);

-:146: WARNING:LONG_LINE: line length of 116 exceeds 100 columns #146: FILE: drivers/pci/pci-acpi.c:1539:
+ "PERST# Assertion Delay request failed. Previous valid delay: %u microseconds.\n", result);

total: 0 errors, 5 warnings, 0 checks, 158 lines checked 90567f1f2c5a drm/xe/vrsr: Detect vrsr capability
46b8052151f6 drm/xe/vrsr: Apis to init and enable VRSR feature -:87: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #87: FILE: drivers/gpu/drm/xe/xe_pm.c:118:
+ ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_D3_VRAM_SELF_REFRESH,
+ PCODE_D3_VRSR_SC_AUX_PL_AND_PERST_DELAY, 0),

-:136: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #136: FILE: drivers/gpu/drm/xe/xe_pm.c:167:
+ ret = xe_pcode_write(root_tile, PCODE_MBOX(PCODE_D3_VRAM_SELF_REFRESH,
+ PCODE_D3_VRSR_SC_ENABLE, 0), uval);

-:139: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #139: FILE: drivers/gpu/drm/xe/xe_pm.c:170:
+ ret = xe_pcode_write(root_tile, PCODE_MBOX(PCODE_D3_VRAM_SELF_REFRESH,
+ PCODE_D3_VRSR_SC_DISABLE, 0), uval);

total: 0 errors, 0 warnings, 3 checks, 137 lines checked c27067331201 drm/xe/vrsr: Refactor d3cold.allowed to a enum 675eae51fcb4 drm/xe/pm: D3Cold target state 85df9e260df2 drm/xe/vrsr: Enable VRSR

#27 lore raw

✗ CI.KUnit: failure for VRAM Self Refresh

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: VRAM Self Refresh
URL : https://patchwork.freedesktop.org/series/145342/
State : failure

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig ERROR:root:In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,

                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/tests/xe_pci_test.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_bb.c:9:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_bo.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/tests/xe_rtp_test.c:16:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_bo_evict.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/tests/xe_wa_test.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_devcoredump.c:15:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_device.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_device_sysfs.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_drm_client.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_dma_buf.c:17:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_exec.c:14:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_vm_types.h:16,
                 from ../drivers/gpu/drm/xe/xe_exec_queue.h:10,
                 from ../drivers/gpu/drm/xe/xe_exec_queue.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_execlist.c:14:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_force_wake.h:9,
                 from ../drivers/gpu/drm/xe/xe_force_wake.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_ggtt.c:20:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_gsc.c:17:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_gsc_proxy.c:17:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gsc_debugfs.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_gsc_submit.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt.h:13,
                 from ../drivers/gpu/drm/xe/xe_gt.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_gt_ccs_mode.c:9:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_gt_clock.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_gt_freq.c:16:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_force_wake.h:9,
                 from ../drivers/gpu/drm/xe/xe_gt_idle.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_gt_topology.h:9,
                 from ../drivers/gpu/drm/xe/xe_gt_mcr.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_mcr.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt_pagefault.c:15:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt.h:13,
                 from ../drivers/gpu/drm/xe/xe_gt_sysfs.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt_throttle.c:9:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c:9:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_gt_topology.h:9,
                 from ../drivers/gpu/drm/xe/xe_gt_topology.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt.h:13,
                 from ../drivers/gpu/drm/xe/xe_guc.h:9,
                 from ../drivers/gpu/drm/xe/xe_guc.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_ads.c:18:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_guc_buf.c:9:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_capture.c:19:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_guc_db_mgr.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_ct.c:20:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
  156 | u64 ioread64_lo_hi(const void __iomem *addr)
      |     ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
  163 | u64 ioread64_hi_lo(const void __iomem *addr)
      |     ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
  170 | u64 ioread64be_lo_hi(const void __iomem *addr)
      |     ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
  178 | u64 ioread64be_hi_lo(const void __iomem *addr)
      |     ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
  264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
      |      ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
  272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
      |      ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
  280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
      |      ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
  288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
      |      ^~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_engine_activity.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_hwconfig.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_guc_id_mgr.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_guc_submit.c:20:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      [00:08:11] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[00:08:15] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json ARCH=um O=.kunit --jobs=48
|     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_heci_gsc.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_pc.c:17:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_huc.c:15:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_guc_log.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_hw_engine.c:16:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c:10:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_hw_engine_group.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_hw_fence.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/display/xe_display.h:9,
                 from ../drivers/gpu/drm/xe/xe_irq.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_migrate.c:21:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_lrc.c:18:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_mmio.h:9,
                 from ../drivers/gpu/drm/xe/xe_mmio.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_mocs.c:9:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_oa.c:20:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_pat.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_pcode.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/display/xe_display.h:9,
                 from ../drivers/gpu/drm/xe/xe_pci.c:18:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_vm_types.h:16,
                 from ../drivers/gpu/drm/xe/xe_exec_queue.h:10,
                 from ../drivers/gpu/drm/xe/xe_preempt_fence.c:10:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_pt.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/display/xe_display.h:9,
                 from ../drivers/gpu/drm/xe/xe_pm.c:15:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_pxp_debugfs.c:14:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_pxp.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_pxp_submit.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_query.c:17:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_reg_whitelist.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/xe/xe_pm.c: In function ‘xe_pm_d3cold_allowed_toggle’:
../drivers/gpu/drm/xe/xe_pm.c:911:45: error: implicit declaration of function ‘xe_display_connected’; did you mean ‘xe_display_create’? [-Werror=implicit-function-declaration]
  911 |         else if (xe->d3cold.vrsr_capable && xe_display_connected(xe))
      |                                             ^~~~~~~~~~~~~~~~~~~~
      |                                             xe_display_create
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_reg_sr.c:18:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt.h:13,
                 from ../drivers/gpu/drm/xe/xe_rtp.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt.h:13,
                 from ../drivers/gpu/drm/xe/xe_ring_ops.c:16:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_sa.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_step.c:10:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_sched_job.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_survivability_mode.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_sync.c:17:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_tile.h:9,
                 from ../drivers/gpu/drm/xe/xe_tile_sysfs.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[7]: *** [../scripts/Makefile.build:207: drivers/gpu/drm/xe/xe_pm.o] Error 1
make[7]: *** Waiting for unfinished jobs....
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_tile.c:10:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_trace.h:18,
                 from ../drivers/gpu/drm/xe/xe_trace.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_trace_guc.h:15,
                 from ../drivers/gpu/drm/xe/xe_trace_guc.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_trace_bo.h:15,
                 from ../drivers/gpu/drm/xe/xe_trace_bo.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_trace_lrc.h:15,
                 from ../drivers/gpu/drm/xe/xe_trace_lrc.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_ttm_sys_mgr.c:15:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c:18:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_tuning.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_vsec.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_ttm_vram_mgr.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_uc.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_wa.h:9,
                 from ../drivers/gpu/drm/xe/xe_wa.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_vm.h:9,
                 from ../drivers/gpu/drm/xe/xe_vm.c:6:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_uc_fw.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_vram.c:14:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_vram_freq.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_hwmon.c:15:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_wopcm.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_sriov.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_wait_user_fence.c:13:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_gt_sriov_vf.c:19:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_vm.h:9,
                 from ../drivers/gpu/drm/xe/xe_hmm.c:14:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c:10:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_guc_relay.c:19:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_memirq.c:12:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_gt_types.h:9,
                 from ../drivers/gpu/drm/xe/xe_assert.h:13,
                 from ../drivers/gpu/drm/xe/xe_sriov_vf.c:8:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_bo_types.h:15,
                 from ../drivers/gpu/drm/xe/xe_bo.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:14:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/xe/xe_device_types.h:10,
                 from ../drivers/gpu/drm/xe/xe_device.h:11,
                 from ../drivers/gpu/drm/xe/xe_gt.h:13,
                 from ../drivers/gpu/drm/xe/xe_gt_sriov_pf.c:11:
../include/linux/pci-acpi.h:143:5: warning: no previous prototype for ‘pci_acpi_request_d3cold_aux_power’ [-Wmissing-prototypes]
  143 | int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/pci-acpi.h:148:5: warning: no previous prototype for ‘pci_acpi_add_perst_assertion_delay’ [-Wmissing-prototypes]
  148 | int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[6]: *** [../scripts/Makefile.build:465: drivers/gpu/drm/xe] Error 2
make[5]: *** [../scripts/Makefile.build:465: drivers/gpu/drm] Error 2
make[4]: *** [../scripts/Makefile.build:465: drivers/gpu] Error 2
make[3]: *** [../scripts/Makefile.build:465: drivers] Error 2
make[2]: *** [/kernel/Makefile:1989: .] Error 2
make[1]: *** [/kernel/Makefile:251: __sub-make] Error 2
make: *** [Makefile:251: __sub-make] Error 2

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel