Skip to contentSkip to conversation

scsi: scsi_debug: Fix addition of uninitialized variable len

PATCH New Colin Ian King 1 participant 1 message Feb 25, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: scsi_debug: Fix addition of uninitialized variable len

There is an addition on a previously uninitialized variable len that results in an undefined result. Fix this by making the addition an assignment. Issue detected with static analysis.

Fixes 568354b24c7d ("scsi: scsi_debug: Add compression mode page for tapes")
---
 drivers/scsi/scsi_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_debug.c +1 -1
index 722ee8c067ae..f3e9a63bbf02 100644
@@ -3032,7 +3032,7 @@ static int resp_mode_sense(struct scsi_cmnd *scp,
 	case 0xf:	/* Compression Mode Page (tape) */
 		if (!is_tape)
 			goto bad_pcode;
-		len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
+		len = resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
 		offset += len;
 		break;
 	case 0x11:	/* Partition Mode Page (tape) */
Signature · 1 line
2.47.2