scsi: hisi: remove incorrect ACPI_PTR annotations
Subsystems (2)
PATCH 1/1 scsi: hisi: remove incorrect ACPI_PTR annotations
From: Arnd Bergmann <[email protected]>
Building with W=1 shows a warning about sas_v2_acpi_match being unused when CONFIG_OF is disabled:
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
--- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +1 -1
@@ -1806,7 +1806,7 @@ static struct platform_driver hisi_sas_v1_driver = { .driver = { .name = DRV_NAME, .of_match_table = sas_v1_of_match, - .acpi_match_table = ACPI_PTR(sas_v1_acpi_match), + .acpi_match_table = sas_v1_acpi_match, }, };
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +1 -1
@@ -3653,7 +3653,7 @@ static struct platform_driver hisi_sas_v2_driver = { .driver = { .name = DRV_NAME, .of_match_table = sas_v2_of_match, - .acpi_match_table = ACPI_PTR(sas_v2_acpi_match), + .acpi_match_table = sas_v2_acpi_match, }, };
Signature · 1 line
2.39.5
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Building with W=1 shows a warning about
sas_v2_acpi_matchbeing unused whenCONFIG_OFis disabled:drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]Signed-off-by Arnd Bergmann <[email protected]>
Looks OK to me.
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Building with W=1 shows a warning about
sas_v2_acpi_matchbeing unused whenCONFIG_OFis disabled:drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]Signed-off-by Arnd Bergmann <[email protected]>
Looks good. So Reviewed-by: Yihang Li <[email protected]>
Hello,
Quoted 11 lines · Yihang Li
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Building with W=1 shows a warning about
sas_v2_acpi_matchbeing unused whenCONFIG_OFis disabled:drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]Signed-off-by Arnd Bergmann <[email protected]>Looks good. So Reviewed-by: Yihang Li <[email protected]>
If you put your Reviewed-by tag in a separate line, the tooling that most maintainers use pick it up automatically. Martin applied your patch (currently as commit 7a9c0476d4073e742f474e71feeef4f54add4bc9 in
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging ) indeed without your tag.
Best regards
Uwe
Quoted 13 lines · Uwe Kleine-König
Hello,
Quoted 10 lines · Yihang Li
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Building with W=1 shows a warning about
sas_v2_acpi_matchbeing unused whenCONFIG_OFis disabled:drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]Signed-off-by Arnd Bergmann <[email protected]>
Quoted 8 lines
Quoted 1 line
Looks good. So Reviewed-by: Yihang Li <[email protected]>
If you put your Reviewed-by tag in a separate line, the tooling that most maintainers use pick it up automatically. Martin applied your patch (currently as commit
7a9c0476d4073e742f474e71feeef4f54add4bc9in
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging ) indeed without your tag.
Ok, thanks for the reminder. I'll pay attention next time.
Thanks
Yihang
Martin K. Petersen
AppliedArnd,
Quoted 2 lines
Building with W=1 shows a warning about
sas_v2_acpi_matchbeing unused whenCONFIG_OFis disabled:
Applied to 6.15/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Arnd Bergmann
Building with W=1 shows a warning about
sas_v2_acpi_matchbeing unused whenCONFIG_OFis disabled:drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
Applied to 6.15/scsi-queue, thanks!
[1/1] scsi: hisi: remove incorrect ACPI_PTR annotations
https://git.kernel.org/mkp/scsi/c/7a9c0476d407
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering