Skip to contentSkip to conversation

dt-bindings: display: mitsubishi,aa104xd12: Allow jeida-18 for data-mapping

PATCH Applied Rob Herring (Arm) 2 participants 6 messages Feb 25, 2025 – Mar 6, 2025

Subsystems (4)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: display: mitsubishi,aa104xd12: Allow jeida-18 for data-mapping

There's both a user and the datasheet[1] indicate that 6-bpp is supported as well.

[1] https://agdisplays.com/pub/media/catalog/datasheet/Mitsubishi/AA104XD12.pdf

---
 .../bindings/display/panel/mitsubishi,aa104xd12.yaml          | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml +3 -1
index 3623ffa6518d..2c92d81caaaf 100644
@@ -33,7 +33,9 @@ properties:
     description: Reference to the regulator powering the panel VCC pins.
 
   data-mapping:
-    const: jeida-24
+    enum:
+      - jeida-18
+      - jeida-24
 
   width-mm:
     const: 210
Signature · 1 line
2.47.2
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: display: mitsubishi,aa104xd12: Adjust allowed and required properties

The Mitsubishi aa104xd12 panel requires an external backlight driver circuit, so allow the "backlight" property.

There are users of this panel without a vcc-supply, so it shouldn't be required.

---
 .../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml +1 -1
index 2c92d81caaaf..96621b89ae9e 100644
@@ -43,6 +43,7 @@ properties:
   height-mm:
     const: 158
 
+  backlight: true
   panel-timing: true
   port: true
 
@@ -50,7 +51,6 @@ additionalProperties: false
 
 required:
   - compatible
-  - vcc-supply
   - data-mapping
   - width-mm
   - height-mm
Signature · 1 line
2.47.2
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dt-bindings: display: mitsubishi,aa104xd12: Adjust allowed and required properties

Quoted 7 lines · Rob Herring (Arm)

The Mitsubishi aa104xd12 panel requires an external backlight driver circuit, so allow the "backlight" property.

There are users of this panel without a vcc-supply, so it shouldn't be required.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author maintainer Applied
#3 lore raw

Re: [PATCH 2/2] dt-bindings: display: mitsubishi,aa104xd12: Adjust allowed and required properties

In reply to Rob Herring (Arm)
Quoted 11 lines · Rob Herring (Arm)

The Mitsubishi aa104xd12 panel requires an external backlight driver circuit, so allow the "backlight" property.

There are users of this panel without a vcc-supply, so it shouldn't be required.

---
 .../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!

Reviewed-by on v1 1/2
#4 lore raw
In reply to Rob Herring (Arm)
Quoted 6 lines · Rob Herring (Arm)

There's both a user and the datasheet[1] indicate that 6-bpp is supported as well.

[1] https://agdisplays.com/pub/media/catalog/datasheet/Mitsubishi/AA104XD12.pdf

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds