clk: Print an error when clk registration fails
Stephen Boyd
maintainerPATCH 1/1 clk: Print an error when clk registration fails
We have a lot of driver code that prints an error message when registering a clk fails. Do that in the core function instead to consolidate code. This also helps drivers avoid the anti-pattern of accessing the struct clk_hw::init pointer after registration.
Signed-off-by Stephen Boyd <[email protected]>
--- drivers/clk/clk.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/clk/clk.c +7 -0
@@ -4397,6 +4397,13 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) fail_name:kref_put (&core->ref, __clk_release); fail_out: +if (dev) { +dev_err_probe (dev, ret,"failed to register clk '%s' (%pS)\n" , + init->name, hw); + }else { +pr_err ("%pOF: error %pe: failed to register clk '%s' (%pS)\n" , + np,ERR_PTR (ret), init->name, hw); + }return ERR_PTR (ret); }
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Quoting Stephen Boyd (2025-02-26 15:54:07)
Quoted 7 lines
We have a lot of driver code that prints an error message when registering a clk fails. Do that in the core function instead to consolidate code. This also helps drivers avoid the anti-pattern of accessing the struct
clk_hw::initpointer after registration.Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next