bpf/selftests: test_select_reuseport_kern: remove unused header
Subsystems (3)
PATCH 1/1 bpf/selftests: test_select_reuseport_kern: remove unused header
test_select_reuseport_kern.c is currently including <stdlib.h>, but it does not use any definition from there.
Remove stdlib.h inclusion from test_select_reuseport_kern.c
---
I stumbled upon this specific header include while trying to build selftests on the current bpf-next_base branch, which ended with this error:
[...]
CLNG-BPF [test_progs-cpuv4] test_select_reuseport_kern.bpf.o
In file included from progs/test_select_reuseport_kern.c:4:/usr/include/bits/floatn.h:83:52: error: unsupported machine mode '__TC__'
83 | typedef _Complex float __cfloat128 __attribute__ ((__mode__
(__TC__)));
| ^/usr/include/bits/floatn.h:97:9: error: __float128 is not supported on this target
97 | typedef __float128 _Float128;
The exact error (unknown TC mode) is likely rather due to some issues in my local build, in which I am actually cross-compiling selftests (for ARM64 from a x86_64 host, but not through vmtests.sh), and I still have to sort out some other issues. But I guess it is not really right anyway to include stdlib.h from an ebpf program, especially if it is not used, so I am still proposing this small change.
--- tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c | 1 - 1 file changed, 1 deletion(-)
tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c +0 -1
@@ -1,7 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2018 Facebook */ -#include <stdlib.h> #include <linux/in.h> #include <linux/ip.h> #include <linux/ipv6.h>
---
base-commit: 072c40912477ebac2ef98cd0b1532ba9bebda20a
change-id: 20250227-remove_wrong_header-02d288d64204
Best regards,
Signature · 3 lines
Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Quoted 8 lines · On Thu, 27 Feb 2025 15:08:23 +0100 you wrote:
test_select_reuseport_kern.cis currently including <stdlib.h>, but it does not use any definition from there.Remove
stdlib.hinclusion fromtest_select_reuseport_kern.cSigned-off-by Alexis Lothoré (eBPF Foundation) <[email protected]>[...]
Here is the summary with links:
- bpf/selftests: test_select_reuseport_kern: remove unused header
https://git.kernel.org/bpf/bpf-next/c/0b9363131daf
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html