um/locking: Remove semicolon from "lock" prefix
Subsystems (2)
PATCH 1/1 um/locking: Remove semicolon from "lock" prefix
Minimum version of binutils required to compile the kernel is 2.25. This version correctly handles the "lock" prefix, so it is possible to remove the semicolon, which was used to support ancient versions of GNU as.
Due to the semicolon, the compiler considers "lock; insn" as two separate instructions. Removing the semicolon makes asm length calculations more accurate, consequently making scheduling and inlining decisions of the compiler more accurate.
Removing the semicolon also enables assembler checks involving lock prefix. Trying to assemble e.g. "lock andl %eax, %ebx" results in:
Error: expecting lockable instruction after `lock'
Signed-off-by Uros Bizjak <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc Anton Ivanov <[email protected]>
Cc Johannes Berg <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Dave Hansen <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
--- arch/x86/um/asm/barrier.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/um/asm/barrier.h +3 -3
@@ -12,9 +12,9 @@*/ #ifdef CONFIG_X86_32 -#define mb () alternative("lock; addl $0,0(%%esp)", "mfence", X86_FEATURE_XMM2) -#define rmb () alternative("lock; addl $0,0(%%esp)", "lfence", X86_FEATURE_XMM2) -#define wmb () alternative("lock; addl $0,0(%%esp)", "sfence", X86_FEATURE_XMM) +#define mb () alternative("lock addl $0,0(%%esp)", "mfence", X86_FEATURE_XMM2) +#define rmb () alternative("lock addl $0,0(%%esp)", "lfence", X86_FEATURE_XMM2) +#define wmb () alternative("lock addl $0,0(%%esp)", "sfence", X86_FEATURE_XMM)#else /* CONFIG_X86_32 */
Signature · 1 line
2.48.1