Skip to contentSkip to conversation

KVM: selftests: Fix printf() format goof in SEV smoke test

PATCH Applied Sean Christopherson 1 participant 2 messages Feb 28, 2025 – Mar 5, 2025

Subsystems (3)
lore
Share & tools
lore

Sean Christopherson

author maintainer
#0 lore raw

PATCH 1/1 KVM: selftests: Fix printf() format goof in SEV smoke test

Print out the index of mismatching XSAVE bytes using unsigned decimal format. Some versions of clang complain about trying to print an integer as an unsigned char.

x86/sev_smoke_test.c:55:51: error: format specifies type 'unsigned char'
but the argument has type 'int' [-Werror,-Wformat]

Fixes 8c53183dbaa2 ("selftests: kvm: add test for transferring FPU state into VMSA")
---
 tools/testing/selftests/kvm/x86/sev_smoke_test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/kvm/x86/sev_smoke_test.c +2 -1
index a1a688e75266..d97816dc476a 100644
@@ -52,7 +52,8 @@ static void compare_xsave(u8 *from_host, u8 *from_guest)
 	bool bad = false;
 	for (i = 0; i < 4095; i++) {
 		if (from_host[i] != from_guest[i]) {
-			printf("mismatch at %02hhx | %02hhx %02hhx\n", i, from_host[i], from_guest[i]);
+			printf("mismatch at %u | %02hhx %02hhx\n",
+			       i, from_host[i], from_guest[i]);
 			bad = true;
 		}
 	}

base-commit: fed48e2967f402f561d80075a20c5c9e16866e53

Signature · 1 line
2.48.1.711.g2feabab25a-goog
author maintainer Applied
#1 lore raw
Quoted 8 lines · Sean Christopherson

Print out the index of mismatching XSAVE bytes using unsigned decimal format. Some versions of clang complain about trying to print an integer as an unsigned char.

x86/sev_smoke_test.c:55:51: error: format specifies type 'unsigned char'
but the argument has type 'int' [-Werror,-Wformat]

[...]

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: selftests: Fix printf() format goof in SEV smoke test

      https://github.com/kvm-x86/linux/commit/3b2d3db36801

--
https://github.com/kvm-x86/linux/tree/next