Skip to contentSkip to conversation

ASoC: tegra: Fix ADX S24_LE audio format

PATCH RESEND In review Thorsten Blum 3 participants 3 messages Mar 2, 2025 – Mar 3, 2025

Subsystems (4)
Stable branch Sound ASoC Tegra architecture support
lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH RESEND 1/1 ASoC: tegra: Fix ADX S24_LE audio format

Commit 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format") added support for the S24_LE audio format, but duplicated S16_LE in OUT_DAI() for ADX instead.

Fix this by adding support for the S24_LE audio format.

Compile-tested only.

Cc [email protected]
Fixes 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
Signed-off-by Thorsten Blum <[email protected]>
---
 sound/soc/tegra/tegra210_adx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/tegra/tegra210_adx.c +2 -2
index 3e6e8f51f380..0aa93b948378 100644
@@ -264,7 +264,7 @@ static const struct snd_soc_dai_ops tegra210_adx_out_dai_ops = {
 			.rates = SNDRV_PCM_RATE_8000_192000,	\
 			.formats = SNDRV_PCM_FMTBIT_S8 |	\
 				   SNDRV_PCM_FMTBIT_S16_LE |	\
-				   SNDRV_PCM_FMTBIT_S16_LE |	\
+				   SNDRV_PCM_FMTBIT_S24_LE |	\
 				   SNDRV_PCM_FMTBIT_S32_LE,	\
 		},						\
 		.capture = {					\

@@ -274,7 +274,7 @@ static const struct snd_soc_dai_ops tegra210_adx_out_dai_ops = {
 			.rates = SNDRV_PCM_RATE_8000_192000,	\
 			.formats = SNDRV_PCM_FMTBIT_S8 |	\
 				   SNDRV_PCM_FMTBIT_S16_LE |	\
-				   SNDRV_PCM_FMTBIT_S16_LE |	\
+				   SNDRV_PCM_FMTBIT_S24_LE |	\
 				   SNDRV_PCM_FMTBIT_S32_LE,	\
 		},						\
 		.ops = &tegra210_adx_out_dai_ops,		\
Signature · 1 line
2.48.1
maintainer
#1 lore raw
Quoted 3 lines · Thorsten Blum

Commit 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format") added support for the S24_LE audio format, but duplicated S16_LE in OUT_DAI() for ADX instead.

Please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.

Acked-by on v1 1/1
#2 lore raw
In reply to Thorsten Blum
Quoted 6 lines · Thorsten Blum

Commit 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format") added support for the S24_LE audio format, but duplicated S16_LE in OUT_DAI() for ADX instead.

Fix this by adding support for the S24_LE audio format.

Quoted 8 lines

Compile-tested only.

Cc [email protected]
Fixes 4204eccc7b2a ("ASoC: tegra: Add support for S24_LE audio format")
Signed-off-by Thorsten Blum <[email protected]>
---
 sound/soc/tegra/tegra210_adx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Good catch!

Acked-by Thierry Reding <[email protected]>