Skip to contentSkip to conversation

Unwired pvrdma_modify_device ?

DISCUSSION Dr. David Alan Gilbert 3 participants 6 messages Mar 2, 2025 – Mar 4, 2025 InfiniBand

lore
Share & tools
lore
#0 lore raw

Hi,
I noticed that pvrdma_modify_device() in
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?

(I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it).

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#1 lore raw
Quoted 7 lines · Dr. David Alan Gilbert

Hi,
I noticed that pvrdma_modify_device() in
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?

(I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it).

Seems probably right

But at this point I'd just delete it unless pvrdma maintainers say otherwise in the next week

Jason

#2 lore raw
Quoted 8 lines · * Jason Gunthorpe ([email protected]) wrote:
Quoted 7 lines · Dr. David Alan Gilbert

Hi,
I noticed that pvrdma_modify_device() in
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?

(I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it).

Hi Jason,
Thanks for the reply,

Quoted 4 lines

Seems probably right

But at this point I'd just delete it unless pvrdma maintainers say otherwise in the next week

OK, lets see if they wake up.

Dave

Quoted 1 line

Jason

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#3 lore raw
Quoted 13 lines · Dr. David Alan Gilbert
Quoted 8 lines · * Jason Gunthorpe ([email protected]) wrote:
Quoted 7 lines · Dr. David Alan Gilbert

Hi,
I noticed that pvrdma_modify_device() in
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?

(I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it).

Hi Jason,
Thanks for the reply,

Quoted 8 lines
Quoted 4 lines

Seems probably right

But at this point I'd just delete it unless pvrdma maintainers say otherwise in the next week

OK, lets see if they wake up.

Dave

Thanks David for bringing this up. You're right, it looks like we never wired it up to pvrdma_dev_ops. Feel free to remove it.

#4 lore raw
Quoted 20 lines · * Bryan Tan ([email protected]) wrote:
Quoted 18 lines · Dr. David Alan Gilbert
Quoted 8 lines · * Jason Gunthorpe ([email protected]) wrote:
Quoted 7 lines · Dr. David Alan Gilbert

Hi,
I noticed that pvrdma_modify_device() in
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?

(I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it).

Hi Jason,
Thanks for the reply,

Quoted 4 lines

Seems probably right

But at this point I'd just delete it unless pvrdma maintainers say otherwise in the next week

Quoted 6 lines
Quoted 3 lines

OK, lets see if they wake up.

Dave

Thanks David for bringing this up. You're right, it looks like we never wired it up to pvrdma_dev_ops. Feel free to remove it.

Hi Bryan,
Thanks for the reply - OK, I'll send a patch later to remove it.

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#5 lore raw
Quoted 23 lines · * Dr. David Alan Gilbert ([email protected]) wrote:
Quoted 22 lines · * Bryan Tan ([email protected]) wrote:
Quoted 20 lines · Dr. David Alan Gilbert
Quoted 8 lines · * Jason Gunthorpe ([email protected]) wrote:
Quoted 7 lines · Dr. David Alan Gilbert

Hi,
I noticed that pvrdma_modify_device() in
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?

(I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it).

Hi Jason,
Thanks for the reply,

Quoted 4 lines

Seems probably right

But at this point I'd just delete it unless pvrdma maintainers say otherwise in the next week

OK, lets see if they wake up.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Dave

Thanks David for bringing this up. You're right, it looks like we never wired it up to pvrdma_dev_ops. Feel free to remove it.

Hi Bryan,
Thanks for the reply - OK, I'll send a patch later to remove it.

Just sent, See [email protected]

Dave

Quoted 8 lines

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/