Skip to contentSkip to conversation

Add Synopsys DesignWare HDMI RX Controller

PATCH In review Dmitry Osipenko 4 participants 16 messages Mar 4, 2025 – Apr 4, 2025

Subsystems (4)
lore
Share & tools
lore

Dmitry Osipenko

author maintainer
#0 lore raw

v13 cover Add Synopsys DesignWare HDMI RX Controller

Note RE the MAINTAINERS patch:
Shreeya is currently busy and will be maintaining driver later on. I'm helping to upstream the driver meantime.

This series implements support for the Synopsys DesignWare HDMI RX Controller, being compliant with standard HDMI 1.4b and HDMI 2.0.

Features that are currently supported by the HDMI RX driver have been tested on rock5b board using a HDMI to micro-HDMI cable. It is recommended to use a good quality cable as there were multiple issues seen during testing the driver.

Please note the below information :-
* HDMIRX driver now only works with the opensource TF-A.
* We have tested the working of OBS studio with HDMIRX driver and there were no issues seen.
* We tested and verified the support for interlaced video.
* We tested capturing of YUV formats.

To test the HDMI RX Controller driver, following example commands can be used :-

root@debian-rockchip-rock5b-rk3588:~#  v4l2-ctl --stream-mmap \
--stream-count=100 --stream-to=/home/hdmiin4k.raw
root@debian-rockchip-rock5b-rk3588:~# ffmpeg -f rawvideo -vcodec rawvideo \
-s 1920x1080 -r 60 -pix_fmt bgr24 -i /home/hdmiin4k.raw output.mkv

CEC compliance test results :-

* https://gitlab.collabora.com/-/snippets/380
* https://gitlab.collabora.com/-/snippets/381

Following is the v4l2-compliance test result :-

root@debian-rockchip-rock5b-rk3588:~# v4l2-compliance -d /dev/video1
v4l2-compliance 1.29.0-5326, 64 bits, 64-bit time_t
v4l2-compliance SHA: 77f5df419204 2025-02-07 08:59:59

Compliance test for snps_hdmirx device /dev/video1:

Driver Info:

        Driver name      : snps_hdmirx
        Card type        : snps_hdmirx
        Bus info         : platform:fdee0000.hdmi_receiver
        Driver version   : 6.14.0
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format

Required ioctls:
test VIDIOC_QUERYCAP: OK
test invalid ioctls: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 1 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK test VIDIOC_DV_TIMINGS_CAP: OK
test VIDIOC_G/S_EDID: OK

Control ioctls (Input 0):
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0

Format ioctls (Input 0):
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK
test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls (Input 0):
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls (Input 0):
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test CREATE_BUFS maximum buffers: OK test VIDIOC_REMOVE_BUFS: OK
test VIDIOC_EXPBUF: OK
test Requests: OK (Not Supported) test blocking wait: OK

Test input 0:

Streaming ioctls:
test read/write: OK (Not Supported)
test MMAP (no poll, REQBUFS): OK
test MMAP (select, REQBUFS): OK
test MMAP (epoll, REQBUFS): OK
test MMAP (no poll, CREATE_BUFS): OK test MMAP (select, CREATE_BUFS): OK
test MMAP (epoll, CREATE_BUFS): OK
test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device

Total for snps_hdmirx device /dev/video1: 57, Succeeded: 57, Failed: 0, Warnings: 0

---

InfoFrame debugfs example output:-

# edid-decode -c -I /sys/kernel/debug/v4l2/fdee0000.hdmi_receiver/infoframes/avi
edid-decode InfoFrame (hex):

82 02 0d b1 12 28 84 00 00 00 00 00 00 00 00 00
00

----------------

HDMI InfoFrame Checksum: 0xb1

AVI InfoFrame
Version: 2
Length: 13
Y: Color Component Sample Format: RGB
A: Active Format Information Present: Yes
B: Bar Data Present: Bar Data not present
S: Scan Information: Composed for an underscanned display
C: Colorimetry: No Data
M: Picture Aspect Ratio: 16:9
R: Active Portion Aspect Ratio: 8
ITC: IT Content: IT Content (CN is valid)
EC: Extended Colorimetry: xvYCC601
Q: RGB Quantization Range: Limited Range
SC: Non-Uniform Picture Scaling: No Known non-uniform scaling
YQ: YCC Quantization Range: Limited Range
CN: IT Content Type: Graphics
PR: Pixel Data Repetition Count: 0
Line Number of End of Top Bar: 0
Line Number of Start of Bottom Bar: 0
Pixel Number of End of Left Bar: 0
Pixel Number of Start of Right Bar: 0

----------------

edid-decode 1.29.0-5326
edid-decode SHA: 77f5df419204 2025-02-07 08:59:59

AVI InfoFrame conformity: PASS

---

Changes in v13 :-
- Removed CEC adapter notifier as it's not used by this driver

Changes in v12 :-
- Removed legacy wait_finish/prepare() callbacks from vb2_ops, tested that driver works without them.
- Updated and extended driver Kconfig description RE the LOAD_DEFAULT_EDID option.
- Made minor cosmetical improvements to the code

Changes in v11 :-
- Reverted back defconfig patch by removing LOAD_DEFAULT_EDID=y option
- Removed CEC notifier since it's not needed for this driver
- Replaced video_unregister_device() with vb2_video_unregister_device()
- Added more clarifying comments to the code and updated the timing sanity-check, borrowing it from a newer downstream driver version.

Changes in v10 :-
- Replaced cec_unregister_adapter() with cec_notifier_cec_adap_unregister() in the error unwinding code path of the driver probe, tested that it works properly.
- Changed CEC registration code to propagate original error code to the driver's probe-failure code path on the CEC registration failure.
- Enabled LOAD_DEFAULT_EDID=y in the defconfig patch

Changes in v9 :-
- Added devm_add_action_or_reset() to free reserved memory properly on driver probe error
- Extra minor code cleanups

Changes in v8 :-
- Changed HPD logic as was requested by Hans Verkuil. HPD handling is now decoupled from HDMI plugin/out events and works independently from 5v status.
- Bumped number of EDID blocks from 2 to 4 as was requested by Hans Verkuil and verified that reading 3/4 EDID blocks from transmitter works properly.
- Made few extra minor cleanup/improvements to the driver code

Changes in v7 :-
- Changed InfoFrame debugfs to return truncated payload data
- Updated cover-letter example stream capture cmdline with a minimized and cleaned version of the cmdline
- Added AVI InfoFrame example output to the cover-letter

Changes in v6 :-
- Driver now keeps HPD low instead of zeroing EDID when EDID-clearing is invoked and when default EDID usage is disabled in the kernel config
- Added InfoFrame debugfs support
- Added another code comment clarifying validation of timing values
- Rebased on top of recent media-next tree

Changes in v5 :-
- Fix the interrupt IRQ number in the dt-bindings and device tree
- Add alignment property to ensure hdmi-receiver-cma starts at a 64KB-aligned address
- Change the MODULE_DESCRIPTION
- Add VIDEO_SYNOPSYS_HDMIRX as prefix to the default edid config
- Drop the enabling of default edid in the Kconfig
- Replace the default EDID with hdmi-4k-300mhz EDID produced by v4l2-ctl tool for better compatibility with various HDMI cables and adapters
- Rework the write_edid and set_edid functions
- During format change, retrieve the current pixel format, color depth, and AVI infoframe details instead of only detecting the format
- Improve the logging mechanism and delays in the hdmirx_wait_signal_lock function
- Fix the 4K@60 capturing for RGB format
- Document what hdmirx_check_timing_valid function does
- Rework the hdmirx_get_detected_timings function
- Fix the NV16/24 size image value
- Add the implementation from Benjamin Hoff to expose the ITC type to v4l2
- Remove all the firmware related code

Changes in v4 :-
- Remove DTS changes included in the device tree patch
- Remove the hdmi rx pin info as it's already present in the rk3588-base-pinctrl.dtsi
- Create a separate config option for selecting the EDID and enable it by default
- Improve the comment related to DV timings and move it to the side of hdmirx_get_detected_timings
- Add 100ms delay before pulling the HPD high
- Do not return the detected timings from VIDIOC_G_DV_TIMINGS
- Drop the bus info from hdmirx_querycap
- If *num_planes != 0 then return 0 in hdmirx_queue_setup
- Set queue->min_queued_buffers to 1
- Drop q->allow_cache_hints = 0; as it's always 0 by default
- Add a comment for q->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
- Drop .read = vb2_fop_read as it's not supported by driver
- Remove redundant edid_init_data_600M
- Make HPD low when driver is loaded
- Add support for reading AVI Infoframe
- Remove msg_len checks from hdmirx_cec_transmit
- Add info about the CEC compliance test in the cover letter
- Add arbitration lost status
- Validate the physical address inside the EDID

Changes in v3 :-
- Use v4l2-common helpers in the HDMIRX driver
- Rename cma node and phandle names
- Elaborate the comment to explain 160MiB calculation
- Move &hdmi_receiver_cma to the rock5b dts file
- Add information about interlaced video testing in the cover-letter

Changes in v2 :-
- Fix checkpatch --strict warnings
- Move the dt-binding include file changes in a separate patch
- Add a description for the hardware in the dt-bindings file
- Rename resets, vo1 grf and HPD properties
- Add a proper description for grf and vo1-grf phandles in the bindings
- Rename the HDMI RX node name to hdmi-receiver
- Include gpio header file in binding example to fix the dt_binding_check failure
- Move hdmirx_cma node to the rk3588.dtsi file
- Add an entry to MAINTAINERS file for the HDMIRX driver

Sebastian Reichel (2):
arm64: dts: rockchip: Enable HDMI receiver on rock-5b
arm64: defconfig: Enable Synopsys HDMI receiver

Shreeya Patel (4):
MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver
dt-bindings: media: Document bindings for HDMI RX Controller
media: platform: synopsys: Add support for HDMI input driver
arm64: dts: rockchip: Add device tree support for HDMI RX Controller

 .../bindings/media/snps,dw-hdmi-rx.yaml       |  132 +
 MAINTAINERS                                   |    8 +
 .../dts/rockchip/rk3588-base-pinctrl.dtsi     |   14 +
 .../arm64/boot/dts/rockchip/rk3588-extra.dtsi |   57 +
 .../boot/dts/rockchip/rk3588-rock-5b.dts      |   18 +
 arch/arm64/configs/defconfig                  |    1 +
 drivers/media/platform/Kconfig                |    1 +
 drivers/media/platform/Makefile               |    1 +
 drivers/media/platform/synopsys/Kconfig       |    3 +
 drivers/media/platform/synopsys/Makefile      |    2 +
 .../media/platform/synopsys/hdmirx/Kconfig    |   35 +
 .../media/platform/synopsys/hdmirx/Makefile   |    4 +
 .../platform/synopsys/hdmirx/snps_hdmirx.c    | 2750 +++++++++++++++++
 .../platform/synopsys/hdmirx/snps_hdmirx.h    |  394 +++
 .../synopsys/hdmirx/snps_hdmirx_cec.c         |  275 ++
 .../synopsys/hdmirx/snps_hdmirx_cec.h         |   43 +
 16 files changed, 3738 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
 create mode 100644 drivers/media/platform/synopsys/Kconfig
 create mode 100644 drivers/media/platform/synopsys/Makefile
 create mode 100644 drivers/media/platform/synopsys/hdmirx/Kconfig
 create mode 100644 drivers/media/platform/synopsys/hdmirx/Makefile
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.c
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.h
Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#1 lore raw

PATCH v13 1/6 MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver

From: Shreeya Patel <[email protected]>

Add an entry for Synopsys DesignWare HDMI Receiver Controller Driver.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index 2286200b355b..1bb6a54e41c6 100644
@@ -22952,6 +22952,14 @@ F:	drivers/net/pcs/pcs-xpcs.c
 F:	drivers/net/pcs/pcs-xpcs.h
 F:	include/linux/pcs/pcs-xpcs.h
 
+SYNOPSYS DESIGNWARE HDMI RX CONTROLLER DRIVER
+M:	Shreeya Patel <[email protected]>
+L:	[email protected]
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
+F:	drivers/media/platform/synopsys/hdmirx/*
+
 SYNOPSYS DESIGNWARE I2C DRIVER
 M:	Jarkko Nikula <[email protected]>
 R:	Andy Shevchenko <[email protected]>
Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#2 lore raw

PATCH v13 2/6 dt-bindings: media: Document bindings for HDMI RX Controller

In reply to Dmitry Osipenko

From: Shreeya Patel <[email protected]>

Document bindings for the Synopsys DesignWare HDMI RX Controller.

---
 .../bindings/media/snps,dw-hdmi-rx.yaml       | 132 ++++++++++++++++++
 1 file changed, 132 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml new file +132 -0
new file mode 100644
index 000000000000..510e94e9ca3a
@@ -0,0 +1,132 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Device Tree bindings for Synopsys DesignWare HDMI RX Controller
+
+---
+$id: http://devicetree.org/schemas/media/snps,dw-hdmi-rx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synopsys DesignWare HDMI RX Controller
+
+maintainers:
+  - Shreeya Patel <[email protected]>
+
+description:
+  Synopsys DesignWare HDMI Input Controller preset on RK3588 SoCs
+  allowing devices to receive and decode high-resolution video streams
+  from external sources like media players, cameras, laptops, etc.
+
+properties:
+  compatible:
+    items:
+      - const: rockchip,rk3588-hdmirx-ctrler
+      - const: snps,dw-hdmi-rx
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 3
+
+  interrupt-names:
+    items:
+      - const: cec
+      - const: hdmi
+      - const: dma
+
+  clocks:
+    maxItems: 7
+
+  clock-names:
+    items:
+      - const: aclk
+      - const: audio
+      - const: cr_para
+      - const: pclk
+      - const: ref
+      - const: hclk_s_hdmirx
+      - const: hclk_vo1
+
+  power-domains:
+    maxItems: 1
+
+  resets:
+    maxItems: 4
+
+  reset-names:
+    items:
+      - const: axi
+      - const: apb
+      - const: ref
+      - const: biu
+
+  memory-region:
+    maxItems: 1
+
+  hpd-gpios:
+    description: GPIO specifier for HPD.
+    maxItems: 1
+
+  rockchip,grf:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      The phandle of the syscon node for the general register file
+      containing HDMIRX PHY status bits.
+
+  rockchip,vo1-grf:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      The phandle of the syscon node for the Video Output GRF register
+      to enable EDID transfer through SDAIN and SCLIN.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - clocks
+  - clock-names
+  - power-domains
+  - resets
+  - pinctrl-0
+  - hpd-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/rockchip,rk3588-cru.h>
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/rk3588-power.h>
+    #include <dt-bindings/reset/rockchip,rk3588-cru.h>
+    hdmi_receiver: hdmi-receiver@fdee0000 {
+      compatible = "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx";
+      reg = <0xfdee0000 0x6000>;
+      interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH 0>,
+                   <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH 0>,
+                   <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH 0>;
+      interrupt-names = "cec", "hdmi", "dma";
+      clocks = <&cru ACLK_HDMIRX>,
+               <&cru CLK_HDMIRX_AUD>,
+               <&cru CLK_CR_PARA>,
+               <&cru PCLK_HDMIRX>,
+               <&cru CLK_HDMIRX_REF>,
+               <&cru PCLK_S_HDMIRX>,
+               <&cru HCLK_VO1>;
+      clock-names = "aclk",
+                    "audio",
+                    "cr_para",
+                    "pclk",
+                    "ref",
+                    "hclk_s_hdmirx",
+                    "hclk_vo1";
+      power-domains = <&power RK3588_PD_VO1>;
+      resets = <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>,
+               <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>;
+      reset-names = "axi", "apb", "ref", "biu";
+      memory-region = <&hdmi_receiver_cma>;
+      pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_5v_detection>;
+      pinctrl-names = "default";
+      hpd-gpios = <&gpio1 22 GPIO_ACTIVE_LOW>;
+    };
Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#3 lore raw

PATCH v13 3/6 media: platform: synopsys: Add support for HDMI input driver

In reply to Dmitry Osipenko

From: Shreeya Patel <[email protected]>

Add initial support for the Synopsys DesignWare HDMI RX Controller Driver used by Rockchip RK3588. The driver supports:
- HDMI 1.4b and 2.0 modes (HDMI 4k@60Hz)
- RGB888, YUV422, YUV444 and YCC420 pixel formats
- CEC
- EDID configuration

The hardware also has Audio and HDCP capabilities, but these are not yet supported by the driver.

---
 drivers/media/platform/Kconfig                |    1 +
 drivers/media/platform/Makefile               |    1 +
 drivers/media/platform/synopsys/Kconfig       |    3 +
 drivers/media/platform/synopsys/Makefile      |    2 +
 .../media/platform/synopsys/hdmirx/Kconfig    |   35 +
 .../media/platform/synopsys/hdmirx/Makefile   |    4 +
 .../platform/synopsys/hdmirx/snps_hdmirx.c    | 2750 +++++++++++++++++
 .../platform/synopsys/hdmirx/snps_hdmirx.h    |  394 +++
 .../synopsys/hdmirx/snps_hdmirx_cec.c         |  275 ++
 .../synopsys/hdmirx/snps_hdmirx_cec.h         |   43 +
 10 files changed, 3508 insertions(+)
 create mode 100644 drivers/media/platform/synopsys/Kconfig
 create mode 100644 drivers/media/platform/synopsys/Makefile
 create mode 100644 drivers/media/platform/synopsys/hdmirx/Kconfig
 create mode 100644 drivers/media/platform/synopsys/hdmirx/Makefile
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.c
 create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.h
drivers/media/platform/Kconfig +1 -0
index 85d2627776b6..9287faafdce5 100644
@@ -85,6 +85,7 @@ source "drivers/media/platform/rockchip/Kconfig"
 source "drivers/media/platform/samsung/Kconfig"
 source "drivers/media/platform/st/Kconfig"
 source "drivers/media/platform/sunxi/Kconfig"
+source "drivers/media/platform/synopsys/Kconfig"
 source "drivers/media/platform/ti/Kconfig"
 source "drivers/media/platform/verisilicon/Kconfig"
 source "drivers/media/platform/via/Kconfig"
drivers/media/platform/Makefile +1 -0
index ace4e34483dd..6fd7db0541c7 100644
@@ -28,6 +28,7 @@ obj-y += rockchip/
 obj-y += samsung/
 obj-y += st/
 obj-y += sunxi/
+obj-y += synopsys/
 obj-y += ti/
 obj-y += verisilicon/
 obj-y += via/
drivers/media/platform/synopsys/Kconfig new file +3 -0
new file mode 100644
index 000000000000..4fd521f78425
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+source "drivers/media/platform/synopsys/hdmirx/Kconfig"
drivers/media/platform/synopsys/Makefile new file +2 -0
new file mode 100644
index 000000000000..3b12c574dd67
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-y += hdmirx/
drivers/media/platform/synopsys/hdmirx/Kconfig new file +35 -0
new file mode 100644
index 000000000000..27e6706f84a3
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: GPL-2.0
+
+config VIDEO_SYNOPSYS_HDMIRX
+	tristate "Synopsys DesignWare HDMI Receiver driver"
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
+	select VIDEO_V4L2_SUBDEV_API
+	select VIDEOBUF2_DMA_CONTIG
+	select CEC_CORE
+	select HDMI
+	help
+	  Support for Synopsys HDMI HDMI RX Controller.
+	  This driver supports HDMI 2.0 version.
+
+	  To compile this driver as a module, choose M here. The module
+	  will be called synopsys_hdmirx.
+
+config VIDEO_SYNOPSYS_HDMIRX_LOAD_DEFAULT_EDID
+	bool "Load default EDID"
+	depends on VIDEO_SYNOPSYS_HDMIRX
+	help
+	  Preload default EDID (Extended Display Identification Data)
+	  branded by Linux Foundation that exposes display modes up
+	  to 4k@30Hz, which have best compatibility with HDMI transmitters.
+
+	  Enabling this option is recommended for a non-production use-cases.
+	  It will make driver usable out-of-the-box.
+
+	  For a higher display modes you will need to load customized EDID
+	  from userspace using v4l2-ctl tool or by other means.
+
+	  Without enabling this option driver will be practically
+	  non-functional until EDID will be loaded from userspace.
+	  Which is a wanted behavior when using this driver in a
+	  commercial product that should utilize own branded EDID.
drivers/media/platform/synopsys/hdmirx/Makefile new file +4 -0
new file mode 100644
index 000000000000..2fa2d9e25300
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
+synopsys-hdmirx-objs := snps_hdmirx.o snps_hdmirx_cec.o
+
+obj-$(CONFIG_VIDEO_SYNOPSYS_HDMIRX) += synopsys-hdmirx.o
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c new file +2750 -0

2,750 lines not on this page · raw message

drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h new file +394 -0

192 lines not on this page · raw message

drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.c new file +275 -0

275 lines not on this page · raw message

drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.h new file +43 -0

43 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Part of the diff is not shown here. View the raw message.

author maintainer
#4 lore raw

PATCH v13 4/6 arm64: dts: rockchip: Add device tree support for HDMI RX Controller

In reply to Dmitry Osipenko

From: Shreeya Patel <[email protected]>

Add device tree support for Synopsys DesignWare HDMI RX Controller.

---
 .../dts/rockchip/rk3588-base-pinctrl.dtsi     | 14 +++++
 .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++
 2 files changed, 71 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi +14 -0
index 7f874c77410c..2d4b9986a177 100644
@@ -594,6 +594,20 @@ hdmim0_tx1_hpd: hdmim0-tx1-hpd {
 				/* hdmim0_tx1_hpd */
 				<1 RK_PA6 5 &pcfg_pull_none>;
 		};
+
+		/omit-if-no-ref/
+		hdmim1_rx: hdmim1-rx {
+			rockchip,pins =
+				/* hdmim1_rx_cec */
+				<3 RK_PD1 5 &pcfg_pull_none>,
+				/* hdmim1_rx_scl */
+				<3 RK_PD2 5 &pcfg_pull_none_smt>,
+				/* hdmim1_rx_sda */
+				<3 RK_PD3 5 &pcfg_pull_none_smt>,
+				/* hdmim1_rx_hpdin */
+				<3 RK_PD4 5 &pcfg_pull_none>;
+		};
+
 		/omit-if-no-ref/
 		hdmim1_rx_cec: hdmim1-rx-cec {
 			rockchip,pins =
arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi +57 -0

69 lines not on this page · raw message

Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#5 lore raw

PATCH v13 5/6 arm64: dts: rockchip: Enable HDMI receiver on rock-5b

In reply to Dmitry Osipenko

From: Sebastian Reichel <[email protected]>

The Rock 5B has a Micro HDMI port, which can be used for receiving HDMI data. This enables support for it.

---
 .../arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +18 -0
index d597112f1d5b..377824e69e20 100644
@@ -220,6 +220,18 @@ hdmi0_out_con: endpoint {
 	};
 };
 
+&hdmi_receiver_cma {
+	status = "okay";
+};
+
+&hdmi_receiver {
+	status = "okay";
+	hpd-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>;
+	pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_hpd>;
+	pinctrl-names = "default";
+	memory-region = <&hdmi_receiver_cma>;
+};
+
 &hdptxphy_hdmi0 {
 	status = "okay";
 };
@@ -377,6 +389,12 @@ &pcie3x4 {
 };
 
 &pinctrl {
+	hdmirx {
+		hdmirx_hpd: hdmirx-5v-detection {
+			rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	hym8563 {
 		hym8563_int: hym8563-int {
 			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#6 lore raw

PATCH v13 6/6 arm64: defconfig: Enable Synopsys HDMI receiver

In reply to Dmitry Osipenko

From: Sebastian Reichel <[email protected]>

The Rockchip RK3588 has a built-in HDMI receiver block from Synopsys. Let's enable the driver for it.

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index cb7da4415599..6ed1ad3c0055 100644
@@ -859,6 +859,7 @@ CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC=m
 CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
 CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
 CONFIG_VIDEO_SUN6I_CSI=m
+CONFIG_VIDEO_SYNOPSYS_HDMIRX=m
 CONFIG_VIDEO_TI_J721E_CSI2RX=m
 CONFIG_VIDEO_HANTRO=m
 CONFIG_VIDEO_IMX219=m
Signature · 7 lines
2.48.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#7 lore raw
In reply to Dmitry Osipenko

Hi Dmitry,

it took a while to get my test setup going again. Sadly it does still not sync with AppleTV Device (which should be a standard-compliant HDMI-Device). In a few hours I will post a timing comparision with the vendor kernel. I don't know if this should block the merge or this should be fixed later.

Best regards
Tim

Quoted 346 lines · Dmitry Osipenko

Note RE the MAINTAINERS patch:
Shreeya is currently busy and will be maintaining driver later on. I'm helping to upstream the driver meantime.

This series implements support for the Synopsys DesignWare HDMI RX Controller, being compliant with standard HDMI 1.4b and HDMI 2.0.

Features that are currently supported by the HDMI RX driver have been tested on rock5b board using a HDMI to micro-HDMI cable. It is recommended to use a good quality cable as there were multiple issues seen during testing the driver.

Please note the below information :-
* HDMIRX driver now only works with the opensource TF-A.
* We have tested the working of OBS studio with HDMIRX driver and there were no issues seen.
* We tested and verified the support for interlaced video.
* We tested capturing of YUV formats.

To test the HDMI RX Controller driver, following example commands can be used :-

root@debian-rockchip-rock5b-rk3588:~#  v4l2-ctl --stream-mmap \
--stream-count=100 --stream-to=/home/hdmiin4k.raw
root@debian-rockchip-rock5b-rk3588:~# ffmpeg -f rawvideo -vcodec rawvideo \
-s 1920x1080 -r 60 -pix_fmt bgr24 -i /home/hdmiin4k.raw output.mkv

CEC compliance test results :-

* https://gitlab.collabora.com/-/snippets/380
* https://gitlab.collabora.com/-/snippets/381

Following is the v4l2-compliance test result :-

root@debian-rockchip-rock5b-rk3588:~# v4l2-compliance -d /dev/video1
v4l2-compliance 1.29.0-5326, 64 bits, 64-bit time_t
v4l2-compliance SHA: 77f5df419204 2025-02-07 08:59:59

Compliance test for snps_hdmirx device /dev/video1:

Driver Info:

         Driver name      : snps_hdmirx
         Card type        : snps_hdmirx
         Bus info         : platform:fdee0000.hdmi_receiver
         Driver version   : 6.14.0
         Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format

Required ioctls:
test VIDIOC_QUERYCAP: OK
test invalid ioctls: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 1 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK test VIDIOC_DV_TIMINGS_CAP: OK
test VIDIOC_G/S_EDID: OK

Control ioctls (Input 0):
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0

Format ioctls (Input 0):
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK
test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls (Input 0):
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls (Input 0):
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test CREATE_BUFS maximum buffers: OK test VIDIOC_REMOVE_BUFS: OK
test VIDIOC_EXPBUF: OK
test Requests: OK (Not Supported) test blocking wait: OK

Test input 0:

Streaming ioctls:
test read/write: OK (Not Supported)
test MMAP (no poll, REQBUFS): OK
test MMAP (select, REQBUFS): OK
test MMAP (epoll, REQBUFS): OK
test MMAP (no poll, CREATE_BUFS): OK test MMAP (select, CREATE_BUFS): OK
test MMAP (epoll, CREATE_BUFS): OK
test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device

Total for snps_hdmirx device /dev/video1: 57, Succeeded: 57, Failed: 0, Warnings: 0

---

InfoFrame debugfs example output:-

# edid-decode -c -I /sys/kernel/debug/v4l2/fdee0000.hdmi_receiver/infoframes/avi
edid-decode InfoFrame (hex):

82 02 0d b1 12 28 84 00 00 00 00 00 00 00 00 00
00

----------------

HDMI InfoFrame Checksum: 0xb1

AVI InfoFrame
Version: 2
Length: 13
Y: Color Component Sample Format: RGB
A: Active Format Information Present: Yes
B: Bar Data Present: Bar Data not present
S: Scan Information: Composed for an underscanned display
C: Colorimetry: No Data
M: Picture Aspect Ratio: 16:9
R: Active Portion Aspect Ratio: 8
ITC: IT Content: IT Content (CN is valid)
EC: Extended Colorimetry: xvYCC601
Q: RGB Quantization Range: Limited Range
SC: Non-Uniform Picture Scaling: No Known non-uniform scaling
YQ: YCC Quantization Range: Limited Range
CN: IT Content Type: Graphics
PR: Pixel Data Repetition Count: 0
Line Number of End of Top Bar: 0
Line Number of Start of Bottom Bar: 0
Pixel Number of End of Left Bar: 0
Pixel Number of Start of Right Bar: 0

----------------

edid-decode 1.29.0-5326
edid-decode SHA: 77f5df419204 2025-02-07 08:59:59

AVI InfoFrame conformity: PASS

---

Changes in v13 :-
- Removed CEC adapter notifier as it's not used by this driver

Changes in v12 :-
- Removed legacy wait_finish/prepare() callbacks from vb2_ops, tested that driver works without them.
- Updated and extended driver Kconfig description RE the LOAD_DEFAULT_EDID option.
- Made minor cosmetical improvements to the code

Changes in v11 :-
- Reverted back defconfig patch by removing LOAD_DEFAULT_EDID=y option
- Removed CEC notifier since it's not needed for this driver
- Replaced video_unregister_device() with vb2_video_unregister_device()
- Added more clarifying comments to the code and updated the timing sanity-check, borrowing it from a newer downstream driver version.

Changes in v10 :-
- Replaced cec_unregister_adapter() with cec_notifier_cec_adap_unregister() in the error unwinding code path of the driver probe, tested that it works properly.
- Changed CEC registration code to propagate original error code to the driver's probe-failure code path on the CEC registration failure.
- Enabled LOAD_DEFAULT_EDID=y in the defconfig patch

Changes in v9 :-
- Added devm_add_action_or_reset() to free reserved memory properly on driver probe error
- Extra minor code cleanups

Changes in v8 :-
- Changed HPD logic as was requested by Hans Verkuil. HPD handling is now decoupled from HDMI plugin/out events and works independently from 5v status.
- Bumped number of EDID blocks from 2 to 4 as was requested by Hans Verkuil and verified that reading 3/4 EDID blocks from transmitter works properly.
- Made few extra minor cleanup/improvements to the driver code

Changes in v7 :-
- Changed InfoFrame debugfs to return truncated payload data
- Updated cover-letter example stream capture cmdline with a minimized and cleaned version of the cmdline
- Added AVI InfoFrame example output to the cover-letter

Changes in v6 :-
- Driver now keeps HPD low instead of zeroing EDID when EDID-clearing is invoked and when default EDID usage is disabled in the kernel config
- Added InfoFrame debugfs support
- Added another code comment clarifying validation of timing values
- Rebased on top of recent media-next tree

Changes in v5 :-
- Fix the interrupt IRQ number in the dt-bindings and device tree
- Add alignment property to ensure hdmi-receiver-cma starts at a 64KB-aligned address
- Change the MODULE_DESCRIPTION
- Add VIDEO_SYNOPSYS_HDMIRX as prefix to the default edid config
- Drop the enabling of default edid in the Kconfig
- Replace the default EDID with hdmi-4k-300mhz EDID produced by v4l2-ctl tool for better compatibility with various HDMI cables and adapters
- Rework the write_edid and set_edid functions
- During format change, retrieve the current pixel format, color depth, and AVI infoframe details instead of only detecting the format
- Improve the logging mechanism and delays in the hdmirx_wait_signal_lock function
- Fix the 4K@60 capturing for RGB format
- Document what hdmirx_check_timing_valid function does
- Rework the hdmirx_get_detected_timings function
- Fix the NV16/24 size image value
- Add the implementation from Benjamin Hoff to expose the ITC type to v4l2
- Remove all the firmware related code

Changes in v4 :-
- Remove DTS changes included in the device tree patch
- Remove the hdmi rx pin info as it's already present in the rk3588-base-pinctrl.dtsi
- Create a separate config option for selecting the EDID and enable it by default
- Improve the comment related to DV timings and move it to the side of hdmirx_get_detected_timings
- Add 100ms delay before pulling the HPD high
- Do not return the detected timings from VIDIOC_G_DV_TIMINGS
- Drop the bus info from hdmirx_querycap
- If *num_planes != 0 then return 0 in hdmirx_queue_setup
- Set queue->min_queued_buffers to 1
- Drop q->allow_cache_hints = 0; as it's always 0 by default
- Add a comment for q->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
- Drop .read = vb2_fop_read as it's not supported by driver
- Remove redundant edid_init_data_600M
- Make HPD low when driver is loaded
- Add support for reading AVI Infoframe
- Remove msg_len checks from hdmirx_cec_transmit
- Add info about the CEC compliance test in the cover letter
- Add arbitration lost status
- Validate the physical address inside the EDID

Changes in v3 :-
- Use v4l2-common helpers in the HDMIRX driver
- Rename cma node and phandle names
- Elaborate the comment to explain 160MiB calculation
- Move &hdmi_receiver_cma to the rock5b dts file
- Add information about interlaced video testing in the cover-letter

Changes in v2 :-
- Fix checkpatch --strict warnings
- Move the dt-binding include file changes in a separate patch
- Add a description for the hardware in the dt-bindings file
- Rename resets, vo1 grf and HPD properties
- Add a proper description for grf and vo1-grf phandles in the bindings
- Rename the HDMI RX node name to hdmi-receiver
- Include gpio header file in binding example to fix the dt_binding_check failure
- Move hdmirx_cma node to the rk3588.dtsi file
- Add an entry to MAINTAINERS file for the HDMIRX driver

Sebastian Reichel (2):
arm64: dts: rockchip: Enable HDMI receiver on rock-5b
arm64: defconfig: Enable Synopsys HDMI receiver

Shreeya Patel (4):
MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver
dt-bindings: media: Document bindings for HDMI RX Controller
media: platform: synopsys: Add support for HDMI input driver
arm64: dts: rockchip: Add device tree support for HDMI RX Controller

  .../bindings/media/snps,dw-hdmi-rx.yaml       |  132 +
  MAINTAINERS                                   |    8 +
  .../dts/rockchip/rk3588-base-pinctrl.dtsi     |   14 +
  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi |   57 +
  .../boot/dts/rockchip/rk3588-rock-5b.dts      |   18 +
  arch/arm64/configs/defconfig                  |    1 +
  drivers/media/platform/Kconfig                |    1 +
  drivers/media/platform/Makefile               |    1 +
  drivers/media/platform/synopsys/Kconfig       |    3 +
  drivers/media/platform/synopsys/Makefile      |    2 +
  .../media/platform/synopsys/hdmirx/Kconfig    |   35 +
  .../media/platform/synopsys/hdmirx/Makefile   |    4 +
  .../platform/synopsys/hdmirx/snps_hdmirx.c    | 2750 +++++++++++++++++
  .../platform/synopsys/hdmirx/snps_hdmirx.h    |  394 +++
  .../synopsys/hdmirx/snps_hdmirx_cec.c         |  275 ++
  .../synopsys/hdmirx/snps_hdmirx_cec.h         |   43 +
  16 files changed, 3738 insertions(+)

create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml create mode 100644 drivers/media/platform/synopsys/Kconfig
create mode 100644 drivers/media/platform/synopsys/Makefile
create mode 100644 drivers/media/platform/synopsys/hdmirx/Kconfig create mode 100644 drivers/media/platform/synopsys/hdmirx/Makefile create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.c create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.h

#8 lore raw
Quoted 7 lines · Tim Surber

Hi Dmitry,

it took a while to get my test setup going again. Sadly it does still not sync with AppleTV Device (which should be a standard-compliant HDMI-Device). In a few hours I will post a timing comparision with the vendor kernel. I don't know if this should block the merge or this should be fixed later.

I'll wait until Thursday before making a decision. Hopefully there is some clarity by then whether or not this is a blocker.

Regards,

Hans

Quoted 352 lines

Best regards
Tim

Quoted 346 lines · Dmitry Osipenko

Note RE the MAINTAINERS patch:
Shreeya is currently busy and will be maintaining driver later on. I'm helping to upstream the driver meantime.

This series implements support for the Synopsys DesignWare HDMI RX Controller, being compliant with standard HDMI 1.4b and HDMI 2.0.

Features that are currently supported by the HDMI RX driver have been tested on rock5b board using a HDMI to micro-HDMI cable. It is recommended to use a good quality cable as there were multiple issues seen during testing the driver.

Please note the below information :-
* HDMIRX driver now only works with the opensource TF-A.
* We have tested the working of OBS studio with HDMIRX driver and there were no issues seen.
* We tested and verified the support for interlaced video.
* We tested capturing of YUV formats.

To test the HDMI RX Controller driver, following example commands can be used :-

root@debian-rockchip-rock5b-rk3588:~#  v4l2-ctl --stream-mmap \
--stream-count=100 --stream-to=/home/hdmiin4k.raw
root@debian-rockchip-rock5b-rk3588:~# ffmpeg -f rawvideo -vcodec rawvideo \
-s 1920x1080 -r 60 -pix_fmt bgr24 -i /home/hdmiin4k.raw output.mkv

CEC compliance test results :-

* https://gitlab.collabora.com/-/snippets/380
* https://gitlab.collabora.com/-/snippets/381

Following is the v4l2-compliance test result :-

root@debian-rockchip-rock5b-rk3588:~# v4l2-compliance -d /dev/video1
v4l2-compliance 1.29.0-5326, 64 bits, 64-bit time_t
v4l2-compliance SHA: 77f5df419204 2025-02-07 08:59:59

Compliance test for snps_hdmirx device /dev/video1:

Driver Info:

         Driver name      : snps_hdmirx
         Card type        : snps_hdmirx
         Bus info         : platform:fdee0000.hdmi_receiver
         Driver version   : 6.14.0
         Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format

Required ioctls:
test VIDIOC_QUERYCAP: OK
test invalid ioctls: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 1 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK test VIDIOC_DV_TIMINGS_CAP: OK
test VIDIOC_G/S_EDID: OK

Control ioctls (Input 0):
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0

Format ioctls (Input 0):
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK
test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls (Input 0):
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls (Input 0):
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test CREATE_BUFS maximum buffers: OK test VIDIOC_REMOVE_BUFS: OK
test VIDIOC_EXPBUF: OK
test Requests: OK (Not Supported) test blocking wait: OK

Test input 0:

Streaming ioctls:
test read/write: OK (Not Supported)
test MMAP (no poll, REQBUFS): OK
test MMAP (select, REQBUFS): OK
test MMAP (epoll, REQBUFS): OK
test MMAP (no poll, CREATE_BUFS): OK test MMAP (select, CREATE_BUFS): OK
test MMAP (epoll, CREATE_BUFS): OK
test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device

Total for snps_hdmirx device /dev/video1: 57, Succeeded: 57, Failed: 0, Warnings: 0

---

InfoFrame debugfs example output:-

# edid-decode -c -I /sys/kernel/debug/v4l2/fdee0000.hdmi_receiver/infoframes/avi
edid-decode InfoFrame (hex):

82 02 0d b1 12 28 84 00 00 00 00 00 00 00 00 00
00

----------------

HDMI InfoFrame Checksum: 0xb1

AVI InfoFrame
Version: 2
Length: 13
Y: Color Component Sample Format: RGB
A: Active Format Information Present: Yes
B: Bar Data Present: Bar Data not present
S: Scan Information: Composed for an underscanned display
C: Colorimetry: No Data
M: Picture Aspect Ratio: 16:9
R: Active Portion Aspect Ratio: 8
ITC: IT Content: IT Content (CN is valid)
EC: Extended Colorimetry: xvYCC601
Q: RGB Quantization Range: Limited Range
SC: Non-Uniform Picture Scaling: No Known non-uniform scaling
YQ: YCC Quantization Range: Limited Range
CN: IT Content Type: Graphics
PR: Pixel Data Repetition Count: 0
Line Number of End of Top Bar: 0
Line Number of Start of Bottom Bar: 0
Pixel Number of End of Left Bar: 0
Pixel Number of Start of Right Bar: 0

----------------

edid-decode 1.29.0-5326
edid-decode SHA: 77f5df419204 2025-02-07 08:59:59

AVI InfoFrame conformity: PASS

---

Changes in v13 :-
- Removed CEC adapter notifier as it's not used by this driver

Changes in v12 :-
- Removed legacy wait_finish/prepare() callbacks from vb2_ops, tested that driver works without them.
- Updated and extended driver Kconfig description RE the LOAD_DEFAULT_EDID option.
- Made minor cosmetical improvements to the code

Changes in v11 :-
- Reverted back defconfig patch by removing LOAD_DEFAULT_EDID=y option
- Removed CEC notifier since it's not needed for this driver
- Replaced video_unregister_device() with vb2_video_unregister_device()
- Added more clarifying comments to the code and updated the timing sanity-check, borrowing it from a newer downstream driver version.

Changes in v10 :-
- Replaced cec_unregister_adapter() with cec_notifier_cec_adap_unregister() in the error unwinding code path of the driver probe, tested that it works properly.
- Changed CEC registration code to propagate original error code to the driver's probe-failure code path on the CEC registration failure.
- Enabled LOAD_DEFAULT_EDID=y in the defconfig patch

Changes in v9 :-
- Added devm_add_action_or_reset() to free reserved memory properly on driver probe error
- Extra minor code cleanups

Changes in v8 :-
- Changed HPD logic as was requested by Hans Verkuil. HPD handling is now decoupled from HDMI plugin/out events and works independently from 5v status.
- Bumped number of EDID blocks from 2 to 4 as was requested by Hans Verkuil and verified that reading 3/4 EDID blocks from transmitter works properly.
- Made few extra minor cleanup/improvements to the driver code

Changes in v7 :-
- Changed InfoFrame debugfs to return truncated payload data
- Updated cover-letter example stream capture cmdline with a minimized and cleaned version of the cmdline
- Added AVI InfoFrame example output to the cover-letter

Changes in v6 :-
- Driver now keeps HPD low instead of zeroing EDID when EDID-clearing is invoked and when default EDID usage is disabled in the kernel config
- Added InfoFrame debugfs support
- Added another code comment clarifying validation of timing values
- Rebased on top of recent media-next tree

Changes in v5 :-
- Fix the interrupt IRQ number in the dt-bindings and device tree
- Add alignment property to ensure hdmi-receiver-cma starts at a 64KB-aligned address
- Change the MODULE_DESCRIPTION
- Add VIDEO_SYNOPSYS_HDMIRX as prefix to the default edid config
- Drop the enabling of default edid in the Kconfig
- Replace the default EDID with hdmi-4k-300mhz EDID produced by v4l2-ctl tool for better compatibility with various HDMI cables and adapters
- Rework the write_edid and set_edid functions
- During format change, retrieve the current pixel format, color depth, and AVI infoframe details instead of only detecting the format
- Improve the logging mechanism and delays in the hdmirx_wait_signal_lock function
- Fix the 4K@60 capturing for RGB format
- Document what hdmirx_check_timing_valid function does
- Rework the hdmirx_get_detected_timings function
- Fix the NV16/24 size image value
- Add the implementation from Benjamin Hoff to expose the ITC type to v4l2
- Remove all the firmware related code

Changes in v4 :-
- Remove DTS changes included in the device tree patch
- Remove the hdmi rx pin info as it's already present in the rk3588-base-pinctrl.dtsi
- Create a separate config option for selecting the EDID and enable it by default
- Improve the comment related to DV timings and move it to the side of hdmirx_get_detected_timings
- Add 100ms delay before pulling the HPD high
- Do not return the detected timings from VIDIOC_G_DV_TIMINGS
- Drop the bus info from hdmirx_querycap
- If *num_planes != 0 then return 0 in hdmirx_queue_setup
- Set queue->min_queued_buffers to 1
- Drop q->allow_cache_hints = 0; as it's always 0 by default
- Add a comment for q->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
- Drop .read = vb2_fop_read as it's not supported by driver
- Remove redundant edid_init_data_600M
- Make HPD low when driver is loaded
- Add support for reading AVI Infoframe
- Remove msg_len checks from hdmirx_cec_transmit
- Add info about the CEC compliance test in the cover letter
- Add arbitration lost status
- Validate the physical address inside the EDID

Changes in v3 :-
- Use v4l2-common helpers in the HDMIRX driver
- Rename cma node and phandle names
- Elaborate the comment to explain 160MiB calculation
- Move &hdmi_receiver_cma to the rock5b dts file
- Add information about interlaced video testing in the cover-letter

Changes in v2 :-
- Fix checkpatch --strict warnings
- Move the dt-binding include file changes in a separate patch
- Add a description for the hardware in the dt-bindings file
- Rename resets, vo1 grf and HPD properties
- Add a proper description for grf and vo1-grf phandles in the bindings
- Rename the HDMI RX node name to hdmi-receiver
- Include gpio header file in binding example to fix the dt_binding_check failure
- Move hdmirx_cma node to the rk3588.dtsi file
- Add an entry to MAINTAINERS file for the HDMIRX driver

Sebastian Reichel (2):
arm64: dts: rockchip: Enable HDMI receiver on rock-5b
arm64: defconfig: Enable Synopsys HDMI receiver

Shreeya Patel (4):
MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver
dt-bindings: media: Document bindings for HDMI RX Controller
media: platform: synopsys: Add support for HDMI input driver
arm64: dts: rockchip: Add device tree support for HDMI RX Controller

  .../bindings/media/snps,dw-hdmi-rx.yaml       |  132 +
  MAINTAINERS                                   |    8 +
  .../dts/rockchip/rk3588-base-pinctrl.dtsi     |   14 +
  .../arm64/boot/dts/rockchip/rk3588-extra.dtsi |   57 +
  .../boot/dts/rockchip/rk3588-rock-5b.dts      |   18 +
  arch/arm64/configs/defconfig                  |    1 +
  drivers/media/platform/Kconfig                |    1 +
  drivers/media/platform/Makefile               |    1 +
  drivers/media/platform/synopsys/Kconfig       |    3 +
  drivers/media/platform/synopsys/Makefile      |    2 +
  .../media/platform/synopsys/hdmirx/Kconfig    |   35 +
  .../media/platform/synopsys/hdmirx/Makefile   |    4 +
  .../platform/synopsys/hdmirx/snps_hdmirx.c    | 2750 +++++++++++++++++
  .../platform/synopsys/hdmirx/snps_hdmirx.h    |  394 +++
  .../synopsys/hdmirx/snps_hdmirx_cec.c         |  275 ++
  .../synopsys/hdmirx/snps_hdmirx_cec.h         |   43 +
  16 files changed, 3738 insertions(+)

create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml create mode 100644 drivers/media/platform/synopsys/Kconfig
create mode 100644 drivers/media/platform/synopsys/Makefile
create mode 100644 drivers/media/platform/synopsys/hdmirx/Kconfig create mode 100644 drivers/media/platform/synopsys/hdmirx/Makefile create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.h create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.c create mode 100644 drivers/media/platform/synopsys/hdmirx/snps_hdmirx_cec.h

#9 lore raw
In reply to Tim Surber

Hi Dmitry,

I did some more testing. That the Apple TV did not work was a bit misleading.

It was just, that the Apple TV defaulted to 4:4:4 Chroma which does not work at all for me. (The same happens using the vendor driver).

When I changed the EDID to match the vendor driver the HDMI handshake happened with 4:2:0 chroma, where I could verify even 4k60fps using your driver, nice!

So the remaining problems I see are:
- 4:4:4 chroma not working in any resolution
- 4:2:2 and RGB not working in 4k60fps (is this a hardware limitation?)

A possible workaround could be to disable these non supported formats in the default EDID.

Best regards,
TIm

#10 lore raw
Quoted 12 lines · Tim Surber

Hi Dmitry,

I did some more testing. That the Apple TV did not work was a bit misleading.

It was just, that the Apple TV defaulted to 4:4:4 Chroma which does not work at all for me. (The same happens using the vendor driver).

When I changed the EDID to match the vendor driver the HDMI handshake happened with 4:2:0 chroma, where I could verify even 4k60fps using your driver, nice!

Quoted 6 lines

So the remaining problems I see are:
- 4:4:4 chroma not working in any resolution
- 4:2:2 and RGB not working in 4k60fps (is this a hardware limitation?)

A possible workaround could be to disable these non supported formats in the default EDID.

I would like to merge this driver this week, since otherwise it will likely slip to v6.16. So if there is a working EDID, perhaps it can be used for now, and later on it can be patched if there is a better EDID.

Would this EDID work? Tim, can you try this?

v4l2-ctl --set-edid type=hdmi-4k-600mhz,ycbcr444,ycbcr422

Alternatively, if there is indeed a HW limitation that prevents 4kp60 to work, try this:

v4l2-ctl --set-edid type=hdmi-4k-300mhz,ycbcr444,ycbcr422

Whichever of the two works is what we can use as default EDID.

Regards,

Hans

author maintainer
#11 lore raw
Quoted 25 lines · Hans Verkuil
Quoted 12 lines · Tim Surber

Hi Dmitry,

I did some more testing. That the Apple TV did not work was a bit misleading.

It was just, that the Apple TV defaulted to 4:4:4 Chroma which does not work at all for me. (The same happens using the vendor driver).

When I changed the EDID to match the vendor driver the HDMI handshake happened with 4:2:0 chroma, where I could verify even 4k60fps using your driver, nice!

Quoted 6 lines

So the remaining problems I see are:
- 4:4:4 chroma not working in any resolution
- 4:2:2 and RGB not working in 4k60fps (is this a hardware limitation?)

A possible workaround could be to disable these non supported formats in the default EDID.

I would like to merge this driver this week, since otherwise it will likely slip to v6.16. So if there is a working EDID, perhaps it can be used for now, and later on it can be patched if there is a better EDID.

Would this EDID work? Tim, can you try this?

Quoted 8 lines

v4l2-ctl --set-edid type=hdmi-4k-600mhz,ycbcr444,ycbcr422

Alternatively, if there is indeed a HW limitation that prevents 4kp60 to work, try this:

v4l2-ctl --set-edid type=hdmi-4k-300mhz,ycbcr444,ycbcr422

Whichever of the two works is what we can use as default EDID.

Disabling 444 and 422 is an option. Though, they work on my setup at 4k@60p.

In general, it often a challenge to get 4k@60p properly with any of these small board devices. 4k@60p works only using a short HDMI cable for me. Also, not everyone aware that the micro HDMI adapter needs to be compliant with HDMI 2.0 for 4k@60, that's why 300MHz is the default.

Will be nice to have the good EDID enabled by default in the defconfig. Dealing with problems like that will be a headache for majority of people, IMO.

Signature · 2 lines
Best regards,
Dmitry
author maintainer
#12 lore raw
Quoted 38 lines · Dmitry Osipenko
Quoted 25 lines · Hans Verkuil
Quoted 12 lines · Tim Surber

Hi Dmitry,

I did some more testing. That the Apple TV did not work was a bit misleading.

It was just, that the Apple TV defaulted to 4:4:4 Chroma which does not work at all for me. (The same happens using the vendor driver).

When I changed the EDID to match the vendor driver the HDMI handshake happened with 4:2:0 chroma, where I could verify even 4k60fps using your driver, nice!

Quoted 6 lines

So the remaining problems I see are:
- 4:4:4 chroma not working in any resolution
- 4:2:2 and RGB not working in 4k60fps (is this a hardware limitation?)

A possible workaround could be to disable these non supported formats in the default EDID.

I would like to merge this driver this week, since otherwise it will likely slip to v6.16. So if there is a working EDID, perhaps it can be used for now, and later on it can be patched if there is a better EDID.

Would this EDID work? Tim, can you try this?

Quoted 8 lines

v4l2-ctl --set-edid type=hdmi-4k-600mhz,ycbcr444,ycbcr422

Alternatively, if there is indeed a HW limitation that prevents 4kp60 to work, try this:

v4l2-ctl --set-edid type=hdmi-4k-300mhz,ycbcr444,ycbcr422

Whichever of the two works is what we can use as default EDID.

Disabling 444 and 422 is an option. Though, they work on my setup at 4k@60p.

Quoted 8 lines

In general, it often a challenge to get 4k@60p properly with any of these small board devices. 4k@60p works only using a short HDMI cable for me. Also, not everyone aware that the micro HDMI adapter needs to be compliant with HDMI 2.0 for 4k@60, that's why 300MHz is the default.

Will be nice to have the good EDID enabled by default in the defconfig. Dealing with problems like that will be a headache for majority of people, IMO.

BTW, I don't see it as a blocker. Driver works in general, new issues can be resolved with additional patches.

Signature · 7 lines
Best regards,
Dmitry

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Tested-by
#13 lore raw

Hi,

so the 4:4:4 issue was just a gstreamer bug and it worked when I applied an experimental fix [1].

So everything works for me using the default EDID now.

[1]: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8534

Quoted 51 lines · Dmitry Osipenko
Quoted 38 lines · Dmitry Osipenko
Quoted 25 lines · Hans Verkuil
Quoted 12 lines · Tim Surber

Hi Dmitry,

I did some more testing. That the Apple TV did not work was a bit misleading.

It was just, that the Apple TV defaulted to 4:4:4 Chroma which does not work at all for me. (The same happens using the vendor driver).

When I changed the EDID to match the vendor driver the HDMI handshake happened with 4:2:0 chroma, where I could verify even 4k60fps using your driver, nice!

Quoted 6 lines

So the remaining problems I see are:
- 4:4:4 chroma not working in any resolution
- 4:2:2 and RGB not working in 4k60fps (is this a hardware limitation?)

A possible workaround could be to disable these non supported formats in the default EDID.

I would like to merge this driver this week, since otherwise it will likely slip to v6.16. So if there is a working EDID, perhaps it can be used for now, and later on it can be patched if there is a better EDID.

Would this EDID work? Tim, can you try this?

Quoted 8 lines

v4l2-ctl --set-edid type=hdmi-4k-600mhz,ycbcr444,ycbcr422

Alternatively, if there is indeed a HW limitation that prevents 4kp60 to work, try this:

v4l2-ctl --set-edid type=hdmi-4k-300mhz,ycbcr444,ycbcr422

Whichever of the two works is what we can use as default EDID.

Disabling 444 and 422 is an option. Though, they work on my setup at 4k@60p.

Quoted 8 lines

In general, it often a challenge to get 4k@60p properly with any of these small board devices. 4k@60p works only using a short HDMI cable for me. Also, not everyone aware that the micro HDMI adapter needs to be compliant with HDMI 2.0 for 4k@60, that's why 300MHz is the default.

Will be nice to have the good EDID enabled by default in the defconfig. Dealing with problems like that will be a headache for majority of people, IMO.

BTW, I don't see it as a blocker. Driver works in general, new issues can be resolved with additional patches.

#15 lore raw
In reply to Tim Surber

Hi Tim,

Le mercredi 05 mars 2025 à 11:41 +0100, Tim Surber a écrit :

Quoted 6 lines

Hi,

so the 4:4:4 issue was just a gstreamer bug and it worked when I applied
an experimental fix [1].

Quoted 6 lines

So everything works for me using the default EDID now.

[1]:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8534

Thanks, I'll try and get this fix moving soon. I now have a RK3588 with hacks that let me force YUV in the 3 subsampling, so I can easily reproduce now.

Nicolas

p.s. I also hit some buffer starvation issues (inside GStreamer), for which I will be sending a fix to this driver so GStreamer is aware of the lost frames.

Quoted 71 lines · Dmitry Osipenko
Quoted 69 lines · Dmitry Osipenko
Quoted 58 lines · Hans Verkuil
Quoted 36 lines · Tim Surber
Quoted 17 lines

Hi Dmitry,

I did some more testing. That the Apple TV did not work was a bit
misleading.

It was just, that the Apple TV defaulted to 4:4:4 Chroma which does not
work at all for me. (The same happens using the vendor driver).

When I changed the EDID to match the vendor driver the HDMI handshake
happened with 4:2:0 chroma, where I could verify even 4k60fps using your
driver, nice!

Quoted 8 lines

So the remaining problems I see are:
- 4:4:4 chroma not working in any resolution
- 4:2:2 and RGB not working in 4k60fps (is this a hardware limitation?)

A possible workaround could be to disable these non supported formats in
the default EDID.

I would like to merge this driver this week, since otherwise it will likely
slip to v6.16. So if there is a working EDID, perhaps it can be used for now,
and later on it can be patched if there is a better EDID.

Would this EDID work? Tim, can you try this?

v4l2-ctl --set-edid type=hdmi-4k-600mhz,ycbcr444,ycbcr422

Quoted 7 lines

Alternatively, if there is indeed a HW limitation that prevents 4kp60 to work,
try this:

v4l2-ctl --set-edid type=hdmi-4k-300mhz,ycbcr444,ycbcr422

Whichever of the two works is what we can use as default EDID.

Disabling 444 and 422 is an option. Though, they work on my setup at
4k@60p.

In general, it often a challenge to get 4k@60p properly with any of
these small board devices. 4k@60p works only using a short HDMI cable
for me. Also, not everyone aware that the micro HDMI adapter needs to be
compliant with HDMI 2.0 for 4k@60, that's why 300MHz is the default.

Quoted 5 lines

Will be nice to have the good EDID enabled by default in the defconfig.
Dealing with problems like that will be a headache for majority of
people, IMO.

BTW, I don't see it as a blocker. Driver works in general, new issues
can be resolved with additional patches.

Signature · 2 lines
Nicolas Dufresne
Principal Engineer at Collabora