Skip to contentSkip to conversation

ufs: core: bsg: Add hibern8 enter/exit to ufshcd_send_bsg_uic_cmd

PATCH Superseded Arthur Simchaev 3 participants 7 messages Mar 4, 2025 – Mar 26, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ufs: core: bsg: Add hibern8 enter/exit to ufshcd_send_bsg_uic_cmd

Eye monitor measurement functionality was added to the M-PHY v5 specification. The measurement of the eye monitor signal for the UFS device begins when the link enters the hibernate state. Hence, allow user-layer applications the capability to send the hibern8 enter command through the BSG framework. For completion, allow the sibling functionality of hibern8 exit as well.

---
 drivers/ufs/core/ufshcd.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/ufs/core/ufshcd.c +10 -0
index 4e1e214fc5a2..546ab557a77c 100644
@@ -4366,6 +4366,16 @@ int ufshcd_send_bsg_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd)
 		goto out;
 	}
 
+	if (uic_cmd->command == UIC_CMD_DME_HIBER_ENTER) {
+		ret = ufshcd_uic_hibern8_enter(hba);
+		goto out;
+	}
+
+	if (uic_cmd->command == UIC_CMD_DME_HIBER_EXIT) {
+		ret = ufshcd_uic_hibern8_exit(hba);
+		goto out;
+	}
+
 	mutex_lock(&hba->uic_cmd_mutex);
 	ufshcd_add_delay_before_dme_cmd(hba);
 
Signature · 1 line
2.34.1
#1 lore raw

Arthur,

At present, we lack a user-space tool to initiate eye monitor measurements. Additionally, opening a channel for users in user land to send MP commands seems unsafe.

Kind regards,
Bean

Quoted 37 lines · Arthur Simchaev

Eye monitor measurement functionality was added to the M-PHY v5 specification. The measurement of the eye monitor signal for the UFS device begins when the link enters the hibernate state. Hence, allow user-layer applications the capability to send the hibern8
enter command through the BSG framework. For completion, allow the sibling functionality of hibern8 exit as well.

---
 drivers/ufs/core/ufshcd.c | 10 ++++++++++

 1 file changed, 10 insertions(+)
drivers/ufs/core/ufshcd.c +0 -0
index 4e1e214fc5a2..546ab557a77c 100644
@@ -4366,6 +4366,16 @@ int ufshcd_send_bsg_uic_cmd(struct ufs_hba
 *hba, struct uic_command *uic_cmd)
                 goto out;
         }


+       if (uic_cmd->command == UIC_CMD_DME_HIBER_ENTER) { +               ret = ufshcd_uic_hibern8_enter(hba); +               goto out;
+       }

drivers/ufs/core/ufshcd.c +6 -0
+
+       if (uic_cmd->command == UIC_CMD_DME_HIBER_EXIT) {
+               ret = ufshcd_uic_hibern8_exit(hba);
+               goto out;
+       }
+

        mutex_lock(&hba->uic_cmd_mutex);
        ufshcd_add_delay_before_dme_cmd(hba);

--
2.34.1

#2 lore raw

Hi Arthur,

Quoted 46 lines · Bean Huo

Arthur,

At present, we lack a user-space tool to initiate eye monitor measurements. Additionally, opening a channel for users in user land to send MP commands seems unsafe.

Kind regards,
Bean

Quoted 35 lines · Arthur Simchaev

Eye monitor measurement functionality was added to the M-PHY v5 specification. The measurement of the eye monitor signal for the UFS device begins when the link enters the hibernate state. Hence, allow user-layer applications the capability to send the hibern8
enter command through the BSG framework. For completion, allow the sibling functionality of hibern8 exit as well.

---
  drivers/ufs/core/ufshcd.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
drivers/ufs/core/ufshcd.c +10 -0
index 4e1e214fc5a2..546ab557a77c 100644
@@ -4366,6 +4366,16 @@ int ufshcd_send_bsg_uic_cmd(struct ufs_hba
 *hba, struct uic_command *uic_cmd)
                 goto out;
         }
 
+       if (uic_cmd->command == UIC_CMD_DME_HIBER_ENTER) {
+               ret = ufshcd_uic_hibern8_enter(hba);
+               goto out;
+       }
+
+       if (uic_cmd->command == UIC_CMD_DME_HIBER_EXIT) {
+               ret = ufshcd_uic_hibern8_exit(hba);
+               goto out;
+       }
+
         mutex_lock(&hba->uic_cmd_mutex);
         ufshcd_add_delay_before_dme_cmd(hba);
Quoted 2 lines
Quoted 2 lines

--
2.34.1

I can understand that you want to use hibern8 enter&exit to trigger a RCT to kick start the EOM, however there is a better/simpler way to do so: you can trigger a power mode change to the same power mode (e.g., from HS-G5 to HS-G5) to trigger a RCT (without invoking hibern8 enter&exit) from user layer by dme_set(PA_PWRMODE).

FYI, we have open-sourced Qcom's EOM tool in GitHub and validated the EOM function on most UFS4.x devices from UFS vendors, you can find the code for your reference:
https://github.com/quic/ufs-tools/blob/main/ufs-cli/ufs_eom.c#L266

The recent change from Ziqi Chen is to serve the power mode change purpose I mentioned above:
https://lore.kernel.org/all/[email protected]/

Hope above info can help you.

Thanks,
Can Guo.

#3 lore raw
Quoted 16 lines

I can understand that you want to use hibern8 enter&exit to trigger a RCT to kick start the EOM, however there is a better/simpler way to do so: you can trigger a power mode change to the same power mode (e.g., from HS-G5 to HS-G5) to trigger a RCT (without invoking hibern8 enter&exit) from user layer by dme_set(PA_PWRMODE).

FYI, we have open-sourced Qcom's EOM tool in GitHub and validated the EOM function on most UFS4.x devices from UFS vendors, you can find the code for your reference:
https://github.com/quic/ufs-tools/blob/main/ufs-cli/ufs_eom.c#L266

The recent change from Ziqi Chen is to serve the power mode change purpose I mentioned above:
https://lore.kernel.org/all/[email protected]
g/

Quoted 4 lines

Hope above info can help you.

Thanks,
Can Guo.

Thank you, Can.

I am familiar with this very useful tool. In fact, I published the patch due to the tool In order to extend the debug functionality from the user space.
In my opinion, the hibern8 enter function can be used in a similar manner as the PMC. For instance, if the host fails to change the power mode to FAST MODE with NO ADAPT.

Regards
Arthur

#4 lore raw
In reply to Can Guo
Quoted 16 lines

I can understand that you want to use hibern8 enter&exit to trigger a RCT to kick start the EOM, however there is a better/simpler way to do so: you can trigger a power mode change to the same power mode (e.g., from HS-G5 to HS-G5) to trigger a RCT (without invoking hibern8 enter&exit) from user layer by dme_set(PA_PWRMODE).

FYI, we have open-sourced Qcom's EOM tool in GitHub and validated the EOM function on most UFS4.x devices from UFS vendors, you can find the code for your reference:
https://github.com/quic/ufs-tools/blob/main/ufs-cli/ufs_eom.c#L266

The recent change from Ziqi Chen is to serve the power mode change purpose I mentioned above:
https://lore.kernel.org/all/[email protected]
g/

Quoted 4 lines

Hope above info can help you.

Thanks,
Can Guo.

Hi Can

Maybe I need reword the commit message. Having h8 from the user space is useful for creating different test cases. For example, stressing h8 , MPHY enter/exit from hibern8.

Regards
Arthur

#5 lore raw
In reply to Bean Huo
Quoted 17 lines

-----Original Message-----
From: Bean Huo <[email protected]>
Sent: Thursday, March 6, 2025 2:50 PM
To: Arthur Simchaev <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Avri Altman <[email protected]>; Avi Shchislowski <[email protected]>; [email protected]; linux- [email protected]; [email protected]
Subject: Re: [PATCH] ufs: core: bsg: Add hibern8 enter/exit to ufshcd_send_bsg_uic_cmd

Arthur,

Quoted 8 lines

At present, we lack a user-space tool to initiate eye monitor measurements. Additionally, opening a channel for users in user land to send MP commands seems unsafe.

Kind regards,
Bean

Hi Bean.

Actually, the EOM tool was published two months ago
See the mail from Can Guo. The patch simply extends the UIC debugging functionality from user space. I think it is quite safe to use hibern8 functionality for debugging purposes.

Regards
Arthur

#6 lore raw
Quoted 30 lines · Arthur Simchaev
Quoted 24 lines

-----Original Message-----
From: Bean Huo <[email protected]>
Sent: Thursday, March 6, 2025 2:50 PM
To: Arthur Simchaev <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Avri Altman <[email protected]>; Avi Shchislowski <[email protected]>; [email protected]; linux- [email protected]; [email protected]
Subject: Re: [PATCH] ufs: core: bsg: Add hibern8 enter/exit to ufshcd_send_bsg_uic_cmd

Arthur,

At present, we lack a user-space tool to initiate eye monitor measurements.
Additionally, opening a channel for users in user land to send MP commands
seems unsafe.

Quoted 3 lines

Kind regards,
Bean

Hi Bean.

Quoted 8 lines

Actually,  the EOM tool was published two months ago
See the mail from Can Guo. The patch simply extends the UIC debugging functionality from user space.
I think it is quite safe to use hibern8 functionality for debugging purposes.

Regards
Arthur

Great, we will work on that.

Kind regards,
Bean