Skip to contentSkip to conversation

pmdomain: rockchip: add regulator dependency

PATCH In review Arnd Bergmann 5 participants 5 messages Mar 4, 2025 – Mar 5, 2025

Subsystems (2)
Arm Rockchip Generic PM domains
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 pmdomain: rockchip: add regulator dependency

From: Arnd Bergmann <[email protected]>

When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:

drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]

  653 |                 pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
      |                              ^~~~~~~~~~~~~~~~~~~~~
      |                              devm_regulator_get

drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
| ^

Add a Kconfig dependency.

Fixes db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pmdomain/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pmdomain/rockchip/Kconfig +1 -0
index 7e4f9b628f0b..218d43186e5b 100644
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
 	bool "Rockchip generic power domain"
 	depends on PM
 	depends on HAVE_ARM_SMCCC_DISCOVERY
+	depends on REGULATOR
 	select PM_GENERIC_DOMAINS
 	help
 	  Say y here to enable power domain support.
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 12 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:

drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]

  653 |                 pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
      |                              ^~~~~~~~~~~~~~~~~~~~~
      |                              devm_regulator_get

drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
| ^

Quoted 5 lines

Add a Kconfig dependency.

Fixes db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by Arnd Bergmann <[email protected]>

---

Reviewed-by Sebastian Reichel <[email protected]>

-- Sebastian

Quoted 18 lines
 drivers/pmdomain/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pmdomain/rockchip/Kconfig +1 -0
index 7e4f9b628f0b..218d43186e5b 100644
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
 	bool "Rockchip generic power domain"
 	depends on PM
 	depends on HAVE_ARM_SMCCC_DISCOVERY
+	depends on REGULATOR
 	select PM_GENERIC_DOMAINS
 	help
 	  Say y here to enable power domain support.
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann

Hello Arnd,

Quoted 32 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:

drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]
653 | pd->supply = devm_of_regulator_get(pmu->dev,

pd->node, "domain");
      |                              ^~~~~~~~~~~~~~~~~~~~~
      |                              devm_regulator_get

drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
653 | pd->supply = devm_of_regulator_get(pmu->dev,
pd->node, "domain");
| ^

Add a Kconfig dependency.

Fixes db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pmdomain/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pmdomain/rockchip/Kconfig +0 -0
index 7e4f9b628f0b..218d43186e5b 100644

drivers/pmdomain/rockchip/Kconfig config ROCKCHIP_PM_DOMAINS · line 11

Quoted 7 lines
drivers/pmdomain/rockchip/Kconfig +1 -0
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
 	bool "Rockchip generic power domain"
 	depends on PM
 	depends on HAVE_ARM_SMCCC_DISCOVERY
+	depends on REGULATOR
 	select PM_GENERIC_DOMAINS
 	help
 	  Say y here to enable power domain support.

Looking good to me, thanks for this patch.

Reviewed-by Dragan Simic <[email protected]>
maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Arnd Bergmann

Am Dienstag, 4. März 2025, 15:27:59 MEZ schrieb Arnd Bergmann:

Quoted 8 lines

From: Arnd Bergmann <[email protected]>

When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:

drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]

  653 |                 pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
      |                              ^~~~~~~~~~~~~~~~~~~~~
      |                              devm_regulator_get
Quoted 8 lines

drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
| ^

Add a Kconfig dependency.

Fixes db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by Arnd Bergmann <[email protected]>
Reviewed-by Heiko Stuebner <[email protected]>
#4 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:

drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]

  653 |                 pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
      |                              ^~~~~~~~~~~~~~~~~~~~~
      |                              devm_regulator_get
Quoted 8 lines

drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
| ^

Add a Kconfig dependency.

Fixes db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by Arnd Bergmann <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

Quoted 19 lines
---
 drivers/pmdomain/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pmdomain/rockchip/Kconfig +1 -1
index 7e4f9b628f0b..218d43186e5b 100644
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
        bool "Rockchip generic power domain"
        depends on PM
        depends on HAVE_ARM_SMCCC_DISCOVERY
+       depends on REGULATOR
        select PM_GENERIC_DOMAINS
        help
          Say y here to enable power domain support.
--

2.39.5