Remove unnecessary prompts for CRC library (batch 1)

PATCH In review Eric Biggers 2 participants 8 messages Mar 4, 2025 – Mar 6, 2025

Subsystems (17)

Arm (32-bit) PowerPC Arm i.MX and Layerscape Library code +13 more subsystems

lore

Share & tools

lore

Eric Biggers

author

2025-03-04 23:08 UTC #0 lore raw

cover Remove unnecessary prompts for CRC library (batch 1)

Library functions are already selected when they are needed, so there is no need to ask users whether to enable them or not. This patchset fixes this for the first batch of CRC library options.

There will be a batch 2 later to handle the rest.

Eric Biggers (5):
lib/crc: remove unnecessary prompt for CONFIG_CRC4 lib/crc: remove unnecessary prompt for CONFIG_CRC7 lib/crc: remove unnecessary prompt for CONFIG_CRC8 lib/crc: remove unnecessary prompt for CONFIG_LIBCRC32C lib/crc: remove unnecessary prompt for CONFIG_CRC64

 arch/arm/configs/dove_defconfig              |  1 -
 arch/arm/configs/ep93xx_defconfig            |  1 -
 arch/arm/configs/imx_v6_v7_defconfig         |  2 --
 arch/arm/configs/lpc18xx_defconfig           |  1 -
 arch/arm/configs/multi_v5_defconfig          |  1 -
 arch/arm/configs/mvebu_v5_defconfig          |  1 -
 arch/arm/configs/mxs_defconfig               |  1 -
 arch/arm/configs/omap1_defconfig             |  1 -
 arch/arm/configs/omap2plus_defconfig         |  2 --
 arch/arm/configs/spitz_defconfig             |  1 -
 arch/arm/configs/stm32_defconfig             |  1 -
 arch/arm/configs/wpcm450_defconfig           |  1 -
 arch/hexagon/configs/comet_defconfig         |  1 -
 arch/mips/configs/bigsur_defconfig           |  1 -
 arch/mips/configs/cobalt_defconfig           |  1 -
 arch/mips/configs/fuloong2e_defconfig        |  1 -
 arch/mips/configs/ip32_defconfig             |  1 -
 arch/parisc/configs/generic-64bit_defconfig  |  1 -
 arch/powerpc/configs/85xx/ge_imp3a_defconfig |  1 -
 arch/powerpc/configs/skiroot_defconfig       |  1 -
 arch/s390/configs/debug_defconfig            |  3 --
 arch/s390/configs/defconfig                  |  3 --
 arch/sh/configs/se7206_defconfig             |  2 --
 arch/sh/configs/sh2007_defconfig             |  1 -
 arch/sh/configs/titan_defconfig              |  1 -
 arch/sparc/configs/sparc32_defconfig         |  1 -
 arch/sparc/configs/sparc64_defconfig         |  1 -
 lib/Kconfig                                  | 29 ++++----------------
 28 files changed, 5 insertions(+), 58 deletions(-)

base-commit: 13f3d13d88b5dcba104a204fcbee61c75f8407d0

Signature · 1 line

2.48.1

Eric Biggers

author

2025-03-04 23:08 UTC #1 lore raw

PATCH 1/5 lib/crc: remove unnecessary prompt for CONFIG_CRC4

From: Eric Biggers <[email protected]>

All modules that need CONFIG_CRC4 already select it, so there is no need to bother users about the option.

Signed-off-by Eric Biggers <[email protected]>

---
 arch/s390/configs/debug_defconfig | 1 -
 arch/s390/configs/defconfig       | 1 -
 lib/Kconfig                       | 7 +------
 3 files changed, 1 insertion(+), 8 deletions(-)

arch/s390/configs/debug_defconfig +0 -1

index d6beec5292a00..c46781f8570c1 100644
@@ -813,11 +813,10 @@ CONFIG_CRYPTO_PAES_S390=m
 CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC4=m
 CONFIG_CRC7=m
 CONFIG_CRC8=m
 CONFIG_RANDOM32_SELFTEST=y
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y

arch/s390/configs/defconfig +0 -1

index 8cfbfb10bba8c..23d8bce642aa4 100644
@@ -801,11 +801,10 @@ CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_PRIME_NUMBERS=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC4=m
 CONFIG_CRC7=m
 CONFIG_CRC8=m
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0

lib/Kconfig +1 -6

index 67bbf4f64dd98..e867971c97669 100644
@@ -207,16 +207,11 @@ config ARCH_HAS_CRC64
 config CRC64_ARCH
 	tristate
 	default CRC64 if ARCH_HAS_CRC64 && CRC_OPTIMIZATIONS
 
 config CRC4
-	tristate "CRC4 functions"
-	help
-	  This option is provided for the case where no in-kernel-tree
-	  modules require CRC4 functions, but a module built outside
-	  the kernel tree does. Such modules that use library CRC4
-	  functions require M here.
+	tristate
 
 config CRC7
 	tristate "CRC7 functions"
 	help
 	  This option is provided for the case where no in-kernel-tree

Signature · 1 line

2.48.1

Eric Biggers

author

2025-03-04 23:08 UTC #2 lore raw

PATCH 2/5 lib/crc: remove unnecessary prompt for CONFIG_CRC7

In reply to Eric Biggers

From: Eric Biggers <[email protected]>

All modules that need CONFIG_CRC7 already select it, so there is no need to bother users about the option.

Signed-off-by Eric Biggers <[email protected]>

---
 arch/arm/configs/imx_v6_v7_defconfig  | 1 -
 arch/arm/configs/lpc18xx_defconfig    | 1 -
 arch/arm/configs/mxs_defconfig        | 1 -
 arch/arm/configs/omap2plus_defconfig  | 1 -
 arch/arm/configs/stm32_defconfig      | 1 -
 arch/mips/configs/bigsur_defconfig    | 1 -
 arch/mips/configs/fuloong2e_defconfig | 1 -
 arch/s390/configs/debug_defconfig     | 1 -
 arch/s390/configs/defconfig           | 1 -
 arch/sh/configs/se7206_defconfig      | 1 -
 lib/Kconfig                           | 7 +------
 11 files changed, 1 insertion(+), 16 deletions(-)

arch/arm/configs/imx_v6_v7_defconfig +0 -1

index 87841e5cafe21..eace4475fa9d2 100644
@@ -481,11 +481,10 @@ CONFIG_SECURITYFS=y
 CONFIG_CRYPTO_DEV_FSL_CAAM=y
 CONFIG_CRYPTO_DEV_SAHARA=y
 CONFIG_CRYPTO_DEV_MXS_DCP=y
 CONFIG_CRC_CCITT=m
 CONFIG_CRC_T10DIF=y
-CONFIG_CRC7=m
 CONFIG_LIBCRC32C=m
 CONFIG_CMA_SIZE_MBYTES=64
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y

arch/arm/configs/lpc18xx_defconfig +0 -1

index f55c231e08708..2aa2ac8c6507d 100644
@@ -146,11 +146,10 @@ CONFIG_EXT2_FS=y
 # CONFIG_DNOTIFY is not set
 # CONFIG_INOTIFY_USER is not set
 CONFIG_JFFS2_FS=y
 # CONFIG_NETWORK_FILESYSTEMS is not set
 CONFIG_CRC_ITU_T=y
-CONFIG_CRC7=y
 CONFIG_PRINTK_TIME=y
 # CONFIG_ENABLE_MUST_CHECK is not set
 # CONFIG_DEBUG_BUGVERBOSE is not set
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y

arch/arm/configs/mxs_defconfig +0 -1

index 43bc1255a5db9..d8a6e43c401ef 100644
@@ -159,11 +159,10 @@ CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_CODEPAGE_850=y
 CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_ISO8859_15=y
 CONFIG_CRYPTO_DEV_MXS_DCP=y
 CONFIG_CRC_ITU_T=m
-CONFIG_CRC7=m
 CONFIG_FONTS=y
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_FRAME_WARN=2048

arch/arm/configs/omap2plus_defconfig +0 -1

index 6de45d7f60781..99636c9dced1a 100644
@@ -708,11 +708,10 @@ CONFIG_CRYPTO_DEV_OMAP_SHAM=m
 CONFIG_CRYPTO_DEV_OMAP_AES=m
 CONFIG_CRYPTO_DEV_OMAP_DES=m
 CONFIG_CRC_CCITT=y
 CONFIG_CRC_T10DIF=y
 CONFIG_CRC_ITU_T=y
-CONFIG_CRC7=y
 CONFIG_LIBCRC32C=y
 CONFIG_DMA_CMA=y
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y

arch/arm/configs/stm32_defconfig +0 -1

index 77048b5e1ec49..423bb41c4225f 100644
@@ -73,11 +73,10 @@ CONFIG_EXT3_FS=y
 # CONFIG_FILE_LOCKING is not set
 # CONFIG_DNOTIFY is not set
 # CONFIG_INOTIFY_USER is not set
 CONFIG_NLS=y
 CONFIG_CRC_ITU_T=y
-CONFIG_CRC7=y
 CONFIG_PRINTK_TIME=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SLUB_DEBUG is not set

arch/mips/configs/bigsur_defconfig +0 -1

index f7c4b3529a2ca..fe282630b51cb 100644
@@ -237,10 +237,9 @@ CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
 CONFIG_CRYPTO_TWOFISH=m
 CONFIG_CRYPTO_LZO=m
 CONFIG_CRC_T10DIF=m
-CONFIG_CRC7=m
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_MEMORY_INIT=y
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_LIST=y

arch/mips/configs/fuloong2e_defconfig +0 -1

index 00329bb5de5ab..5ab149cd3178e 100644
@@ -217,6 +217,5 @@ CONFIG_CRYPTO_RMD160=m
 CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_DEFLATE=m
 CONFIG_CRYPTO_LZO=m
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC_CCITT=y
-CONFIG_CRC7=m

arch/s390/configs/debug_defconfig +0 -1

index c46781f8570c1..ea9c3a944e37c 100644
@@ -813,11 +813,10 @@ CONFIG_CRYPTO_PAES_S390=m
 CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC7=m
 CONFIG_CRC8=m
 CONFIG_RANDOM32_SELFTEST=y
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0

arch/s390/configs/defconfig +0 -1

index 23d8bce642aa4..c929fa5131f1e 100644
@@ -801,11 +801,10 @@ CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_PRIME_NUMBERS=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC7=m
 CONFIG_CRC8=m
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0
 CONFIG_PRINTK_TIME=y

arch/sh/configs/se7206_defconfig +0 -1

index 78e0e7be57ee1..f104c3b9a1770 100644
@@ -102,7 +102,6 @@ CONFIG_CRYPTO_LZO=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC_CCITT=y
 CONFIG_CRC16=y
 CONFIG_CRC_ITU_T=y
-CONFIG_CRC7=y
 CONFIG_LIBCRC32C=y

lib/Kconfig +1 -6

index e867971c97669..9b668c4b60e9e 100644
@@ -210,16 +210,11 @@ config CRC64_ARCH
 
 config CRC4
 	tristate
 
 config CRC7
-	tristate "CRC7 functions"
-	help
-	  This option is provided for the case where no in-kernel-tree
-	  modules require CRC7 functions, but a module built outside
-	  the kernel tree does. Such modules that use library CRC7
-	  functions require M here.
+	tristate
 
 config LIBCRC32C
 	tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check"
 	select CRC32
 	help

Signature · 1 line

2.48.1

Eric Biggers

author

2025-03-04 23:08 UTC #3 lore raw

PATCH 3/5 lib/crc: remove unnecessary prompt for CONFIG_CRC8

In reply to Eric Biggers

From: Eric Biggers <[email protected]>

All modules that need CONFIG_CRC8 already select it, so there is no need to bother users about the option.

Signed-off-by Eric Biggers <[email protected]>

---
 arch/s390/configs/debug_defconfig | 1 -
 arch/s390/configs/defconfig       | 1 -
 lib/Kconfig                       | 6 +-----
 3 files changed, 1 insertion(+), 7 deletions(-)

arch/s390/configs/debug_defconfig +0 -1

index ea9c3a944e37c..51c5b40920656 100644
@@ -813,11 +813,10 @@ CONFIG_CRYPTO_PAES_S390=m
 CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC8=m
 CONFIG_RANDOM32_SELFTEST=y
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0
 CONFIG_PRINTK_TIME=y

arch/s390/configs/defconfig +0 -1

index c929fa5131f1e..f2e6ada5c719d 100644
@@ -801,11 +801,10 @@ CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_PRIME_NUMBERS=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC8=m
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0
 CONFIG_PRINTK_TIME=y
 CONFIG_DYNAMIC_DEBUG=y

lib/Kconfig +1 -5

index 9b668c4b60e9e..31add0dc42925 100644
@@ -220,15 +220,11 @@ config LIBCRC32C
 	help
 	  This option just selects CRC32 and is provided for compatibility
 	  purposes until the users are updated to select CRC32 directly.
 
 config CRC8
-	tristate "CRC8 function"
-	help
-	  This option provides CRC8 function. Drivers may select this
-	  when they need to do cyclic redundancy check according CRC8
-	  algorithm. Module will be called crc8.
+	tristate
 
 config CRC_OPTIMIZATIONS
 	bool "Enable optimized CRC implementations" if EXPERT
 	default y
 	help

Signature · 1 line

2.48.1

Eric Biggers

author

2025-03-04 23:08 UTC #4 lore raw

PATCH 4/5 lib/crc: remove unnecessary prompt for CONFIG_LIBCRC32C

In reply to Eric Biggers

From: Eric Biggers <[email protected]>

All modules that need CONFIG_LIBCRC32C already select it, so there is no need to bother users about the option.

Signed-off-by Eric Biggers <[email protected]>

---
 arch/arm/configs/dove_defconfig              | 1 -
 arch/arm/configs/ep93xx_defconfig            | 1 -
 arch/arm/configs/imx_v6_v7_defconfig         | 1 -
 arch/arm/configs/multi_v5_defconfig          | 1 -
 arch/arm/configs/mvebu_v5_defconfig          | 1 -
 arch/arm/configs/omap1_defconfig             | 1 -
 arch/arm/configs/omap2plus_defconfig         | 1 -
 arch/arm/configs/spitz_defconfig             | 1 -
 arch/arm/configs/wpcm450_defconfig           | 1 -
 arch/hexagon/configs/comet_defconfig         | 1 -
 arch/mips/configs/cobalt_defconfig           | 1 -
 arch/mips/configs/ip32_defconfig             | 1 -
 arch/parisc/configs/generic-64bit_defconfig  | 1 -
 arch/powerpc/configs/85xx/ge_imp3a_defconfig | 1 -
 arch/powerpc/configs/skiroot_defconfig       | 1 -
 arch/sh/configs/se7206_defconfig             | 1 -
 arch/sh/configs/sh2007_defconfig             | 1 -
 arch/sh/configs/titan_defconfig              | 1 -
 arch/sparc/configs/sparc32_defconfig         | 1 -
 arch/sparc/configs/sparc64_defconfig         | 1 -
 lib/Kconfig                                  | 2 +-
 21 files changed, 1 insertion(+), 21 deletions(-)

arch/arm/configs/dove_defconfig +0 -1

index 2849d17f58566..b382a2e175fbc 100644
@@ -127,11 +127,10 @@ CONFIG_CRYPTO_SHA512=y
 CONFIG_CRYPTO_DEFLATE=y
 CONFIG_CRYPTO_LZO=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_CRYPTO_DEV_MARVELL_CESA=y
 CONFIG_CRC_CCITT=y
-CONFIG_LIBCRC32C=y
 CONFIG_PRINTK_TIME=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y

arch/arm/configs/ep93xx_defconfig +0 -1

index 7dece9d988288..2248afaf35b50 100644
@@ -111,11 +111,10 @@ CONFIG_TMPFS=y
 CONFIG_JFFS2_FS=y
 CONFIG_NFS_FS=y
 CONFIG_ROOT_NFS=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
-CONFIG_LIBCRC32C=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_SLAB=y
 CONFIG_DEBUG_SPINLOCK=y
 CONFIG_DEBUG_MUTEXES=y
 CONFIG_DEBUG_USER=y

arch/arm/configs/imx_v6_v7_defconfig +0 -1

index eace4475fa9d2..297c6a7b978a6 100644
@@ -481,11 +481,10 @@ CONFIG_SECURITYFS=y
 CONFIG_CRYPTO_DEV_FSL_CAAM=y
 CONFIG_CRYPTO_DEV_SAHARA=y
 CONFIG_CRYPTO_DEV_MXS_DCP=y
 CONFIG_CRC_CCITT=m
 CONFIG_CRC_T10DIF=y
-CONFIG_LIBCRC32C=m
 CONFIG_CMA_SIZE_MBYTES=64
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y
 CONFIG_PRINTK_TIME=y

arch/arm/configs/multi_v5_defconfig +0 -1

index 3f4ddcf49ec75..db81862bdb937 100644
@@ -288,11 +288,10 @@ CONFIG_NLS_ISO8859_2=y
 CONFIG_NLS_UTF8=y
 CONFIG_CRYPTO_CBC=m
 CONFIG_CRYPTO_PCBC=m
 CONFIG_CRYPTO_DEV_MARVELL_CESA=y
 CONFIG_CRC_CCITT=y
-CONFIG_LIBCRC32C=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set

arch/arm/configs/mvebu_v5_defconfig +0 -1

index 2467afd32146b..a518d4a2581e0 100644
@@ -186,11 +186,10 @@ CONFIG_NLS_ISO8859_2=y
 CONFIG_NLS_UTF8=y
 CONFIG_CRYPTO_CBC=m
 CONFIG_CRYPTO_PCBC=m
 CONFIG_CRYPTO_DEV_MARVELL_CESA=y
 CONFIG_CRC_CCITT=y
-CONFIG_LIBCRC32C=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set

arch/arm/configs/omap1_defconfig +0 -1

index 025b595dd8375..661e5d6894bd3 100644
@@ -219,11 +219,10 @@ CONFIG_SECURITY=y
 CONFIG_CRYPTO_ECB=y
 CONFIG_CRYPTO_PCBC=y
 CONFIG_CRYPTO_DEFLATE=y
 CONFIG_CRYPTO_LZO=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
-CONFIG_LIBCRC32C=y
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y
 CONFIG_FONT_6x11=y
 CONFIG_FONT_MINI_4x6=y

arch/arm/configs/omap2plus_defconfig +0 -1

index 99636c9dced1a..d62b17f14d541 100644
@@ -708,11 +708,10 @@ CONFIG_CRYPTO_DEV_OMAP_SHAM=m
 CONFIG_CRYPTO_DEV_OMAP_AES=m
 CONFIG_CRYPTO_DEV_OMAP_DES=m
 CONFIG_CRC_CCITT=y
 CONFIG_CRC_T10DIF=y
 CONFIG_CRC_ITU_T=y
-CONFIG_LIBCRC32C=y
 CONFIG_DMA_CMA=y
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y
 CONFIG_PRINTK_TIME=y

arch/arm/configs/spitz_defconfig +0 -1

index 294d16ddeb18a..ac5b7a5aaff68 100644
@@ -233,11 +233,10 @@ CONFIG_CRYPTO_HMAC=y
 CONFIG_CRYPTO_MD4=m
 CONFIG_CRYPTO_MICHAEL_MIC=m
 CONFIG_CRYPTO_SHA512=m
 CONFIG_CRYPTO_WP512=m
 CONFIG_CRC_CCITT=y
-CONFIG_LIBCRC32C=m
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_DEBUG_PREEMPT is not set

arch/arm/configs/wpcm450_defconfig +0 -1

index 45483deab034f..5e4397f7f828c 100644
@@ -191,11 +191,10 @@ CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y
 CONFIG_X509_CERTIFICATE_PARSER=y
 CONFIG_PKCS7_MESSAGE_PARSER=y
 CONFIG_SYSTEM_TRUSTED_KEYRING=y
 CONFIG_CRC_CCITT=y
 CONFIG_CRC_ITU_T=m
-CONFIG_LIBCRC32C=y
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set

arch/hexagon/configs/comet_defconfig +0 -1

index 6cb7649475964..469c025297c69 100644
@@ -73,10 +73,9 @@ CONFIG_CRYPTO_MD5=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC_CCITT=y
 CONFIG_CRC16=y
 CONFIG_CRC_T10DIF=y
-CONFIG_LIBCRC32C=y
 CONFIG_FRAME_WARN=0
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set

arch/mips/configs/cobalt_defconfig +0 -1

index e835730ea7fa4..b0b551efac7c4 100644
@@ -68,6 +68,5 @@ CONFIG_TMPFS_POSIX_ACL=y
 CONFIG_CONFIGFS_FS=y
 CONFIG_NFS_FS=y
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFSD=y
 CONFIG_NFSD_V3_ACL=y
-CONFIG_LIBCRC32C=y

arch/mips/configs/ip32_defconfig +0 -1

index 930c5f6ed1828..121e7e48fa771 100644
@@ -176,10 +176,9 @@ CONFIG_CRYPTO_KHAZAD=y
 CONFIG_CRYPTO_SERPENT=y
 CONFIG_CRYPTO_TEA=y
 CONFIG_CRYPTO_TWOFISH=y
 CONFIG_CRYPTO_DEFLATE=y
 CONFIG_CRC_T10DIF=y
-CONFIG_LIBCRC32C=y
 CONFIG_FONTS=y
 CONFIG_FONT_8x8=y
 CONFIG_FONT_8x16=y
 CONFIG_MAGIC_SYSRQ=y

arch/parisc/configs/generic-64bit_defconfig +0 -1

index 19a804860ed5b..3f96c02ecaf64 100644
@@ -292,11 +292,10 @@ CONFIG_CRYPTO_MD4=m
 CONFIG_CRYPTO_MD5=y
 CONFIG_CRYPTO_MICHAEL_MIC=m
 CONFIG_CRYPTO_DEFLATE=m
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC_CCITT=m
-CONFIG_LIBCRC32C=y
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_STRIP_ASM_SYMS=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y

arch/powerpc/configs/85xx/ge_imp3a_defconfig +0 -1

index da6fc203e2dc6..6f58ee1edf1fc 100644
@@ -221,11 +221,10 @@ CONFIG_NLS_ISO8859_15=y
 CONFIG_NLS_KOI8_R=m
 CONFIG_NLS_KOI8_U=m
 CONFIG_NLS_UTF8=y
 CONFIG_CRC_CCITT=y
 CONFIG_CRC_T10DIF=y
-CONFIG_LIBCRC32C=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_CRYPTO_CBC=y
 CONFIG_CRYPTO_MD5=y
 CONFIG_CRYPTO_SHA512=m
 CONFIG_CRYPTO_DES=y

arch/powerpc/configs/skiroot_defconfig +0 -1

index 9d44e6630908d..1eb446452fc04 100644
@@ -279,11 +279,10 @@ CONFIG_LOCK_DOWN_KERNEL_FORCE_INTEGRITY=y
 # CONFIG_INTEGRITY is not set
 CONFIG_LSM="yama,loadpin,safesetid,integrity"
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC16=y
 CONFIG_CRC_ITU_T=y
-CONFIG_LIBCRC32C=y
 # CONFIG_XZ_DEC_X86 is not set
 # CONFIG_XZ_DEC_IA64 is not set
 # CONFIG_XZ_DEC_ARM is not set
 # CONFIG_XZ_DEC_ARMTHUMB is not set
 # CONFIG_XZ_DEC_SPARC is not set

arch/sh/configs/se7206_defconfig +0 -1

index f104c3b9a1770..472fdf365cad0 100644
@@ -102,6 +102,5 @@ CONFIG_CRYPTO_LZO=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC_CCITT=y
 CONFIG_CRC16=y
 CONFIG_CRC_ITU_T=y
-CONFIG_LIBCRC32C=y

arch/sh/configs/sh2007_defconfig +0 -1

index 977ae405a75e7..1b1174a07e361 100644
@@ -193,6 +193,5 @@ CONFIG_CRYPTO_DEFLATE=y
 CONFIG_CRYPTO_LZO=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 # CONFIG_CRYPTO_HW is not set
 CONFIG_CRC_CCITT=y
 CONFIG_CRC16=y
-CONFIG_LIBCRC32C=y

arch/sh/configs/titan_defconfig +0 -1

index 99bc0e889287a..11ff5fd510de1 100644
@@ -264,6 +264,5 @@ CONFIG_CRYPTO_KHAZAD=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
 CONFIG_CRYPTO_TWOFISH=m
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_CRC16=m
-CONFIG_LIBCRC32C=m

arch/sparc/configs/sparc32_defconfig +0 -1

index 5010164de3e45..f6341b063b01b 100644
@@ -92,6 +92,5 @@ CONFIG_CRYPTO_CAST5=m
 CONFIG_CRYPTO_CAST6=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TWOFISH=m
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 # CONFIG_CRYPTO_HW is not set
-CONFIG_LIBCRC32C=m

arch/sparc/configs/sparc64_defconfig +0 -1

index 0bb0d4da52277..01b2bdfbf9a89 100644
@@ -228,11 +228,10 @@ CONFIG_CRYPTO_SEED=m
 CONFIG_CRYPTO_SERPENT=m
 CONFIG_CRYPTO_TEA=m
 CONFIG_CRYPTO_TWOFISH=m
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_CRC16=m
-CONFIG_LIBCRC32C=m
 CONFIG_VCC=m
 CONFIG_PATA_CMD64X=y
 CONFIG_IP_PNP=y
 CONFIG_IP_PNP_DHCP=y
 CONFIG_DEVTMPFS=y

lib/Kconfig +1 -1

index 31add0dc42925..4bf2dd9f49a80 100644
@@ -213,11 +213,11 @@ config CRC4
 
 config CRC7
 	tristate
 
 config LIBCRC32C
-	tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check"
+	tristate
 	select CRC32
 	help
 	  This option just selects CRC32 and is provided for compatibility
 	  purposes until the users are updated to select CRC32 directly.

Signature · 1 line

2.48.1

Eric Biggers

author

2025-03-04 23:08 UTC #5 lore raw

PATCH 5/5 lib/crc: remove unnecessary prompt for CONFIG_CRC64

In reply to Eric Biggers

From: Eric Biggers <[email protected]>

All modules that need CONFIG_CRC64 already select it, so there is no need to bother users about the option.

Signed-off-by Eric Biggers <[email protected]>

---
 lib/Kconfig | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

lib/Kconfig +1 -6

index 4bf2dd9f49a80..61cce0686b53e 100644
@@ -192,16 +192,11 @@ config ARCH_HAS_CRC32
 config CRC32_ARCH
 	tristate
 	default CRC32 if ARCH_HAS_CRC32 && CRC_OPTIMIZATIONS
 
 config CRC64
-	tristate "CRC64 functions"
-	help
-	  This option is provided for the case where no in-kernel-tree
-	  modules require CRC64 functions, but a module built outside
-	  the kernel tree does. Such modules that use library CRC64
-	  functions require M here.
+	tristate
 
 config ARCH_HAS_CRC64
 	bool
 
 config CRC64_ARCH

Signature · 1 line

2.48.1

Ard Biesheuvel

Acked-by on the v1 series

2025-03-06 08:17 UTC #6 lore raw

In reply to Eric Biggers

Quoted 5 lines · Eric Biggers

Library functions are already selected when they are needed, so there is no need to ask users whether to enable them or not. This patchset fixes this for the first batch of CRC library options.

Quoted 9 lines

There will be a batch 2 later to handle the rest.
Eric Biggers (5):
lib/crc: remove unnecessary prompt for CONFIG_CRC4 lib/crc: remove unnecessary prompt for CONFIG_CRC7 lib/crc: remove unnecessary prompt for CONFIG_CRC8 lib/crc: remove unnecessary prompt for CONFIG_LIBCRC32C lib/crc: remove unnecessary prompt for CONFIG_CRC64

Acked-by Ard Biesheuvel <[email protected]>

Eric Biggers

author

2025-03-06 17:22 UTC #7 lore raw

In reply to Eric Biggers

Quoted 4 lines · Eric Biggers

Library functions are already selected when they are needed, so there is no need to ask users whether to enable them or not. This patchset fixes this for the first batch of CRC library options.

Quoted 9 lines

There will be a batch 2 later to handle the rest.
Eric Biggers (5):
lib/crc: remove unnecessary prompt for CONFIG_CRC4 lib/crc: remove unnecessary prompt for CONFIG_CRC7 lib/crc: remove unnecessary prompt for CONFIG_CRC8 lib/crc: remove unnecessary prompt for CONFIG_LIBCRC32C lib/crc: remove unnecessary prompt for CONFIG_CRC64

Applied to
https://web.git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

- Eric