scsi: megaraid_sas: static most module parameters
Subsystems (2)
PATCH 1/1 scsi: megaraid_sas: static most module parameters
From: "Dr. David Alan Gilbert" <[email protected]>
Most of the module parameters are only used locally in the same C file; so static them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
--- drivers/scsi/megaraid/megaraid_sas_base.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/scsi/megaraid/megaraid_sas_base.c +5 -5
@@ -93,7 +93,7 @@ static unsigned int scmd_timeout = MEGASAS_DEFAULT_CMD_TIMEOUT;module_param (scmd_timeout, int,0444 );MODULE_PARM_DESC (scmd_timeout,"scsi command timeout (10-90s), default 90s. See megasas_reset_timer." ); -int perf_mode =-1 ; +static int perf_mode =-1 ;module_param (perf_mode, int,0444 );MODULE_PARM_DESC (perf_mode,"Performance mode (only for Aero adapters), options:\n\t\t" "0 - balanced: High iops and low latency queues are allocated &\n\t\t"
@@ -105,15 +105,15 @@ MODULE_PARM_DESC(perf_mode, "Performance mode (only for Aero adapters), options:"default mode is 'balanced'" ); -int event_log_level =MFI_EVT_CLASS_CRITICAL ; +static int event_log_level =MFI_EVT_CLASS_CRITICAL ;module_param (event_log_level, int,0644 );MODULE_PARM_DESC (event_log_level,"Asynchronous event logging level- range is: -2(CLASS_DEBUG) to 4(CLASS_DEAD), Default: 2(CLASS_CRITICAL)" ); -unsigned int enable_sdev_max_qd; +static unsigned int enable_sdev_max_qd;module_param (enable_sdev_max_qd, int,0444 );MODULE_PARM_DESC (enable_sdev_max_qd,"Enable sdev max qd as can_queue. Default: 0" ); -int poll_queues; +static int poll_queues;module_param (poll_queues, int,0444 );MODULE_PARM_DESC (poll_queues,"Number of queues to be use for io_uring poll mode.\n\t\t" "This parameter is effective only if host_tagset_enable=1 &\n\t\t"
@@ -122,7 +122,7 @@ MODULE_PARM_DESC(poll_queues, "Number of queues to be use for io_uring poll mode"High iops queues are not allocated &\n\t\t" ); -int host_tagset_enable =1 ; +static int host_tagset_enable =1 ;module_param (host_tagset_enable, int,0444 );MODULE_PARM_DESC (host_tagset_enable,"Shared host tagset enable/disable Default: enable(1)" );
Signature · 1 line
2.48.1
Quoted 6 lines · On 3/9/25 23:33, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
Most of the module parameters are only used locally in the same C file; so static them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Reviewed-by Damien Le Moal <[email protected]>
Signature · 2 lines
Damien Le Moal Western Digital Research
Martin K. Petersen
AppliedQuoted 3 lines
Most of the module parameters are only used locally in the same C file; so static them.
Applied to 6.15/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 4 lines · On Sun, 09 Mar 2025 14:33:48 +0000, [email protected] wrote:
Most of the module parameters are only used locally in the same C file; so static them.
Applied to 6.15/scsi-queue, thanks!
[1/1] scsi: megaraid_sas: static most module parameters
https://git.kernel.org/mkp/scsi/c/b79e4a2d3e5f
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering