usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev()
Subsystems (4)
PATCH 1/1 usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev()
The variable d->name, returned by devm_kasprintf(), could be NULL. A pointer check is added to prevent potential NULL pointer dereference. This is similar to the fix in commit 3027e7b15b02
("ice: Fix some null pointer dereference issues in ice_ptp.c").
This issue is found by our static analysis tool
Signed-off-by Chenyuan Yang <[email protected]>
--- drivers/usb/gadget/udc/aspeed-vhub/dev.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/gadget/udc/aspeed-vhub/dev.c +3 -0
@@ -548,6 +548,9 @@ int ast_vhub_init_dev(struct ast_vhub *vhub, unsigned int idx) d->vhub = vhub; d->index = idx; d->name =devm_kasprintf (parent,GFP_KERNEL ,"port%d" , idx+1 ); +if (!d->name) +return -ENOMEM ; + d->regs = vhub->regs +0x100 +0x10 * idx;ast_vhub_init_ep0 (vhub, &d->ep0, d);
Signature · 1 line
2.34.1
Quoted 7 lines · Chenyuan Yang
The variable
d->name, returned bydevm_kasprintf(), could be NULL. A pointer check is added to prevent potential NULL pointer dereference.
This is similar to the fix in commit3027e7b15b02("ice: Fix some null pointer dereference issues inice_ptp.c").This issue is found by our static analysis tool
Which tool is this? Can it be run by others (me)?
Quoted 2 lines
Signed-off-by Chenyuan Yang <[email protected]>
Reviewed-by Andrew Jeffery <[email protected]>