media: ipu6: Remove workaround for Meteor Lake ES2
Subsystems (2)
PATCH 1/1 media: ipu6: Remove workaround for Meteor Lake ES2
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
--- drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/media/pci/intel/ipu6/ipu6.c +0 -5
@@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) {int ret; -/* disable IPU6 PCI ATS on mtl ES2 */ -if (is_ipu6ep_mtl (hw_ver) && boot_cpu_data.x86_stepping ==0x2 && -pci_ats_supported (dev)) -pci_disable_ats (dev); -/* No PCI msi capability for IPU6EP */ if (is_ipu6ep (hw_ver) ||is_ipu6ep_mtl (hw_ver)) {/* likely do nothing as msi not enabled by default */
Signature · 1 line
2.43.0
Quoted 5 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
Signed-off-by Hao Yao <[email protected]>
Regards
Stanislaw
Quoted 24 lines
--- drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- 1 file changed, 5 deletions(-)drivers/media/pci/intel/ipu6/ipu6.c +0
-5@@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) {int ret; -/* disable IPU6 PCI ATS on mtl ES2 */ -if (is_ipu6ep_mtl (hw_ver) && boot_cpu_data.x86_stepping ==0x2 && -pci_ats_supported (dev)) -pci_disable_ats (dev); -/* No PCI msi capability for IPU6EP */ if (is_ipu6ep (hw_ver) ||is_ipu6ep_mtl (hw_ver)) {/* likely do nothing as msi not enabled by default */ Signature · 1 line
2.43.0
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
It is better to send v2 with fixes tag here:
Quoted 22 lines
Signed-off-by Hao Yao <[email protected]>--- drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- 1 file changed, 5 deletions(-)drivers/media/pci/intel/ipu6/ipu6.c +0
-5@@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) {int ret; -/* disable IPU6 PCI ATS on mtl ES2 */ -if (is_ipu6ep_mtl (hw_ver) && boot_cpu_data.x86_stepping ==0x2 && -pci_ats_supported (dev)) -pci_disable_ats (dev); -/* No PCI msi capability for IPU6EP */ if (is_ipu6ep (hw_ver) ||is_ipu6ep_mtl (hw_ver)) {/* likely do nothing as msi not enabled by default */
Signature · 2 lines
Best regards, Bingbu Cao
Sakari Ailus
maintainerHi Bingbu,
Quoted 11 lines · Bingbu Cao
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
It is better to send v2 with fixes tag here:
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
Is this worth backporting? Nothing is broken because of this, is it?
Quoted 24 lines
Quoted 23 lines
Signed-off-by Hao Yao <[email protected]>--- drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- 1 file changed, 5 deletions(-)drivers/media/pci/intel/ipu6/ipu6.c +0
-5@@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) {int ret; -/* disable IPU6 PCI ATS on mtl ES2 */ -if (is_ipu6ep_mtl (hw_ver) && boot_cpu_data.x86_stepping ==0x2 && -pci_ats_supported (dev)) -pci_disable_ats (dev); -/* No PCI msi capability for IPU6EP */ if (is_ipu6ep (hw_ver) ||is_ipu6ep_mtl (hw_ver)) {/* likely do nothing as msi not enabled by default */
Signature · 3 lines
Regards, Sakari Ailus
Sakari,
Quoted 11 lines · Sakari Ailus
Hi Bingbu,
Quoted 8 lines · Bingbu Cao
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
Quoted 5 lines
Quoted 3 lines
It is better to send v2 with fixes tag here:
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")Is this worth backporting? Nothing is broken because of this, is it?
It is necessary. IPU6 on Raptor Lake share same device ID with Meteor Lake, this workaround will break camera on Raptor Lake.
And Meteor Lake ES2 is not used in product.
Quoted 26 lines
Quoted 25 lines
Quoted 24 lines
Signed-off-by Hao Yao <[email protected]>--- drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- 1 file changed, 5 deletions(-)drivers/media/pci/intel/ipu6/ipu6.c +0
-5@@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) {int ret; -/* disable IPU6 PCI ATS on mtl ES2 */ -if (is_ipu6ep_mtl (hw_ver) && boot_cpu_data.x86_stepping ==0x2 && -pci_ats_supported (dev)) -pci_disable_ats (dev); -/* No PCI msi capability for IPU6EP */ if (is_ipu6ep (hw_ver) ||is_ipu6ep_mtl (hw_ver)) {/* likely do nothing as msi not enabled by default */
Signature · 2 lines
Best regards, Bingbu Cao
Sakari Ailus
maintainerHi Bingbu,
Quoted 16 lines · Bingbu Cao
Sakari,
Quoted 13 lines · Sakari Ailus
Hi Bingbu,
Quoted 10 lines · Bingbu Cao
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
It is better to send v2 with fixes tag here:
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")Is this worth backporting? Nothing is broken because of this, is it?
It is necessary. IPU6 on Raptor Lake share same device ID with Meteor Lake, this workaround will break camera on Raptor Lake.
And Meteor Lake ES2 is not used in product.
Ok, this should be visible in the commit message.
How about adding:
Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but does have the bug. Removing the Meteor Lake workaround is also required for the driver to function on Raptor Lake.
Signature · 3 lines
Regards, Sakari Ailus
Hi Sakari, Bingbu,
Quoted 28 lines · Sakari Ailus
Hi Bingbu,
Quoted 16 lines · Bingbu Cao
Sakari,
Quoted 13 lines · Sakari Ailus
Hi Bingbu,
Quoted 10 lines · Bingbu Cao
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
It is better to send v2 with fixes tag here:
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")Is this worth backporting? Nothing is broken because of this, is it?
It is necessary. IPU6 on Raptor Lake share same device ID with Meteor Lake, this workaround will break camera on Raptor Lake.
And Meteor Lake ES2 is not used in product.
Quoted 8 lines
Ok, this should be visible in the commit message.
How about adding:
Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but does have the bug. Removing the Meteor Lake workaround is also required for the driver to function on Raptor Lake.
In fact it should be Arrow Lake. I will add below to next version:
---
Additionally, Arrow Lake has the same IPU6 PCI ID and x86 stepping
but does not have the bug. Removing the Meteor Lake workaround is
also required for the driver to function on Arrow Lake.
driver")
---
Sakari Ailus
maintainerQuoted 45 lines · Hao Yao
Hi Sakari, Bingbu,
Quoted 28 lines · Sakari Ailus
Hi Bingbu,
Quoted 16 lines · Bingbu Cao
Sakari,
Quoted 13 lines · Sakari Ailus
Hi Bingbu,
Quoted 10 lines · Bingbu Cao
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
It is better to send v2 with fixes tag here:
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")Is this worth backporting? Nothing is broken because of this, is it?
It is necessary. IPU6 on Raptor Lake share same device ID with Meteor Lake, this workaround will break camera on Raptor Lake.
And Meteor Lake ES2 is not used in product.
Quoted 8 lines
Ok, this should be visible in the commit message.
How about adding:
Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but does have the bug. Removing the Meteor Lake workaround is also required for the driver to function on Raptor Lake.
In fact it should be Arrow Lake. I will add below to next version:
---
Additionally, Arrow Lake has the same IPU6 PCI ID and x86 steppingbut does not have the bug. Removing the Meteor Lake workaround is
Quoted 7 lines
also required for the driver to function on Arrow Lake.
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI devicedriver")
---
I can just take it from here, no need to resed.
Signature · 1 line
Sakari Ailus
Quoted 49 lines · Sakari Ailus
Quoted 48 lines · Hao Yao
Hi Sakari, Bingbu,
Quoted 28 lines · Sakari Ailus
Hi Bingbu,
Quoted 16 lines · Bingbu Cao
Sakari,
Quoted 13 lines · Sakari Ailus
Hi Bingbu,
Quoted 10 lines · Bingbu Cao
Hao,
Quoted 4 lines · Hao Yao
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level.
It is better to send v2 with fixes tag here:
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")Is this worth backporting? Nothing is broken because of this, is it?
It is necessary. IPU6 on Raptor Lake share same device ID with Meteor Lake, this workaround will break camera on Raptor Lake.
And Meteor Lake ES2 is not used in product.
Quoted 8 lines
Ok, this should be visible in the commit message.
How about adding:
Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but does have the bug. Removing the Meteor Lake workaround is also required for the driver to function on Raptor Lake.
In fact it should be Arrow Lake. I will add below to next version:
---
Additionally, Arrow Lake has the same IPU6 PCI ID and x86 steppingbut does not have the bug. Removing the Meteor Lake workaround is
also required for the driver to function on Arrow Lake.
Quoted 6 lines
Quoted 4 lines
Fixes 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI devicedriver")
---I can just take it from here, no need to resed.
Thanks!
Signature · 2 lines
Best regards, Bingbu Cao