Skip to contentSkip to conversation

rust: sync: optimize Rust symbol generation for PollCondVar

PATCH New Kunwu Chan 1 participant 1 message Mar 13, 2025

Subsystems (3)
lore
Share & tools
lore

Kunwu Chan

author
#0 lore raw

PATCH 1/1 rust: sync: optimize Rust symbol generation for PollCondVar

From: Kunwu Chan <[email protected]>

When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64 with ARCH=arm64, the following symbols are generated:

$nm vmlinux | grep ' _R'.*PollCondVar | rustfilt ffff800080019e90 T <kernel::sync::poll::PollCondVar>

			::new::{closure#0}::{closure#0}::panic_cold_explicit
ffff8000805b8e04 T <kernel::sync::poll::PollCondVar
			as kernel::init::PinnedDrop>::drop
ffff8000805b8e04 T <kernel::sync::poll::PollCondVar
			as core::ops::drop::Drop>::drop

This Rust symbol
(<kernel::sync::poll::PollCondVar as kernel::init::PinnedDrop>::drop) is trivial wrappers around the C functions __wake_up_pollfree and synchronize_rcu. It doesn't make sense to go through a trivial wrapper for its functions,so mark them inline.

After doing so, the above symbol will not in output.

---
 rust/kernel/sync/poll.rs | 1 +
 1 file changed, 1 insertion(+)
rust/kernel/sync/poll.rs +1 -0
index d5f17153b424..a4f92c545fec 100644
@@ -107,6 +107,7 @@ fn deref(&self) -> &CondVar {
 
 #[pinned_drop]
 impl PinnedDrop for PollCondVar {
+    #[inline]
     fn drop(self: Pin<&mut Self>) {
         // Clear anything registered using `register_wait`.
         //
Signature · 1 line
2.43.0