kbuild: do not generate .tmp_vmlinux*.map when CONFIG_VMLINUX_MAP=y
PATCH 1/1 kbuild: do not generate .tmp_vmlinux*.map when CONFIG_VMLINUX_MAP=y
Commit 5cc124720461 ("kbuild: add CONFIG_VMLINUX_MAP expert option") mentioned that "the .map file can be rather large (several MB), and that's a waste of space when one isn't interested in these things."
If that is the case, generating map files for the intermediate tmp_vmlinux* files is also a waste of space. It is unlikely that anyone would be interested in the .tmp_vmlinux.map* files.
This commit stops passing the -Map= option when linking the .tmp_vmlinux* intermediates.
I also hard-coded the file name 'vmlinux.map' instead of ${output}.map because a later commit will introduce vmlinux.unstripped but I want to keep the name of the map file.
---
scripts/link-vmlinux.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
scripts/link-vmlinux.sh +7 -2
@@ -98,8 +98,8 @@ vmlinux_link() ldflags="${ldflags} ${wl}--strip-debug" fi - if is_enabled CONFIG_VMLINUX_MAP; then - ldflags="${ldflags} ${wl}-Map=${output}.map" + if [ -n "${generate_map}" ]; then + ldflags="${ldflags} ${wl}-Map=vmlinux.map" fi ${ld} ${ldflags} -o ${output} \
@@ -211,6 +211,7 @@ fi btf_vmlinux_bin_o= kallsymso= strip_debug= +generate_map= if is_enabled CONFIG_KALLSYMS; then true > .tmp_vmlinux0.syms
@@ -279,6 +280,10 @@ fi strip_debug= +if is_enabled CONFIG_VMLINUX_MAP; then + generate_map=1 +fi + vmlinux_link "${VMLINUX}" # fill in BTF IDs
Signature · 1 line
2.43.0
Quoted 9 lines · Masahiro Yamada
Commit
5cc124720461("kbuild: addCONFIG_VMLINUX_MAPexpert option") mentioned that "the .map file can be rather large (several MB), and that's a waste of space when one isn't interested in these things."If that is the case, generating map files for the intermediate tmp_vmlinux* files is also a waste of space. It is unlikely that anyone would be interested in the .tmp_vmlinux.map* files.
Quoted 8 lines
This commit stops passing the -Map= option when linking the .tmp_vmlinux* intermediates.
I also hard-coded the file name 'vmlinux.map' instead of ${output}.map because a later commit will introduce vmlinux.unstripped but I want to keep the name of the map file.
Signed-off-by Masahiro Yamada <[email protected]>
Quoted 42 lines
---
scripts/link-vmlinux.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)scripts/link-vmlinux.sh +7
-3@@ -98,8 +98,8 @@ vmlinux_link() ldflags="${ldflags} ${wl}--strip-debug" fi - if is_enabled CONFIG_VMLINUX_MAP; then - ldflags="${ldflags} ${wl}-Map=${output}.map" + if [ -n "${generate_map}" ]; then + ldflags="${ldflags} ${wl}-Map=vmlinux.map" fi ${ld} ${ldflags} -o ${output} \@@ -211,6 +211,7 @@ fi btf_vmlinux_bin_o= kallsymso= strip_debug= +generate_map= if is_enabled CONFIG_KALLSYMS; then true > .tmp_vmlinux0.syms@@ -279,6 +280,10 @@ fi strip_debug= +if is_enabled CONFIG_VMLINUX_MAP; then + generate_map=1 +fi + vmlinux_link "${VMLINUX}" # fill in BTF IDs --2.43.0
Quoted 8 lines · Masahiro Yamada
Commit
5cc124720461("kbuild: addCONFIG_VMLINUX_MAPexpert option") mentioned that "the .map file can be rather large (several MB), and that's a waste of space when one isn't interested in these things."If that is the case, generating map files for the intermediate tmp_vmlinux* files is also a waste of space. It is unlikely that anyone would be interested in the .tmp_vmlinux.map* files.
I fixed this typo:
.tmp_vmlinux.map* -> .tmp_vmlinux*.map
Quoted 10 lines
This commit stops passing the -Map= option when linking the .tmp_vmlinux* intermediates.
I also hard-coded the file name 'vmlinux.map' instead of ${output}.map because a later commit will introduce vmlinux.unstripped but I want to keep the name of the map file.
Signed-off-by Masahiro Yamada <[email protected]>---
Inserted before Ard's patch set.
Signature · 2 lines
Best Regards Masahiro Yamada