Skip to contentSkip to conversation

usb: xhci: Don't log transfer ring segment list on errors

PATCH New Michal Pecio 1 participant 1 message Mar 14, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: xhci: Don't log transfer ring segment list on errors

The error message above used to span two lines, rarely more. A recent cleanup concentrated useful information from it in one line, but then it added printing the list of all ring segments, which is even longer than before. It provides no new information in usual cases and little in unusual ones, but adds noise to the log. Drop it.

---
 drivers/usb/host/xhci-ring.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/usb/host/xhci-ring.c +0 -3
index 5d64c297721c..9e50cc3354cb 100644
@@ -2981,9 +2981,6 @@ static int handle_tx_event(struct xhci_hcd *xhci,
 		 (unsigned long long)xhci_trb_virt_to_dma(td->start_seg, td->start_trb),
 		 (unsigned long long)xhci_trb_virt_to_dma(td->end_seg, td->end_trb));
 
-	xhci_for_each_ring_seg(ep_ring->first_seg, ep_seg)
-		xhci_warn(xhci, "Ring seg %u dma %pad\n", ep_seg->num, &ep_seg->dma);
-
 	return -ESHUTDOWN;
 
 err_out:
Signature · 1 line
2.48.1