btrfs: fix signedness issue in min()
PATCH 1/1 btrfs: fix signedness issue in min()
From: Arnd Bergmann <[email protected]>
Comparing a u64 to an loff_t causes a warning in min()
fs/btrfs/extent_io.c: In function 'extent_write_locked_range':include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_588' declared with attribute error: min(folio_pos(folio) + folio_size(folio) - 1, end) signedness error fs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
2472 | cur_end = min(folio_pos(folio) + folio_size(folio) - 1, end);
| ^~~
Use min_t() instead.
--- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/extent_io.c +1 -1
@@ -2468,7 +2468,7 @@ void extent_write_locked_range(struct inode *inode, const struct folio *locked_fcontinue ; } - cur_end =min (folio_pos (folio) +folio_size (folio) -1 , end); + cur_end =min_t (u64,folio_pos (folio) +folio_size (folio) -1 , end); cur_len = cur_end +1 - cur;ASSERT (folio_test_locked (folio));
Signature · 1 line
2.39.5
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Comparing a u64 to an
loff_tcauses a warning inmin()
fs/btrfs/extent_io.c: In function 'extent_write_locked_range':include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_588' declared with attribute error:min(folio_pos(folio) + folio_size(folio) - 1, end)signedness errorfs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
2472 |cur_end=min(folio_pos(folio) + folio_size(folio) - 1, end);
| ^~~
Quoted 4 lines
Use
min_t()instead.Fixes f286b1c72175 ("btrfs: prepare extent_io.c for future larger folio support")Signed-off-by Arnd Bergmann <[email protected]>
Thanks, there was another report and the upcoming for-next will have it fixed.
Quoted 11 lines · On Fri, 14 Mar 2025 16:54:41 +0100 Arnd Bergmann <[email protected]> wrote:
From: Arnd Bergmann <[email protected]>
Comparing a u64 to an
loff_tcauses a warning inmin()
fs/btrfs/extent_io.c: In function 'extent_write_locked_range':include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_588' declared with attribute error:min(folio_pos(folio) + folio_size(folio) - 1, end)signedness errorfs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
2472 |cur_end=min(folio_pos(folio) + folio_size(folio) - 1, end);
| ^~~Use
min_t()instead.
It would be slightly better to use min_unsigned() since, regardless of the types involved, it can't discard significant bits.
OTOH the real problem here is that both folio_pos() and folio_size() return signed types.
David
Quoted 20 lines
Fixes f286b1c72175 ("btrfs: prepare extent_io.c for future larger folio support")Signed-off-by Arnd Bergmann <[email protected]>--- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/btrfs/extent_io.c +1
-1@@ -2468,7 +2468,7 @@ void extent_write_locked_range(struct inode *inode, const struct folio *locked_fcontinue ; } - cur_end =min (folio_pos (folio) +folio_size (folio) -1 , end); + cur_end =min_t (u64,folio_pos (folio) +folio_size (folio) -1 , end); cur_len = cur_end +1 - cur;ASSERT (folio_test_locked (folio));
Quoted 13 lines · David Laight
Quoted 10 lines · On Fri, 14 Mar 2025 16:54:41 +0100 Arnd Bergmann <[email protected]> wrote:
From: Arnd Bergmann <[email protected]>
Comparing a u64 to an
loff_tcauses a warning inmin()
fs/btrfs/extent_io.c: In function 'extent_write_locked_range':include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_588' declared with attribute error:min(folio_pos(folio) + folio_size(folio) - 1, end)signedness errorfs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
2472 |cur_end=min(folio_pos(folio) + folio_size(folio) - 1, end);
| ^~~
Quoted 6 lines
Quoted 1 line
Use
min_t()instead.It would be slightly better to use
min_unsigned()since, regardless of the types involved, it can't discard significant bits.OTOH the real problem here is that both
folio_pos()andfolio_size()return signed types.
folio_size() returns size_t:
static inline size_t folio_size(const struct folio *folio)
{
return PAGE_SIZE << folio_order(folio);
}Otherwise the min_t with force u64 is ok and lots of min() use (in btrfs) was converted to the typed variant in case the types don't match.
Quoted 23 lines · On Mon, 17 Mar 2025 20:26:39 +0100 David Sterba <[email protected]> wrote:
Quoted 13 lines · David Laight
Quoted 10 lines · On Fri, 14 Mar 2025 16:54:41 +0100 Arnd Bergmann <[email protected]> wrote:
From: Arnd Bergmann <[email protected]>
Comparing a u64 to an
loff_tcauses a warning inmin()
fs/btrfs/extent_io.c: In function 'extent_write_locked_range':include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_588' declared with attribute error:min(folio_pos(folio) + folio_size(folio) - 1, end)signedness errorfs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
2472 |cur_end=min(folio_pos(folio) + folio_size(folio) - 1, end);
| ^~~Quoted 6 lines
Quoted 1 line
Use
min_t()instead.It would be slightly better to use
min_unsigned()since, regardless of the types involved, it can't discard significant bits.OTOH the real problem here is that both
folio_pos()andfolio_size()return signed types.
folio_size()returnssize_t:
Quoted 7 lines
static inline
size_tfolio_size(const struct folio *folio){ return PAGE_SIZE << folio_order(folio); }Otherwise the
min_twith force u64 is ok and lots ofmin()use (in btrfs) was converted to the typed variant in case the types don't match.
That is just broken.min_t(u64, x, y) is just min((u64)x, (u64)y) and you wouldn't do the same casts anywhere else unless you really had to.
So you really shouldn't use min_t() unless there is no other way around the problem.
Ok (u64) are unlikely to be a problem, but there are plenty of places where (u8) get used and can (and actually has) discard significant bits and cause bugs.
David