Skip to contentSkip to conversation

dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml

PATCH Superseded Fabio Estevam 2 participants 2 messages Mar 15, 2025 – Mar 17, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml

From: Fabio Estevam <[email protected]>

Currently, when the 'spi-max-frequency' property is passed, the following dt-schema warning is seen:

'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'

Fix it by adding a reference to spi-peripheral-props.yaml and change it to use 'unevaluatedProperties: false'.

---
 Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml +2 -1
index 2d9fe5a75b06..11fcf0ca1ae0 100644
@@ -8,6 +8,7 @@ title: NXP PCF2127 Real Time Clock
 
 allOf:
   - $ref: rtc.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
 
 maintainers:
   - Alexandre Belloni <[email protected]>
@@ -34,7 +35,7 @@ required:
   - compatible
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently, when the 'spi-max-frequency' property is passed, the following dt-schema warning is seen:

'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'

Is this real or imaginary error? If imaginary, then do not include it because it just confuses.

Otherwise: which Makefile target in upstream has this error?

Quoted 3 lines

Fix it by adding a reference to spi-peripheral-props.yaml and change it to use 'unevaluatedProperties: false'.

You wrote 7 lines for something as simple as saying this is a SPI device thus its binding should reference SPI device properties. Please write concise and accurate commit msgs.

Best regards,
Krzysztof