Skip to contentSkip to conversation

maple_tree-remove-a-bug_on-in-mas_alloc_nodes.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Mar 17, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: maple_tree: remove a BUG_ON() in mas_alloc_nodes()
has been removed from the -mm tree. Its filename was
maple_tree-remove-a-bug_on-in-mas_alloc_nodes.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Petr Tesarik <[email protected]>
Subject: maple_tree: remove a BUG_ON() in mas_alloc_nodes()
Date: Thu, 13 Feb 2025 12:44:53 +0100

Remove a BUG_ON() right before a WARN_ON() with the same condition.

Calling WARN_ON() and BUG_ON() here is definitely wrong. Since the goal is generally to remove BUG_ON() invocations from the kernel, keep only the WARN_ON().

Fixes 067311d33e65 ("maple_tree: separate ma_state node from status")

---

 lib/maple_tree.c |    1 -
 1 file changed, 1 deletion(-)
lib/maple_tree.c renamed from lib/maple_tree.c~maple_tree-remove-a-bug_on-in-mas_alloc_nodes +0 -1
@@ -1242,7 +1242,6 @@ static inline void mas_alloc_nodes(struc
 	if (mas->mas_flags & MA_STATE_PREALLOC) {
 		if (allocated)
 			return;
-		BUG_ON(!allocated);
 		WARN_ON(!allocated);
 	}
 

_

Patches currently in -mm which might be from [email protected] are