Skip to contentSkip to conversation

filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Mar 17, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: filemap: remove redundant folio_test_large check in filemap_free_folio
has been removed from the -mm tree. Its filename was
filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Guanjun <[email protected]>
Subject: filemap: remove redundant folio_test_large check in filemap_free_folio
Date: Thu, 13 Feb 2025 13:56:12 +0800

The folio_test_large() check in filemap_free_folio() is unnecessary because folio_nr_pages(), which is called internally already performs this check. Removing the redundant condition simplifies the code and avoids double validation.

This change improves code readability and reduces unnecessary operations in the folio freeing path.

---

 mm/filemap.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
mm/filemap.c renamed from mm/filemap.c~filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio +1 -4
@@ -227,15 +227,12 @@ void __filemap_remove_folio(struct folio
 void filemap_free_folio(struct address_space *mapping, struct folio *folio)
 {
 	void (*free_folio)(struct folio *);
-	int refs = 1;
 
 	free_folio = mapping->a_ops->free_folio;
 	if (free_folio)
 		free_folio(folio);
 
-	if (folio_test_large(folio))
-		refs = folio_nr_pages(folio);
-	folio_put_refs(folio, refs);
+	folio_put_refs(folio, folio_nr_pages(folio));
 }
 
 /**

_

Patches currently in -mm which might be from [email protected] are