batman-adv: no need to start/stop queue on soft-iface
Antonio Quartulli
maintainerPATCH 1/1 batman-adv: no need to start/stop queue on soft-iface
The batman-adv soft-iface is flagged with IFF_NO_QUEUE, therefore there is no reason to start/stop any queue in ndo_open/close.
--- net/batman-adv/soft-interface.c | 14 -------------- 1 file changed, 14 deletions(-)
net/batman-adv/soft-interface.c +0 -14
@@ -77,18 +77,6 @@ int batadv_skb_head_push(struct sk_buff *skb, unsigned int len)return 0 ; } -static int batadv_interface_open (struct net_device *dev) -{ -netif_start_queue (dev); -return 0 ; -} - -static int batadv_interface_release (struct net_device *dev) -{ -netif_stop_queue (dev); -return 0 ; -} -/** * batadv_sum_counter() - Sum the cpu-local counters for index 'idx' * @bat_priv: the bat priv with all the soft interface information
@@ -906,8 +894,6 @@ static int batadv_softif_slave_del(struct net_device *dev,static const struct net_device_ops batadv_netdev_ops = { .ndo_init = batadv_softif_init_late, - .ndo_open = batadv_interface_open, - .ndo_stop = batadv_interface_release, .ndo_get_stats = batadv_interface_stats, .ndo_vlan_rx_add_vid = batadv_interface_add_vid, .ndo_vlan_rx_kill_vid = batadv_interface_kill_vid,
Signature · 1 line
2.48.1
Sven Eckelmann
maintainerQuoted 5 lines · On Monday, 17 March 2025 11:54:34 CET Antonio Quartulli wrote:
The batman-adv soft-iface is flagged with
IFF_NO_QUEUE, therefore there is no reason to start/stop any queue in ndo_open/close.Signed-off-by Antonio Quartulli <[email protected]>
$ b4 shazam -s [email protected] Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Analyzing 1 messages in the thread Analyzing 0 code-review messages Checking attestation on all messages, may take a moment... --- ✓ [PATCH] batman-adv: no need to start/stop queue on soft-iface + Signed-off-by: Sven Eckelmann <[email protected]> --- ✓ Signed: DKIM/mandelbit.com --- Total patches: 1 --- Applying: batman-adv: no need to start/stop queue on soft-iface Patch failed at 0001 batman-adv: no need to start/stop queue on soft-iface When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". error: net/batman-adv/soft-interface.c: does not exist in index hint: Use 'git am --show-current-patch=diff' to see the failed patch
Might be related to the fact that soft-interface is now called mesh-interface.
Kind regards,
Sven
Antonio Quartulli
maintainerPATCH v2 1/1 batman-adv: no need to start/stop queue on soft-iface
The batman-adv soft-iface is flagged with IFF_NO_QUEUE, therefore there is no reason to start/stop any queue in ndo_open/close.
--- net/batman-adv/mesh-interface.c | 14 -------------- 1 file changed, 14 deletions(-)
net/batman-adv/mesh-interface.c +0 -14
@@ -77,18 +77,6 @@ int batadv_skb_head_push(struct sk_buff *skb, unsigned int len)return 0 ; } -static int batadv_interface_open (struct net_device *dev) -{ -netif_start_queue (dev); -return 0 ; -} - -static int batadv_interface_release (struct net_device *dev) -{ -netif_stop_queue (dev); -return 0 ; -} -/** * batadv_sum_counter() - Sum the cpu-local counters for index 'idx' * @bat_priv: the bat priv with all the mesh interface information
@@ -890,8 +878,6 @@ static int batadv_meshif_slave_del(struct net_device *dev,static const struct net_device_ops batadv_netdev_ops = { .ndo_init = batadv_meshif_init_late, - .ndo_open = batadv_interface_open, - .ndo_stop = batadv_interface_release, .ndo_get_stats = batadv_interface_stats, .ndo_vlan_rx_add_vid = batadv_interface_add_vid, .ndo_vlan_rx_kill_vid = batadv_interface_kill_vid,
Signature · 1 line
2.48.1
Antonio Quartulli
maintainerOn 17/03/2025 12:16, Sven Eckelmann wrote:
[...]
Quoted 11 lines
Applying: batman-adv: no need to start/stop queue on soft-iface Patch failed at 0001 batman-adv: no need to start/stop queue on soft-iface When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
error:net/batman-adv/soft-interface.c: does not exist in index
hint: Use 'git am --show-current-patch=diff' to see the failed patchMight be related to the fact that soft-interface is now called mesh-interface.
Yeah, it was based on old code.
v2 incoming.
Regards,
Signature · 5 lines
Antonio Quartulli CEO and Co-Founder Mandelbit Srl https://www.mandelbit.com