webkitgtk: 2.46.6 -> 2.48.0
PATCH 1/24 webkitgtk: 2.46.6 -> 2.48.0
From: Kai Kang <[email protected]>
Upgrade webkitgtk from 2.46.6 to 2.48.0:
* remove backported patch bmalloc-fix.patch
* update context of no-musttail-arm.patch
* add PACKAGECONFIG speech
---
.../webkit/webkitgtk/bmalloc-fix.patch | 36 -------------------
.../webkit/webkitgtk/no-musttail-arm.patch | 14 +++++---
...ebkitgtk_2.46.6.bb => webkitgtk_2.48.0.bb} | 4 +--
3 files changed, 11 insertions(+), 43 deletions(-)
delete mode 100644 meta/recipes-sato/webkit/webkitgtk/bmalloc-fix.patch
rename meta/recipes-sato/webkit/{webkitgtk_2.46.6.bb => webkitgtk_2.48.0.bb} (97%)meta/recipes-sato/webkit/webkitgtk/bmalloc-fix.patch deleted +0 -36
@@ -1,36 +0,0 @@ -From 6ab7d3f7d8d0d8e1ab401d0fb13f60bbc64279a2 Mon Sep 17 00:00:00 2001 -From: Thomas Klausner <[email protected]> -Date: Thu, 7 Nov 2024 11:54:30 -0800 -Subject: [PATCH] bmalloc: Build problem in bmalloc when X11/X.h is in the same - namespace https://bugs.webkit.org/show_bug.cgi?id=282693 - -This avoids a build problem when the X11/X.h is included, -which defines Success to '0'. - -Reviewed by Fujii Hironori. - -* Source/bmalloc/bmalloc/EligibilityResult.h: - -Canonical link: https://commits.webkit.org/286295@main -Upstream-Status: Backport [https://github.com/WebKit/WebKit/commit/6ab7d3f7d8d0d8e1ab401d0fb13f60bbc64279a2] -Signed-off-by: Alexander Kanavin <[email protected]> ---- - Source/bmalloc/bmalloc/EligibilityResult.h | 5 +++++ - 1 file changed, 5 insertions(+) - -diff --git a/Source/bmalloc/bmalloc/EligibilityResult.h b/Source/bmalloc/bmalloc/EligibilityResult.h -index ead7dbb52c07a..48f9e5bfe8a80 100644 ---- a/Source/bmalloc/bmalloc/EligibilityResult.h -+++ b/Source/bmalloc/bmalloc/EligibilityResult.h -@@ -29,6 +29,11 @@ - - #if !BUSE(LIBPAS) - -+/* avoid conflict with symbol from X11 headers */ -+#ifdef Success -+#undef Success -+#endif -+ - namespace bmalloc { - - enum class EligibilityKind {
meta/recipes-sato/webkit/webkitgtk/no-musttail-arm.patch +9 -5
@@ -11,20 +11,24 @@ this code is new in webkit 2.42[2] thats why we do not see the crash in older we Upstream-Status: Inappropriate [work around to avoid clang compiler crash] Signed-off-by: Khem Raj <[email protected]> + +Update context for webkitgtk 2.48.0. + +Signed-off-by: Kai Kang <[email protected]> --- Source/WTF/wtf/Compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h -index c01ed849..b69b1527 100644 +index 16e416d..68dd9a0 100644 --- a/Source/WTF/wtf/Compiler.h +++ b/Source/WTF/wtf/Compiler.h -@@ -290,7 +290,7 @@ +@@ -293,7 +293,7 @@ #if COMPILER(CLANG) #if __SIZEOF_POINTER__ == 8 #if !defined(MUST_TAIL_CALL) && defined(__cplusplus) && defined(__has_cpp_attribute) --#if __has_cpp_attribute(clang::musttail) && !defined(__powerpc__) -+#if __has_cpp_attribute(clang::musttail) && !defined(__powerpc__) && !defined(__arm__) +-#if __has_cpp_attribute(clang::musttail) && !defined(__powerpc__) && !defined(_WIN32) ++#if __has_cpp_attribute(clang::musttail) && !defined(__powerpc__) && !defined(_WIN32) && !defined(__arm__) #define MUST_TAIL_CALL [[clang::musttail]] - #endif + #define HAVE_MUST_TAIL_CALL 1 #endif
meta/recipes-sato/webkit/webkitgtk_2.48.0.bb renamed from meta/recipes-sato/webkit/webkitgtk_2.46.6.bb +2 -2
@@ -15,10 +15,9 @@ SRC_URI = "https://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \ file://0001-CMake-Add-a-variable-to-control-macro-__PAS_ALWAYS_I.patch \ file://no-musttail-arm.patch \ file://t6-not-declared.patch \ - file://bmalloc-fix.patch \ file://sys_futex.patch \ " -SRC_URI[sha256sum] = "f2b31de693220ba9bab76ce6ddfe5b0bfab2515cb2b0a70f3c54d4050766c32b" +SRC_URI[sha256sum] = "94904a55cf12d44a4e36ceadafff02d46da73d76be9b4769f34cbfdf0eebf88e" inherit cmake pkgconfig gobject-introspection perlnative features_check upstream-version-is-even gi-docgen
@@ -81,6 +80,7 @@ PACKAGECONFIG[jpegxl] = "-DUSE_JPEGXL=ON,-DUSE_JPEGXL=OFF,libjxl" PACKAGECONFIG[backtrace] = "-DUSE_LIBBACKTRACE=ON,-DUSE_LIBBACKTRACE=OFF,libbacktrace" PACKAGECONFIG[gamepad] = "-DENABLE_GAMEPAD=ON,-DENABLE_GAMEPAD=OFF,libmanette" PACKAGECONFIG[sysprof-capture] = "-DUSE_SYSTEM_SYSPROF_CAPTURE=YES,-DUSE_SYSTEM_SYSPROF_CAPTURE=NO,sysprof" +PACKAGECONFIG[speech] = "-DENABLE_SPEECH_SYNTHESIS=ON,-DENABLE_SPEECH_SYNTHESIS=OFF,flite" EXTRA_OECMAKE = " \ -DPORT=GTK \
PATCH 2/24 webkitgtk: Add packageconfig for assertions
assertions have new knob in 2.48, add a packageconfig to control it
--- meta/recipes-sato/webkit/webkitgtk_2.48.0.bb | 1 + 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.48.0.bb +1 -0
@@ -55,6 +55,7 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd wayland x11', ${PACKAGECONFIG_SOUP} \ " +PACKAGECONFIG[assertions] = "-DUSE_CXX_STDLIB_ASSERTIONS=ON,-DUSE_CXX_STDLIB_ASSERTIONS=OFF," PACKAGECONFIG[wayland] = "-DENABLE_WAYLAND_TARGET=ON,-DENABLE_WAYLAND_TARGET=OFF,wayland libwpe wpebackend-fdo wayland-native" PACKAGECONFIG[angle] = "-DUSE_ANGLE_WEBGL=ON,-DUSE_ANGLE_WEBGL=OFF" PACKAGECONFIG[x11] = "-DENABLE_X11_TARGET=ON,-DENABLE_X11_TARGET=OFF,virtual/libx11 libxcomposite libxdamage libxrender libxt"
PATCH 3/24 webkitgtk: Fix build with clang-20
In reply to Khem RajBackport the proposed patch to sync Enum traits header
--- ...or-no-matching-function-for-call-to-.patch | 77 +++++++++++++++++++ meta/recipes-sato/webkit/webkitgtk_2.48.0.bb | 1 + 2 files changed, 78 insertions(+) create mode 100644 meta/recipes-sato/webkit/webkitgtk/0001-EnumTraits.h-error-no-matching-function-for-call-to-.patch
meta/recipes-sato/webkit/webkitgtk/0001-EnumTraits.h-error-no-matching-function-for-call-to-.patch new file +77 -0
@@ -0,0 +1,77 @@ +From 7d159a631ae55c10a0b7a92cf031200a11629736 Mon Sep 17 00:00:00 2001 +From: Fujii Hironori <[email protected]> +Date: Tue, 18 Mar 2025 10:25:47 +0900 +Subject: [PATCH] EnumTraits.h: error: no matching function for call to + 'enumName' with Clang 20 https://bugs.webkit.org/show_bug.cgi?id=289669 + +Reviewed by NOBODY (OOPS!). + +Clang 20 couldn't compile EnumTraits.h. + +> wtf/EnumTraits.h:212:33: note: candidate template ignored: invalid explicitly-specified argument for template parameter 'V' + +An invalid enum value can't be specifed to the template parameter `V`. + +> template<auto V> constexpr std::span<const char> enumName() + +The upstream Magic Enum C++ has a template variable `is_enum_constexpr_static_cast_valid<E, V>` to check a enum value is valid. +<https://github.com/Neargye/magic_enum/blob/a413fcc9c46a020a746907136a384c227f3cd095/include/magic_enum/magic_enum.hpp#L624-L634> + +Imported the template variable. + +* Source/WTF/wtf/EnumTraits.h: +(WTF::enumName): +(WTF::makeEnumNames): + +Upstream-Status: Submitted [https://github.com/WebKit/WebKit/pull/42597] +Signed-off-by: Khem Raj <[email protected]> +--- + Source/WTF/wtf/EnumTraits.h | 21 ++++++++++++++++++++- + 1 file changed, 20 insertions(+), 1 deletion(-) + +diff --git a/Source/WTF/wtf/EnumTraits.h b/Source/WTF/wtf/EnumTraits.h +index 0d33e39a..95e6318b 100644 +--- a/Source/WTF/wtf/EnumTraits.h ++++ b/Source/WTF/wtf/EnumTraits.h +@@ -152,6 +152,16 @@ constexpr bool isZeroBasedContiguousEnum() + #pragma clang diagnostic ignored "-Wenum-constexpr-conversion" + #endif + ++#if COMPILER(CLANG) && __clang_major__ >= 16 ++template <typename E, auto V, typename = void> ++inline constexpr bool isEnumConstexprStaticCastValid = false; ++template <typename E, auto V> ++inline constexpr bool isEnumConstexprStaticCastValid<E, V, std::void_t<std::integral_constant<E, static_cast<E>(V)>>> = true; ++#else ++template <typename, auto> ++inline constexpr bool isEnumConstexprStaticCastValid = true; ++#endif ++ + template<typename E> + constexpr std::span<const char> enumTypeNameImpl() + { +@@ -215,6 +225,15 @@ constexpr std::span<const char> enumName() + return result; + } + ++template<typename E, auto V> ++constexpr std::span<const char> enumName() ++{ ++ if constexpr (isEnumConstexprStaticCastValid<E, V>) ++ return enumName<static_cast<E>(V)>(); ++ else ++ return { }; ++} ++ + template<typename E> + constexpr std::underlying_type_t<E> enumNamesMin() + { +@@ -264,7 +283,7 @@ constexpr auto makeEnumNames(std::index_sequence<Is...>) + { + constexpr auto min = enumNamesMin<E>(); + return std::array<std::span<const char>, sizeof...(Is)> { +- enumName<static_cast<E>(static_cast<std::underlying_type_t<E>>(Is) + min)>()... ++ enumName<E, static_cast<std::underlying_type_t<E>>(Is) + min>()... + }; + } +
meta/recipes-sato/webkit/webkitgtk_2.48.0.bb +1 -0
@@ -16,6 +16,7 @@ SRC_URI = "https://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \ file://no-musttail-arm.patch \ file://t6-not-declared.patch \ file://sys_futex.patch \ + file://0001-EnumTraits.h-error-no-matching-function-for-call-to-.patch \ " SRC_URI[sha256sum] = "94904a55cf12d44a4e36ceadafff02d46da73d76be9b4769f34cbfdf0eebf88e"
PATCH 4/24 libpam: add ptest cases back
In reply to Khem RajFrom: Kai Kang <[email protected]>
It removes the installation of ptest cases when upgrade libpam to 1.7.0. Add them back to make ptest work. And 2 more cases in libpam 1.7.0.
--- meta/recipes-extended/pam/libpam_1.7.0.bb | 6 ++++++ 1 file changed, 6 insertions(+)
meta/recipes-extended/pam/libpam_1.7.0.bb +6 -0
@@ -142,6 +142,12 @@ do_install:append() { fi } +do_install_ptest() { + mkdir -p ${D}${PTEST_PATH}/tests + find ${B}/tests -maxdepth 1 -type f -exec cp {} ${D}${PTEST_PATH}/tests \; + install -m 0644 ${S}/tests/confdir ${D}${PTEST_PATH}/tests +} + pkg_postinst:${PN}() { if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then /etc/init.d/populate-volatile.sh update
PATCH 5/24 ncurses: Upgrade to v6_5_20250315
In reply to Khem RajBrings needed fixes to build with GCC15
License-Update: Copyright Years changed
--- .../ncurses/files/0001-tic-hang.patch | 4 +--- .../files/0002-configure-reproducible.patch | 4 +--- ...in-Do-not-include-LDFLAGS-in-generated.patch | 4 +--- .../ncurses/files/exit_prototype.patch | 17 ++++++++++++----- meta/recipes-core/ncurses/ncurses.inc | 2 +- meta/recipes-core/ncurses/ncurses_6.5.bb | 8 +++++--- 6 files changed, 21 insertions(+), 18 deletions(-)
meta/recipes-core/ncurses/files/0001-tic-hang.patch +1 -3
@@ -16,11 +16,9 @@ Signed-off-by: Hongxu Jia <[email protected]> misc/terminfo.src | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -diff --git a/misc/terminfo.src b/misc/terminfo.src -index 5d575b8e..f9cc6880 100644 --- a/misc/terminfo.src +++ b/misc/terminfo.src -@@ -6518,12 +6518,11 @@ konsole-xf3x|KDE console window with keyboard for XFree86 3.x xterm, +@@ -6577,12 +6577,11 @@ konsole-xf3x|KDE console window with key # The value for kbs (see konsole-vt100) reflects local customization rather # than the settings used for XFree86 xterm. konsole-xf4x|KDE console window with keyboard for XFree86 4.x xterm,
meta/recipes-core/ncurses/files/0002-configure-reproducible.patch +1 -3
@@ -17,11 +17,9 @@ Signed-off-by: Hongxu Jia <[email protected]> configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/configure b/configure -index 488d93fc..005d44e2 100755 --- a/configure +++ b/configure -@@ -5129,7 +5129,7 @@ else +@@ -5448,7 +5448,7 @@ else ;; (*) cf_cv_ar_flags=unknown
meta/recipes-core/ncurses/files/0003-gen-pkgconfig.in-Do-not-include-LDFLAGS-in-generated.patch +1 -3
@@ -14,11 +14,9 @@ Signed-off-by: Nathan Rossi <[email protected]> misc/gen-pkgconfig.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/misc/gen-pkgconfig.in b/misc/gen-pkgconfig.in -index 89a5cd4a..07d94d17 100644 --- a/misc/gen-pkgconfig.in +++ b/misc/gen-pkgconfig.in -@@ -83,7 +83,7 @@ if [ "$includedir" != "/usr/include" ]; then +@@ -83,7 +83,7 @@ if [ "$includedir" != "/usr/include" ]; fi lib_flags=
meta/recipes-core/ncurses/files/exit_prototype.patch +12 -5
@@ -9,19 +9,26 @@ Signed-off-by: Khem Raj <[email protected]> configure | 2 ++ 1 file changed, 2 insertions(+) -diff --git a/configure b/configure -index 005d44e2..72fa6c23 100755 --- a/configure +++ b/configure -@@ -3462,6 +3462,7 @@ rm -f "conftest.$ac_objext" "conftest.$ac_ext" +@@ -3763,6 +3763,7 @@ rm -f "conftest.$ac_objext" "conftest.$a cat >"conftest.$ac_ext" <<_ACEOF - #line 3463 "configure" + #line 3764 "configure" #include "confdefs.h" +#include <stdlib.h> $ac_declaration int main (void) -@@ -13533,6 +13534,7 @@ cat >"conftest.$ac_ext" <<_ACEOF +@@ -3821,7 +3822,7 @@ echo $ECHO_N "checking if $CXX works... + + save_CPPFLAGS="$CPPFLAGS" + eval cf_includedir=${includedir} +- CPPFLAGS="$CPPFLAGS -I${cf_includedir}" ++ CPPFLAGS="$CPPFLAGS " + + cat >"conftest.$ac_ext" <<_ACEOF + #line 3827 "configure" +@@ -13891,6 +13892,7 @@ cat >"conftest.$ac_ext" <<_ACEOF #include <stdlib.h> #include <stdarg.h> #include <stdio.h>
meta/recipes-core/ncurses/ncurses.inc +1 -1
@@ -2,7 +2,7 @@ SUMMARY = "The New Curses library" DESCRIPTION = "SVr4 and XSI-Curses compatible curses library and terminfo tools including tic, infocmp, captoinfo. Supports color, multiple highlights, forms-drawing characters, and automatic recognition of keypad and function-key sequences. Extensions include resizable windows and mouse support on both xterm and Linux console using the gpm library." HOMEPAGE = "http://www.gnu.org/software/ncurses/ncurses.html" LICENSE = "MIT" -LIC_FILES_CHKSUM = "file://COPYING;md5=6f291ee54551d9d8d992ecd623fe4bc7;endline=27" +LIC_FILES_CHKSUM = "file://COPYING;md5=c534844fa5a74d14ae8fa3d9b3b42138;endline=27" SECTION = "libs" DEPENDS = "ncurses-native" DEPENDS:class-native = ""
meta/recipes-core/ncurses/ncurses_6.5.bb +5 -3
@@ -6,10 +6,12 @@ SRC_URI += "file://0001-tic-hang.patch \ file://exit_prototype.patch \ " # commit id corresponds to the revision in package version -SRCREV = "1c55d64d9d3e00399a21f04e9cac1e472ab5f70a" +# v6_5_20250315 +SRCREV = "5fa5aea6d020750dbe601c1136c7cc35a8a53dd8" +PV .= "+20250315" S = "${WORKDIR}/git" EXTRA_OECONF += "--with-abi-version=5" UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+_\d+)$" -# This is needed when using patchlevel versions like 6.1+20181013 -#CVE_VERSION = "${@d.getVar("PV").split('+')[0]}.${@d.getVar("PV").split('+')[1]}" +# This is needed when using patchlevel versions like 6.5+20250315 +CVE_VERSION = "${@d.getVar("PV").split('+')[0]}.${@d.getVar("PV").split('+')[1]}"
Re: [OE-core] [PATCH 05/24] ncurses: Upgrade to v6_5_20250315
meta/recipes-core/ncurses/ncurses_6.5.bb SRC_URI += "file://0001-tic-hang.patch \ · line 11
Quoted 6 lines · Khem Raj via lists.openembedded.org
Brings needed fixes to build with GCC15
# commit id corresponds to the revision in package versionmeta/recipes-core/ncurses/ncurses_6.5.bb +3
-1-SRCREV = "1c55d64d9d3e00399a21f04e9cac1e472ab5f70a" +# v6_5_20250315 +SRCREV = "5fa5aea6d020750dbe601c1136c7cc35a8a53dd8" +PV .= "+20250315"
I know we had them in the past, but ncurses' YYYYMMDD are all random development snapshots, and I wouldn't want to update to them. Is it possible to cherry-pick needed fixes?
Alex
Re: [OE-core] [PATCH 05/24] ncurses: Upgrade to v6_5_20250315
Quoted 13 lines · Alexander Kanavin
meta/recipes-core/ncurses/ncurses_6.5.bb SRC_URI += "file://0001-tic-hang.patch \ · line 11
Quoted 6 lines · Khem Raj via lists.openembedded.org
Brings needed fixes to build with GCC15
# commit id corresponds to the revision in package versionmeta/recipes-core/ncurses/ncurses_6.5.bb +3
-1-SRCREV = "1c55d64d9d3e00399a21f04e9cac1e472ab5f70a" +# v6_5_20250315 +SRCREV = "5fa5aea6d020750dbe601c1136c7cc35a8a53dd8" +PV .= "+20250315"I know we had them in the past, but ncurses' YYYYMMDD are all random development snapshots, and I wouldn't want to update to them. Is it possible to cherry-pick needed fixes?
Fedora is using these releases as well, so I am hoping that it is sane.
Quoted 2 lines
Alex
Re: [OE-core] [PATCH 05/24] ncurses: Upgrade to v6_5_20250315
Quoted 5 lines · Khem Raj
Quoted 3 lines
I know we had them in the past, but ncurses' YYYYMMDD are all random development snapshots, and I wouldn't want to update to them. Is it possible to cherry-pick needed fixes?
Fedora is using these releases as well, so I am hoping that it is sane.
Fedora is wrong too. They're *not* releases. I have to put my foot down here Khem:
https://github.com/ThomasDickey/ncurses-snapshots/blob/master/NEWS
Alex
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [OE-core] [PATCH 05/24] ncurses: Upgrade to v6_5_20250315
Quoted 6 lines · Alexander Kanavin via lists.openembedded.org
Quoted 4 lines · Khem Raj
Quoted 3 lines
I know we had them in the past, but ncurses' YYYYMMDD are all random development snapshots, and I wouldn't want to update to them. Is it possible to cherry-pick needed fixes?
Quoted 6 lines
Quoted 1 line
Fedora is using these releases as well, so I am hoping that it is sane.
Fedora is wrong too. They're *not* releases. I have to put my foot down here Khem:
https://github.com/ThomasDickey/ncurses-snapshots/blob/master/NEWS
That said, upstream doesn't seem to be doing proper commits: they just roll up any changes into those weekly snapshots:
https://github.com/ThomasDickey/ncurses-snapshots/commits/master/
I'd still hope you can find the snapshot commit where the gcc15 fixes
are, and extract just the needed pieces from it.
Alex
PATCH 6/24 gdbm: Use C11 standard
In reply to Khem RajGCC15 is switching defaults to C23 and gdbm is not yet ready to compile using C23 std.
--- meta/recipes-support/gdbm/gdbm_1.24.bb | 3 +++ 1 file changed, 3 insertions(+)
meta/recipes-support/gdbm/gdbm_1.24.bb +3 -0
@@ -23,6 +23,9 @@ EXTRA_OECONF = "--enable-libgdbm-compat --without-readline" # Stop presence of dbm/nbdm on the host contaminating builds CACHED_CONFIGUREVARS += "ac_cv_lib_ndbm_main=no ac_cv_lib_dbm_main=no" +# Not yet ready for C23 +CFLAGS += "-std=gnu11" + BBCLASSEXTEND = "native nativesdk" do_install:append () {
PATCH 7/24 bluez: Fix build with GCC-15
In reply to Khem Rajgcc-15 switched to -std=c23 by default:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212
As a result bluez fails the build as:
src/shared/ad.c:1090:24: error: incompatible types when returning type '_Bool' but 'const char *' was expected
1090 | return false;
| ^~~~~
--- meta/recipes-connectivity/bluez5/bluez5.inc | 3 + ...-shared-ad-fix-std-c23-build-failure.patch | 34 +++++++++++ ...ared-shell-fix-std-c23-build-failure.patch | 34 +++++++++++ ...tt-helpers-fix-std-c23-build-failure.patch | 58 +++++++++++++++++++ 4 files changed, 129 insertions(+) create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-shared-ad-fix-std-c23-build-failure.patch create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0002-shared-shell-fix-std-c23-build-failure.patch create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0003-shared-gatt-helpers-fix-std-c23-build-failure.patch
meta/recipes-connectivity/bluez5/bluez5.inc +3 -0
@@ -70,6 +70,9 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \ file://0001-tests-add-a-target-for-building-tests-without-runnin.patch \ file://0001-test-gatt-Fix-hung-issue.patch \ file://0001-gdbus-define-MAX_INPUT-for-musl.patch \ + file://0001-shared-ad-fix-std-c23-build-failure.patch \ + file://0002-shared-shell-fix-std-c23-build-failure.patch \ + file://0003-shared-gatt-helpers-fix-std-c23-build-failure.patch \ " S = "${WORKDIR}/bluez-${PV}"
meta/recipes-connectivity/bluez5/bluez5/0001-shared-ad-fix-std-c23-build-failure.patch new file +34 -0
@@ -0,0 +1,34 @@ +From 5c4cbf5cb95e4fc1a53545af52b420a8008b3ffa Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum <[email protected]> +Date: Wed, 20 Nov 2024 13:02:56 +0000 +Subject: [PATCH 1/3] shared/ad: fix -std=c23 build failure + +gcc-15 switched to -std=c23 by default: + + https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 + +As a result `bluez` fails the build as: + + src/shared/ad.c:1090:24: error: incompatible types when returning type '_Bool' but 'const char *' was expected + 1090 | return false; + | ^~~~~ + +Upstream-Status: Backport [https://web.git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=da5b5b0ecb1ead38676768ef78d46449d404bdc0] +Signed-off-by: Khem Raj <[email protected]> +--- + src/shared/ad.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/shared/ad.c b/src/shared/ad.c +index d08ce7a..dac381b 100644 +--- a/src/shared/ad.c ++++ b/src/shared/ad.c +@@ -1087,7 +1087,7 @@ bool bt_ad_add_name(struct bt_ad *ad, const char *name) + const char *bt_ad_get_name(struct bt_ad *ad) + { + if (!ad) +- return false; ++ return NULL; + + return ad->name; + }
meta/recipes-connectivity/bluez5/bluez5/0002-shared-shell-fix-std-c23-build-failure.patch new file +34 -0
@@ -0,0 +1,34 @@ +From 408510d751e9482fe965e5dd96fbac7f9ee2ef62 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum <[email protected]> +Date: Wed, 20 Nov 2024 13:03:29 +0000 +Subject: [PATCH 2/3] shared/shell: fix -std=c23 build failure + +gcc-15 switched to -std=c23 by default: + + https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 + +As a result `bluez` fails the build as: + + src/shared/shell.c:365:24: error: incompatible types when returning type '_Bool' but 'struct input *' was expected + 365 | return false; + | ^~~~~ + +Upstream-Status: Backport [https://web.git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=4d60826865c760cc4e5718b6414746a394768110] +Signed-off-by: Khem Raj <[email protected]> +--- + src/shared/shell.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/shared/shell.c b/src/shared/shell.c +index a8fa876..aa6c16c 100644 +--- a/src/shared/shell.c ++++ b/src/shared/shell.c +@@ -362,7 +362,7 @@ static struct input *input_new(int fd) + + io = io_new(fd); + if (!io) +- return false; ++ return NULL; + + input = new0(struct input, 1); + input->io = io;
meta/recipes-connectivity/bluez5/bluez5/0003-shared-gatt-helpers-fix-std-c23-build-failure.patch new file +58 -0
58 lines not on this page · raw message
PATCH 8/24 readline: Fixed build with GCC-15
In reply to Khem Raj--- ...ages-that-are-not-compatible-with-C2.patch | 29 +++++++++++++++++++ meta/recipes-core/readline/readline_8.2.13.bb | 4 ++- 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch
meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 9459ee899a291c55f08341df63e9a1b9b7af200a Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Sun, 16 Mar 2025 12:48:46 -0700 +Subject: [PATCH] Add fix for packages that are not compatible with C23 + +Fixes builds with GCC-15 +Sourced from Fedora: https://src.fedoraproject.org/rpms/readline/c/c47eb813afb942128253213ad5b8221770557e48?branch=rawhide + +Help getting packages like bluez5 building + +Upstream-Status: Pending +Signed-off-by: Khem Raj <[email protected]> +--- + rlstdc.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/rlstdc.h b/rlstdc.h +index 2aaa30b..a7a0ef3 100644 +--- a/rlstdc.h ++++ b/rlstdc.h +@@ -44,7 +44,7 @@ + + /* Moved from config.h.in because readline.h:rl_message depends on these + defines. */ +-#if defined (__STDC__) && defined (HAVE_STDARG_H) ++#if defined (__STDC__) + # define PREFER_STDARG + # define USE_VARARGS + #else
meta/recipes-core/readline/readline_8.2.13.bb +3 -1
@@ -1,5 +1,7 @@ require readline.inc -SRC_URI += " file://norpath.patch" +SRC_URI += "file://norpath.patch \ + file://0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch \ + " SRC_URI[archive.sha256sum] = "0e5be4d2937e8bd9b7cd60d46721ce79f88a33415dd68c2d738fb5924638f656"
Patchtest results for [PATCH 08/24] readline: Fixed build with GCC-15
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/08-24-readline-Fixed-build-with-GCC-15.patch
FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
Re: [OE-core] [PATCH 08/24] readline: Fixed build with GCC-15
In reply to Khem Rajmeta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch line 11
Quoted 6 lines · Khem Raj via lists.openembedded.org
meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch new file +6
-0+Fixes builds with GCC-15 +Sourced from Fedora: https://src.fedoraproject.org/rpms/readline/c/c47eb813afb942128253213ad5b8221770557e48?branch=rawhide + +Help getting packages like bluez5 building + +Upstream-Status: Pending
Please no new Pending.
Alex
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [OE-core] [PATCH 08/24] readline: Fixed build with GCC-15
Quoted 11 lines · Alexander Kanavin via lists.openembedded.org
meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch line 11
Quoted 6 lines · Khem Raj via lists.openembedded.org
meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch new file +6
-0+Fixes builds with GCC-15 +Sourced from Fedora: https://src.fedoraproject.org/rpms/readline/c/c47eb813afb942128253213ad5b8221770557e48?branch=rawhide + +Help getting packages like bluez5 building + +Upstream-Status: PendingPlease no new Pending.
Per https://tiswww.cwru.edu/php/chet/readline/rltop.html the submissions should go to [email protected], [email protected]
Alex
Re: [OE-core] [PATCH 08/24] readline: Fixed build with GCC-15
Quoted 16 lines · Alexander Kanavin
Quoted 11 lines · Alexander Kanavin via lists.openembedded.org
meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch line 11
Quoted 6 lines · Khem Raj via lists.openembedded.org
meta/recipes-core/readline/readline/0001-Add-fix-for-packages-that-are-not-compatible-with-C2.patch new file +6
-0+Fixes builds with GCC-15 +Sourced from Fedora: https://src.fedoraproject.org/rpms/readline/c/c47eb813afb942128253213ad5b8221770557e48?branch=rawhide + +Help getting packages like bluez5 building + +Upstream-Status: PendingPlease no new Pending.
Quoted 2 lines
Per https://tiswww.cwru.edu/php/chet/readline/rltop.html the submissions should go to [email protected], [email protected]
yes thanks, I have sent is now, I will update the status in V2
Quoted 2 lines
Alex
PATCH 9/24 bash: Stick to C17 std
In reply to Khem RajGCC 15 defaults to C23 and bash is not yet ready for that so keep using C17 like GCC 14 for now
--- meta/recipes-extended/bash/bash_5.2.37.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-extended/bash/bash_5.2.37.bb +2 -0
@@ -20,4 +20,6 @@ SRC_URI[tarball.sha256sum] = "9599b22ecd1d5787ad7d3b7bf0c59f312b3396d1e281175dd1 DEBUG_OPTIMIZATION:append:armv4 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" DEBUG_OPTIMIZATION:append:armv5 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" +CFLAGS += "-std=gnu17" + BBCLASSEXTEND = "nativesdk"
PATCH 10/24 tcp-wrappers: Stick to C17 standard
In reply to Khem RajGCC 15 has switched to C23 by default and tcp-wrappers is old code pre-c99 and would need to be fixed all around to get to work in C23
--- meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb +2 -0
@@ -55,6 +55,8 @@ SRC_URI[sha256sum] = "9543d7adedf78a6de0b221ccbbd1952e08b5138717f4ade814039bb489 S = "${WORKDIR}/tcp_wrappers_${PV}" +CFLAGS += "-std=gnu17" + EXTRA_OEMAKE = "'CC=${CC}' \ 'AR=${AR}' \ 'RANLIB=${RANLIB}' \
PATCH 11/24 libsndfile1: Include <stdbool.h> instead of redefining bool true and false
In reply to Khem Raj--- ...h-instead-of-redefining-bool-true-an.patch | 65 +++++++++++++++++++ .../libsndfile/libsndfile1_1.2.2.bb | 1 + 2 files changed, 66 insertions(+) create mode 100644 meta/recipes-multimedia/libsndfile/libsndfile1/0001-Include-stdbool.h-instead-of-redefining-bool-true-an.patch
meta/recipes-multimedia/libsndfile/libsndfile1/0001-Include-stdbool.h-instead-of-redefining-bool-true-an.patch new file +65 -0
@@ -0,0 +1,65 @@ +From 0ba5ab2fb7f29a01dbe570c324011e8cffc89d82 Mon Sep 17 00:00:00 2001 +From: Fabian Greffrath <[email protected]> +Date: Tue, 17 Dec 2024 10:38:47 +0100 +Subject: [PATCH] Include <stdbool.h> instead of redefining `bool`, `true` and + `false` keywords + +Fixes #1049 + +Upstream-Status: Submitted [https://github.com/libsndfile/libsndfile/pull/1055] + +Signed-off-by: Khem Raj <[email protected]> +--- + src/ALAC/alac_decoder.c | 6 +----- + src/ALAC/alac_encoder.c | 7 +------ + 2 files changed, 2 insertions(+), 11 deletions(-) + +diff --git a/src/ALAC/alac_decoder.c b/src/ALAC/alac_decoder.c +index 46d3330..1b4a87c 100644 +--- a/src/ALAC/alac_decoder.c ++++ b/src/ALAC/alac_decoder.c +@@ -26,6 +26,7 @@ + #include <stdio.h> + #include <stdlib.h> + #include <stddef.h> ++#include <stdbool.h> + #include <string.h> + + #include "alac_codec.h" +@@ -38,11 +39,6 @@ + #include "ALACBitUtilities.h" + #include "EndianPortable.h" + +-typedef enum +-{ false = 0, +- true = 1 +-} bool ; +- + // constants/data + const uint32_t kMaxBitDepth = 32 ; // max allowed bit depth is 32 + +diff --git a/src/ALAC/alac_encoder.c b/src/ALAC/alac_encoder.c +index 599399a..f303311 100644 +--- a/src/ALAC/alac_encoder.c ++++ b/src/ALAC/alac_encoder.c +@@ -30,6 +30,7 @@ + // headers + #include <stdio.h> + #include <stdlib.h> ++#include <stdbool.h> + #include <string.h> + + #include "sfendian.h" +@@ -44,12 +45,6 @@ + #include "ALACAudioTypes.h" + #include "EndianPortable.h" + +-typedef enum +-{ +- false = 0, +- true = 1 +-} bool ; +- + static void GetConfig (ALAC_ENCODER *p, ALACSpecificConfig * config) ; + + static int32_t EncodeStereo (ALAC_ENCODER *p, struct BitBuffer * bitstream, const int32_t * input, uint32_t stride, uint32_t channelIndex, uint32_t numSamples) ;
meta/recipes-multimedia/libsndfile/libsndfile1_1.2.2.bb +1 -0
@@ -11,6 +11,7 @@ SRC_URI = "${GITHUB_BASE_URI}/download/${PV}/libsndfile-${PV}.tar.xz \ file://noopus.patch \ file://cve-2022-33065.patch \ file://CVE-2024-50612.patch \ + file://0001-Include-stdbool.h-instead-of-redefining-bool-true-an.patch \ " GITHUB_BASE_URI = "https://github.com/libsndfile/libsndfile/releases/"
Patchtest results for [PATCH 11/24] libsndfile1: Include <stdbool.h> instead of redefining bool true and false
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/11-24-libsndfile1-Include-stdbool.h-instead-of-redefining-bool-true-and-false.patch
FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
PATCH 12/24 e2fsprogs: Fix build failure with gcc 15
In reply to Khem RajBackport a needed fix
--- ...-libext2fs-fix-std-c23-build-failure.patch | 42 +++++++++++++++++++ .../e2fsprogs/e2fsprogs_1.47.1.bb | 1 + 2 files changed, 43 insertions(+) create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-libext2fs-fix-std-c23-build-failure.patch
meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-libext2fs-fix-std-c23-build-failure.patch new file +42 -0
@@ -0,0 +1,42 @@ +From 72dcef02bee9924c4d5b3dc6e7ef4d07becebcc6 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum <[email protected]> +Date: Fri, 22 Nov 2024 12:36:32 +0000 +Subject: [PATCH] libext2fs: fix -std=c23 build failure + +gcc-15 switched to -std=c23 by default: + + https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 + +As a result `e2fsprogs` fails the build so only typedef int bool +for __STDC_VERSION__ <= 201710L (C17) + + ../../../lib/ext2fs/tdb.c:113:13: error: two or more data types in declaration specifiers + ../../../lib/ext2fs/tdb.c:113:1: warning: useless type name in empty declaration + 113 | typedef int bool; + | ^~~~~~~ + +https://github.com/tytso/e2fsprogs/issues/202 + +Upstream-Status: Backport [https://github.com/tytso/e2fsprogs/commit/49fd04d77b3244c6c6990be41142168eef373aef] +Signed-off-by: Rudi Heitbaum <[email protected]> +Link: https://lore.kernel.org/r/Z0B60JhdvT9bpSQ6@6f91903e89da +Signed-off-by: Theodore Ts'o <[email protected]> +Signed-off-by: Khem Raj <[email protected]> +--- + lib/ext2fs/tdb.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/lib/ext2fs/tdb.c b/lib/ext2fs/tdb.c +index b07b2917..98dc95d8 100644 +--- a/lib/ext2fs/tdb.c ++++ b/lib/ext2fs/tdb.c +@@ -110,7 +110,9 @@ static char *rep_strdup(const char *s) + #endif + #endif + ++#if defined __STDC__ && defined __STDC_VERSION__ && __STDC_VERSION__ <= 201710L + typedef int bool; ++#endif + + #include "tdb.h" +
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.1.bb +1 -0
@@ -4,6 +4,7 @@ SRC_URI += "file://remove.ldconfig.call.patch \ file://run-ptest \ file://ptest.patch \ file://mkdir_p.patch \ + file://0001-libext2fs-fix-std-c23-build-failure.patch \ " SRC_URI:append:class-native = " \ file://e2fsprogs-fix-missing-check-for-permission-denied.patch \
PATCH 13/24 man-db: Add missing rdep for col utility
In reply to Khem Rajman utility calls col utility internally when formatting is asked for therefore it expects col to be in rootfs otherwise silently errors with retcode 3 meaning 'file not found' in this case its due to col not being found, other distros eg. gets this via bsdextrautils dependency
libssh2 ptest mansyntax.sh fails due to this error, which now works
--- meta/recipes-extended/man-db/man-db_2.13.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/man-db/man-db_2.13.0.bb +1 -1
@@ -14,7 +14,7 @@ SRC_URI = "${SAVANNAH_NONGNU_MIRROR}/man-db/man-db-${PV}.tar.xz \ SRC_URI[sha256sum] = "82f0739f4f61aab5eb937d234de3b014e777b5538a28cbd31433c45ae09aefb9" DEPENDS = "libpipeline gdbm groff-native base-passwd" -RDEPENDS:${PN} += "base-passwd" +RDEPENDS:${PN} += "base-passwd util-linux-col" PACKAGE_WRITE_DEPS += "base-passwd" # | /usr/src/debug/man-db/2.8.0-r0/man-db-2.8.0/src/whatis.c:939: undefined reference to `_nl_msg_cat_cntr'
Re: [OE-core] [PATCH 13/24] man-db: Add missing rdep for col utility
Quoted 9 lines · Khem Raj via lists.openembedded.org
man utility calls col utility internally when formatting is asked for therefore it expects col to be in rootfs otherwise silently errors with retcode 3 meaning 'file not found' in this case its due to col not being found, other distros eg. gets this via bsdextrautils dependency
libssh2 ptest
mansyntax.shfails due to this error, which now worksSigned-off-by Khem Raj <[email protected]>---
Hi Khem,
This triggers a new QA issue:
ERROR: man-db-2.13.0-r0 do_package_qa: QA Issue: man-db rdepends on util-linux-col, but it isn't a build dependency? [build-deps]
ERROR: man-db-2.13.0-r0 do_package_qa: Fatal QA errors were found, failing task.
https://autobuilder.yoctoproject.org/valkyrie/#/builders/3/builds/1229
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [OE-core] [PATCH 13/24] man-db: Add missing rdep for col utility
Quoted 12 lines · Mathieu Dubois-Briand
Quoted 9 lines · Khem Raj via lists.openembedded.org
man utility calls col utility internally when formatting is asked for therefore it expects col to be in rootfs otherwise silently errors with retcode 3 meaning 'file not found' in this case its due to col not being found, other distros eg. gets this via bsdextrautils dependency
libssh2 ptest
mansyntax.shfails due to this error, which now worksSigned-off-by Khem Raj <[email protected]>---
Quoted 9 lines
Hi Khem,
This triggers a new QA issue:
ERROR: man-db-2.13.0-r0
do_package_qa: QA Issue: man-db rdepends on util-linux-col, but it isn't a build dependency? [build-deps]
ERROR: man-db-2.13.0-r0do_package_qa: Fatal QA errors were found, failing task.https://autobuilder.yoctoproject.org/valkyrie/#/builders/3/builds/1229
Its because col utility is deprecated and moreover only built for glibc based sysrems see
https://github.com/util-linux/util-linux/commit/8886d84e25a457702b45194d69a47313f76dc6bc
Therefore the rdep has to be glibc specific and the second problem is that man-db pokes for native tools like col and configures target to use it which works in native compile but could be problematic with cross compile. I have fixed this in V3 of the patchset so please take the full set
Quoted 5 lines
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
PATCH 14/24 dbus-glib: Fix build with GCC 15
In reply to Khem RajGCC 15 defaults to C23, it can not handle it
latest release is from 2021, and this seems to be
deprecated upstream and no longer actively
developed.
--- meta/recipes-core/dbus/dbus-glib_0.112.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-core/dbus/dbus-glib_0.112.bb +2 -0
@@ -26,6 +26,8 @@ PACKAGECONFIG[tests] = "--enable-tests,,," EXTRA_OECONF:class-target = "--with-dbus-binding-tool=${STAGING_BINDIR_NATIVE}/dbus-binding-tool" +CFLAGS += "-std=gnu17" + PACKAGES += "${PN}-tests" FILES:${PN} = "${libdir}/lib*${SOLIBS}"
PATCH 15/24 libmatchbox: Fix build with gcc-15
In reply to Khem Raj--- meta/recipes-graphics/libmatchbox/libmatchbox_1.12.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-graphics/libmatchbox/libmatchbox_1.12.bb +3 -3
@@ -15,10 +15,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34 \ DEPENDS = "virtual/libx11 libxext" -#SRCREV for 1.12 -SRCREV = "e846ee434f8e23d9db38af13c523f791495e0e87" +PV .= "+git" +#SRCREV for 1.12 + 1 patch for gcc15 +SRCREV = "312c04b6ba60dca0d6c4a7d1393f0ec816a265e3" SRC_URI = "git://git.yoctoproject.org/${BPN};branch=master;protocol=https" - S = "${WORKDIR}/git" inherit autotools pkgconfig features_check
Patchtest results for [PATCH 15/24] libmatchbox: Fix build with gcc-15
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/15-24-libmatchbox-Fix-build-with-gcc-15.patch
FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
PATCH 16/24 ppp: Fix build when shadow is enabled
In reply to Khem RajGCC-15 patch is not sufficient when shadow is enabled, therefore fix the remaining issues.
--- ...d-session-Fixed-building-with-GCC-15.patch | 33 +++++++++++++++++++ meta/recipes-connectivity/ppp/ppp_2.5.2.bb | 1 + 2 files changed, 34 insertions(+) create mode 100644 meta/recipes-connectivity/ppp/ppp/0001-pppd-session-Fixed-building-with-GCC-15.patch
meta/recipes-connectivity/ppp/ppp/0001-pppd-session-Fixed-building-with-GCC-15.patch new file +33 -0
@@ -0,0 +1,33 @@ +From 5edcb01f1d8d521c819d45df1f1bb87697252130 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Mon, 17 Mar 2025 14:38:26 -0700 +Subject: [PATCH] pppd/session: Fixed building with GCC 15 + +Fixed building with GCC 15 which defaults to C23 +and find conflicting declration of getspnam() here +with the one provided by shadow.h (extern struct spwd *getspnam (const char *__name);) + +Fixes +../../ppp-2.5.2/pppd/session.c: In function 'session_start': +../../ppp-2.5.2/pppd/session.c:185:18: error: conflicting types for 'getspnam'; have 'struct spwd *(void)' + 185 | struct spwd *getspnam(); + | ^~~~~~~~ + +Upstream-Status: Submitted [https://github.com/ppp-project/ppp/pull/553] +Signed-off-by: Khem Raj <[email protected]> +--- + pppd/session.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/pppd/session.c b/pppd/session.c +index f08d8e1..9cc7538 100644 +--- a/pppd/session.c ++++ b/pppd/session.c +@@ -182,7 +182,6 @@ session_start(const int flags, const char *user, const char *passwd, const char + char *cbuf; + #ifdef HAVE_SHADOW_H + struct spwd *spwd; +- struct spwd *getspnam(); + long now = 0; + #endif /* #ifdef HAVE_SHADOW_H */ + #endif /* #ifdef PPP_WITH_PAM */
meta/recipes-connectivity/ppp/ppp_2.5.2.bb +1 -0
@@ -24,6 +24,7 @@ SRC_URI = "https://download.samba.org/pub/${BPN}/${BP}.tar.gz \ file://provider \ file://[email protected] \ file://0001-pppdump-Fixed-building-with-GCC-15-548.patch \ + file://0001-pppd-session-Fixed-building-with-GCC-15.patch \ " SRC_URI[sha256sum] = "47da358de54a10cb10bf6ff2cf9b1c03c0d3555518f6182e8f701b8e55733cb2"
PATCH 17/24 unzip: Fix build with GCC-15
In reply to Khem RajAdd a patch to remove redundant declarations
--- meta/recipes-extended/unzip/unzip/gcc15.patch | 17 +++++++++++++++++ meta/recipes-extended/unzip/unzip_6.0.bb | 1 + 2 files changed, 18 insertions(+) create mode 100644 meta/recipes-extended/unzip/unzip/gcc15.patch
meta/recipes-extended/unzip/unzip/gcc15.patch new file +17 -0
@@ -0,0 +1,17 @@ +Do not redefine gmtime(), localtime() + +They are already provided by system time.h header + +Upstream-Status: Inactive-Upstream [need a new release] + +Sign-off-by: Khem Raj <[email protected]> +--- a/unix/unxcfg.h ++++ b/unix/unxcfg.h +@@ -117,7 +117,6 @@ typedef struct stat z_stat; + # endif + #else + # include <time.h> +- struct tm *gmtime(), *localtime(); + #endif + + #if (defined(BSD4_4) || (defined(SYSV) && defined(MODERN)))
meta/recipes-extended/unzip/unzip_6.0.bb +1 -0
@@ -32,6 +32,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/infozip/UnZip%206.x%20%28latest%29/UnZip%206.0/ file://CVE-2022-0530.patch \ file://0001-configure-Add-correct-system-headers-and-prototypes-.patch \ file://0001-unix-configure-fix-detection-for-cross-compilation.patch \ + file://gcc15.patch \ " UPSTREAM_VERSION_UNKNOWN = "1"
Patchtest results for [PATCH 17/24] unzip: Fix build with GCC-15
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/17-24-unzip-Fix-build-with-GCC-15.patch
FAIL: test Signed-off-by presence: A patch file has been added without a Signed-off-by tag: 'gcc15.patch' (test_patch.TestPatch.test_signed_off_by_presence)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
PATCH 18/24 makedumpfile: Fix build with GCC-15
In reply to Khem Rajfix gcc-15 compiling error: too many arguments to function eppic_init
--- ...-compiling-error-too-many-arguments-.patch | 43 +++++++++++++++++++ .../makedumpfile/makedumpfile_1.7.6.bb | 1 + 2 files changed, 44 insertions(+) create mode 100644 meta/recipes-kernel/makedumpfile/makedumpfile/0001-PATCH-fix-gcc-15-compiling-error-too-many-arguments-.patch
meta/recipes-kernel/makedumpfile/makedumpfile/0001-PATCH-fix-gcc-15-compiling-error-too-many-arguments-.patch new file +43 -0
@@ -0,0 +1,43 @@ +From 73e62a08022bf8e5edad250f8c1452f0be3771a3 Mon Sep 17 00:00:00 2001 +From: Coiby Xu <[email protected]> +Date: Thu, 23 Jan 2025 17:47:10 +0800 +Subject: [PATCH] [PATCH] fix gcc-15 compiling error: too many arguments to function eppic_init +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2340813 + +When building makekdumpfile against gcc-15, the following error is +shown, + + erase_info.c: In function ‘process_eppic_file’: + erase_info.c:2226:13: error: too many arguments to function ‘eppic_init’; expected 0, have 1 + 2226 | if (eppic_init(&eppic_cb)) { + | ^~~~~~~~~~ ~~~~~~~~~ + make: *** [Makefile:109: erase_info.o] Error 1 + +Upstream-Status: Backport [https://github.com/makedumpfile/makedumpfile/commit/73e62a08022bf8e5edad250f8c1452f0be3771a3] + +Signed-off-by: Coiby Xu <[email protected]> +Signed-off-by: Coiby Xu <[email protected]> +--- + erase_info.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/erase_info.c b/erase_info.c +index cbe1681..af6bfae 100644 +--- a/erase_info.c ++++ b/erase_info.c +@@ -2192,7 +2192,7 @@ process_eppic_file(char *name_config) + { + void *handle; + void (*eppic_load)(char *), (*eppic_unload)(char *); +- int (*eppic_init)(); ++ int (*eppic_init)(struct call_back *); + + /* + * Dynamically load the eppic_makedumpfile.so library. +-- +2.48.1 +
meta/recipes-kernel/makedumpfile/makedumpfile_1.7.6.bb +1 -0
@@ -26,6 +26,7 @@ FILES:${PN}-tools = "${bindir}/*.pl" SRC_URI = "\ git://github.com/makedumpfile/makedumpfile;branch=${SRCBRANCH};protocol=https \ file://0001-makedumpfile-replace-hardcode-CFLAGS.patch \ + file://0001-PATCH-fix-gcc-15-compiling-error-too-many-arguments-.patch \ " S = "${WORKDIR}/git"
PATCH 19/24 cpio: Pin to use C17 std
In reply to Khem RajFixes build with GCC-15 which is defaulting to C23
--- meta/recipes-extended/cpio/cpio_2.15.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-extended/cpio/cpio_2.15.bb +2 -0
@@ -20,6 +20,8 @@ CVE_STATUS[CVE-2023-7216] = "disputed: intended behaviour, see https://lists.gnu EXTRA_OECONF += "DEFAULT_RMT_DIR=${sbindir}" +CFLAGS += "-std=gnu17" + do_install () { autotools_do_install if [ "${base_bindir}" != "${bindir}" ]; then
PATCH 20/24 expect: Fix build with GCC 15
In reply to Khem RajStick to C17 standard as GCC 15 switches to C23
--- meta/recipes-devtools/expect/expect_5.45.4.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-devtools/expect/expect_5.45.4.bb +2 -0
@@ -42,6 +42,8 @@ S = "${WORKDIR}/${BPN}${PV}" EXTRA_AUTORECONF += "--exclude=aclocal" +CFLAGS += "-std=gnu17" + do_install:append() { mv ${D}${libdir}/expect${PV}/libexpect*.so ${D}${libdir}/ install -m 0755 ${S}/fixline1 ${D}${libdir}/expect${PV}/
PATCH 21/24 cronie: Resolve build failure with GCC15
In reply to Khem RajFix function prototypes for C23 to work
--- .../make_error_func_prototype_complete.patch | 41 +++++++++++++++++++ meta/recipes-extended/cronie/cronie_1.7.2.bb | 1 + 2 files changed, 42 insertions(+) create mode 100644 meta/recipes-extended/cronie/cronie/make_error_func_prototype_complete.patch
meta/recipes-extended/cronie/cronie/make_error_func_prototype_complete.patch new file +41 -0
@@ -0,0 +1,41 @@ +From 09c630c654b2aeff06a90a412cce0a60ab4955a4 Mon Sep 17 00:00:00 2001 +From: Tomas Mraz <[email protected]> +Date: Mon, 18 Nov 2024 21:02:30 +0100 +Subject: [PATCH] load_entry(): Make error_func prototype complete + +Fixes #193 + +Upstream-Status: Backport [https://github.com/cronie-crond/cronie/commit/09c630c654b2aeff06a90a412cce0a60ab4955a4] + +Signed-off-by: Khem Raj <[email protected]> +--- + src/entry.c | 2 +- + src/funcs.h | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/src/entry.c b/src/entry.c +index 586eb9d..a2077e8 100644 +--- a/src/entry.c ++++ b/src/entry.c +@@ -90,7 +90,7 @@ void free_entry(entry * e) { + /* return NULL if eof or syntax error occurs; + * otherwise return a pointer to a new entry. + */ +-entry *load_entry(FILE * file, void (*error_func) (), struct passwd *pw, ++entry *load_entry(FILE * file, void (*error_func) (const char *), struct passwd *pw, + char **envp) { + /* this function reads one crontab entry -- the next -- from a file. + * it skips any leading blank lines, ignores comments, and returns +diff --git a/src/funcs.h b/src/funcs.h +index 427e027..f28d634 100644 +--- a/src/funcs.h ++++ b/src/funcs.h +@@ -89,7 +89,7 @@ char *env_get(const char *, char **), + user *load_user(int, struct passwd *, const char *, const char *, const char *), + *find_user(cron_db *, const char *, const char *); + +-entry *load_entry(FILE *, void (*)(), struct passwd *, char **); ++entry *load_entry(FILE *, void (*)(const char *), struct passwd *, char **); + + FILE *cron_popen(char *, const char *, struct passwd *, char **); +
meta/recipes-extended/cronie/cronie_1.7.2.bb +1 -0
@@ -17,6 +17,7 @@ SECTION = "utils" GITHUB_BASE_URI = "https://github.com/cronie-crond/${BPN}/releases/" SRC_URI = "${GITHUB_BASE_URI}/download/cronie-${PV}/cronie-${PV}.tar.gz \ + file://make_error_func_prototype_complete.patch \ file://crond.init \ file://crontab \ file://crond.service \
PATCH 22/24 time: Fix build with GCC 15
In reply to Khem RajInitialize interrupt_signal and quit_signal with correct type
--- .../time-1.9-Fix-compiling-with-GCC15.patch | 33 +++++++++++++++++++ meta/recipes-extended/time/time_1.9.bb | 1 + 2 files changed, 34 insertions(+) create mode 100644 meta/recipes-extended/time/time/time-1.9-Fix-compiling-with-GCC15.patch
meta/recipes-extended/time/time/time-1.9-Fix-compiling-with-GCC15.patch new file +33 -0
@@ -0,0 +1,33 @@ +From 831194f0be7733c99c7a2c69d9e9695b82e05010 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Ond=C5=99ej=20Poho=C5=99elsk=C3=BD?= <[email protected]> +Date: Thu, 30 Jan 2025 08:48:47 +0100 +Subject: [PATCH] time: fix compiling with GCC15 +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +GCC15 complains about incompatible pointer type in run_command() +Initialize interrupt_signal and quit_signal with correct type + +Upstream-Status: Submitted [https://lists.gnu.org/archive/html/bug-time/2025-01/msg00000.html] +Signed-off-by: Ondřej Pohořelský <[email protected]> +--- + src/time.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/time.c b/src/time.c +index 7b401bc..c8d7ab0 100644 +--- a/src/time.c ++++ b/src/time.c +@@ -803,7 +803,7 @@ run_command (cmd, resp) + RESUSE *resp; + { + pid_t pid; /* Pid of child. */ +- sighandler interrupt_signal, quit_signal; ++ __sighandler_t interrupt_signal, quit_signal; + int saved_errno; + + resuse_start (resp); +-- +2.48.1 +
meta/recipes-extended/time/time_1.9.bb +1 -0
@@ -15,6 +15,7 @@ BBCLASSEXTEND = "native nativesdk" SRC_URI = "${GNU_MIRROR}/time/time-${PV}.tar.gz \ file://0001-include-string.h-for-memset.patch \ + file://time-1.9-Fix-compiling-with-GCC15.patch \ " SRC_URI[md5sum] = "d2356e0fe1c0b85285d83c6b2ad51b5f"
Re: [OE-core] [PATCH 22/24] time: Fix build with GCC 15
Quoted 4 lines · Khem Raj via lists.openembedded.org
Initialize
interrupt_signalandquit_signalwith correct typeSigned-off-by Khem Raj <[email protected]>---
Hi Khem,
Thanks for your patch.
It looks like this is breaking the build, maybe just for musl:
ERROR: time-1.9-r0 do_compile: Execution of '/srv/pokybuild/yocto-worker/musl-qemux86/build/build/tmp/work/core2-32-poky-linux-musl/time/1.9/temp/run.do_compile.3718025' failed with exit code 1
...
| ../time-1.9/src/time.c:731:3: error: unknown type name '__sighandler_t'; did you mean 'sighandler_t'?
https://autobuilder.yoctoproject.org/valkyrie/#/builders/6/builds/1215
Can you have a look at this build failure please?
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [OE-core] [PATCH 22/24] time: Fix build with GCC 15
Quoted 13 lines · Mathieu Dubois-Briand
Quoted 4 lines · Khem Raj via lists.openembedded.org
Initialize
interrupt_signalandquit_signalwith correct typeSigned-off-by Khem Raj <[email protected]>---
Hi Khem,
Thanks for your patch.
It looks like this is breaking the build, maybe just for musl:
Quoted 7 lines
ERROR: time-1.9-r0
do_compile: Execution of '/srv/pokybuild/yocto-worker/musl-qemux86/build/build/tmp/work/core2-32-poky-linux-musl/time/1.9/temp/run.do_compile.3718025' failed with exit code 1
...
|../time-1.9/src/time.c:731:3: error: unknown type name '__sighandler_t'; did you mean 'sighandler_t'?https://autobuilder.yoctoproject.org/valkyrie/#/builders/6/builds/1215
Can you have a look at this build failure please?
musl found that upstream fix is not complete, I have fixed the fallout and sent upstream as well as its included in V3 series here.
Quoted 6 lines
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
PATCH 23/24 psplash: Fix build with GCC 15
In reply to Khem Raj--- ...ine-bool-if-using-C-standard-older-t.patch | 32 +++++++++++++++++++ meta/recipes-core/psplash/psplash_git.bb | 1 + 2 files changed, 33 insertions(+) create mode 100644 meta/recipes-core/psplash/files/0001-psplash-Only-define-bool-if-using-C-standard-older-t.patch
meta/recipes-core/psplash/files/0001-psplash-Only-define-bool-if-using-C-standard-older-t.patch new file +32 -0
@@ -0,0 +1,32 @@ +From eab6948cd8eba493f2af7533a931df5ef1d30715 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Mon, 17 Mar 2025 20:31:19 -0700 +Subject: [PATCH] psplash: Only define bool if using C standard older than C23 + +gcc-15 switched to -std=c23 by default: + +https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 + +only typedef int bool for __STDC_VERSION__ <= 201710L (C17) + +Upstream-Status: Submitted [https://lists.yoctoproject.org/g/yocto-patches/message/1213] +Signed-off-by: Khem Raj <[email protected]> +--- + psplash.h | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/psplash.h b/psplash.h +index 1c42ec7..138e49d 100644 +--- a/psplash.h ++++ b/psplash.h +@@ -37,7 +37,10 @@ + + typedef uint8_t uint8; + typedef uint16_t uint16; ++ ++#if defined __STDC__ && defined __STDC_VERSION__ && __STDC_VERSION__ <= 201710L + typedef int bool; ++#endif + + #ifndef FALSE + #define FALSE 0
meta/recipes-core/psplash/psplash_git.bb +1 -0
@@ -10,6 +10,7 @@ SRCREV = "5a32cf6392c784a7ae1983a354cf07b024625cd2" PV = "0.1+git" SRC_URI = "git://git.yoctoproject.org/${BPN};branch=master;protocol=https \ + file://0001-psplash-Only-define-bool-if-using-C-standard-older-t.patch \ file://psplash-init \ file://[email protected] \ file://psplash-systemd.service \
Patchtest results for [PATCH 23/24] psplash: Fix build with GCC 15
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/23-24-psplash-Fix-build-with-GCC-15.patch
FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
PATCH 24/24 at: Remove mktime signature from posixtm.c
In reply to Khem RajThis is in conflict with signature from system time.h
extern time_t mktime (struct tm *__tp) __THROW;
GCC-15 with C23 on, this is treated at error
posixtm.c:45:8: error: conflicting types for 'mktime'; have 'time_t(void)' {aka 'long int(void)'}
| 45 | time_t mktime (); | | ^~~~~~ |
config.h is local include file to use quotes to include it
--- meta/recipes-extended/at/at/posixtm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-extended/at/at/posixtm.c +1 -3
@@ -20,7 +20,7 @@/* Yacc-based version written by Jim Kingdon and David MacKenzie. Rewritten by Jim Meyering. */ -#include <config.h> +#include "config.h" #include "posixtm.h"
@@ -42,8 +42,6 @@of `digit' even when the host does not conform to POSIX. */ #define ISDIGIT (c) ((unsigned int) (c) - '0' <= 9) -time_t mktime (); -/* POSIX requires: