Skip to contentSkip to conversation

usb: dwc3: xilinx: Prevent spike in reset signal

PATCH In review Mike Looijmans 4 participants 4 messages Mar 18, 2025 – Mar 26, 2025 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.92a20336-7677-4cd7-9893-b0e0da853ba9@emailsignatures365.codetwo.com

#1 lore raw

PATCH v2 1/1 usb: dwc3: xilinx: Prevent spike in reset signal

The "reset" GPIO controls the RESET signal to an external, usually ULPI PHY, chip. The original code path acquires the signal in LOW state, and then immediately asserts it HIGH again, if the reset signal defaulted to asserted, there'd be a short "spike" before the reset.

Here is what happens depending on the pre-existing state of the reset signal:

Reset (previously asserted):   ~~~|_|~~~~|_______
Reset (previously deasserted): _____|~~~~|_______

^ ^ ^
A B C

At point A, the low going transition is because the reset line is requested using GPIOD_OUT_LOW. If the line is successfully requested, the first thing we do is set it high _without_ any delay. This is point B. So, a glitch occurs between A and B.

Requesting the line using GPIOD_OUT_HIGH eliminates the A and B transitions. Instead we get:

Reset (previously asserted) : ~~~~~~~~~~|______
Reset (previously deasserted): ____|~~~~~|______

                                   ^     ^
                                   A     C

Where A and C are the points described above in the code. Point B has been eliminated.

The issue was found during code inspection.

Also remove the cryptic "toggle ulpi .." comment.

Fixes ca05b38252d7 ("usb: dwc3: xilinx: Add gpio-reset support")

---

Changes in v2:
Add "Fixes" tag
Remove "toggle ulpi" comment
Extend comment to explain what is happening in detail

 drivers/usb/dwc3/dwc3-xilinx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/dwc3/dwc3-xilinx.c +1 -3
index a33a42ba0249..4ca7f6240d07 100644
@@ -207,15 +207,13 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data)
 
 skip_usb3_phy:
 	/* ulpi reset via gpio-modepin or gpio-framework driver */
-	reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+	reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
 	if (IS_ERR(reset_gpio)) {
 		return dev_err_probe(dev, PTR_ERR(reset_gpio),
 				     "Failed to request reset GPIO\n");
 	}
 
 	if (reset_gpio) {
-		/* Toggle ulpi to reset the phy. */
-		gpiod_set_value_cansleep(reset_gpio, 1);
 		usleep_range(5000, 10000);
 		gpiod_set_value_cansleep(reset_gpio, 0);
 		usleep_range(5000, 10000);
Signature · 18 lines
2.43.0


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

Please consider the environment before printing this e-mail
maintainer
#2 lore raw

+Radhey

Quoted 66 lines · Mike Looijmans

The "reset" GPIO controls the RESET signal to an external, usually ULPI PHY, chip. The original code path acquires the signal in LOW state, and then immediately asserts it HIGH again, if the reset signal defaulted to asserted, there'd be a short "spike" before the reset.

Here is what happens depending on the pre-existing state of the reset signal:

Reset (previously asserted):   ~~~|_|~~~~|_______
Reset (previously deasserted): _____|~~~~|_______

^ ^ ^
A B C

At point A, the low going transition is because the reset line is requested using GPIOD_OUT_LOW. If the line is successfully requested, the first thing we do is set it high _without_ any delay. This is point B. So, a glitch occurs between A and B.

Requesting the line using GPIOD_OUT_HIGH eliminates the A and B transitions. Instead we get:

Reset (previously asserted) : ~~~~~~~~~~|______
Reset (previously deasserted): ____|~~~~~|______

                                    ^     ^
                                    A     C

Where A and C are the points described above in the code. Point B has been eliminated.

The issue was found during code inspection.

Also remove the cryptic "toggle ulpi .." comment.

Fixes ca05b38252d7 ("usb: dwc3: xilinx: Add gpio-reset support")

---

Changes in v2:
Add "Fixes" tag
Remove "toggle ulpi" comment
Extend comment to explain what is happening in detail

  drivers/usb/dwc3/dwc3-xilinx.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/dwc3/dwc3-xilinx.c +1 -3
index a33a42ba0249..4ca7f6240d07 100644
@@ -207,15 +207,13 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data)
 
  skip_usb3_phy:
  	/* ulpi reset via gpio-modepin or gpio-framework driver */
-	reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+	reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
  	if (IS_ERR(reset_gpio)) {
  		return dev_err_probe(dev, PTR_ERR(reset_gpio),
  				     "Failed to request reset GPIO\n");
  	}
 
  	if (reset_gpio) {
-		/* Toggle ulpi to reset the phy. */
-		gpiod_set_value_cansleep(reset_gpio, 1);
  		usleep_range(5000, 10000);
  		gpiod_set_value_cansleep(reset_gpio, 0);
  		usleep_range(5000, 10000);
#3 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Quoted 10 lines

-----Original Message-----
From: Simek, Michal <[email protected]>
Sent: Tuesday, March 18, 2025 1:07 PM
To: Mike Looijmans <[email protected]>; [email protected]; Pandey, Radhey Shyam <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; Thinh Nguyen <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH v2] usb: dwc3: xilinx: Prevent spike in reset signal

Quoted 37 lines

+Radhey

Quoted 34 lines · Mike Looijmans

The "reset" GPIO controls the RESET signal to an external, usually ULPI PHY, chip. The original code path acquires the signal in LOW state, and then immediately asserts it HIGH again, if the reset signal defaulted to asserted, there'd be a short "spike" before the reset.

Here is what happens depending on the pre-existing state of the reset signal:

Reset (previously asserted):   ~~~|_|~~~~|_______
Reset (previously deasserted): _____|~~~~|_______

^ ^ ^
A B C

At point A, the low going transition is because the reset line is requested using GPIOD_OUT_LOW. If the line is successfully requested, the first thing we do is set it high _without_ any delay. This is point B. So, a glitch occurs between A and B.

Requesting the line using GPIOD_OUT_HIGH eliminates the A and B transitions. Instead we get:

Reset (previously asserted) : ~~~~~~~~~~|______ Reset (previously deasserted): ____|~~~~~|______

                                    ^     ^
                                    A     C

Where A and C are the points described above in the code. Point B has been eliminated.

The issue was found during code inspection.

Also remove the cryptic "toggle ulpi .." comment.

Fixes ca05b38252d7 ("usb: dwc3: xilinx: Add gpio-reset support")

Thanks.

Quoted 33 lines
Quoted 33 lines

---

Changes in v2:
Add "Fixes" tag
Remove "toggle ulpi" comment
Extend comment to explain what is happening in detail

  drivers/usb/dwc3/dwc3-xilinx.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/usb/dwc3/dwc3-xilinx.c index a33a42ba0249..4ca7f6240d07 100644

drivers/usb/dwc3/dwc3-xilinx.c +1 -3
@@ -207,15 +207,13 @@ static int dwc3_xlnx_init_zynqmp(struct
 dwc3_xlnx *priv_data)
 
  skip_usb3_phy:
    /* ulpi reset via gpio-modepin or gpio-framework driver */
-   reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+   reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
    if (IS_ERR(reset_gpio)) {
            return dev_err_probe(dev, PTR_ERR(reset_gpio),
                                 "Failed to request reset GPIO\n");
    }
 
    if (reset_gpio) {
-           /* Toggle ulpi to reset the phy. */
-           gpiod_set_value_cansleep(reset_gpio, 1);
            usleep_range(5000, 10000);
            gpiod_set_value_cansleep(reset_gpio, 0);
            usleep_range(5000, 10000);
maintainer Acked-by on v2 1/1
#4 lore raw
In reply to Mike Looijmans
Quoted 26 lines · Mike Looijmans

The "reset" GPIO controls the RESET signal to an external, usually ULPI PHY, chip. The original code path acquires the signal in LOW state, and then immediately asserts it HIGH again, if the reset signal defaulted to asserted, there'd be a short "spike" before the reset.

Here is what happens depending on the pre-existing state of the reset signal:

Reset (previously asserted):   ~~~|_|~~~~|_______
Reset (previously deasserted): _____|~~~~|_______

^ ^ ^
A B C

At point A, the low going transition is because the reset line is requested using GPIOD_OUT_LOW. If the line is successfully requested, the first thing we do is set it high _without_ any delay. This is point B. So, a glitch occurs between A and B.

Requesting the line using GPIOD_OUT_HIGH eliminates the A and B transitions. Instead we get:

Reset (previously asserted) : ~~~~~~~~~~|______
Reset (previously deasserted): ____|~~~~~|______

                                   ^     ^
                                   A     C
Quoted 8 lines

Where A and C are the points described above in the code. Point B has been eliminated.

The issue was found during code inspection.

Also remove the cryptic "toggle ulpi .." comment.

Fixes ca05b38252d7 ("usb: dwc3: xilinx: Add gpio-reset support")

May want to add stable tag also?

Quoted 11 lines

---

Changes in v2:
Add "Fixes" tag
Remove "toggle ulpi" comment
Extend comment to explain what is happening in detail

 drivers/usb/dwc3/dwc3-xilinx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

In any case,

Thanks,
Thinh