config/arm: fix meson for native instruction set Arm CPUs
PATCH 1/1 config/arm: fix meson for native instruction set Arm CPUs
Arm meson.build unconditionally relays on the extra_features member of SoC configuration.
SoC dictionary is populated for Arm CPUs with generic instruction set only.
For Arm CPUs with native CPU instruction set the SoC dictionary is empty.
meson setup failed for the BlueField-3 because it belongs to the native Arm CPU instruction set.
The patch adds global definition for extra_features.
--- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+)
config/arm/meson.build +1 -0
@@ -767,6 +767,7 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) update_flags = false soc_flags = [] +extra_features = [] if dpdk_conf.get('RTE_ARCH_32') # 32-bit build dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
Signature · 1 line
2.45.2
Hi Gregory,
Quoted 24 lines
Arm meson.build unconditionally relays on the
extra_featuresmember of SoC configuration.SoC dictionary is populated for Arm CPUs with generic instruction set only.
For Arm CPUs with native CPU instruction set the SoC dictionary is empty.meson setup failed for the BlueField-3 because it belongs to the native Arm CPU instruction set.
The patch adds global definition for
extra_features.Fixes 7829776d0abf ("config/arm: add extra -march features")Signed-off-by Gregory Etelson <[email protected]>--- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+)config/arm/meson.build +0
-0
config/arm/meson.build dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) · line 770
Quoted 4 lines
config/arm/meson.build +1
-0@@ -767,6 +767,7 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) update_flags = false soc_flags = [] +extra_features = []
We do set the default to be [] when extra_march_features is not found In soc_config.
extra_features = soc_config.get('extra_march_features', [])
I have tested cross build[1] of bluefield3 with both meson 1.7.0 and 0.61.2 and didn’t see any failure which version of meson are you using?
[1]meson build --cross-file config/arm/arm64_bluefield3_linux_gcc
Thanks,
Pavan.
Quoted 5 lines
config/arm/meson.build +0
-1if dpdk_conf.get('RTE_ARCH_32') # 32-bit build dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) --2.45.2
Pavan Nikhilesh Bhagavatula
Acked-byQuoted 17 lines
Hi Gregory,
Quoted 15 lines
Arm meson.build unconditionally relays on the
extra_featuresmember of SoC configuration.SoC dictionary is populated for Arm CPUs with generic instruction set only.
For Arm CPUs with native CPU instruction set the SoC dictionary is empty.meson setup failed for the BlueField-3 because it belongs to the native Arm CPU instruction set.
The patch adds global definition for
extra_features.Fixes 7829776d0abf ("config/arm: add extra -march features")Signed-off-by Gregory Etelson <[email protected]>
Quoted 10 lines
Quoted 10 lines
--- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+)config/arm/meson.build +0
-0@@ -767,6 +767,7 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)
Quoted 4 lines
config/arm/meson.build dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) · line 770
Quoted 3 lines
config/arm/meson.build +1
-0update_flags = false soc_flags = [] +extra_features = []
I re-checked with arm64 native compilation and see the issue.
Thanks,
Pavan.
Quoted 19 lines
We do set the default to be [] when
extra_march_featuresis not found Insoc_config.
extra_features=soc_config.get('extra_march_features', [])I have tested cross build[1] of bluefield3 with both meson 1.7.0 and 0.61.2 and didn’t see any failure which version of meson are you using?
[1]meson build --cross-file config/arm/arm64_bluefield3_linux_gcc
Thanks,
Pavan.Quoted 5 lines
config/arm/meson.build +0
-1if dpdk_conf.get('RTE_ARCH_32') # 32-bit build dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) --2.45.2
Thomas Monjalon
Applied19/03/2025 12:10, Pavan Nikhilesh Bhagavatula:
Quoted 13 lines
Quoted 13 lines
Hi Gregory,
Quoted 11 lines
Arm meson.build unconditionally relays on the
extra_featuresmember of SoC configuration.SoC dictionary is populated for Arm CPUs with generic instruction set only.
For Arm CPUs with native CPU instruction set the SoC dictionary is empty.meson setup failed for the BlueField-3 because it belongs to the native Arm CPU instruction set.
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
The patch adds global definition for
extra_features.Fixes 7829776d0abf ("config/arm: add extra -march features")Signed-off-by Gregory Etelson <[email protected]>Acked-by Pavan Nikhilesh <[email protected]>
Applied, thanks.