sched_ext: Enhance built-in idle selection with allowed CPUs
Subsystems (4)
Andrea Righi
reviewerPATCH v5 1/1 sched_ext: Enhance built-in idle selection with allowed CPUs
Many scx schedulers implement their own hard or soft-affinity rules to support topology characteristics, such as heterogeneous architectures (e.g., big.LITTLE, P-cores/E-cores), or to categorize tasks based on specific properties (e.g., running certain tasks only in a subset of CPUs).
Currently, there is no mechanism that allows to use the built-in idle CPU selection policy to an arbitrary subset of CPUs. As a result, schedulers often implement their own idle CPU selection policies, which are typically similar to one another, leading to a lot of code duplication.
To address this, extend the built-in idle CPU selection policy introducing the concept of allowed CPUs.
With this concept, BPF schedulers can apply the built-in idle CPU selection policy to a subset of allowed CPUs, allowing them to implement their own hard/soft-affinity rules while still using the topology optimizations of the built-in policy, preventing code duplication across different schedulers.
To implement this introduce a new helper kfunc scx_bpf_select_cpu_and() that accepts a cpumask of allowed CPUs:
s32 scx_bpf_select_cpu_and(struct task_struct *p, s32 prev_cpu,
u64 wake_flags, const struct cpumask *cpus_allowed, u64 flags);
Example usage
=============
s32 BPF_STRUCT_OPS(foo_select_cpu, struct task_struct *p,
s32 prev_cpu, u64 wake_flags)
{
const struct cpumask *cpus = task_allowed_cpus(p) ?: p->cpus_ptr;
s32 cpu;
cpu = scx_bpf_select_cpu_and(p, prev_cpu, wake_flags, cpus, 0);
if (cpu >= 0) {
scx_bpf_dsq_insert(p, SCX_DSQ_LOCAL, SCX_SLICE_DFL, 0);
return cpu;
}
return prev_cpu;
}Results
=======
Load distribution on a 4 sockets / 4 cores per socket system, simulated using virtme-ng, running a modified version of scx_bpfland that uses the new helper scx_bpf_select_cpu_and() and 0xff00 as allowed domain:
$ vng --cpu 16,sockets=4,cores=4,threads=1
...
$ stress-ng -c 16
...
$ htop
...
0[ 0.0%] 8[||||||||||||||||||||||||100.0%]
1[ 0.0%] 9[||||||||||||||||||||||||100.0%]
2[ 0.0%] 10[||||||||||||||||||||||||100.0%]
3[ 0.0%] 11[||||||||||||||||||||||||100.0%]
4[ 0.0%] 12[||||||||||||||||||||||||100.0%]
5[ 0.0%] 13[||||||||||||||||||||||||100.0%]
6[ 0.0%] 14[||||||||||||||||||||||||100.0%]
7[ 0.0%] 15[||||||||||||||||||||||||100.0%]With scx_bpf_select_cpu_dfl() tasks would be distributed evenly across all the available CPUs.
ChangeLog v4 -> v5:
- simplify the code to compute (and) task's temporary cpumasks
ChangeLog v3 -> v4:
- keep p->nr_cpus_allowed optimizations (skip cpumask operations when the task can run on all CPUs)
- allow to call scx_bpf_select_cpu_and() also from ops.enqueue() and modify the kselftest to cover this case as well
- rebase to the latest sched_ext/for-6.15
ChangeLog v2 -> v3:
- incrementally refactor scx_select_cpu_dfl() to accept idle flags and an arbitrary allowed cpumask
- build scx_bpf_select_cpu_and() on top of the existing logic
- re-arrange scx_select_cpu_dfl() prototype, aligning the first three arguments with select_task_rq()
- do not use "domain" for the allowed cpumask to avoid potential ambiguity with sched_domain
ChangeLog v1 -> v2:
- rename scx_bpf_select_cpu_pref() to scx_bpf_select_cpu_and() and always select idle CPUs strictly within the allowed domain
- rename preferred CPUs -> allowed CPU
- drop %SCX_PICK_IDLE_IN_PREF (not required anymore)
- deprecate scx_bpf_select_cpu_dfl() in favor of scx_bpf_select_cpu_and() and provide all the required backward compatibility boilerplate
Andrea Righi (6):
sched_ext: idle: Extend topology optimizations to all tasks
sched_ext: idle: Explicitly pass allowed cpumask to scx_select_cpu_dfl()
sched_ext: idle: Accept an arbitrary cpumask in scx_select_cpu_dfl()
sched_ext: idle: Introduce scx_bpf_select_cpu_and() selftests/sched_ext: Add test for scx_bpf_select_cpu_and()
sched_ext: idle: Deprecate scx_bpf_select_cpu_dfl()
Documentation/scheduler/sched-ext.rst | 11 +- kernel/sched/ext.c | 6 +- kernel/sched/ext_idle.c | 196 ++++++++++++++++----- kernel/sched/ext_idle.h | 3 +- tools/sched_ext/include/scx/common.bpf.h | 5 +- tools/sched_ext/include/scx/compat.bpf.h | 37 ++++ tools/sched_ext/scx_flatcg.bpf.c | 12 +- tools/sched_ext/scx_simple.bpf.c | 9 +- tools/testing/selftests/sched_ext/Makefile | 1 + .../testing/selftests/sched_ext/allowed_cpus.bpf.c | 121 +++++++++++++ tools/testing/selftests/sched_ext/allowed_cpus.c | 57 ++++++ .../selftests/sched_ext/enq_select_cpu_fails.bpf.c | 12 +- .../selftests/sched_ext/enq_select_cpu_fails.c | 2 +- tools/testing/selftests/sched_ext/exit.bpf.c | 6 +- .../sched_ext/select_cpu_dfl_nodispatch.bpf.c | 13 +- .../sched_ext/select_cpu_dfl_nodispatch.c | 2 +- 16 files changed, 404 insertions(+), 89 deletions(-) create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.bpf.c create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.c
Andrea Righi
reviewerPATCH 1/6 sched_ext: idle: Extend topology optimizations to all tasks
The built-in idle selection policy, scx_select_cpu_dfl(), always prioritizes picking idle CPUs within the same LLC or NUMA node, but these optimizations are currently applied only when a task has no CPU affinity constraints.
This is done primarily for efficiency, as it avoids the overhead of updating a cpumask every time we need to select an idle CPU (which can be costly in large SMP systems).
However, this approach limits the effectiveness of the built-in idle policy and results in inconsistent behavior, as affinity-restricted tasks don't benefit from topology-aware optimizations.
To address this, modify the policy to apply LLC and NUMA-aware optimizations even when a task is constrained to a subset of CPUs.
We can still avoid updating the cpumasks by checking if the subset of LLC and node CPUs are contained in the subset of allowed CPUs usable by the task (which is true in most of the cases - for tasks that don't have affinity constratints).
Moreover, use temporary local per-CPU cpumasks to determine the LLC and node subsets, minimizing potential overhead even on large SMP systems.
--- kernel/sched/ext_idle.c | 78 ++++++++++++++++++++++++++++------------- 1 file changed, 54 insertions(+), 24 deletions(-)
kernel/sched/ext_idle.c +54 -24
@@ -46,6 +46,12 @@ static struct scx_idle_cpus scx_idle_global_masks;*/ static struct scx_idle_cpus **scx_idle_node_masks; +/* +* Local per-CPU cpumasks (used to generate temporary idle cpumasks). +*/ +static DEFINE_PER_CPU(cpumask_var_t, local_llc_idle_cpumask); +static DEFINE_PER_CPU(cpumask_var_t, local_numa_idle_cpumask); +/* * Return the idle masks associated to a target @node. *
@@ -391,6 +397,30 @@ void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops)static_branch_disable_cpuslocked (&scx_selcpu_topo_numa); } +/* +* Return the subset of @cpus that task @p can use or NULL if none of the +* CPUs in the @cpus cpumask can be used. +*/ +static const struct cpumask *task_cpumask (const struct task_struct *p,const struct cpumask *cpus, +struct cpumask *local_cpus) +{ +/* +* If the task is allowed to run on all CPUs, simply use the +* architecture's cpumask directly. Otherwise, compute the +* intersection of the architecture's cpumask and the task's +* allowed cpumask. +*/ +if (!cpus || p->nr_cpus_allowed >=num_possible_cpus () || +cpumask_subset (cpus, p->cpus_ptr)) +return cpus; + +if (!cpumask_equal (cpus, p->cpus_ptr) && +cpumask_and (local_cpus, cpus, p->cpus_ptr)) +return local_cpus; + +return NULL ; +} +/* * Built-in CPU idle selection policy: *
@@ -426,8 +456,7 @@ void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops)*/ s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags,u64 flags) { -const struct cpumask *llc_cpus =NULL ; -const struct cpumask *numa_cpus =NULL ; +const struct cpumask *llc_cpus =NULL , *numa_cpus =NULL ;int node =scx_cpu_node_if_enabled (prev_cpu);s32 cpu;
@@ -437,23 +466,16 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64rcu_read_lock ();/* -* Determine the scheduling domain only if the task is allowed to run -* on all CPUs. -* -* This is done primarily for efficiency, as it avoids the overhead of -* updating a cpumask every time we need to select an idle CPU (which -* can be costly in large SMP systems), but it also aligns logically: -* if a task's scheduling domain is restricted by user-space (through -* CPU affinity), the task will simply use the flat scheduling domain -* defined by user-space. +* Determine the subset of CPUs that the task can use in its +* current LLC and node. */ -if (p->nr_cpus_allowed >=num_possible_cpus ()) { -if (static_branch_maybe (CONFIG_NUMA , &scx_selcpu_topo_numa)) - numa_cpus =numa_span (prev_cpu); +if (static_branch_maybe (CONFIG_NUMA , &scx_selcpu_topo_numa)) + numa_cpus =task_cpumask (p,numa_span (prev_cpu), +this_cpu_cpumask_var_ptr (local_numa_idle_cpumask)); -if (static_branch_maybe (CONFIG_SCHED_MC , &scx_selcpu_topo_llc)) - llc_cpus =llc_span (prev_cpu); - } +if (static_branch_maybe (CONFIG_SCHED_MC , &scx_selcpu_topo_llc)) + llc_cpus =task_cpumask (p,llc_span (prev_cpu), +this_cpu_cpumask_var_ptr (local_llc_idle_cpumask));/* * If WAKE_SYNC, try to migrate the wakee to the waker's CPU.
@@ -598,7 +620,7 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64*/ void scx_idle_init_masks (void ) { -int node; +int i;/* Allocate global idle cpumasks */ BUG_ON (!alloc_cpumask_var (&scx_idle_global_masks.cpu,GFP_KERNEL ));
@@ -609,13 +631,21 @@ void scx_idle_init_masks(void) sizeof(*scx_idle_node_masks), GFP_KERNEL);BUG_ON (!scx_idle_node_masks); -for_each_node (node) { - scx_idle_node_masks[node] =kzalloc_node (sizeof (**scx_idle_node_masks), -GFP_KERNEL , node); -BUG_ON (!scx_idle_node_masks[node]); +for_each_node (i) { + scx_idle_node_masks[i] =kzalloc_node (sizeof (**scx_idle_node_masks), +GFP_KERNEL , i); +BUG_ON (!scx_idle_node_masks[i]); + +BUG_ON (!alloc_cpumask_var_node (&scx_idle_node_masks[i]->cpu,GFP_KERNEL , i)); +BUG_ON (!alloc_cpumask_var_node (&scx_idle_node_masks[i]->smt,GFP_KERNEL , i)); + } -BUG_ON (!alloc_cpumask_var_node (&scx_idle_node_masks[node]->cpu,GFP_KERNEL , node)); -BUG_ON (!alloc_cpumask_var_node (&scx_idle_node_masks[node]->smt,GFP_KERNEL , node)); +/* Allocate local per-cpu idle cpumasks */ +for_each_possible_cpu (i) { +BUG_ON (!alloc_cpumask_var_node (&per_cpu (local_llc_idle_cpumask, i), +GFP_KERNEL ,cpu_to_node (i))); +BUG_ON (!alloc_cpumask_var_node (&per_cpu (local_numa_idle_cpumask, i), +GFP_KERNEL ,cpu_to_node (i))); } }
Signature · 1 line
2.48.1
Tejun Heo
reviewerRe: [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks
Quoted 4 lines · Andrea Righi
kernel/sched/ext_idle.c +4
-0+static const struct cpumask *task_cpumask (const struct task_struct *p,const struct cpumask *cpus, +struct cpumask *local_cpus) +{ +/*
kernel/sched/ext_idle.c void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops) · line 417
Quoted 10 lines
kernel/sched/ext_idle.c +10
-0+* If the task is allowed to run on all CPUs, simply use the +* architecture's cpumask directly. Otherwise, compute the +* intersection of the architecture's cpumask and the task's +* allowed cpumask. +*/ +if (!cpus || p->nr_cpus_allowed >=num_possible_cpus () || +cpumask_subset (cpus, p->cpus_ptr)) +return cpus; + + if (!cpumask_equal(cpus, p->cpus_ptr) &&
Weren't we talkign about removing this test?
Thanks.
Signature · 1 line
tejun
Andrea Righi
reviewerRe: [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks
Hi Tejun,
Quoted 17 lines · Tejun Heo
Quoted 4 lines · Andrea Righi
kernel/sched/ext_idle.c +4
-0+static const struct cpumask *task_cpumask (const struct task_struct *p,const struct cpumask *cpus, +struct cpumask *local_cpus) +{ +/* kernel/sched/ext_idle.c void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops) · line 417
Quoted 10 lines
kernel/sched/ext_idle.c +10
-0+* If the task is allowed to run on all CPUs, simply use the +* architecture's cpumask directly. Otherwise, compute the +* intersection of the architecture's cpumask and the task's +* allowed cpumask. +*/ +if (!cpus || p->nr_cpus_allowed >=num_possible_cpus () || +cpumask_subset (cpus, p->cpus_ptr)) +return cpus; + + if (!cpumask_equal(cpus, p->cpus_ptr) &&Weren't we talkign about removing this test?
sorry, it's actually removed in PATCH 3/6, but I'll clean it up also in this one.
Thanks,
-Andrea
Quoted 5 lines
Thanks.
Signature · 1 line
tejun
Andrea Righi
reviewerPATCH 2/6 sched_ext: idle: Explicitly pass allowed cpumask to scx_select_cpu_dfl()
In reply to Andrea RighiModify scx_select_cpu_dfl() to take the allowed cpumask as an explicit argument, instead of implicitly using @p->cpus_ptr.
This prepares for future changes where arbitrary cpumasks may be passed to the built-in idle CPU selection policy.
This is a pure refactoring with no functional changes.
--- kernel/sched/ext.c | 2 +- kernel/sched/ext_idle.c | 45 ++++++++++++++++++++++++++--------------- kernel/sched/ext_idle.h | 3 ++- 3 files changed, 32 insertions(+), 18 deletions(-)
kernel/sched/ext.c +1 -1
@@ -3395,7 +3395,7 @@ static int select_task_rq_scx(struct task_struct *p, int prev_cpu, int wake_flag }else {s32 cpu; - cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags,0 ); + cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags, p->cpus_ptr,0 );if (cpu >=0 ) { p->scx.slice =SCX_SLICE_DFL ; p->scx.ddsp_dsq_id =SCX_DSQ_LOCAL ;
kernel/sched/ext_idle.c +29 -16
100 lines not on this page · raw message
kernel/sched/ext_idle.h +2 -1
@@ -27,7 +27,8 @@ static inline s32 scx_pick_idle_cpu(const struct cpumask *cpus_allowed, int node }#endif /* CONFIG_SMP */ -s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags,u64 flags); +s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags, +const struct cpumask *cpus_allowed,u64 flags);void scx_idle_enable (struct sched_ext_ops *ops);void scx_idle_disable (void );int scx_idle_init (void );
Signature · 1 line
2.48.1
changwoo
reviewerRe: [PATCH 2/6] sched_ext: idle: Explicitly pass allowed cpumask to scx_select_cpu_dfl()
Hi Andrea,
Quoted 33 lines · Andrea Righi
Modify
scx_select_cpu_dfl()to take the allowed cpumask as an explicit argument, instead of implicitly using @p->cpus_ptr.This prepares for future changes where arbitrary cpumasks may be passed to the built-in idle CPU selection policy.
This is a pure refactoring with no functional changes.
Signed-off-by Andrea Righi <[email protected]>--- kernel/sched/ext.c | 2 +- kernel/sched/ext_idle.c | 45 ++++++++++++++++++++++++++--------------- kernel/sched/ext_idle.h | 3 ++- 3 files changed, 32 insertions(+), 18 deletions(-)kernel/sched/ext.c +1
-1@@ -3395,7 +3395,7 @@ static int select_task_rq_scx(struct task_struct *p, int prev_cpu, int wake_flag }else {s32 cpu; - cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags,0 ); + cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags, p->cpus_ptr,0 );if (cpu >=0 ) { p->scx.slice =SCX_SLICE_DFL ; p->scx.ddsp_dsq_id =SCX_DSQ_LOCAL ;kernel/sched/ext_idle.c +0
-0
kernel/sched/ext_idle.c void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops) · line 403
Quoted 7 lines
kernel/sched/ext_idle.c +4
-0@@ -397,11 +397,19 @@ void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops)static_branch_disable_cpuslocked (&scx_selcpu_topo_numa); } +static inline bool task_allowed_all_cpus (const struct task_struct *p) +{ +return p->nr_cpus_allowed >=num_possible_cpus (); +}
This function will be renamed to task_affinity_all() in patch #3. Can we use the same name from the beginning?
That will make the commits easier to read.
Quoted 41 lines
kernel/sched/ext_idle.c +11
-8+/* -* Return the subset of @cpus that task @p can use or NULL if none of the -* CPUs in the @cpus cpumask can be used. +* Return the subset of @cpus that task @p can use, according to +* @cpus_allowed, or NULL if none of the CPUs in the @cpus cpumask can be +* used. */ -static const struct cpumask *task_cpumask (const struct task_struct *p,const struct cpumask *cpus, +static const struct cpumask *task_cpumask (const struct task_struct *p, +const struct cpumask *cpus_allowed, +const struct cpumask *cpus,struct cpumask *local_cpus) {/* @@ -410,12 +418,10 @@ static const struct cpumask *task_cpumask(const struct task_struct *p, const str* intersection of the architecture's cpumask and the task's * allowed cpumask. */ -if (!cpus || p->nr_cpus_allowed >=num_possible_cpus () || -cpumask_subset (cpus, p->cpus_ptr)) +if (!cpus ||task_allowed_all_cpus (p) ||cpumask_subset (cpus, cpus_allowed))return cpus; -if (!cpumask_equal (cpus, p->cpus_ptr) && -cpumask_and (local_cpus, cpus, p->cpus_ptr)) +if (cpumask_and (local_cpus, cpus, cpus_allowed))return local_cpus;return NULL ;@@ -454,7 +460,8 @@ static const struct cpumask *task_cpumask(const struct task_struct *p, const str* NOTE: tasks that can only run on 1 CPU are excluded by this logic, because * we never call ops.select_cpu() for them, see select_task_rq(). */ -s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags,u64 flags) +s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags, +const struct cpumask *cpus_allowed,u64 flags) {const struct cpumask *llc_cpus =NULL , *numa_cpus =NULL ;int node =scx_cpu_node_if_enabled (prev_cpu);
kernel/sched/ext_idle.c s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64 · line 482
Quoted 9 lines
kernel/sched/ext_idle.c +3
-2@@ -469,13 +476,19 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64* Determine the subset of CPUs that the task can use in its * current LLC and node. */ -if (static_branch_maybe (CONFIG_NUMA , &scx_selcpu_topo_numa)) - numa_cpus =task_cpumask (p,numa_span (prev_cpu), +if (static_branch_maybe (CONFIG_NUMA , &scx_selcpu_topo_numa)) { + numa_cpus =task_cpumask (p, cpus_allowed,numa_span (prev_cpu),this_cpu_cpumask_var_ptr (local_numa_idle_cpumask)); +if (cpumask_equal (numa_cpus, cpus_allowed))
Since task_cpumask() can return NULL, I think we should test if numa_cpus is NULL or not here, something like this:
if (numa_cpus && cpumask_equal(numa_cpus, cpus_allowed))
kernel/sched/ext_idle.c s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64 · line 489
Quoted 9 lines
kernel/sched/ext_idle.c +5
-2+ numa_cpus =NULL ; + } -if (static_branch_maybe (CONFIG_SCHED_MC , &scx_selcpu_topo_llc)) - llc_cpus =task_cpumask (p,llc_span (prev_cpu), +if (static_branch_maybe (CONFIG_SCHED_MC , &scx_selcpu_topo_llc)) { + llc_cpus =task_cpumask (p, cpus_allowed,llc_span (prev_cpu),this_cpu_cpumask_var_ptr (local_llc_idle_cpumask)); +if (cpumask_equal (llc_cpus, cpus_allowed))
Same here.
if (llc_cpus && cpumask_equal(llc_cpus, cpus_allowed))
Quoted 46 lines
kernel/sched/ext_idle.c +6
-4+ llc_cpus =NULL ; + }/* * If WAKE_SYNC, try to migrate the wakee to the waker's CPU. @@ -512,7 +525,7 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64 cpu_rq(cpu)->scx.local_dsq.nr == 0 && (!(flags & SCX_PICK_IDLE_IN_NODE) || (waker_node == node)) && !cpumask_empty(idle_cpumask(waker_node)->cpu)) { -if (cpumask_test_cpu (cpu, p->cpus_ptr)) +if (cpumask_test_cpu (cpu, cpus_allowed)) goto out_unlock; } }@@ -557,7 +570,7 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64* begin in prev_cpu's node and proceed to other nodes in * order of increasing distance. */ - cpu =scx_pick_idle_cpu (p->cpus_ptr, node, flags |SCX_PICK_IDLE_CORE ); + cpu =scx_pick_idle_cpu (cpus_allowed, node, flags |SCX_PICK_IDLE_CORE );if (cpu >=0 ) goto out_unlock;@@ -605,7 +618,7 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64* in prev_cpu's node and proceed to other nodes in order of * increasing distance. */ - cpu =scx_pick_idle_cpu (p->cpus_ptr, node, flags); + cpu =scx_pick_idle_cpu (cpus_allowed, node, flags);if (cpu >=0 ) goto out_unlock;@@ -861,7 +874,7 @@ __bpf_kfunc s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, goto prev_cpu;#ifdef CONFIG_SMP - cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags,0 ); + cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags, p->cpus_ptr,0 );if (cpu >=0 ) { *is_idle = true;return cpu;kernel/sched/ext_idle.h +0
-0
kernel/sched/ext_idle.h static inline s32 scx_pick_idle_cpu(const struct cpumask *cpus_allowed, int node · line 34
Quoted 9 lines
kernel/sched/ext_idle.h +2
-1@@ -27,7 +27,8 @@ static inline s32 scx_pick_idle_cpu(const struct cpumask *cpus_allowed, int node }#endif /* CONFIG_SMP */ -s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags,u64 flags); +s32 scx_select_cpu_dfl (struct task_struct *p,s32 prev_cpu,u64 wake_flags, +const struct cpumask *cpus_allowed,u64 flags);void scx_idle_enable (struct sched_ext_ops *ops);void scx_idle_disable (void );int scx_idle_init (void );
Regards,
Changwoo Min
Andrea Righi
reviewerRe: [PATCH 2/6] sched_ext: idle: Explicitly pass allowed cpumask to scx_select_cpu_dfl()
Quoted 39 lines · changwoo
Hi Andrea,
Quoted 36 lines · Andrea Righi
Modify
scx_select_cpu_dfl()to take the allowed cpumask as an explicit argument, instead of implicitly using @p->cpus_ptr.This prepares for future changes where arbitrary cpumasks may be passed to the built-in idle CPU selection policy.
This is a pure refactoring with no functional changes.
Signed-off-by Andrea Righi <[email protected]>--- kernel/sched/ext.c | 2 +- kernel/sched/ext_idle.c | 45 ++++++++++++++++++++++++++--------------- kernel/sched/ext_idle.h | 3 ++- 3 files changed, 32 insertions(+), 18 deletions(-)kernel/sched/ext.c +1
-1@@ -3395,7 +3395,7 @@ static int select_task_rq_scx(struct task_struct *p, int prev_cpu, int wake_flag }else {s32 cpu; - cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags,0 ); + cpu =scx_select_cpu_dfl (p, prev_cpu, wake_flags, p->cpus_ptr,0 );if (cpu >=0 ) { p->scx.slice =SCX_SLICE_DFL ; p->scx.ddsp_dsq_id =SCX_DSQ_LOCAL ;kernel/sched/ext_idle.c +0
-0@@ -397,11 +397,19 @@ void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops)static_branch_disable_cpuslocked (&scx_selcpu_topo_numa); }
Quoted 8 lines
kernel/sched/ext_idle.c void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops) · line 403
Quoted 4 lines
kernel/sched/ext_idle.c +4
-0+static inline bool task_allowed_all_cpus (const struct task_struct *p) +{ +return p->nr_cpus_allowed >=num_possible_cpus (); +}This function will be renamed to
task_affinity_all()in patch #3. Can we use the same name from the beginning?
That will make the commits easier to read.
Right, I'll clean up also this patch in the next version, thanks!
-Andrea
Andrea Righi
reviewerPATCH 3/6 sched_ext: idle: Accept an arbitrary cpumask in scx_select_cpu_dfl()
In reply to Andrea RighiMany scx schedulers implement their own hard or soft-affinity rules to support topology characteristics, such as heterogeneous architectures (e.g., big.LITTLE, P-cores/E-cores), or to categorize tasks based on specific properties (e.g., running certain tasks only in a subset of CPUs).
Currently, there is no mechanism that allows to use the built-in idle CPU selection policy to an arbitrary subset of CPUs. As a result, schedulers often implement their own idle CPU selection policies, which are typically similar to one another, leading to a lot of code duplication.
To address this, modify scx_select_cpu_dfl() to accept an arbitrary cpumask, that can be used by the BPF schedulers to apply the existent built-in idle CPU selection policy to a subset of allowed CPUs.
With this concept the idle CPU selection policy becomes the following:
- always prioritize CPUs from fully idle SMT cores (if SMT is enabled),
- select the same CPU if it's idle and in the allowed CPUs,
- select an idle CPU within the same LLC, if the LLC cpumask is a subset of the allowed CPUs,
- select an idle CPU within the same node, if the node cpumask is a subset of the allowed CPUs,
- select an idle CPU within the allowed CPUs.
This functionality will be exposed through a dedicated kfunc in a separate patch.
--- kernel/sched/ext_idle.c | 110 +++++++++++++++++++++++++--------------- 1 file changed, 69 insertions(+), 41 deletions(-)
kernel/sched/ext_idle.c +69 -41
@@ -49,6 +49,7 @@ static struct scx_idle_cpus **scx_idle_node_masks;/* * Local per-CPU cpumasks (used to generate temporary idle cpumasks). */ +static DEFINE_PER_CPU(cpumask_var_t, local_idle_cpumask); static DEFINE_PER_CPU(cpumask_var_t, local_llc_idle_cpumask); static DEFINE_PER_CPU(cpumask_var_t, local_numa_idle_cpumask);
@@ -397,34 +398,12 @@ void scx_idle_update_selcpu_topology(struct sched_ext_ops *ops)static_branch_disable_cpuslocked (&scx_selcpu_topo_numa); } -static inline bool task_allowed_all_cpus (const struct task_struct *p) -{ -return p->nr_cpus_allowed >=num_possible_cpus (); -} -/* -* Return the subset of @cpus that task @p can use, according to -* @cpus_allowed, or NULL if none of the CPUs in the @cpus cpumask can be -* used. +* Return true if @p can run on all possible CPUs, false otherwise. */ -static const struct cpumask *task_cpumask (const struct task_struct *p, -const struct cpumask *cpus_allowed, -const struct cpumask *cpus, -struct cpumask *local_cpus) +static inline bool task_affinity_all (const struct task_struct *p) { -/* -* If the task is allowed to run on all CPUs, simply use the -* architecture's cpumask directly. Otherwise, compute the -* intersection of the architecture's cpumask and the task's -* allowed cpumask. -*/ -if (!cpus ||task_allowed_all_cpus (p) ||cpumask_subset (cpus, cpus_allowed)) -return cpus; - -if (cpumask_and (local_cpus, cpus, cpus_allowed)) -return local_cpus; - -return NULL ; +return p->nr_cpus_allowed >=num_possible_cpus (); }/*
@@ -439,13 +418,15 @@ static const struct cpumask *task_cpumask(const struct task_struct *p,* branch prediction optimizations. * * 3. Pick a CPU within the same LLC (Last-Level Cache): -* - if the above conditions aren't met, pick a CPU that shares the same LLC -* to maintain cache locality. +* - if the above conditions aren't met, pick a CPU that shares the same +* LLC, if the LLC domain is a subset of @cpus_allowed, to maintain +* cache locality. * * 4. Pick a CPU within the same NUMA node, if enabled: -* - choose a CPU from the same NUMA node to reduce memory access latency. +* - choose a CPU from the same NUMA node, if the node cpumask is a +* subset of @cpus_allowed, to reduce memory access latency. * -* 5. Pick any idle CPU usable by the task. +* 5. Pick any idle CPU within the @cpus_allowed domain. * * Step 3 and 4 are performed only if the system has, respectively, * multiple LLCs / multiple NUMA nodes (see scx_selcpu_topo_llc and
@@ -464,9 +445,43 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, const struct cpumask *cpus_allowed, u64 flags) {const struct cpumask *llc_cpus =NULL , *numa_cpus =NULL ; -int node =scx_cpu_node_if_enabled (prev_cpu); +const struct cpumask *allowed = p->cpus_ptr; +int node;s32 cpu; +preempt_disable (); + +/* +* Determine the subset of CPUs usable by @p within @cpus_allowed. +*/ +if (cpus_allowed != p->cpus_ptr) { +struct cpumask *local_cpus =this_cpu_cpumask_var_ptr (local_idle_cpumask); + +if (task_affinity_all (p)) { + allowed = cpus_allowed; + }else if (cpumask_and (local_cpus, cpus_allowed, p->cpus_ptr)) { + allowed = local_cpus; + }else { + cpu = -EBUSY ; + goto out_enable; + } + } + +/* +* If @prev_cpu is not in the allowed domain, try to assign a new +* arbitrary CPU usable by the task in the allowed domain. +*/ +if (!cpumask_test_cpu (prev_cpu, allowed)) { + cpu =cpumask_any_and_distribute (p->cpus_ptr, allowed); +if (cpu < nr_cpu_ids) { + prev_cpu = cpu; + }else { + cpu = -EBUSY ; + goto out_enable; + } + } + node =scx_cpu_node_if_enabled (prev_cpu); +/* * This is necessary to protect llc_cpus. */
@@ -475,19 +490,28 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags,/* * Determine the subset of CPUs that the task can use in its * current LLC and node. +* +* If the task can run on all CPUs, use the node and LLC cpumasks +* directly. */ if (static_branch_maybe (CONFIG_NUMA , &scx_selcpu_topo_numa)) { - numa_cpus =task_cpumask (p, cpus_allowed,numa_span (prev_cpu), -this_cpu_cpumask_var_ptr (local_numa_idle_cpumask)); -if (cpumask_equal (numa_cpus, cpus_allowed)) - numa_cpus =NULL ; +struct cpumask *local_cpus =this_cpu_cpumask_var_ptr (local_numa_idle_cpumask); +const struct cpumask *cpus =numa_span (prev_cpu); + +if (allowed == p->cpus_ptr &&task_affinity_all (p)) + numa_cpus = cpus; +else if (cpus &&cpumask_and (local_cpus, allowed, cpus)) + numa_cpus = local_cpus; }if (static_branch_maybe (CONFIG_SCHED_MC , &scx_selcpu_topo_llc)) { - llc_cpus =task_cpumask (p, cpus_allowed,llc_span (prev_cpu), -this_cpu_cpumask_var_ptr (local_llc_idle_cpumask)); -if (cpumask_equal (llc_cpus, cpus_allowed)) - llc_cpus =NULL ; +struct cpumask *local_cpus =this_cpu_cpumask_var_ptr (local_llc_idle_cpumask); +const struct cpumask *cpus =llc_span (prev_cpu); + +if (allowed == p->cpus_ptr &&task_affinity_all (p)) + llc_cpus = cpus; +else if (cpus &&cpumask_and (local_cpus, allowed, cpus)) + llc_cpus = local_cpus; }/*
@@ -525,7 +549,7 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, cpu_rq(cpu)->scx.local_dsq.nr == 0 && (!(flags & SCX_PICK_IDLE_IN_NODE) || (waker_node == node)) && !cpumask_empty(idle_cpumask(waker_node)->cpu)) { -if (cpumask_test_cpu (cpu, cpus_allowed)) +if (cpumask_test_cpu (cpu, allowed)) goto out_unlock; } }
@@ -570,7 +594,7 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags,* begin in prev_cpu's node and proceed to other nodes in * order of increasing distance. */ - cpu =scx_pick_idle_cpu (cpus_allowed, node, flags |SCX_PICK_IDLE_CORE ); + cpu =scx_pick_idle_cpu (allowed, node, flags |SCX_PICK_IDLE_CORE );if (cpu >=0 ) goto out_unlock;
@@ -618,12 +642,14 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags,* in prev_cpu's node and proceed to other nodes in order of * increasing distance. */ - cpu =scx_pick_idle_cpu (cpus_allowed, node, flags); + cpu =scx_pick_idle_cpu (allowed, node, flags);if (cpu >=0 ) goto out_unlock; out_unlock:rcu_read_unlock (); +out_enable: +preempt_enable ();return cpu; }
@@ -655,6 +681,8 @@ void scx_idle_init_masks(void)/* Allocate local per-cpu idle cpumasks */ for_each_possible_cpu(i) { + BUG_ON(!alloc_cpumask_var_node(&per_cpu(local_idle_cpumask, i), + GFP_KERNEL, cpu_to_node(i))); BUG_ON(!alloc_cpumask_var_node(&per_cpu(local_llc_idle_cpumask, i), GFP_KERNEL, cpu_to_node(i))); BUG_ON(!alloc_cpumask_var_node(&per_cpu(local_numa_idle_cpumask, i),
Signature · 1 line
2.48.1
Andrea Righi
reviewerPATCH 4/6 sched_ext: idle: Introduce scx_bpf_select_cpu_and()
In reply to Andrea RighiProvide a new kfunc, scx_bpf_select_cpu_and(), that can be used to apply the built-in idle CPU selection policy to a subset of allowed CPU.
This new helper is basically an extension of scx_bpf_select_cpu_dfl(). However, when an idle CPU can't be found, it returns a negative value instead of @prev_cpu, aligning its behavior more closely with scx_bpf_pick_idle_cpu().
It also accepts %SCX_PICK_IDLE_* flags, which can be used to enforce strict selection to @prev_cpu's node (%SCX_PICK_IDLE_IN_NODE), or to request only a full-idle SMT core (%SCX_PICK_IDLE_CORE), while applying the built-in selection logic.
With this helper, BPF schedulers can apply the built-in idle CPU selection policy restricted to any arbitrary subset of CPUs.
Example usage
=============
Possible usage in ops.select_cpu():
s32 BPF_STRUCT_OPS(foo_select_cpu, struct task_struct *p,
s32 prev_cpu, u64 wake_flags)
{
const struct cpumask *cpus = task_allowed_cpus(p) ?: p->cpus_ptr;
s32 cpu;
cpu = scx_bpf_select_cpu_and(p, prev_cpu, wake_flags, cpus, 0);
if (cpu >= 0) {
scx_bpf_dsq_insert(p, SCX_DSQ_LOCAL, SCX_SLICE_DFL, 0);
return cpu;
}
return prev_cpu;
}Results
=======
Load distribution on a 4 sockets, 4 cores per socket system, simulated using virtme-ng, running a modified version of scx_bpfland that uses scx_bpf_select_cpu_and() with 0xff00 as the allowed subset of CPUs:
$ vng --cpu 16,sockets=4,cores=4,threads=1 ... $ stress-ng -c 16 ... $ htop ... 0[ 0.0%] 8[||||||||||||||||||||||||100.0%] 1[ 0.0%] 9[||||||||||||||||||||||||100.0%] 2[ 0.0%] 10[||||||||||||||||||||||||100.0%] 3[ 0.0%] 11[||||||||||||||||||||||||100.0%] 4[ 0.0%] 12[||||||||||||||||||||||||100.0%] 5[ 0.0%] 13[||||||||||||||||||||||||100.0%] 6[ 0.0%] 14[||||||||||||||||||||||||100.0%] 7[ 0.0%] 15[||||||||||||||||||||||||100.0%]
With scx_bpf_select_cpu_dfl() tasks would be distributed evenly across all the available CPUs.
--- kernel/sched/ext.c | 1 + kernel/sched/ext_idle.c | 43 ++++++++++++++++++++++++ tools/sched_ext/include/scx/common.bpf.h | 2 ++ 3 files changed, 46 insertions(+)
kernel/sched/ext.c +1 -0
@@ -465,6 +465,7 @@ struct sched_ext_ops {* idle CPU tracking and the following helpers become unavailable: * * - scx_bpf_select_cpu_dfl() +* - scx_bpf_select_cpu_and() * - scx_bpf_test_and_clear_cpu_idle() * - scx_bpf_pick_idle_cpu() *
kernel/sched/ext_idle.c +43 -0
55 lines not on this page · raw message
tools/sched_ext/include/scx/common.bpf.h +2 -0
@@ -48,6 +48,8 @@ static inline void ___vmlinux_h_sanity_check___(void) s32 scx_bpf_create_dsq(u64 dsq_id, s32 node) __ksym; s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, bool *is_idle) __ksym; +s32 scx_bpf_select_cpu_and(struct task_struct *p, s32 prev_cpu, u64 wake_flags, + const struct cpumask *cpus_allowed, u64 flags) __ksym __weak; void scx_bpf_dsq_insert(struct task_struct *p, u64 dsq_id, u64 slice, u64 enq_flags) __ksym __weak; void scx_bpf_dsq_insert_vtime(struct task_struct *p, u64 dsq_id, u64 slice, u64 vtime, u64 enq_flags) __ksym __weak; u32 scx_bpf_dispatch_nr_slots(void) __ksym;
Signature · 1 line
2.48.1
Andrea Righi
reviewerPATCH 5/6 selftests/sched_ext: Add test for scx_bpf_select_cpu_and()
In reply to Andrea RighiAdd a selftest to validate the behavior of the built-in idle CPU selection policy applied to a subset of allowed CPUs, using scx_bpf_select_cpu_and().
--- tools/testing/selftests/sched_ext/Makefile | 1 + .../selftests/sched_ext/allowed_cpus.bpf.c | 121 ++++++++++++++++++ .../selftests/sched_ext/allowed_cpus.c | 57 +++++++++ 3 files changed, 179 insertions(+) create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.bpf.c create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.c
tools/testing/selftests/sched_ext/Makefile +1 -0
@@ -173,6 +173,7 @@ auto-test-targets := \ maybe_null \ minimal \ numa \ + allowed_cpus \ prog_run \ reload_loop \ select_cpu_dfl \
tools/testing/selftests/sched_ext/allowed_cpus.bpf.c new file +121 -0
121 lines not on this page · raw message
tools/testing/selftests/sched_ext/allowed_cpus.c new file +57 -0
57 lines not on this page · raw message
Signature · 1 line
2.48.1
Andrea Righi
reviewerPATCH 6/6 sched_ext: idle: Deprecate scx_bpf_select_cpu_dfl()
In reply to Andrea RighiWith the introduction of scx_bpf_select_cpu_and(), we can deprecate scx_bpf_select_cpu_dfl(), as it offers only a subset of features and it's also more consistent with other idle-related APIs (returning a negative value when no idle CPU is found).
Therefore, mark scx_bpf_select_cpu_dfl() as deprecated (printing a warning when it's used), update all the scheduler examples and kselftests to adopt the new API, and ensure backward (source and binary) compatibility by providing the necessary macros and hooks.
Support for scx_bpf_select_cpu_dfl() can be maintained until v6.17.
--- Documentation/scheduler/sched-ext.rst | 11 +++--- kernel/sched/ext.c | 3 +- kernel/sched/ext_idle.c | 18 ++------- tools/sched_ext/include/scx/common.bpf.h | 3 +- tools/sched_ext/include/scx/compat.bpf.h | 37 +++++++++++++++++++ tools/sched_ext/scx_flatcg.bpf.c | 12 +++--- tools/sched_ext/scx_simple.bpf.c | 9 +++-- .../sched_ext/enq_select_cpu_fails.bpf.c | 12 +----- .../sched_ext/enq_select_cpu_fails.c | 2 +- tools/testing/selftests/sched_ext/exit.bpf.c | 6 ++- .../sched_ext/select_cpu_dfl_nodispatch.bpf.c | 13 +++---- .../sched_ext/select_cpu_dfl_nodispatch.c | 2 +- 12 files changed, 73 insertions(+), 55 deletions(-)
Documentation/scheduler/sched-ext.rst +5 -6
@@ -142,15 +142,14 @@ optional. The following modified excerpt is from s32 prev_cpu, u64 wake_flags) { s32 cpu; - /* Need to initialize or the BPF verifier will reject the program */ - bool direct = false; - cpu = scx_bpf_select_cpu_dfl(p, prev_cpu, wake_flags, &direct); - - if (direct) + cpu = scx_bpf_select_cpu_and(p, prev_cpu, wake_flags, p->cpus_ptr, 0); + if (cpu >= 0) scx_bpf_dsq_insert(p, SCX_DSQ_LOCAL, SCX_SLICE_DFL, 0); + return cpu; + } - return cpu; + return prev_cpu; } /*
kernel/sched/ext.c +1 -2
@@ -464,13 +464,12 @@ struct sched_ext_ops {* state. By default, implementing this operation disables the built-in * idle CPU tracking and the following helpers become unavailable: * -* - scx_bpf_select_cpu_dfl() * - scx_bpf_select_cpu_and() * - scx_bpf_test_and_clear_cpu_idle() * - scx_bpf_pick_idle_cpu() * * The user also must implement ops.select_cpu() as the default -* implementation relies on scx_bpf_select_cpu_dfl(). +* implementation relies on scx_bpf_select_cpu_and(). * * Specify the %SCX_OPS_KEEP_BUILTIN_IDLE flag to keep the built-in idle * tracking.
kernel/sched/ext_idle.c +4 -14
@@ -872,26 +872,16 @@ __bpf_kfunc int scx_bpf_cpu_node(s32 cpu)#endif } -/** -* scx_bpf_select_cpu_dfl - The default implementation of ops.select_cpu() -* @p: task_struct to select a CPU for -* @prev_cpu: CPU @p was on previously -* @wake_flags: %SCX_WAKE_* flags -* @is_idle: out parameter indicating whether the returned CPU is idle -* -* Can only be called from ops.select_cpu() if the built-in CPU selection is -* enabled - ops.update_idle() is missing or %SCX_OPS_KEEP_BUILTIN_IDLE is set. -* @p, @prev_cpu and @wake_flags match ops.select_cpu(). -* -* Returns the picked CPU with *@is_idle indicating whether the picked CPU is -* currently idle and thus a good candidate for direct dispatching. -*/ +/* Provided for backward binary compatibility, will be removed in v6.17. */ __bpf_kfunc s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu,u64 wake_flags,bool *is_idle) {#ifdef CONFIG_SMP s32 cpu;#endif +printk_deferred_once (KERN_WARNING +"sched_ext: scx_bpf_select_cpu_dfl() deprecated in favor of scx_bpf_select_cpu_and()" ); +if (!ops_cpu_valid (prev_cpu,NULL )) goto prev_cpu;
tools/sched_ext/include/scx/common.bpf.h +2 -1
@@ -47,7 +47,8 @@ static inline void ___vmlinux_h_sanity_check___(void) } s32 scx_bpf_create_dsq(u64 dsq_id, s32 node) __ksym; -s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, bool *is_idle) __ksym; +s32 scx_bpf_select_cpu_dfl(struct task_struct *p, + s32 prev_cpu, u64 wake_flags, bool *is_idle) __ksym __weak; s32 scx_bpf_select_cpu_and(struct task_struct *p, s32 prev_cpu, u64 wake_flags, const struct cpumask *cpus_allowed, u64 flags) __ksym __weak; void scx_bpf_dsq_insert(struct task_struct *p, u64 dsq_id, u64 slice, u64 enq_flags) __ksym __weak;
tools/sched_ext/include/scx/compat.bpf.h +37 -0
@@ -225,6 +225,43 @@ static inline bool __COMPAT_is_enq_cpu_selected(u64 enq_flags) scx_bpf_pick_any_cpu_node(cpus_allowed, node, flags) : \ scx_bpf_pick_any_cpu(cpus_allowed, flags)) +/** +* scx_bpf_select_cpu_dfl - The default implementation of ops.select_cpu(). +* We will preserve this compatible helper until v6.17. +* +* @p: task_struct to select a CPU for +* @prev_cpu: CPU @p was on previously +* @wake_flags: %SCX_WAKE_* flags +* @is_idle: out parameter indicating whether the returned CPU is idle +* +* Can only be called from ops.select_cpu() if the built-in CPU selection is +* enabled - ops.update_idle() is missing or %SCX_OPS_KEEP_BUILTIN_IDLE is set. +* @p, @prev_cpu and @wake_flags match ops.select_cpu(). +* +* Returns the picked CPU with *@is_idle indicating whether the picked CPU is +* currently idle and thus a good candidate for direct dispatching. +*/ +#define scx_bpf_select_cpu_dfl (p, prev_cpu, wake_flags, is_idle) \ +({ \ + s32 __cpu; \ + \ + if (bpf_ksym_exists(scx_bpf_select_cpu_and)) { \ + __cpu = scx_bpf_select_cpu_and((p), (prev_cpu), (wake_flags), \ + (p)->cpus_ptr, 0); \ + if (__cpu >= 0) { \ + *(is_idle) = true; \ + } else { \ + *(is_idle) = false; \ + __cpu = (prev_cpu); \ + } \ + } else { \ + __cpu = scx_bpf_select_cpu_dfl((p), (prev_cpu), \ + (wake_flags), (is_idle)); \ + } \ + \ + __cpu; \ +}) +/* * Define sched_ext_ops. This may be expanded to define multiple variants for * backward compatibility. See compat.h::SCX_OPS_LOAD/ATTACH().
tools/sched_ext/scx_flatcg.bpf.c +6 -6
@@ -317,15 +317,12 @@ static void set_bypassed_at(struct task_struct *p, struct fcg_task_ctx *taskc)s32 BPF_STRUCT_OPS (fcg_select_cpu ,struct task_struct *p,s32 prev_cpu,u64 wake_flags) {struct fcg_task_ctx *taskc; -bool is_idle = false;s32 cpu; - cpu =scx_bpf_select_cpu_dfl (p, prev_cpu, wake_flags, &is_idle); - taskc =bpf_task_storage_get (&task_ctx, p,0 ,0 );if (!taskc) {scx_bpf_error ("task_ctx lookup failed" ); -return cpu; +return prev_cpu; }/*
@@ -333,13 +330,16 @@ s32 BPF_STRUCT_OPS(fcg_select_cpu, struct task_struct *p, s32 prev_cpu, u64 wake* idle. Follow it and charge the cgroup later in fcg_stopping() after * the fact. */ -if (is_idle) { + cpu =scx_bpf_select_cpu_and (p, prev_cpu, wake_flags, p->cpus_ptr,0 ); +if (cpu >=0 ) {set_bypassed_at (p, taskc);stat_inc (FCG_STAT_LOCAL );scx_bpf_dsq_insert (p,SCX_DSQ_LOCAL ,SCX_SLICE_DFL ,0 ); + +return cpu; } -return cpu; +return prev_cpu; }void BPF_STRUCT_OPS (fcg_enqueue ,struct task_struct *p,u64 enq_flags)
tools/sched_ext/scx_simple.bpf.c +5 -4
@@ -54,16 +54,17 @@ static void stat_inc(u32 idx)s32 BPF_STRUCT_OPS (simple_select_cpu ,struct task_struct *p,s32 prev_cpu,u64 wake_flags) { -bool is_idle = false;s32 cpu; - cpu =scx_bpf_select_cpu_dfl (p, prev_cpu, wake_flags, &is_idle); -if (is_idle) { + cpu =scx_bpf_select_cpu_and (p, prev_cpu, wake_flags, p->cpus_ptr,0 ); +if (cpu >=0 ) {stat_inc (0 );/* count local queueing */ scx_bpf_dsq_insert (p,SCX_DSQ_LOCAL ,SCX_SLICE_DFL ,0 ); + +return cpu; } -return cpu; +return prev_cpu; }void BPF_STRUCT_OPS (simple_enqueue ,struct task_struct *p,u64 enq_flags)
tools/testing/selftests/sched_ext/enq_select_cpu_fails.bpf.c +1 -11
@@ -9,10 +9,6 @@ char _license[] SEC("license") = "GPL"; -/* Manually specify the signature until the kfunc is added to the scx repo. */ -s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, - bool *found) __ksym; -s32 BPF_STRUCT_OPS (enq_select_cpu_fails_select_cpu ,struct task_struct *p,s32 prev_cpu,u64 wake_flags) {
@@ -22,14 +18,8 @@ s32 BPF_STRUCT_OPS(enq_select_cpu_fails_select_cpu, struct task_struct *p,void BPF_STRUCT_OPS (enq_select_cpu_fails_enqueue ,struct task_struct *p,u64 enq_flags) { -/* -* Need to initialize the variable or the verifier will fail to load. -* Improving these semantics is actively being worked on. -*/ -bool found = false; -/* Can only call from ops.select_cpu() */ -scx_bpf_select_cpu_dfl (p,0 ,0 , &found); +scx_bpf_select_cpu_and (p,0 ,0 , p->cpus_ptr,0 );scx_bpf_dsq_insert (p,SCX_DSQ_GLOBAL ,SCX_SLICE_DFL , enq_flags); }
tools/testing/selftests/sched_ext/enq_select_cpu_fails.c +1 -1
@@ -52,7 +52,7 @@ static void cleanup(void *ctx)struct scx_test enq_select_cpu_fails = { .name ="enq_select_cpu_fails" , - .description ="Verify we fail to call scx_bpf_select_cpu_dfl() " + .description ="Verify we fail to call scx_bpf_select_cpu_and() " "from ops.enqueue()" , .setup = setup, .run = run,
tools/testing/selftests/sched_ext/exit.bpf.c +4 -2
@@ -20,12 +20,14 @@ UEI_DEFINE(uei);s32 BPF_STRUCT_OPS (exit_select_cpu ,struct task_struct *p,s32 prev_cpu,u64 wake_flags) { -bool found; +s32 cpu;if (exit_point ==EXIT_SELECT_CPU )EXIT_CLEANLY (); -return scx_bpf_select_cpu_dfl (p, prev_cpu, wake_flags, &found); + cpu =scx_bpf_select_cpu_and (p, prev_cpu, wake_flags, p->cpus_ptr,0 ); + +return cpu >=0 ? cpu : prev_cpu; }void BPF_STRUCT_OPS (exit_enqueue ,struct task_struct *p,u64 enq_flags)
tools/testing/selftests/sched_ext/select_cpu_dfl_nodispatch.bpf.c +6 -7
@@ -27,10 +27,6 @@ struct { __type(value, struct task_ctx); } task_ctx_stor SEC(".maps"); -/* Manually specify the signature until the kfunc is added to the scx repo. */ -s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, - bool *found) __ksym; -s32 BPF_STRUCT_OPS (select_cpu_dfl_nodispatch_select_cpu ,struct task_struct *p,s32 prev_cpu,u64 wake_flags) {
@@ -43,10 +39,13 @@ s32 BPF_STRUCT_OPS(select_cpu_dfl_nodispatch_select_cpu, struct task_struct *p,return -ESRCH ; } - cpu =scx_bpf_select_cpu_dfl (p, prev_cpu, wake_flags, - &tctx->force_local); + cpu =scx_bpf_select_cpu_and (p, prev_cpu, wake_flags, p->cpus_ptr,0 ); +if (cpu >=0 ) { + tctx->force_local = true; +return cpu; + } -return cpu; +return prev_cpu; } void BPF_STRUCT_OPS(select_cpu_dfl_nodispatch_enqueue, struct task_struct *p,
tools/testing/selftests/sched_ext/select_cpu_dfl_nodispatch.c +1 -1
@@ -66,7 +66,7 @@ static void cleanup(void *ctx)struct scx_test select_cpu_dfl_nodispatch = { .name ="select_cpu_dfl_nodispatch" , - .description ="Verify behavior of scx_bpf_select_cpu_dfl() in " + .description ="Verify behavior of scx_bpf_select_cpu_and() in " "ops.select_cpu()" , .setup = setup, .run = run,
Signature · 1 line
2.48.1
Quoted 26 lines · Andrea Righi
Many scx schedulers implement their own hard or soft-affinity rules to support topology characteristics, such as heterogeneous architectures (e.g., big.LITTLE, P-cores/E-cores), or to categorize tasks based on specific properties (e.g., running certain tasks only in a subset of CPUs).
Currently, there is no mechanism that allows to use the built-in idle CPU selection policy to an arbitrary subset of CPUs. As a result, schedulers often implement their own idle CPU selection policies, which are typically similar to one another, leading to a lot of code duplication.
To address this, extend the built-in idle CPU selection policy introducing the concept of allowed CPUs.
With this concept, BPF schedulers can apply the built-in idle CPU selection policy to a subset of allowed CPUs, allowing them to implement their own hard/soft-affinity rules while still using the topology optimizations of the built-in policy, preventing code duplication across different schedulers.
To implement this introduce a new helper kfunc
scx_bpf_select_cpu_and()that accepts a cpumask of allowed CPUs:s32 scx_bpf_select_cpu_and(struct
task_struct*p, s32prev_cpu,u64 wake_flags, const struct cpumask *cpus_allowed, u64 flags);
Quoted 8 lines
Example usage
=============s32 BPF_STRUCT_OPS(foo_select_cpu, struct
task_struct*p,s32 prev_cpu, u64 wake_flags) { const struct cpumask *cpus = task_allowed_cpus(p) ?: p->cpus_ptr; s32 cpu;
Andrea, I'm curious why cannot this expression simply be moved into the default select implementation? And then for those that need a more custom mask, we can do the scx_bpf_select_cpu_and() as a second step.
Also I think I am missing, what is the motivation in the existing code to not do LLC/NUMA-only scans if the task is restrained? Thanks for clarifying.
thanks,
- Joel
Quoted 89 lines
cpu = scx_bpf_select_cpu_and(p, prev_cpu, wake_flags, cpus, 0); if (cpu >= 0) { scx_bpf_dsq_insert(p, SCX_DSQ_LOCAL, SCX_SLICE_DFL, 0); return cpu; } return prev_cpu; }Results
=======Load distribution on a 4 sockets / 4 cores per socket system, simulated using virtme-ng, running a modified version of
scx_bpflandthat uses the new helperscx_bpf_select_cpu_and()and0xff00as allowed domain:$ vng --cpu 16,sockets=4,cores=4,threads=1 ... $ stress-ng -c 16 ... $ htop ... 0[ 0.0%] 8[||||||||||||||||||||||||100.0%] 1[ 0.0%] 9[||||||||||||||||||||||||100.0%] 2[ 0.0%] 10[||||||||||||||||||||||||100.0%] 3[ 0.0%] 11[||||||||||||||||||||||||100.0%] 4[ 0.0%] 12[||||||||||||||||||||||||100.0%] 5[ 0.0%] 13[||||||||||||||||||||||||100.0%] 6[ 0.0%] 14[||||||||||||||||||||||||100.0%] 7[ 0.0%] 15[||||||||||||||||||||||||100.0%]With
scx_bpf_select_cpu_dfl()tasks would be distributed evenly across all the available CPUs.ChangeLog v4 -> v5:
- simplify the code to compute (and) task's temporary cpumasksChangeLog v3 -> v4:
- keepp->nr_cpus_allowedoptimizations (skip cpumask operations when the task can run on all CPUs)
- allow to callscx_bpf_select_cpu_and()also fromops.enqueue()and modify the kselftest to cover this case as well
- rebase to the latest sched_ext/for-6.15ChangeLog v2 -> v3:
- incrementally refactorscx_select_cpu_dfl()to accept idle flags and an arbitrary allowed cpumask
- buildscx_bpf_select_cpu_and()on top of the existing logic
- re-arrangescx_select_cpu_dfl()prototype, aligning the first three arguments withselect_task_rq()
- do not use "domain" for the allowed cpumask to avoid potential ambiguity withsched_domainChangeLog v1 -> v2:
- renamescx_bpf_select_cpu_pref()toscx_bpf_select_cpu_and()and always select idle CPUs strictly within the allowed domain
- rename preferred CPUs -> allowed CPU
- drop %SCX_PICK_IDLE_IN_PREF (not required anymore)
- deprecatescx_bpf_select_cpu_dfl()in favor ofscx_bpf_select_cpu_and()and provide all the required backward compatibility boilerplateAndrea Righi (6):
sched_ext: idle: Extend topology optimizations to all tasks
sched_ext: idle: Explicitly pass allowed cpumask toscx_select_cpu_dfl()
sched_ext: idle: Accept an arbitrary cpumask inscx_select_cpu_dfl()
sched_ext: idle: Introducescx_bpf_select_cpu_and()selftests/sched_ext: Add test forscx_bpf_select_cpu_and()
sched_ext: idle: Deprecatescx_bpf_select_cpu_dfl()Documentation/scheduler/sched-ext.rst | 11 +- kernel/sched/ext.c | 6 +- kernel/sched/ext_idle.c | 196 ++++++++++++++++----- kernel/sched/ext_idle.h | 3 +- tools/sched_ext/include/scx/common.bpf.h | 5 +- tools/sched_ext/include/scx/compat.bpf.h | 37 ++++ tools/sched_ext/scx_flatcg.bpf.c | 12 +- tools/sched_ext/scx_simple.bpf.c | 9 +- tools/testing/selftests/sched_ext/Makefile | 1 + .../testing/selftests/sched_ext/allowed_cpus.bpf.c | 121 +++++++++++++ tools/testing/selftests/sched_ext/allowed_cpus.c | 57 ++++++ .../selftests/sched_ext/enq_select_cpu_fails.bpf.c | 12 +- .../selftests/sched_ext/enq_select_cpu_fails.c | 2 +- tools/testing/selftests/sched_ext/exit.bpf.c | 6 +- .../sched_ext/select_cpu_dfl_nodispatch.bpf.c | 13 +- .../sched_ext/select_cpu_dfl_nodispatch.c | 2 +- 16 files changed, 404 insertions(+), 89 deletions(-) create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.bpf.c create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.c
Andrea Righi
reviewerQuoted 1 line · Joel Fernandes
On 3/20/2025 8:36 AM, Andrea Righi wrote:
...
Quoted 9 lines
Quoted 8 lines
Example usage
=============s32 BPF_STRUCT_OPS(foo_select_cpu, struct
task_struct*p,s32 prev_cpu, u64 wake_flags) { const struct cpumask *cpus = task_allowed_cpus(p) ?: p->cpus_ptr; s32 cpu;
Quoted 3 lines
Andrea, I'm curious why cannot this expression simply be moved into the default select implementation? And then for those that need a more custom mask, we can do the
scx_bpf_select_cpu_and()as a second step.
Yeah, maybe the example could be improved a bit. Basically I'm doing task_allowed_cpus(p) ?: p->cpus_ptr to highlight that you can't pass NULL as the extra "and" cpumask (otherwise the verifier won't be happy).
Also, if you call the old scx_bpf_select_cpu_dfl(), the internal logic already uses the same backend as scx_bpf_select_cpu_and() passing p->cpus_ptr as @cpus_allowed.
Quoted 3 lines
Also I think I am missing, what is the motivation in the existing code to not do LLC/NUMA-only scans if the task is restrained? Thanks for clarifying.
You can use the "flags" argument to restrict the selection to the current node, setting SCX_PICK_IDLE_IN_NODE.
We currently don't have a SCX_PICK_IDLE_IN_LLC flag (it'd be nice to introduce it), so currently the only way to restrict the selection to the current LLC is to use the additional "and" cpumask (@cpus_allowed), passing the LLC span.
Thanks,
-Andrea
Quoted 97 lines
thanks,
- Joel
Quoted 89 lines
cpu = scx_bpf_select_cpu_and(p, prev_cpu, wake_flags, cpus, 0); if (cpu >= 0) { scx_bpf_dsq_insert(p, SCX_DSQ_LOCAL, SCX_SLICE_DFL, 0); return cpu; } return prev_cpu; }Results
=======Load distribution on a 4 sockets / 4 cores per socket system, simulated using virtme-ng, running a modified version of
scx_bpflandthat uses the new helperscx_bpf_select_cpu_and()and0xff00as allowed domain:$ vng --cpu 16,sockets=4,cores=4,threads=1 ... $ stress-ng -c 16 ... $ htop ... 0[ 0.0%] 8[||||||||||||||||||||||||100.0%] 1[ 0.0%] 9[||||||||||||||||||||||||100.0%] 2[ 0.0%] 10[||||||||||||||||||||||||100.0%] 3[ 0.0%] 11[||||||||||||||||||||||||100.0%] 4[ 0.0%] 12[||||||||||||||||||||||||100.0%] 5[ 0.0%] 13[||||||||||||||||||||||||100.0%] 6[ 0.0%] 14[||||||||||||||||||||||||100.0%] 7[ 0.0%] 15[||||||||||||||||||||||||100.0%]With
scx_bpf_select_cpu_dfl()tasks would be distributed evenly across all the available CPUs.ChangeLog v4 -> v5:
- simplify the code to compute (and) task's temporary cpumasksChangeLog v3 -> v4:
- keepp->nr_cpus_allowedoptimizations (skip cpumask operations when the task can run on all CPUs)
- allow to callscx_bpf_select_cpu_and()also fromops.enqueue()and modify the kselftest to cover this case as well
- rebase to the latest sched_ext/for-6.15ChangeLog v2 -> v3:
- incrementally refactorscx_select_cpu_dfl()to accept idle flags and an arbitrary allowed cpumask
- buildscx_bpf_select_cpu_and()on top of the existing logic
- re-arrangescx_select_cpu_dfl()prototype, aligning the first three arguments withselect_task_rq()
- do not use "domain" for the allowed cpumask to avoid potential ambiguity withsched_domainChangeLog v1 -> v2:
- renamescx_bpf_select_cpu_pref()toscx_bpf_select_cpu_and()and always select idle CPUs strictly within the allowed domain
- rename preferred CPUs -> allowed CPU
- drop %SCX_PICK_IDLE_IN_PREF (not required anymore)
- deprecatescx_bpf_select_cpu_dfl()in favor ofscx_bpf_select_cpu_and()and provide all the required backward compatibility boilerplateAndrea Righi (6):
sched_ext: idle: Extend topology optimizations to all tasks
sched_ext: idle: Explicitly pass allowed cpumask toscx_select_cpu_dfl()
sched_ext: idle: Accept an arbitrary cpumask inscx_select_cpu_dfl()
sched_ext: idle: Introducescx_bpf_select_cpu_and()selftests/sched_ext: Add test forscx_bpf_select_cpu_and()
sched_ext: idle: Deprecatescx_bpf_select_cpu_dfl()Documentation/scheduler/sched-ext.rst | 11 +- kernel/sched/ext.c | 6 +- kernel/sched/ext_idle.c | 196 ++++++++++++++++----- kernel/sched/ext_idle.h | 3 +- tools/sched_ext/include/scx/common.bpf.h | 5 +- tools/sched_ext/include/scx/compat.bpf.h | 37 ++++ tools/sched_ext/scx_flatcg.bpf.c | 12 +- tools/sched_ext/scx_simple.bpf.c | 9 +- tools/testing/selftests/sched_ext/Makefile | 1 + .../testing/selftests/sched_ext/allowed_cpus.bpf.c | 121 +++++++++++++ tools/testing/selftests/sched_ext/allowed_cpus.c | 57 ++++++ .../selftests/sched_ext/enq_select_cpu_fails.bpf.c | 12 +- .../selftests/sched_ext/enq_select_cpu_fails.c | 2 +- tools/testing/selftests/sched_ext/exit.bpf.c | 6 +- .../sched_ext/select_cpu_dfl_nodispatch.bpf.c | 13 +- .../sched_ext/select_cpu_dfl_nodispatch.c | 2 +- 16 files changed, 404 insertions(+), 89 deletions(-) create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.bpf.c create mode 100644 tools/testing/selftests/sched_ext/allowed_cpus.c