Skip to contentSkip to conversation

spdx30: handle links to inaccessible locations

PATCH In review Peter Marko 3 participants 7 messages Mar 20, 2025 – Mar 22, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spdx30: handle links to inaccessible locations

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

When a link is pointing to location inaccessible to build user (e.g. "/root/something"), filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/spdx30_tasks.py +1 -1
index 0618f2f139..bba11ae930 100644
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
             relpath = str(fpath.relative_to(image_rootfs))
Reviewed-by on v1 1/1
#1 lore raw

LGTM, Thanks

Quoted 37 lines · Peter Marko via lists.openembedded.org

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

When a link is pointing to location inaccessible to build user (e.g. "/root/something"), filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/spdx30_tasks.py +1 -2
index 0618f2f139..bba11ae930 100644
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
             relpath = str(fpath.relative_to(image_rootfs))
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#213385): https://lists.openembedded.org/g/openembedded-core/message/213385
Mute This Topic: https://lists.openembedded.org/mt/111807091/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
In reply to Peter Marko
Quoted 5 lines · Peter Marko

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

Quoted 8 lines

When a link is pointing to location inaccessible to build user (e.g. "/root/something"), filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This commit breaks building recipes here:

ERROR: quilt-native-0.68-r0 do_create_spdx: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

     0001:
 *** 0002:do_create_spdx(d)
     0003:
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-core/meta/classes/create-spdx-3.0.bbclass', lineno: 135, function: do_create_spdx
     0131:    "
     0132:
     0133:python do_create_spdx() {
     0134:    import oe.spdx30_tasks
 *** 0135:    oe.spdx30_tasks.create_spdx(d)
     0136:}
     0137:do_create_spdx[vardeps] += "\
     0138:    SPDX_INCLUDE_BITBAKE_PARENT_BUILD \
     0139:    SPDX_PACKAGE_ADDITIONAL_PURPOSE \
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-core/meta/lib/oe/spdx30_tasks.py', lineno: 537, function: create_spdx
     0533:            )
     0534:
     0535:    cpe_ids = oe.cve_check.get_cpe_ids(d.getVar("CVE_PRODUCT"), d.getVar("CVE_VERSION"))
     0536:
 *** 0537:    source_files = add_download_files(d, build_objset)
     0538:    build_inputs |= source_files
     0539:
     0540:    recipe_spdx_license = add_license_expression(
     0541:        d, build_objset, d.getVar("LICENSE"), license_data
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-core/meta/lib/oe/spdx30_tasks.py', lineno: 408, function: add_download_files
     0404:                    creationInfo=objset.doc.creationInfo,
     0405:                    name=file_name,
     0406:                    software_primaryPurpose=primary_purpose,
     0407:                    software_downloadLocation=oe.spdx_common.fetch_data_to_uri(
 *** 0408:                        fd, fd.name
     0409:                    ),
     0410:                )
     0411:            )
     0412:

Exception: AttributeError: 'FetchData' object has no attribute 'name'

ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp-nodistro/work/x86_64-linux/quilt-native/0.68/temp/log.do_create_spdx.3116916
ERROR: Task (/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-core/meta/recipes-devtools/quilt/quilt-native_0.68.bb:do_create_spdx) failed with exit code '1'

Reverting this commit makes the error disappear.

Quoted 15 lines
meta/lib/oe/spdx30_tasks.py +1 -1
index 0618f2f139..bba11ae930 100644
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
             relpath = str(fpath.relative_to(image_rootfs))
Signature · 2 lines
With best wishes
Dmitry
#3 lore raw

I think there is something else breaking your build.

My commit changed function create_rootfs_spdx.
That should not influence recipe spdx code...
Did you try a build with my commit reverted?

Peter

Quoted 97 lines

-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Friday, March 21, 2025 13:38
To: Marko, Peter (FT D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core][PATCH] spdx30: handle links to inaccessible locations

Quoted 6 lines · Peter Marko

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

When a link is pointing to location inaccessible to build user (e.g.

"/root/something"),

Quoted 7 lines

filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This commit breaks building recipes here:

ERROR: quilt-native-0.68-r0 do_create_spdx: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

     0001:
 *** 0002:do_create_spdx(d)
     0003:
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/classes/create-spdx-3.0.bbclass', lineno: 135, function: do_create_spdx
     0131:    "
     0132:
     0133:python do_create_spdx() {
     0134:    import oe.spdx30_tasks
 *** 0135:    oe.spdx30_tasks.create_spdx(d)
     0136:}
     0137:do_create_spdx[vardeps] += "\
     0138:    SPDX_INCLUDE_BITBAKE_PARENT_BUILD \
     0139:    SPDX_PACKAGE_ADDITIONAL_PURPOSE \
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 537, function: create_spdx
     0533:            )
     0534:
     0535:    cpe_ids = oe.cve_check.get_cpe_ids(d.getVar("CVE_PRODUCT"),
d.getVar("CVE_VERSION"))
     0536:
 *** 0537:    source_files = add_download_files(d, build_objset)
     0538:    build_inputs |= source_files
     0539:
     0540:    recipe_spdx_license = add_license_expression(
     0541:        d, build_objset, d.getVar("LICENSE"), license_data
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 408, function: add_download_files
     0404:                    creationInfo=objset.doc.creationInfo,
     0405:                    name=file_name,
     0406:                    software_primaryPurpose=primary_purpose,
     0407:
software_downloadLocation=oe.spdx_common.fetch_data_to_uri(
 *** 0408:                        fd, fd.name
     0409:                    ),
     0410:                )
     0411:            )
     0412:

Exception: AttributeError: 'FetchData' object has no attribute 'name'

ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp- nodistro/work/x86_64-linux/quilt-native/0.68/temp/log.do_create_spdx.3116916
ERROR: Task (/home/lumag/Projects/RPB/build- rpb/conf/../../layers/openembedded-core/meta/recipes-devtools/quilt/quilt- native_0.68.bb:do_create_spdx) failed with exit code '1'

Reverting this commit makes the error disappear.

Quoted 7 lines
meta/lib/oe/spdx30_tasks.py +0 -0
index 0618f2f139..bba11ae930 100644

meta/lib/oe/spdx30_tasks.py def create_rootfs_spdx(d): · line 1074

Quoted 8 lines
meta/lib/oe/spdx30_tasks.py +1 -1
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
             relpath = str(fpath.relative_to(image_rootfs))

--
With best wishes
Dmitry

#4 lore raw
Quoted 6 lines · Peter

I think there is something else breaking your build.

My commit changed function create_rootfs_spdx.
That should not influence recipe spdx code...
Did you try a build with my commit reverted?

As I wrote, reverting it makes the error disappear.

Quoted 100 lines

Peter

Quoted 97 lines

-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Friday, March 21, 2025 13:38
To: Marko, Peter (FT D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core][PATCH] spdx30: handle links to inaccessible locations

Quoted 6 lines · Peter Marko

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

When a link is pointing to location inaccessible to build user (e.g.

"/root/something"),

Quoted 7 lines

filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This commit breaks building recipes here:

ERROR: quilt-native-0.68-r0 do_create_spdx: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

     0001:
 *** 0002:do_create_spdx(d)
     0003:
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/classes/create-spdx-3.0.bbclass', lineno: 135, function: do_create_spdx
     0131:    "
     0132:
     0133:python do_create_spdx() {
     0134:    import oe.spdx30_tasks
 *** 0135:    oe.spdx30_tasks.create_spdx(d)
     0136:}
     0137:do_create_spdx[vardeps] += "\
     0138:    SPDX_INCLUDE_BITBAKE_PARENT_BUILD \
     0139:    SPDX_PACKAGE_ADDITIONAL_PURPOSE \
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 537, function: create_spdx
     0533:            )
     0534:
     0535:    cpe_ids = oe.cve_check.get_cpe_ids(d.getVar("CVE_PRODUCT"),
d.getVar("CVE_VERSION"))
     0536:
 *** 0537:    source_files = add_download_files(d, build_objset)
     0538:    build_inputs |= source_files
     0539:
     0540:    recipe_spdx_license = add_license_expression(
     0541:        d, build_objset, d.getVar("LICENSE"), license_data
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 408, function: add_download_files
     0404:                    creationInfo=objset.doc.creationInfo,
     0405:                    name=file_name,
     0406:                    software_primaryPurpose=primary_purpose,
     0407:
software_downloadLocation=oe.spdx_common.fetch_data_to_uri(
 *** 0408:                        fd, fd.name
     0409:                    ),
     0410:                )
     0411:            )
     0412:

Exception: AttributeError: 'FetchData' object has no attribute 'name'

ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp- nodistro/work/x86_64-linux/quilt-native/0.68/temp/log.do_create_spdx.3116916
ERROR: Task (/home/lumag/Projects/RPB/build- rpb/conf/../../layers/openembedded-core/meta/recipes-devtools/quilt/quilt- native_0.68.bb:do_create_spdx) failed with exit code '1'

Reverting this commit makes the error disappear.

Quoted 7 lines
meta/lib/oe/spdx30_tasks.py +0 -0
index 0618f2f139..bba11ae930 100644

meta/lib/oe/spdx30_tasks.py def create_rootfs_spdx(d): · line 1074

Quoted 8 lines
meta/lib/oe/spdx30_tasks.py +1 -1
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
             relpath = str(fpath.relative_to(image_rootfs))

--
With best wishes
Dmitry

Signature · 2 lines
With best wishes
Dmitry
#5 lore raw

I believe that you have a problem with:
* commit https://git.openembedded.org/openembedded-core/commit/?id=4859cdf97fd9a260036e148e25f0b78eb393df1e
* commit https://git.openembedded.org/bitbake/commit/?id=2515fbd10824005fa7f34e87706000c079920366
Using new oe-core without matching bitbake change will lead to unknown attribute name since it was changed from names to name in both commits together.

I can cleanly build core-image-minimal with spdx3 from latest poky master (which contains matching oe-core and bitbake versions). Maybe you have reverted whole oe-core update and not just my commit when looking for the breaking change?

Peter

Quoted 125 lines

-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Friday, March 21, 2025 14:10
To: Marko, Peter (FT D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core][PATCH] spdx30: handle links to inaccessible locations

Quoted 6 lines · Peter

I think there is something else breaking your build.

My commit changed function create_rootfs_spdx.
That should not influence recipe spdx code...
Did you try a build with my commit reverted?

As I wrote, reverting it makes the error disappear.

Quoted 29 lines

Peter

Quoted 26 lines

-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Friday, March 21, 2025 13:38
To: Marko, Peter (FT D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core][PATCH] spdx30: handle links to inaccessible locations

Quoted 6 lines · Peter Marko

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

When a link is pointing to location inaccessible to build user (e.g.

"/root/something"),

Quoted 7 lines

filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This commit breaks building recipes here:

ERROR: quilt-native-0.68-r0 do_create_spdx: Error executing a python function

in

Quoted 9 lines
Quoted 9 lines

exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

     0001:
 *** 0002:do_create_spdx(d)
     0003:

File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded- core/meta/classes/create-spdx-3.0.bbclass', lineno: 135, function:

do_create_spdx

Quoted 56 lines
Quoted 56 lines
     0131:    "
     0132:
     0133:python do_create_spdx() {
     0134:    import oe.spdx30_tasks
 *** 0135:    oe.spdx30_tasks.create_spdx(d)
     0136:}
     0137:do_create_spdx[vardeps] += "\
     0138:    SPDX_INCLUDE_BITBAKE_PARENT_BUILD \
     0139:    SPDX_PACKAGE_ADDITIONAL_PURPOSE \
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 537, function: create_spdx
     0533:            )
     0534:
     0535:    cpe_ids = oe.cve_check.get_cpe_ids(d.getVar("CVE_PRODUCT"),
d.getVar("CVE_VERSION"))
     0536:
 *** 0537:    source_files = add_download_files(d, build_objset)
     0538:    build_inputs |= source_files
     0539:
     0540:    recipe_spdx_license = add_license_expression(
     0541:        d, build_objset, d.getVar("LICENSE"), license_data
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 408, function: add_download_files
     0404:                    creationInfo=objset.doc.creationInfo,
     0405:                    name=file_name,
     0406:                    software_primaryPurpose=primary_purpose,
     0407:
software_downloadLocation=oe.spdx_common.fetch_data_to_uri(
 *** 0408:                        fd, fd.name
     0409:                    ),
     0410:                )
     0411:            )
     0412:

Exception: AttributeError: 'FetchData' object has no attribute 'name'

ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp- nodistro/work/x86_64-linux/quilt-native/0.68/temp/log.do_create_spdx.3116916
ERROR: Task (/home/lumag/Projects/RPB/build- rpb/conf/../../layers/openembedded-core/meta/recipes-devtools/quilt/quilt- native_0.68.bb:do_create_spdx) failed with exit code '1'

Reverting this commit makes the error disappear.

Quoted 13 lines
meta/lib/oe/spdx30_tasks.py +1 -1
index 0618f2f139..bba11ae930 100644
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
Quoted 6 lines
Quoted 6 lines

meta/lib/oe/spdx30_tasks.py def create_rootfs_spdx(d): · line 1074

Quoted 2 lines
meta/lib/oe/spdx30_tasks.py +0 -0
             relpath = str(fpath.relative_to(image_rootfs))

--
With best wishes
Dmitry

--
With best wishes
Dmitry

#6 lore raw
Quoted 7 lines · Peter

I believe that you have a problem with:
* commit https://git.openembedded.org/openembedded-core/commit/?id=4859cdf97fd9a260036e148e25f0b78eb393df1e
* commit https://git.openembedded.org/bitbake/commit/?id=2515fbd10824005fa7f34e87706000c079920366
Using new oe-core without matching bitbake change will lead to unknown attribute name since it was changed from names to name in both commits together.

I can cleanly build core-image-minimal with spdx3 from latest poky master (which contains matching oe-core and bitbake versions). Maybe you have reverted whole oe-core update and not just my commit when looking for the breaking change?

Most likely I was unfortunate or there was some repo issue. Afre running repo sync again, the build succeeds even without a revert. Please excuse me for the noise.

Quoted 128 lines

Peter

Quoted 125 lines

-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Friday, March 21, 2025 14:10
To: Marko, Peter (FT D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core][PATCH] spdx30: handle links to inaccessible locations

Quoted 6 lines · Peter

I think there is something else breaking your build.

My commit changed function create_rootfs_spdx.
That should not influence recipe spdx code...
Did you try a build with my commit reverted?

As I wrote, reverting it makes the error disappear.

Quoted 29 lines

Peter

Quoted 26 lines

-----Original Message-----
From: Dmitry Baryshkov <[email protected]>
Sent: Friday, March 21, 2025 13:38
To: Marko, Peter (FT D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core][PATCH] spdx30: handle links to inaccessible locations

Quoted 6 lines · Peter Marko

From: Peter Marko <[email protected]>

This is the same as e105befbe4ee0d85e94c2048a744f0373e2dbcdf on additional place in the code.

When a link is pointing to location inaccessible to build user (e.g.

"/root/something"),

Quoted 7 lines

filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link.

---
 meta/lib/oe/spdx30_tasks.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This commit breaks building recipes here:

ERROR: quilt-native-0.68-r0 do_create_spdx: Error executing a python function

in

Quoted 9 lines
Quoted 9 lines

exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

     0001:
 *** 0002:do_create_spdx(d)
     0003:

File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded- core/meta/classes/create-spdx-3.0.bbclass', lineno: 135, function:

do_create_spdx

Quoted 56 lines
Quoted 56 lines
     0131:    "
     0132:
     0133:python do_create_spdx() {
     0134:    import oe.spdx30_tasks
 *** 0135:    oe.spdx30_tasks.create_spdx(d)
     0136:}
     0137:do_create_spdx[vardeps] += "\
     0138:    SPDX_INCLUDE_BITBAKE_PARENT_BUILD \
     0139:    SPDX_PACKAGE_ADDITIONAL_PURPOSE \
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 537, function: create_spdx
     0533:            )
     0534:
     0535:    cpe_ids = oe.cve_check.get_cpe_ids(d.getVar("CVE_PRODUCT"),
d.getVar("CVE_VERSION"))
     0536:
 *** 0537:    source_files = add_download_files(d, build_objset)
     0538:    build_inputs |= source_files
     0539:
     0540:    recipe_spdx_license = add_license_expression(
     0541:        d, build_objset, d.getVar("LICENSE"), license_data
File: '/home/lumag/Projects/RPB/build-rpb/conf/../../layers/openembedded-
core/meta/lib/oe/spdx30_tasks.py', lineno: 408, function: add_download_files
     0404:                    creationInfo=objset.doc.creationInfo,
     0405:                    name=file_name,
     0406:                    software_primaryPurpose=primary_purpose,
     0407:
software_downloadLocation=oe.spdx_common.fetch_data_to_uri(
 *** 0408:                        fd, fd.name
     0409:                    ),
     0410:                )
     0411:            )
     0412:

Exception: AttributeError: 'FetchData' object has no attribute 'name'

ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp- nodistro/work/x86_64-linux/quilt-native/0.68/temp/log.do_create_spdx.3116916
ERROR: Task (/home/lumag/Projects/RPB/build- rpb/conf/../../layers/openembedded-core/meta/recipes-devtools/quilt/quilt- native_0.68.bb:do_create_spdx) failed with exit code '1'

Reverting this commit makes the error disappear.

Quoted 13 lines
meta/lib/oe/spdx30_tasks.py +1 -1
index 0618f2f139..bba11ae930 100644
@@ -1068,7 +1068,7 @@ def create_rootfs_spdx(d):
         filenames.sort()
         for fn in filenames:
             fpath = Path(dirpath) / fn
-            if not fpath.is_file() or fpath.is_symlink():
+            if fpath.is_symlink() or not fpath.is_file():
                 continue
 
Quoted 6 lines
Quoted 6 lines

meta/lib/oe/spdx30_tasks.py def create_rootfs_spdx(d): · line 1074

Quoted 2 lines
meta/lib/oe/spdx30_tasks.py +0 -0
             relpath = str(fpath.relative_to(image_rootfs))

--
With best wishes
Dmitry

--
With best wishes
Dmitry

Signature · 2 lines
With best wishes
Dmitry