Skip to contentSkip to conversation

tst_test: Add TCONF when no required filesystems are available

PATCH In review Li Wang via ltp 3 participants 4 messages Mar 21, 2025 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tst_test: Add TCONF when no required filesystems are available

Currently, when no required filesystems (filesystem[i].type) are available, the test silently does nothing, leading to a misleading test summary.

This patch adds a check to issue TCONF when no valid filesystems are found, ensuring clearer test results.

  # ./ioctl_ficlone03
  tst_buffers.c:57: TINFO: Test is using guarded buffers
  tst_tmpdir.c:317: TINFO: Using /tmp/LTP_iocSKLS9l as tmpdir (tmpfs filesystem)
  tst_device.c:99: TINFO: Found free device 0 '/dev/loop0'
  tst_test.c:1900: TINFO: LTP version: 20250130-166-g17960d952
  tst_test.c:1904: TINFO: Tested kernel: 4.5.0-00002-g22bd332f11d4 #162 SMP Thu Mar 20 18:00:10 CET 2025 x86_64
  tst_kconfig.c:88: TINFO: Parsing kernel config '/.config'
  tst_test.c:1724: TINFO: Overall timeout per run is 0h 00m 31s
  tst_supported_fs_types.c:97: TINFO: Kernel supports ext2
  tst_supported_fs_types.c:62: TINFO: mkfs.ext2 does exist
  tst_supported_fs_types.c:97: TINFO: Kernel supports ext3
  tst_supported_fs_types.c:62: TINFO: mkfs.ext3 does exist
  tst_supported_fs_types.c:97: TINFO: Kernel supports ext4
  tst_supported_fs_types.c:62: TINFO: mkfs.ext4 does exist
  tst_supported_fs_types.c:105: TINFO: Skipping bcachefs because of FUSE blacklist
  tst_supported_fs_types.c:97: TINFO: Kernel supports vfat
  tst_supported_fs_types.c:62: TINFO: mkfs.vfat does exist
  tst_supported_fs_types.c:97: TINFO: Kernel supports tmpfs
  tst_supported_fs_types.c:49: TINFO: mkfs is not needed for tmpfs

Summary:

  passed   0
  failed   0
  broken   0
  skipped  0

warnings 0

---
 lib/tst_test.c | 5 +++++
 1 file changed, 5 insertions(+)
lib/tst_test.c +5 -0
index 3823ea109..9a23cd4a0 100644
@@ -1855,6 +1855,7 @@ static int run_tcases_per_fs(void)
 {
 	int ret = 0;
 	unsigned int i;
+	bool found_valid_fs = false;
 	const char *const *filesystems = tst_get_supported_fs_types(tst_test->skip_filesystems);
 
 	if (!filesystems[0])
@@ -1866,6 +1867,7 @@ static int run_tcases_per_fs(void)
 		if (!fs)
 			continue;
 
+		found_valid_fs = true;
 		ret = run_tcase_on_fs(fs, filesystems[i]);
 
 		if (ret == TCONF)
@@ -1877,6 +1879,9 @@ static int run_tcases_per_fs(void)
 		do_exit(ret);
 	}
 
+	if (!found_valid_fs)
+		tst_brk(TCONF, "No required filesystems are available");
+
 	return ret;
 }
 
Signature · 5 lines
2.48.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by Tested-by on v1 1/1
#1 lore raw

Hi Li,

Quoted 5 lines

Currently, when no required filesystems (filesystem[i].type) are available, the test silently does nothing, leading to a misleading test summary.

This patch adds a check to issue TCONF when no valid filesystems are found, ensuring clearer test results.

Thanks!

Kind regards,
Petr

Quoted 38 lines
  # ./ioctl_ficlone03
  tst_buffers.c:57: TINFO: Test is using guarded buffers
  tst_tmpdir.c:317: TINFO: Using /tmp/LTP_iocSKLS9l as tmpdir (tmpfs filesystem)
  tst_device.c:99: TINFO: Found free device 0 '/dev/loop0'
  tst_test.c:1900: TINFO: LTP version: 20250130-166-g17960d952
  tst_test.c:1904: TINFO: Tested kernel: 4.5.0-00002-g22bd332f11d4 #162 SMP Thu Mar 20 18:00:10 CET 2025 x86_64
  tst_kconfig.c:88: TINFO: Parsing kernel config '/.config'
  tst_test.c:1724: TINFO: Overall timeout per run is 0h 00m 31s
  tst_supported_fs_types.c:97: TINFO: Kernel supports ext2
  tst_supported_fs_types.c:62: TINFO: mkfs.ext2 does exist
  tst_supported_fs_types.c:97: TINFO: Kernel supports ext3
  tst_supported_fs_types.c:62: TINFO: mkfs.ext3 does exist
  tst_supported_fs_types.c:97: TINFO: Kernel supports ext4
  tst_supported_fs_types.c:62: TINFO: mkfs.ext4 does exist
  tst_supported_fs_types.c:105: TINFO: Skipping bcachefs because of FUSE blacklist
  tst_supported_fs_types.c:97: TINFO: Kernel supports vfat
  tst_supported_fs_types.c:62: TINFO: mkfs.vfat does exist
  tst_supported_fs_types.c:97: TINFO: Kernel supports tmpfs
  tst_supported_fs_types.c:49: TINFO: mkfs is not needed for tmpfs

Summary:

  passed   0
  failed   0
  broken   0
  skipped  0

warnings 0

---
 lib/tst_test.c | 5 +++++
 1 file changed, 5 insertions(+)
lib/tst_test.c +0 -0
index 3823ea109..9a23cd4a0 100644

lib/tst_test.c static int run_tcases_per_fs(void) · line 1858

Quoted 4 lines
lib/tst_test.c +1 -0
@@ -1855,6 +1855,7 @@ static int run_tcases_per_fs(void)
 {
 	int ret = 0;
 	unsigned int i;
+	bool found_valid_fs = false;

nit: I would chose slightly shorter variable name (e.g. tested), but that's not important.

Thanks for sending a patch!

Kind regards,
Petr

Quoted 20 lines
lib/tst_test.c +4 -0
 	const char *const *filesystems = tst_get_supported_fs_types(tst_test->skip_filesystems);
 
 	if (!filesystems[0])
@@ -1866,6 +1867,7 @@ static int run_tcases_per_fs(void)
 		if (!fs)
 			continue;
 
+		found_valid_fs = true;
 		ret = run_tcase_on_fs(fs, filesystems[i]);
 
 		if (ret == TCONF)
@@ -1877,6 +1879,9 @@ static int run_tcases_per_fs(void)
 		do_exit(ret);
 	}
 
+	if (!found_valid_fs)
+		tst_brk(TCONF, "No required filesystems are available");
+
 	return ret;
 }
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 54 lines · Petr Vorel

Hi Li,

Quoted 1 line

Currently, when no required filesystems (filesystem[i].type) are

available,

Quoted 3 lines

the test silently does nothing, leading to a misleading test summary.

This patch adds a check to issue TCONF when no valid filesystems are

found,

Quoted 1 line

ensuring clearer test results.

Thanks!

Kind regards,
Petr

Quoted 3 lines
  # ./ioctl_ficlone03
  tst_buffers.c:57: TINFO: Test is using guarded buffers
  tst_tmpdir.c:317: TINFO: Using /tmp/LTP_iocSKLS9l as tmpdir (tmpfs

filesystem)

Quoted 3 lines

tst_device.c:99: TINFO: Found free device 0 '/dev/loop0' tst_test.c:1900: TINFO: LTP version: 20250130-166-g17960d952 tst_test.c:1904: TINFO: Tested kernel: 4.5.0-00002-g22bd332f11d4 #162

SMP Thu Mar 20 18:00:10 CET 2025 x86_64

Quoted 9 lines

tst_kconfig.c:88: TINFO: Parsing kernel config '/.config' tst_test.c:1724: TINFO: Overall timeout per run is 0h 00m 31s tst_supported_fs_types.c:97: TINFO: Kernel supports ext2 tst_supported_fs_types.c:62: TINFO: mkfs.ext2 does exist tst_supported_fs_types.c:97: TINFO: Kernel supports ext3 tst_supported_fs_types.c:62: TINFO: mkfs.ext3 does exist tst_supported_fs_types.c:97: TINFO: Kernel supports ext4 tst_supported_fs_types.c:62: TINFO: mkfs.ext4 does exist tst_supported_fs_types.c:105: TINFO: Skipping bcachefs because of FUSE

blacklist

Quoted 17 lines

tst_supported_fs_types.c:97: TINFO: Kernel supports vfat tst_supported_fs_types.c:62: TINFO: mkfs.vfat does exist tst_supported_fs_types.c:97: TINFO: Kernel supports tmpfs tst_supported_fs_types.c:49: TINFO: mkfs is not needed for tmpfs

Summary:

  passed   0
  failed   0
  broken   0
  skipped  0

warnings 0

---
 lib/tst_test.c | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 13 lines

lib/tst_test.c static int run_tcases_per_fs(void) · line 1858

Quoted 9 lines
lib/tst_test.c +1 -0
index 3823ea109..9a23cd4a0 100644
@@ -1855,6 +1855,7 @@ static int run_tcases_per_fs(void)
 {
      int ret = 0;
      unsigned int i;
+     bool found_valid_fs = false;

nit: I would chose slightly shorter variable name (e.g. tested), but that's not
important.

'found_valid_fs' is more understandable, I merged it into the original version.
Thanks for your testing and review.

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp