Skip to contentSkip to conversation

perf: annotate asm_pure_loop.S

PATCH Applied Marcus Meissner 3 participants 3 messages Mar 23, 2025 – Mar 25, 2025 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf: annotate asm_pure_loop.S

Annotate so it is built with non-executable stack.

Fixes 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2
---
 tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S +2 -0
index 75cf084a927d..577760046772 100644
@@ -26,3 +26,5 @@ skip:
 	mov	x0, #0
 	mov	x8, #93 // __NR_exit syscall
 	svc	#0
+
+.section .note.GNU-stack, "", @progbits
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Marcus Meissner

Annotate so it is built with non-executable stack.

Fixes 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2
Fixes 8b97519711c3 ("perf test: Add asm pureloop test tool")
Quoted 10 lines
---
 tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S +0 -0
index 75cf084a927d..577760046772 100644

tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S skip: · line 30

Quoted 5 lines
tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S +2 -0
@@ -26,3 +26,5 @@ skip:
 	mov	x0, #0
 	mov	x8, #93 // __NR_exit syscall
 	svc	#0
+
+.section .note.GNU-stack, "", @progbits

With the fix tag change:

I found actually Jan Stancek has submitted a similiar patch [1] ~2 years ago but we missed, sorry for that.

[1] https://lore.kernel.org/linux-perf-users/e79288922fbd0bad6facf06488735ec74f811d1b.1689588798.git.jstancek@redhat.com/