Skip to contentSkip to conversation

xfs_repair: fix wording of error message about leftover CoW blocks on the rt device

PATCH In review Darrick J. Wong 2 participants 2 messages Mar 24, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_repair: fix wording of error message about leftover CoW blocks on the rt device

From: Darrick J. Wong <[email protected]>

Fix the wording so the user knows it's the rt cow staging extents that were lost.

Fixes a9b8f0134594d0 ("xfs_repair: use realtime refcount btree data to check block types")
---
 repair/scan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
repair/scan.c +1 -1
index 86565ebb9f2faf..7d22ff378484aa 100644
@@ -2082,7 +2082,7 @@ _("invalid rt reference count %u in record %u of %s\n"),
 				case XR_E_UNKNOWN:
 				case XR_E_COW:
 					do_warn(
-_("leftover CoW rtextent (%llu)\n"),
+_("leftover rt CoW rtextent (%llu)\n"),
 						(unsigned long long)rgbno);
 					set_bmap_ext(rgno, b, len, XR_E_FREE,
 							true);
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Fix the wording so the user knows it's the rt cow staging extents that were lost.

Fixes a9b8f0134594d0 ("xfs_repair: use realtime refcount btree data to check block types")
---
 repair/scan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
repair/scan.c +0 -0
index 86565ebb9f2faf..7d22ff378484aa 100644

repair/scan.c _("invalid rt reference count %u in record %u of %s\n"), · line 2088

Quoted 8 lines
repair/scan.c +1 -1
@@ -2082,7 +2082,7 @@ _("invalid rt reference count %u in record %u of %s\n"),
 				case XR_E_UNKNOWN:
 				case XR_E_COW:
 					do_warn(
-_("leftover CoW rtextent (%llu)\n"),
+_("leftover rt CoW rtextent (%llu)\n"),
 						(unsigned long long)rgbno);
 					set_bmap_ext(rgno, b, len, XR_E_FREE,
 							true);

LGTM

Signature · 1 line
- Andrey