staging: rtl8723bs: Rename variables
PATCH v4 1/1 staging: rtl8723bs: Rename variables
Rename the variable mediaStatus to media_status and variable lpsVal to lps_val to adhere to Linux kernel coding standards by using snake_case instead of CamelCase.
Fixes checkpatch.pl warning:
CHECK: Avoid CamelCase: <mediaStatus>
CHECK: Avoid CamelCase: <lpsVal>
changes in v4:
reverted double blank line changes committed earier ensuring my patch contains uniform changes.
--- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8723bs/core/rtw_btcoex.c +6 -6
@@ -8,14 +8,14 @@#include <rtw_btcoex.h> #include <hal_btcoex.h> -void rtw_btcoex_MediaStatusNotify (struct adapter *padapter,u8 mediaStatus) +void rtw_btcoex_MediaStatusNotify (struct adapter *padapter,u8 media_status) { -if ((mediaStatus ==RT_MEDIA_CONNECT ) +if ((media_status ==RT_MEDIA_CONNECT ) && (check_fwstate (&padapter->mlmepriv,WIFI_AP_STATE ) == true)) {rtw_hal_set_hwreg (padapter,HW_VAR_DL_RSVD_PAGE ,NULL ); } -hal_btcoex_MediaStatusNotify (padapter, mediaStatus); +hal_btcoex_MediaStatusNotify (padapter, media_status); }void rtw_btcoex_HaltNotify (struct adapter *padapter)
@@ -52,14 +52,14 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)void rtw_btcoex_LPS_Enter (struct adapter *padapter) {struct pwrctrl_priv *pwrpriv; -u8 lpsVal; +u8 lps_val; pwrpriv =adapter_to_pwrctl (padapter); pwrpriv->bpower_saving = true; - lpsVal =hal_btcoex_LpsVal (padapter); -rtw_set_ps_mode (padapter,PS_MODE_MIN ,0 , lpsVal,"BTCOEX" ); + lps_val =hal_btcoex_LpsVal (padapter); +rtw_set_ps_mode (padapter,PS_MODE_MIN ,0 , lps_val,"BTCOEX" ); }void rtw_btcoex_LPS_Leave (struct adapter *padapter)
Signature · 1 line
2.43.0
Quoted 8 lines · Erick Karanja
Rename the variable
mediaStatustomedia_statusand variablelpsValtolps_valto adhere to Linux kernel coding standards by usingsnake_caseinstead of CamelCase.Fixes checkpatch.pl warning:
CHECK: Avoid CamelCase: <mediaStatus>
CHECK: Avoid CamelCase: <lpsVal>
Quoted 5 lines
Signed-off-by Erick Karanja <[email protected]>changes in v4:
reverted double blank line changes committed earier ensuring my patch contains uniform changes.
This is still the wrong place. It should go under the --- not above it. It is the text that is under the --- and before the diff that is dropped.
Also you should include the complete history.
julia
Quoted 49 lines
--- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/staging/rtl8723bs/core/rtw_btcoex.c +6
-7@@ -8,14 +8,14 @@#include <rtw_btcoex.h> #include <hal_btcoex.h> -void rtw_btcoex_MediaStatusNotify (struct adapter *padapter,u8 mediaStatus) +void rtw_btcoex_MediaStatusNotify (struct adapter *padapter,u8 media_status) { -if ((mediaStatus ==RT_MEDIA_CONNECT ) +if ((media_status ==RT_MEDIA_CONNECT ) && (check_fwstate (&padapter->mlmepriv,WIFI_AP_STATE ) == true)) {rtw_hal_set_hwreg (padapter,HW_VAR_DL_RSVD_PAGE ,NULL ); } -hal_btcoex_MediaStatusNotify (padapter, mediaStatus); +hal_btcoex_MediaStatusNotify (padapter, media_status); }void rtw_btcoex_HaltNotify (struct adapter *padapter)@@ -52,14 +52,14 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)void rtw_btcoex_LPS_Enter (struct adapter *padapter) {struct pwrctrl_priv *pwrpriv; -u8 lpsVal; +u8 lps_val; pwrpriv =adapter_to_pwrctl (padapter); pwrpriv->bpower_saving = true; - lpsVal =hal_btcoex_LpsVal (padapter); -rtw_set_ps_mode (padapter,PS_MODE_MIN ,0 , lpsVal,"BTCOEX" ); + lps_val =hal_btcoex_LpsVal (padapter); +rtw_set_ps_mode (padapter,PS_MODE_MIN ,0 , lps_val,"BTCOEX" ); }void rtw_btcoex_LPS_Leave (struct adapter *padapter) --2.43.0