Skip to contentSkip to conversation

gpio: tegra186: fix resource handling in ACPI probe path

PATCH Applied Guixin Liu 2 participants 2 messages Mar 27, 2025 – Apr 3, 2025

Subsystems (3)
Stable branch GPIO Tegra architecture support
lore
Share & tools
lore

Guixin Liu

author
#0 lore raw

PATCH v3 1/1 gpio: tegra186: fix resource handling in ACPI probe path

When the Tegra186 GPIO controller is probed through ACPI matching, the driver emits two error messages during probing:
"tegra186-gpio NVDA0508:00: invalid resource (null)" "tegra186-gpio NVDA0508:00: invalid resource (null)"

Fix this by getting resource first and then do the ioremap.

Fixes 2606e7c9f5fc ("gpio: tegra186: Add ACPI support")
Cc [email protected]
Signed-off-by Guixin Liu <[email protected]>

---
Changes from v2 to v3:
- Add "CC: stable" to commit body.

Changes from v1 to v2:
- Add "Fixes" to commit body.

 drivers/gpio/gpio-tegra186.c | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)
drivers/gpio/gpio-tegra186.c +14 -13
index 6895b65c86af..d27bfac6c9f5 100644
@@ -823,6 +823,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
 	struct gpio_irq_chip *irq;
 	struct tegra_gpio *gpio;
 	struct device_node *np;
+	struct resource *res;
 	char **names;
 	int err;
 

@@ -842,19 +843,19 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
 	gpio->num_banks++;
 
 	/* get register apertures */
-	gpio->secure = devm_platform_ioremap_resource_byname(pdev, "security");
-	if (IS_ERR(gpio->secure)) {
-		gpio->secure = devm_platform_ioremap_resource(pdev, 0);
-		if (IS_ERR(gpio->secure))
-			return PTR_ERR(gpio->secure);
-	}
-
-	gpio->base = devm_platform_ioremap_resource_byname(pdev, "gpio");
-	if (IS_ERR(gpio->base)) {
-		gpio->base = devm_platform_ioremap_resource(pdev, 1);
-		if (IS_ERR(gpio->base))
-			return PTR_ERR(gpio->base);
-	}
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "security");
+	if (!res)
+		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	gpio->secure = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(gpio->secure))
+		return PTR_ERR(gpio->secure);
+
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "gpio");
+	if (!res)
+		res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
+	gpio->base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(gpio->base))
+		return PTR_ERR(gpio->base);
 
 	err = platform_irq_count(pdev);
 	if (err < 0)
Signature · 1 line
2.43.0
Applied
#1 lore raw

From: Bartosz Golaszewski <[email protected]>

Quoted 8 lines · Guixin Liu

When the Tegra186 GPIO controller is probed through ACPI matching, the driver emits two error messages during probing:
"tegra186-gpio NVDA0508:00: invalid resource (null)" "tegra186-gpio NVDA0508:00: invalid resource (null)"

Fix this by getting resource first and then do the ioremap.

[...]

Applied, thanks!

[1/1] gpio: tegra186: fix resource handling in ACPI probe path

      commit: 380c913737edb4ec03974f653feee6cbfbb7e013

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>