Skip to contentSkip to conversation

ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT

PATCH In review Arnd Bergmann 3 participants 3 messages Mar 28, 2025 – Mar 31, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT

From: Arnd Bergmann <[email protected]>

The newly added driver fails to link without this:

ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!

Fixes 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire BPT DMA")
---
 sound/soc/sof/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/sof/intel/Kconfig +1 -0
index 41cb33fe98fb..7e92aa2f7e39 100644
@@ -351,6 +351,7 @@ endif ## SND_SOC_SOF_HDA_GENERIC
 
 config SND_SOF_SOF_HDA_SDW_BPT
 	tristate
+	select SND_HDA_EXT_CORE
 	help
 	  This option is not user-selectable but automagically handled by
 	  'select' statements at a higher level.
Signature · 1 line
2.39.5
Acked-by Bard Liao on v1 1/1
#1 lore raw
Quoted 35 lines

-----Original Message-----
From: Arnd Bergmann <[email protected]>
Sent: Friday, March 28, 2025 9:25 PM
To: Liam Girdwood <[email protected]>; Peter Ujfalusi <[email protected]>; Bard Liao <[email protected]>; Ranjani Sridharan <[email protected]>; Daniel Baluta <[email protected]>; Mark Brown <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>; Vinod Koul <[email protected]>
Cc: Arnd Bergmann <[email protected]>; Kai Vehmanen <[email protected]>; Pierre-Louis Bossart <pierre- [email protected]>; [email protected]; linux- [email protected]; [email protected]
Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT

From: Arnd Bergmann <[email protected]>

The newly added driver fails to link without this:

ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!

Quoted 3 lines
Fixes 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire

BPT DMA")

I have the same patch which is pending review/apply.
https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/
I am fine if we go with this patch.

Quoted 18 lines
---
 sound/soc/sof/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/sof/intel/Kconfig +1 -1
index 41cb33fe98fb..7e92aa2f7e39 100644
@@ -351,6 +351,7 @@ endif ## SND_SOC_SOF_HDA_GENERIC
 
 config SND_SOF_SOF_HDA_SDW_BPT
 	tristate
+	select SND_HDA_EXT_CORE
 	help
 	  This option is not user-selectable but automagically handled by
 	  'select' statements at a higher level.
--

2.39.5

#2 lore raw
Quoted 35 lines · Bard
Quoted 35 lines

-----Original Message-----
From: Arnd Bergmann <[email protected]>
Sent: Friday, March 28, 2025 9:25 PM
To: Liam Girdwood <[email protected]>; Peter Ujfalusi <[email protected]>; Bard Liao <[email protected]>; Ranjani Sridharan <[email protected]>; Daniel Baluta <[email protected]>; Mark Brown <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>; Vinod Koul <[email protected]>
Cc: Arnd Bergmann <[email protected]>; Kai Vehmanen <[email protected]>; Pierre-Louis Bossart <pierre- [email protected]>; [email protected]; linux- [email protected]; [email protected]
Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT

From: Arnd Bergmann <[email protected]>

The newly added driver fails to link without this:

ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof- intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!

Quoted 8 lines
Quoted 3 lines
Fixes 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire

BPT DMA")

I have the same patch which is pending review/apply.
https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/
I am fine if we go with this patch.

I have picked yours as that came first, thanks

Signature · 1 line
~Vinod