Skip to contentSkip to conversation

make: remove the .extradep file in libxfs on "make clean"

PATCH In review Theodore Ts'o 4 participants 6 messages Feb 19, 2025 – Mar 31, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make: remove the .extradep file in libxfs on "make clean"

Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist.

Fix this by removing .extradep (along with files like .ltdep) on a "make clean".

Fixes 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")
---
 include/buildrules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/buildrules +1 -1
index 7a139ff0..6b76abce 100644
@@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1
 include $(TOPDIR)/include/builddefs
 
 clean clobber : $(addsuffix -clean,$(SUBDIRS))
-	@rm -f $(DIRT) .ltdep .dep
+	@rm -f $(DIRT) .ltdep .dep .extradep
 	@rm -fr $(DIRDIRT)
 %-clean:
 	@echo "Cleaning $*"
Signature · 1 line
2.47.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Theodore Ts'o

Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist.

Fix this by removing .extradep (along with files like .ltdep) on a "make clean".

Fixes 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")

Oops, yeah, I forgot that. :(

--D

Quoted 20 lines
---
 include/buildrules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/buildrules +1 -1
index 7a139ff0..6b76abce 100644
@@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1
 include $(TOPDIR)/include/builddefs
 
 clean clobber : $(addsuffix -clean,$(SUBDIRS))
-	@rm -f $(DIRT) .ltdep .dep
+	@rm -f $(DIRT) .ltdep .dep .extradep
 	@rm -fr $(DIRDIRT)
 %-clean:
 	@echo "Cleaning $*"
Signature · 1 line
2.47.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Theodore Ts'o
Quoted 9 lines · Theodore Ts'o

Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist.

Fix this by removing .extradep (along with files like .ltdep) on a "make clean".

Fixes 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")

Looks good.

Quoted 21 lines
---
 include/buildrules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/buildrules +1 -2
index 7a139ff0..6b76abce 100644
@@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1
 include $(TOPDIR)/include/builddefs
 
 clean clobber : $(addsuffix -clean,$(SUBDIRS))
-	@rm -f $(DIRT) .ltdep .dep
+	@rm -f $(DIRT) .ltdep .dep .extradep
 	@rm -fr $(DIRDIRT)
 %-clean:
 	@echo "Cleaning $*"
--

2.47.2

#3 lore raw
Quoted 5 lines · Carlos Maiolino
Quoted 4 lines · Theodore Ts'o

Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist.

Quoted 8 lines
Quoted 5 lines

Fix this by removing .extradep (along with files like .ltdep) on a "make clean".

Fixes 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")

Looks good.

Looks like this hasn't yet landed in the xfsprogs repo? Is there anything that I need to do?

Thanks,

- Ted

#4 lore raw
Quoted 9 lines · Theodore Ts'o
Quoted 8 lines · Carlos Maiolino
Quoted 7 lines · Theodore Ts'o

Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist.

Fix this by removing .extradep (along with files like .ltdep) on a "make clean".

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Fixes 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")

Looks good.

Looks like this hasn't yet landed in the xfsprogs repo? Is there anything that I need to do?

Poke the maintainer [now added to the To: line], I guess. :)

--D

Quoted 3 lines

Thanks,

- Ted

#5 lore raw
Quoted 13 lines · Darrick J. Wong
Quoted 12 lines · Theodore Ts'o
Quoted 11 lines · Carlos Maiolino
Quoted 9 lines · Theodore Ts'o

Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist.

Fix this by removing .extradep (along with files like .ltdep) on a "make clean".

Fixes 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Looks good.

Looks like this hasn't yet landed in the xfsprogs repo? Is there anything that I need to do?

Poke the maintainer [now added to the To: line], I guess. :)

Thanks, missed it somehow, will include it in next for-next update.

*failed in restoring my corrupted notmuch db index recently, so this probably was it*

Signature · 1 line
- Andrey