Skip to contentSkip to conversation

perf report: Skip unsupported new event types

PATCH Superseded Chun-Tse Shao 2 participants 2 messages Mar 28, 2025 – Mar 29, 2025 perf events

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf report: Skip unsupported new event types

perf report currently halts with an error when encountering unsupported new event types (event.type >= PERF_RECORD_HEADER_MAX). This patch modifies the behavior to skip these samples and continue processing the remaining events.

---
 tools/perf/util/session.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
tools/perf/util/session.c +7 -2
index 60fb9997ea0d..d58fc1ed2fdf 100644
@@ -1639,8 +1639,13 @@ static s64 perf_session__process_event(struct perf_session *session,
 	if (session->header.needs_swap)
 		event_swap(event, evlist__sample_id_all(evlist));
 
-	if (event->header.type >= PERF_RECORD_HEADER_MAX)
-		return -EINVAL;
+	if (event->header.type >= PERF_RECORD_HEADER_MAX) {
+		/* This perf is outdated and does not support the latest event type. */
+		ui__warning("Unsupported type %u, please considering update perf.\n",
+			    event->header.type);
+		/* Skip the supported event by returning its size. */
+		return event->header.size;
+	}
 
 	events_stats__inc(&evlist->stats, event->header.type);
 
Signature · 1 line
2.49.0.472.ge94155a9ec-goog
maintainer
#1 lore raw

Hello,

Quoted 18 lines · Chun-Tse Shao

perf report currently halts with an error when encountering unsupported new event types (event.type >= PERF_RECORD_HEADER_MAX). This patch modifies the behavior to skip these samples and continue processing the remaining events.

---
 tools/perf/util/session.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
tools/perf/util/session.c +0 -0
index 60fb9997ea0d..d58fc1ed2fdf 100644
@@ -1639,8 +1639,13 @@ static s64 perf_session__process_event(struct perf_session *session,
 	if (session->header.needs_swap)

tools/perf/util/session.c static s64 perf_session__process_event(struct perf_session *session, · line 1647

Quoted 10 lines
tools/perf/util/session.c +6 -2
 		event_swap(event, evlist__sample_id_all(evlist));
 
-	if (event->header.type >= PERF_RECORD_HEADER_MAX)
-		return -EINVAL;
+	if (event->header.type >= PERF_RECORD_HEADER_MAX) {
+		/* This perf is outdated and does not support the latest event type. */
+		ui__warning("Unsupported type %u, please considering update perf.\n",
+			    event->header.type);
+		/* Skip the supported event by returning its size. */
+		return event->header.size;

Please make sure if the size is 8-byte aligned.

Thanks,
Namhyung

Quoted 7 lines
tools/perf/util/session.c +1 -0
+	}
 
 	events_stats__inc(&evlist->stats, event->header.type);
 
Signature · 1 line
2.49.0.472.ge94155a9ec-goog