netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets
Subsystems (3)
PATCH 1/1 netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets
Added IPv6 socket checks in calipso_sock_getattr, calipso_sock_setattr, and calipso_sock_delattr functions.
Return -EAFNOSUPPORT error code if the socket is not of the IPv6 type. This fix prevents the IPv6 datagram code from
incorrectly calling the IPv4 datagram code,
thereby avoiding a NULL pointer exception.
--- net/ipv6/calipso.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)
net/ipv6/calipso.c +21 -6
@@ -1072,8 +1072,13 @@ static int calipso_sock_getattr(struct sock *sk,struct ipv6_opt_hdr *hop;int opt_len, len, ret_val = -ENOMSG , offset;unsigned char *opt; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +/* Prevent IPv6 datagram code from calling IPv4 datagram code, causing pinet6 to be NULL */ +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
@@ -1125,8 +1130,13 @@ static int calipso_sock_setattr(struct sock *sk, {int ret_val;struct ipv6_opt_hdr *old, *new; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +/* Prevent IPv6 datagram code from calling IPv4 datagram code, causing pinet6 to be NULL */ +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo); old =NULL ;if (txopts) old = txopts->hopopt;
@@ -1153,8 +1163,13 @@ static int calipso_sock_setattr(struct sock *sk,static void calipso_sock_delattr (struct sock *sk) {struct ipv6_opt_hdr *new_hop; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +/* Prevent IPv6 datagram code from calling IPv4 datagram code, causing pinet6 to be NULL */ +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
--
2.34.1
Quoted 8 lines · Debin Zhu
Added IPv6 socket checks in
calipso_sock_getattr,calipso_sock_setattr, andcalipso_sock_delattrfunctions.
Return-EAFNOSUPPORTerror code if the socket is not of the IPv6 type. This fix prevents the IPv6 datagram code from
incorrectly calling the IPv4 datagram code,
thereby avoiding a NULL pointer exception.
Quoted 5 lines
Signed-off-by Debin Zhu <[email protected]>Signed-off-by Bitao Ouyang <[email protected]>--- net/ipv6/calipso.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)
Adding netdev and Jakub to the To/CC line, original lore link below:
https://lore.kernel.org/all/[email protected]/
Quoted 9 lines
net/ipv6/calipso.c +0
-1@@ -1072,8 +1072,13 @@ static int calipso_sock_getattr(struct sock *sk,struct ipv6_opt_hdr *hop;int opt_len, len, ret_val = -ENOMSG , offset;unsigned char *opt; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk));
net/ipv6/calipso.c static int calipso_sock_getattr(struct sock *sk, · line 1083
Quoted 10 lines
net/ipv6/calipso.c +7
-1- +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +/* Prevent IPv6 datagram code from calling IPv4 datagram code, causing pinet6 to be NULL */ +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
For all three function, I'd probably add a single blank line between the local variable declarations and the code below for the sake of readability. I'd probably also drop the comment as the code seems reasonably obvious (inet6_sk() can return NULL, we can't do anything with a NULL ptr so bail), but neither are reasons for not applying this patch, if anything they can be fixed up during the merge assuming the patch author agrees.
Anyway, this looks good to me, Jakub and/or other netdev folks, we should get this marked for stable and sent up to Linus, do you want to do that or should I?
Quoted 34 lines
net/ipv6/calipso.c +14
-5@@ -1125,8 +1130,13 @@ static int calipso_sock_setattr(struct sock *sk, {int ret_val;struct ipv6_opt_hdr *old, *new; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +/* Prevent IPv6 datagram code from calling IPv4 datagram code, causing pinet6 to be NULL */ +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo); old =NULL ;if (txopts) old = txopts->hopopt;@@ -1153,8 +1163,13 @@ static int calipso_sock_setattr(struct sock *sk,static void calipso_sock_delattr (struct sock *sk) {struct ipv6_opt_hdr *new_hop; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +/* Prevent IPv6 datagram code from calling IPv4 datagram code, causing pinet6 to be NULL */ +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done; --2.34.1
Signature · 1 line
paul-moore.com
Jakub Kicinski
maintainerQuoted 11 lines · On Wed, 26 Mar 2025 15:38:25 -0400 Paul Moore wrote:
For all three function, I'd probably add a single blank line between the local variable declarations and the code below for the sake of readability. I'd probably also drop the comment as the code seems reasonably obvious (
inet6_sk()can return NULL, we can't do anything with a NULL ptr so bail), but neither are reasons for not applying this patch, if anything they can be fixed up during the merge assuming the patch author agrees.Anyway, this looks good to me, Jakub and/or other netdev folks, we should get this marked for stable and sent up to Linus, do you want to do that or should I?
Thanks for the CC! Feel free to take it to Linus if you're happy with it. We don't have the posting on the list so it'd be minor pain to apply.
As you say the safety check is probably okay, tho, it's unclear from the commit message and comment how we get here with a v4 socket or perhaps not a fullsock..
Paul Moore
maintainerQuoted 9 lines · Jakub Kicinski
Quoted 8 lines · On Wed, 26 Mar 2025 15:38:25 -0400 Paul Moore wrote:
For all three function, I'd probably add a single blank line between the local variable declarations and the code below for the sake of readability. I'd probably also drop the comment as the code seems reasonably obvious (
inet6_sk()can return NULL, we can't do anything with a NULL ptr so bail), but neither are reasons for not applying this patch, if anything they can be fixed up during the merge assuming the patch author agrees.
Quoted 6 lines
Quoted 3 lines
Anyway, this looks good to me, Jakub and/or other netdev folks, we should get this marked for stable and sent up to Linus, do you want to do that or should I?
Thanks for the CC! Feel free to take it to Linus if you're happy with it. We don't have the posting on the list so it'd be minor pain to apply.
Will do. As long as it gets up to Linus somehow I'm happy.
Quoted 3 lines
As you say the safety check is probably okay, tho, it's unclear from the commit message and comment how we get here with a v4 socket or perhaps not a fullsock..
Good point about the root-cause/reproducer; there was some discussion about this issue on a separate private list and I think we lost some of the information along the way. The initial report was for the connect() case, but while looking into the problem I noticed a few instances with a similar pattern and since we're only talking about one additional NULL check during socket-level ops on a CALIPSO marked socket (nothing per-packet), I figured to err on the side of safety.
Debin Zhu and Bitao Ouyang, considering the other suggested changes to the code, would you be able to submit a second revision to the patch that incorporates the suggested changes as well as an improved patch description which includes your reproducer and notes on testing? You can send the email to the LSM <[email protected]> list while CC'ing the netdev <[email protected]> list, the SELinux <[email protected]> list, and me directly (just in case there is another issue with the mailing lists). This should also give you an opportunity to try posting to the mailing lists again ;)
Signature · 1 line
paul-moore.com
PATCH v2 1/1 netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets
Vulnerability Description:
From Linux Kernel v4.0 to the latest version,
a type confusion issue exists in the netlbl_conn_setattr function (net/netlabel/netlabel_kapi.c) within SELinux, which can lead to a local DoS attack.
When calling netlbl_conn_setattr, addr->sa_family is used to determine the function behavior. If sk is an IPv4 socket,
but the connect function is called with an IPv6 address, the function calipso_sock_setattr() is triggered. Inside this function, the following code is executed:
sk_fullsock(__sk) ? inet_sk(__sk)->pinet6 : NULL;
Since sk is an IPv4 socket, pinet6 is NULL, leading to a null pointer dereference and triggering a DoS attack.
<TASK> calipso_sock_setattr+0x4f/0x80 net/netlabel/netlabel_calipso.c:557 netlbl_conn_setattr+0x12a/0x390 net/netlabel/netlabel_kapi.c:1152 selinux_netlbl_socket_connect_helper selinux_netlbl_socket_connect_locked+0xf5/0x1d0 selinux_netlbl_socket_connect+0x22/0x40 security/selinux/netlabel.c:611 selinux_socket_connect+0x60/0x80 security/selinux/hooks.c:4923 security_socket_connect+0x71/0xb0 security/security.c:2260 __sys_connect_file+0xa4/0x190 net/socket.c:2007 __sys_connect+0x145/0x170 net/socket.c:2028 __do_sys_connect net/socket.c:2038 [inline] __se_sys_connect net/socket.c:2035 [inline] __x64_sys_connect+0x6e/0xb0 net/socket.c:2035 do_syscall_x64 arch/x86/entry/common.c:51
Affected Versions:
- Linux 4.0 - Latest Linux Kernel version
Reproduction Steps:
Use the netlabelctl tool and
run the following commands to trigger the vulnerability:
netlabelctl map del default
netlabelctl cipsov4 add pass doi:8 tags:1
netlabelctl map add default address:192.168.1.0/24 protocol:cipsov4,8 netlabelctl calipso add pass doi:7
netlabelctl map add default address:2001:db8::1/32 protocol:calipso,7
Then, execute the following PoC code:
int sockfd = socket(AF_INET, SOCK_STREAM, 0);
struct sockaddr_in6 server_addr = {0};
server_addr.sin6_family = AF_INET6;
server_addr.sin6_port = htons(8080);
const char *ipv6_str = "2001:db8::1";
inet_pton(AF_INET6, ipv6_str, &server_addr.sin6_addr);
connect(sockfd, (struct sockaddr*)&server_addr, sizeof(server_addr));Suggested Fix:
When using an IPv4 address on an IPv6 UDP/datagram socket, the operation will invoke the IPv4 datagram code through the IPv6 datagram code and execute successfully. It is necessary to check whether the pinet6 pointer returned by inet6_sk() is NULL; otherwise, unexpected issues may occur.
--- net/ipv6/calipso.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-)
net/ipv6/calipso.c +19 -4
@@ -1072,8 +1072,13 @@ static int calipso_sock_getattr(struct sock *sk,struct ipv6_opt_hdr *hop;int opt_len, len, ret_val = -ENOMSG , offset;unsigned char *opt; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
@@ -1125,8 +1130,13 @@ static int calipso_sock_setattr(struct sock *sk, {int ret_val;struct ipv6_opt_hdr *old, *new; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; + +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo); old =NULL ;if (txopts) old = txopts->hopopt;
@@ -1153,8 +1163,13 @@ static int calipso_sock_setattr(struct sock *sk,static void calipso_sock_delattr (struct sock *sk) {struct ipv6_opt_hdr *new_hop; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +if (!pinfo) +return ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
Signature · 1 line
[email protected]
Paolo Abeni
maintainerQuoted 62 lines · Debin Zhu
Vulnerability Description:
From Linux Kernel v4.0 to the latest version,
a type confusion issue exists in thenetlbl_conn_setattrfunction (net/netlabel/netlabel_kapi.c) within SELinux, which can lead to a local DoS attack.When calling
netlbl_conn_setattr,addr->sa_familyis used to determine the function behavior. Ifskis an IPv4 socket,
but theconnectfunction is called with an IPv6 address, the functioncalipso_sock_setattr()is triggered. Inside this function, the following code is executed:
sk_fullsock(__sk)? inet_sk(__sk)->pinet6 : NULL;Since
skis an IPv4 socket,pinet6isNULL, leading to a null pointer dereference and triggering a DoS attack.<TASK> calipso_sock_setattr+0x4f/0x80 net/netlabel/netlabel_calipso.c:557 netlbl_conn_setattr+0x12a/0x390 net/netlabel/netlabel_kapi.c:1152 selinux_netlbl_socket_connect_helper selinux_netlbl_socket_connect_locked+0xf5/0x1d0 selinux_netlbl_socket_connect+0x22/0x40 security/selinux/netlabel.c:611 selinux_socket_connect+0x60/0x80 security/selinux/hooks.c:4923 security_socket_connect+0x71/0xb0 security/security.c:2260 __sys_connect_file+0xa4/0x190 net/socket.c:2007 __sys_connect+0x145/0x170 net/socket.c:2028 __do_sys_connect net/socket.c:2038 [inline] __se_sys_connect net/socket.c:2035 [inline] __x64_sys_connect+0x6e/0xb0 net/socket.c:2035 do_syscall_x64 arch/x86/entry/common.c:51Affected Versions:
- Linux 4.0 - Latest Linux Kernel version
Reproduction Steps:
Use the
netlabelctltool and
run the following commands to trigger the vulnerability:netlabelctl map del default
netlabelctl cipsov4 add pass doi:8 tags:1
netlabelctl map add default address:192.168.1.0/24 protocol:cipsov4,8 netlabelctl calipso add pass doi:7
netlabelctl map add default address:2001:db8::1/32 protocol:calipso,7Then, execute the following PoC code:
int sockfd = socket(AF_INET, SOCK_STREAM, 0); struct sockaddr_in6 server_addr = {0}; server_addr.sin6_family = AF_INET6; server_addr.sin6_port = htons(8080); const char *ipv6_str = "2001:db8::1"; inet_pton(AF_INET6, ipv6_str, &server_addr.sin6_addr); connect(sockfd, (struct sockaddr*)&server_addr, sizeof(server_addr));
Quoted 8 lines
Suggested Fix:
When using an IPv4 address on an IPv6 UDP/datagram socket, the operation will invoke the IPv4 datagram code through the IPv6 datagram code and execute successfully. It is necessary to check whether the
pinet6pointer returned byinet6_sk()is NULL; otherwise, unexpected issues may occur.
The fix makes sense to me, but the commit message could use a significant rewrite, avoiding the formatting and 'splitting' it in several 'sections' with 'headers'.
The 'Affected Versions:' info is irrelevant, instead please include a suitable 'Fixes:' tag, like:
secattr.")
and Paul's ack.
Thanks,
Paolo
PATCH v3 1/1 netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets
When calling netlbl_conn_setattr(), addr->sa_family is used to determine the function behavior. If sk is an IPv4 socket, but the connect function is called with an IPv6 address, the function calipso_sock_setattr() is triggered. Inside this function, the following code is executed:
sk_fullsock(__sk) ? inet_sk(__sk)->pinet6 : NULL;
Since sk is an IPv4 socket, pinet6 is NULL, leading to a null pointer dereference.
This patch fixes the issue by checking if inet6_sk(sk) returns a NULL pointer before accessing pinet6.
--- net/ipv6/calipso.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-)
net/ipv6/calipso.c +19 -4
@@ -1072,8 +1072,13 @@ static int calipso_sock_getattr(struct sock *sk,struct ipv6_opt_hdr *hop;int opt_len, len, ret_val = -ENOMSG , offset;unsigned char *opt; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
@@ -1125,8 +1130,13 @@ static int calipso_sock_setattr(struct sock *sk, {int ret_val;struct ipv6_opt_hdr *old, *new; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; + +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo); old =NULL ;if (txopts) old = txopts->hopopt;
@@ -1153,8 +1163,13 @@ static int calipso_sock_setattr(struct sock *sk,static void calipso_sock_delattr (struct sock *sk) {struct ipv6_opt_hdr *new_hop; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +if (!pinfo) +return ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;
Signature · 1 line
2.34.1
Paul Moore
maintainerQuoted 12 lines · Debin Zhu
When calling
netlbl_conn_setattr(),addr->sa_familyis used to determine the function behavior. If sk is an IPv4 socket, but the connect function is called with an IPv6 address, the functioncalipso_sock_setattr()is triggered. Inside this function, the following code is executed:
sk_fullsock(__sk)? inet_sk(__sk)->pinet6 : NULL;Since sk is an IPv4 socket, pinet6 is NULL, leading to a null pointer dereference.
Quoted 7 lines
This patch fixes the issue by checking if
inet6_sk(sk)returns a NULL pointer before accessing pinet6.Fixes ceba1832b1b2("calipso: Set the calipso socket label to match the secattr.")Signed-off-by Debin Zhu <[email protected]>Signed-off-by Bitao Ouyang <[email protected]>Acked-by Paul Moore <[email protected]>
As a FYI in case people aren't seeing the previous messages in this thread, I did ACK an earlier version of this patch, and while there have been some changes to the code, they are largely superficial and my ACK still applies.
The commit description looks okay to me. Paolo, do you plan to take this via the netdev tree or would you like me to take this? Regardless, the patch should also be marked for stable.
Quoted 56 lines
--- net/ipv6/calipso.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-)net/ipv6/calipso.c +19
-5@@ -1072,8 +1072,13 @@ static int calipso_sock_getattr(struct sock *sk,struct ipv6_opt_hdr *hop;int opt_len, len, ret_val = -ENOMSG , offset;unsigned char *opt; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done;@@ -1125,8 +1130,13 @@ static int calipso_sock_setattr(struct sock *sk, {int ret_val;struct ipv6_opt_hdr *old, *new; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); - +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; + +if (!pinfo) +return -EAFNOSUPPORT ; + + txopts =txopt_get (pinfo); old =NULL ;if (txopts) old = txopts->hopopt;@@ -1153,8 +1163,13 @@ static int calipso_sock_setattr(struct sock *sk,static void calipso_sock_delattr (struct sock *sk) {struct ipv6_opt_hdr *new_hop; -struct ipv6_txoptions *txopts =txopt_get (inet6_sk (sk)); +struct ipv6_pinfo *pinfo =inet6_sk (sk); +struct ipv6_txoptions *txopts; +if (!pinfo) +return ; + + txopts =txopt_get (pinfo);if (!txopts || !txopts->hopopt) goto done; --2.34.1
Signature · 1 line
paul-moore.com
Simon Horman
reviewerQuoted 8 lines · Debin Zhu
When calling
netlbl_conn_setattr(),addr->sa_familyis used to determine the function behavior. If sk is an IPv4 socket, but the connect function is called with an IPv6 address, the functioncalipso_sock_setattr()is triggered. Inside this function, the following code is executed:
sk_fullsock(__sk)? inet_sk(__sk)->pinet6 : NULL;
Quoted 7 lines
Since sk is an IPv4 socket, pinet6 is NULL, leading to a null pointer dereference.
This patch fixes the issue by checking if
inet6_sk(sk)returns a NULL pointer before accessing pinet6.Fixes ceba1832b1b2("calipso: Set the calipso socket label to match the secattr.")
There is probably no need to repost for this, but
there is a missing space in the Fixes tag. It should be like this:
Quoted 3 lines
Signed-off-by Debin Zhu <[email protected]>Signed-off-by Bitao Ouyang <[email protected]>Acked-by Paul Moore <[email protected]>
...
Paul Moore
maintainerQuoted 15 lines · Simon Horman
Quoted 14 lines · Debin Zhu
When calling
netlbl_conn_setattr(),addr->sa_familyis used to determine the function behavior. If sk is an IPv4 socket, but the connect function is called with an IPv6 address, the functioncalipso_sock_setattr()is triggered. Inside this function, the following code is executed:
sk_fullsock(__sk)? inet_sk(__sk)->pinet6 : NULL;Since sk is an IPv4 socket, pinet6 is NULL, leading to a null pointer dereference.
This patch fixes the issue by checking if
inet6_sk(sk)returns a NULL pointer before accessing pinet6.
Quoted 6 lines
Quoted 1 line
Fixes ceba1832b1b2("calipso: Set the calipso socket label to match the secattr.")There is probably no need to repost for this, but
there is a missing space in the Fixes tag. It should be like this:Fixes ceba1832b1b2 ("calipso: Set the calipso socket label to match the secattr.")
Thanks.
Not sure if the netdev folks are going to pick this up or if I'll end up taking it, but if I end up taking it I'll update the tag while merging.
Quoted 3 lines
Quoted 3 lines
Signed-off-by Debin Zhu <[email protected]>Signed-off-by Bitao Ouyang <[email protected]>Acked-by Paul Moore <[email protected]>
Signature · 1 line
paul-moore.com
Jakub Kicinski
maintainerQuoted 3 lines · On Wed, 2 Apr 2025 14:28:40 -0400 Paul Moore wrote:
Not sure if the netdev folks are going to pick this up or if I'll end up taking it, but if I end up taking it I'll update the tag while merging.
Fixed and applied to net, thanks!
Hi Paul, Jakub, and all maintainers,
Thanks for your review and suggestions.
I have submitted the v2 patch and made the following improvements:
- Added a blank line between local variable declarations and the main logic for better readability.
- Removed unnecessary comments as the code is self-explanatory.
- Improved the commit message and included more detailed information, including the reproducer steps.
Many thanks to Paul for your careful guidance—you are a great teacher.
Thanks again for your feedback!
Thanks again.
Debin Zhu & Bitao Ouyang