netlink: specs: fix schema of rt_addr
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 netlink: specs: fix schema of rt_addr
The spec is mis-formatted, schema validation says:
Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']:
{'minimum': 0, 'type': 'integer'}On instance['operations']['list'][3]['dump']['request']['value']:
'58 - ifa-family'
The ifa-family clearly wants to be part of an attribute list.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- Documentation/netlink/specs/rt_addr.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/netlink/specs/rt_addr.yaml +1 -0
@@ -187,6 +187,7 @@ protonum: 0 dump: request: value: 58 + attributes: - ifa-family reply: value: 58
Signature · 1 line
2.49.0
Quoted 36 lines · Jakub Kicinski
The spec is mis-formatted, schema validation says:
Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']:
{'minimum': 0, 'type': 'integer'}On instance['operations']['list'][3]['dump']['request']['value']:
'58 - ifa-family'The ifa-family clearly wants to be part of an attribute list.
Fixes dfb0f7d9d979 ("doc/netlink: Add spec for rt addr messages")Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]--- Documentation/netlink/specs/rt_addr.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/netlink/specs/rt_addr.yaml +1
-1@@ -187,6 +187,7 @@ protonum: 0 dump: request: value: 58 + attributes: - ifa-family reply: value: 58 --2.49.0
Donald Hunter
maintainerQuoted 11 lines · Jakub Kicinski
The spec is mis-formatted, schema validation says:
Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']:
{'minimum': 0, 'type': 'integer'}On instance['operations']['list'][3]['dump']['request']['value']:
'58 - ifa-family'The ifa-family clearly wants to be part of an attribute list.
Fixes dfb0f7d9d979 ("doc/netlink: Add spec for rt addr messages")
The fixes tag looks wrong. I think it should be:
I wonder if the op name should be changed from getmaddrs to getmaddr, removing the plural to be consistent with do/dump conventions, or to getmulticast to be consistent with RTM_GETMULTICAST.
Quoted 21 lines
Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]--- Documentation/netlink/specs/rt_addr.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/netlink/specs/rt_addr.yaml +1
-0@@ -187,6 +187,7 @@ protonum: 0 dump: request: value: 58 + attributes: - ifa-family reply: value: 58
Jakub Kicinski
maintainerQuoted 1 line · On Tue, 01 Apr 2025 09:28:10 +0100 Donald Hunter wrote:
Fixes 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support")
My bad!
Quoted 3 lines
I wonder if the op name should be changed from getmaddrs to getmaddr, removing the plural to be consistent with do/dump conventions, or to getmulticast to be consistent with
RTM_GETMULTICAST.
Well spotted! I have that change queued for net-next, but you're right, we better send it as a fix, before too many people depend on it.
Signature · 1 line
pw-bot: cr