f2fs: support to disable linear lookup fallback
Chao Yu
maintainerPATCH v2 1/1 f2fs: support to disable linear lookup fallback
After commit 91b587ba79e1 ("f2fs: Introduce linear search for dentries"), f2fs forced to use linear lookup whenever a hash-based lookup fails on casefolded directory, it may affect performance for scenarios: a) create a new file w/ filename it doesn't exist in directory, b) lookup a file which may be removed.
This patch supports to disable linear lookup fallback, so, once there is a solution for commit 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points") to fix red heart unicode issue, then we can set an encodeing flag to disable the fallback for performance recovery.
The way is kept in line w/ ext4, refer to commit 9e28059d5664 ("ext4:
introduce linear search for dentries").
---
v2:
- check sb_no_casefold_compat_fallback in prior to other condition
fs/f2fs/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/f2fs/dir.c +2 -1
@@ -366,7 +366,8 @@ struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, out:#if IS_ENABLED (CONFIG_UNICODE ) -if (IS_CASEFOLDED (dir) && !de && use_hash) { +if (!sb_no_casefold_compat_fallback (dir->i_sb) && +IS_CASEFOLDED (dir) && !de && use_hash) { use_hash = false; goto start_find_entry; }
Signature · 1 line
2.49.0
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 6 lines · On Tue, 1 Apr 2025 11:58:00 +0800 you wrote:
After commit
91b587ba79e1("f2fs: Introduce linear search for dentries"), f2fs forced to use linear lookup whenever a hash-based lookup fails on casefolded directory, it may affect performance for scenarios: a) create a new file w/ filename it doesn't exist in directory, b) lookup a file which may be removed.
Quoted 6 lines
This patch supports to disable linear lookup fallback, so, once there is a solution for commit
5c26d2f1d3f5("unicode: Don't special case ignorable code points") to fix red heart unicode issue, then we can set an encodeing flag to disable the fallback for performance recovery.[...]
Here is the summary with links:
- [f2fs-dev,v2] f2fs: support to disable linear lookup fallback
https://git.kernel.org/jaegeuk/f2fs/c/51dc491a0855
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html