uio: uio_fsl_elbc_gpcm: Add NULL check in the uio_fsl_elbc_gpcm_probe()
Subsystems (2)
PATCH v3 1/1 uio: uio_fsl_elbc_gpcm: Add NULL check in the uio_fsl_elbc_gpcm_probe()
devm_kasprintf() returns NULL when memory allocation fails. Currently, uio_fsl_elbc_gpcm_probe() does not check for this case, which results in a NULL pointer dereference.
Add NULL check after devm_kasprintf() to prevent this issue and ensuring no resources are left allocated.
---
V2 -> V3: Add Cc: [email protected]
V1 -> V2: Remove printk after memory failure and add proper resource cleanup.
drivers/uio/uio_fsl_elbc_gpcm.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/uio/uio_fsl_elbc_gpcm.c +5 -0
@@ -384,6 +384,10 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev)/* set all UIO data */ info->mem[0 ].name =devm_kasprintf (&pdev->dev,GFP_KERNEL ,"%pOFn" , node); +if (!info->mem[0 ].name) { + ret = -ENOMEM ; + goto out_err3; + } info->mem[0 ].addr = res.start; info->mem[0 ].size =resource_size (&res); info->mem[0 ].memtype =UIO_MEM_PHYS ;
@@ -423,6 +427,7 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev) out_err2:if (priv->shutdown) priv->shutdown (info, true); +out_err3:iounmap (info->mem[0 ].internal_addr);return ret; }
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 45 lines · Henry Martin
devm_kasprintf()returns NULL when memory allocation fails. Currently,uio_fsl_elbc_gpcm_probe()does not check for this case, which results in a NULL pointer dereference.Add NULL check after
devm_kasprintf()to prevent this issue and ensuring no resources are left allocated.Fixes d57801c45f53 ("uio: uio_fsl_elbc_gpcm: use device-managed allocators")Signed-off-by Henry Martin <[email protected]>---
V2 -> V3: Add Cc: [email protected]
V1 -> V2: Remove printk after memory failure and add proper resource cleanup.drivers/uio/uio_fsl_elbc_gpcm.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/uio/uio_fsl_elbc_gpcm.c +5
-0@@ -384,6 +384,10 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev)/* set all UIO data */ info->mem[0 ].name =devm_kasprintf (&pdev->dev,GFP_KERNEL ,"%pOFn" , node); +if (!info->mem[0 ].name) { + ret = -ENOMEM ; + goto out_err3; + } info->mem[0 ].addr = res.start; info->mem[0 ].size =resource_size (&res); info->mem[0 ].memtype =UIO_MEM_PHYS ;@@ -423,6 +427,7 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev) out_err2:if (priv->shutdown) priv->shutdown (info, true); +out_err3:iounmap (info->mem[0 ].internal_addr);return ret; }Signature · 1 line
2.34.1
How was this tested?