x86/mm: stop prefetching the mmap semaphore on page faults
Subsystems (3)
PATCH 1/1 x86/mm: stop prefetching the mmap semaphore on page faults
The prefetchw dates back decades and the fundamental notion of doing something like this on a lock is shady.
Moreover, for few years now in the fast path faults are handled with RCU
+ per-vma locking, hopefully not even looking at the lock to begin with.
As such just remove it.
I did not see a point benchmarking this. Given that it is not expected to be looked at by default justifies not doing the prefetch.
--- arch/x86/mm/fault.c | 3 --- 1 file changed, 3 deletions(-)
arch/x86/mm/fault.c +0 -3
@@ -13,7 +13,6 @@#include <linux/mmiotrace.h> /* kmmio_handler, ... */ #include <linux/perf_event.h> /* perf_sw_event */ #include <linux/hugetlb.h> /* hstate_index_to_shift */ -#include <linux/prefetch.h> /* prefetchw */ #include <linux/context_tracking.h> /* exception_enter(), ... */ #include <linux/uaccess.h> /* faulthandler_disabled() */ #include <linux/efi.h> /* efi_crash_gracefully_on_page_fault()*/
@@ -1496,8 +1495,6 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) address =cpu_feature_enabled (X86_FEATURE_FRED ) ?fred_event_data (regs) :read_cr2 (); -prefetchw (¤t->mm->mmap_lock); -/* * KVM uses #PF vector to deliver 'page not present' events to guests * (asynchronous page fault mechanism). The event happens when a
Signature · 1 line
2.43.0
[tip: x86/mm] x86/mm: Stop prefetching current->mm->mmap_lock on page faults
The following commit has been merged into the x86/mm branch of tip:
The following commit has been merged into the x86/mm branch of tip:
Commit-ID: 0f0a9bf602449c0114117a72eab4329c9a22176d Gitweb: https://git.kernel.org/tip/0f0a9bf602449c0114117a72eab4329c9a22176d Author: Mateusz Guzik <[email protected]> AuthorDate: Tue, 01 Apr 2025 16:35:20 +02:00 Committer: Ingo Molnar <[email protected]> CommitterDate: Tue, 01 Apr 2025 20:26:35 +02:00
x86/mm: Stop prefetching current->mm->mmap_lock on page faults
The prefetchw() dates back decades and the fundamental notion of doing something like this on a lock is shady.
Moreover, for a few years now in the fast path faults are handled with RCU
+ per-vma locking, hopefully not even looking at the lock to begin with.
As such just remove it.
I did not see a point benchmarking this. Given that it is not expected to be looked at by default justifies not doing the prefetch.
--- arch/x86/mm/fault.c | 3 --- 1 file changed, 3 deletions(-)
arch/x86/mm/fault.c +0 -3
@@ -13,7 +13,6 @@#include <linux/mmiotrace.h> /* kmmio_handler, ... */ #include <linux/perf_event.h> /* perf_sw_event */ #include <linux/hugetlb.h> /* hstate_index_to_shift */ -#include <linux/prefetch.h> /* prefetchw */ #include <linux/context_tracking.h> /* exception_enter(), ... */ #include <linux/uaccess.h> /* faulthandler_disabled() */ #include <linux/efi.h> /* efi_crash_gracefully_on_page_fault()*/
@@ -1496,8 +1495,6 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) address =cpu_feature_enabled (X86_FEATURE_FRED ) ?fred_event_data (regs) :read_cr2 (); -prefetchw (¤t->mm->mmap_lock); -/* * KVM uses #PF vector to deliver 'page not present' events to guests * (asynchronous page fault mechanism). The event happens when a
[tip: x86/mm] x86/mm: Stop prefetching current->mm->mmap_lock on page faults
In reply to Mateusz GuzikThe following commit has been merged into the x86/mm branch of tip:
The following commit has been merged into the x86/mm branch of tip:
Commit-ID: 0b2695d58e800ad53e718d003310829db492a39c Gitweb: https://git.kernel.org/tip/0b2695d58e800ad53e718d003310829db492a39c Author: Mateusz Guzik <[email protected]> AuthorDate: Tue, 01 Apr 2025 16:35:20 +02:00 Committer: Ingo Molnar <[email protected]> CommitterDate: Tue, 01 Apr 2025 22:47:02 +02:00
x86/mm: Stop prefetching current->mm->mmap_lock on page faults
The prefetchw() dates back decades and the fundamental notion of doing something like this on a lock is shady.
Moreover, for a few years now in the fast path faults are handled with RCU
+ per-vma locking, hopefully not even looking at the lock to begin with.
As such just remove it.
I did not see a point benchmarking this. Given that it is not expected to be looked at by default justifies not doing the prefetch.
--- arch/x86/mm/fault.c | 3 --- 1 file changed, 3 deletions(-)
arch/x86/mm/fault.c +0 -3
@@ -13,7 +13,6 @@#include <linux/mmiotrace.h> /* kmmio_handler, ... */ #include <linux/perf_event.h> /* perf_sw_event */ #include <linux/hugetlb.h> /* hstate_index_to_shift */ -#include <linux/prefetch.h> /* prefetchw */ #include <linux/context_tracking.h> /* exception_enter(), ... */ #include <linux/uaccess.h> /* faulthandler_disabled() */ #include <linux/efi.h> /* efi_crash_gracefully_on_page_fault()*/
@@ -1496,8 +1495,6 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) address =cpu_feature_enabled (X86_FEATURE_FRED ) ?fred_event_data (regs) :read_cr2 (); -prefetchw (¤t->mm->mmap_lock); -/* * KVM uses #PF vector to deliver 'page not present' events to guests * (asynchronous page fault mechanism). The event happens when a
[tip: x86/mm] x86/mm: Stop prefetching current->mm->mmap_lock on page faults
In reply to Mateusz GuzikThe following commit has been merged into the x86/mm branch of tip:
The following commit has been merged into the x86/mm branch of tip:
Commit-ID: 1701771d3069fbee154ca48e882e227fdcfbb583 Gitweb: https://git.kernel.org/tip/1701771d3069fbee154ca48e882e227fdcfbb583 Author: Mateusz Guzik <[email protected]> AuthorDate: Tue, 01 Apr 2025 16:35:20 +02:00 Committer: Ingo Molnar <[email protected]> CommitterDate: Tue, 01 Apr 2025 22:48:56 +02:00
x86/mm: Stop prefetching current->mm->mmap_lock on page faults
The prefetchw() dates back decades and the fundamental notion of doing something like this on a lock is shady.
Moreover, for a few years now in the fast path faults are handled with RCU
+ per-vma locking, hopefully not even looking at the lock to begin with.
As such just remove it.
I did not see a point benchmarking this. Given that it is not expected to be looked at by default justifies not doing the prefetch.
--- arch/x86/mm/fault.c | 3 --- 1 file changed, 3 deletions(-)
arch/x86/mm/fault.c +0 -3
@@ -13,7 +13,6 @@#include <linux/mmiotrace.h> /* kmmio_handler, ... */ #include <linux/perf_event.h> /* perf_sw_event */ #include <linux/hugetlb.h> /* hstate_index_to_shift */ -#include <linux/prefetch.h> /* prefetchw */ #include <linux/context_tracking.h> /* exception_enter(), ... */ #include <linux/uaccess.h> /* faulthandler_disabled() */ #include <linux/efi.h> /* efi_crash_gracefully_on_page_fault()*/
@@ -1496,8 +1495,6 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) address =cpu_feature_enabled (X86_FEATURE_FRED ) ?fred_event_data (regs) :read_cr2 (); -prefetchw (¤t->mm->mmap_lock); -/* * KVM uses #PF vector to deliver 'page not present' events to guests * (asynchronous page fault mechanism). The event happens when a
Quoted 29 lines · Mateusz Guzik
The prefetchw dates back decades and the fundamental notion of doing something like this on a lock is shady.
Moreover, for few years now in the fast path faults are handled with RCU
+ per-vma locking, hopefully not even looking at the lock to begin with.As such just remove it.
I did not see a point benchmarking this. Given that it is not expected to be looked at by default justifies not doing the prefetch.
Signed-off-by Mateusz Guzik <[email protected]>--- arch/x86/mm/fault.c | 3 --- 1 file changed, 3 deletions(-)arch/x86/mm/fault.c +0
-1@@ -13,7 +13,6 @@#include <linux/mmiotrace.h> /* kmmio_handler, ... */ #include <linux/perf_event.h> /* perf_sw_event */ #include <linux/hugetlb.h> /* hstate_index_to_shift */ -#include <linux/prefetch.h> /* prefetchw */ #include <linux/context_tracking.h> /* exception_enter(), ... */ #include <linux/uaccess.h> /* faulthandler_disabled() */ #include <linux/efi.h> /* efi_crash_gracefully_on_page_fault()*/
arch/x86/mm/fault.c DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) · line 1500
Quoted 8 lines
arch/x86/mm/fault.c +0
-2@@ -1496,8 +1495,6 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) address =cpu_feature_enabled (X86_FEATURE_FRED ) ?fred_event_data (regs) :read_cr2 (); -prefetchw (¤t->mm->mmap_lock); -/* * KVM uses #PF vector to deliver 'page not present' events to guests * (asynchronous page fault mechanism). The event happens when a
I'm sure if this would have any value, we'd get notified about it :)
Signature · 3 lines
Cheers, David / dhildenb