Skip to contentSkip to conversation

KVM: x86: Add a module param for device posted IRQs

PATCH In review Sean Christopherson 1 participant 5 messages Apr 1, 2025 – Apr 25, 2025

Subsystems (3)
lore
Share & tools
lore

Sean Christopherson

author maintainer
#0 lore raw

v3 cover KVM: x86: Add a module param for device posted IRQs

Add a module param, enable_device_posted_irqs, to control and enumerate KVM support for device posted IRQs.

v3:
- Put the module param in vendor code to avoid issue with reloading vendor modules, and to match enable_apicv (and enable_ipiv in the future).
- Fix a shortlog typo. [Jim]

v2:
- https://lore.kernel.org/all/[email protected]
- Add prep patches to use kvm_arch_has_irq_bypass() in vendor code when querying support IRQ bypass, a.k.a. device posted IRQs, so as not to unexpectedly introduce a (desired) dependency on enable_apicv. [Yosry]
- Use "&=" when constraining enable_device_posted_irqs based on APICv and IOMMU posting support. [Yosry]

v1: https://lore.kernel.org/all/[email protected]

Sean Christopherson (3):
KVM: VMX: Don't send UNBLOCK when starting device assignment without
APICv
KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled
KVM: x86: Add module param to control and enumerate device posted IRQs

 arch/x86/include/asm/kvm_host.h | 1 +
 arch/x86/kvm/svm/avic.c         | 3 +--
 arch/x86/kvm/svm/svm.c          | 2 ++
 arch/x86/kvm/vmx/posted_intr.c  | 7 +++----
 arch/x86/kvm/vmx/vmx.c          | 2 ++
 arch/x86/kvm/x86.c              | 9 ++++++++-
 6 files changed, 17 insertions(+), 7 deletions(-)

base-commit: 782f9feaa9517caf33186dcdd6b50a8f770ed29b

Signature · 1 line
2.49.0.472.ge94155a9ec-goog
author maintainer
#1 lore raw

PATCH v3 1/3 KVM: VMX: Don't send UNBLOCK when starting device assignment without APICv

When starting device assignment, i.e. potential IRQ bypass, don't blast KVM_REQ_UNBLOCK if APICv is disabled/unsupported. There is no need to wake vCPUs if they can never use VT-d posted IRQs (sending UNBLOCK guards against races being vCPUs blocking and devices starting IRQ bypass).

Opportunistically use kvm_arch_has_irq_bypass() for all relevant checks in the VMX Posted Interrupt code so that all checks in KVM x86 incorporate the same information (once AMD/AVIC is given similar treatment).

---
 arch/x86/kvm/vmx/posted_intr.c | 7 +++----
 arch/x86/kvm/x86.c             | 1 +
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/kvm/vmx/posted_intr.c +3 -4
index ec08fa3caf43..16121d29dfd9 100644
@@ -134,9 +134,8 @@ void vmx_vcpu_pi_load(struct kvm_vcpu *vcpu, int cpu)
 
 static bool vmx_can_use_vtd_pi(struct kvm *kvm)
 {
-	return irqchip_in_kernel(kvm) && enable_apicv &&
-		kvm_arch_has_assigned_device(kvm) &&
-		irq_remapping_cap(IRQ_POSTING_CAP);
+	return irqchip_in_kernel(kvm) && kvm_arch_has_irq_bypass() &&
+	       kvm_arch_has_assigned_device(kvm);
 }
 
 /*
@@ -254,7 +253,7 @@ bool pi_has_pending_interrupt(struct kvm_vcpu *vcpu)
  */
 void vmx_pi_start_assignment(struct kvm *kvm)
 {
-	if (!irq_remapping_cap(IRQ_POSTING_CAP))
+	if (!kvm_arch_has_irq_bypass())
 		return;
 
 	kvm_make_all_cpus_request(kvm, KVM_REQ_UNBLOCK);
arch/x86/kvm/x86.c +1 -0
index c841817a914a..a5ea4b4c7036 100644
@@ -13556,6 +13556,7 @@ bool kvm_arch_has_irq_bypass(void)
 {
 	return enable_apicv && irq_remapping_cap(IRQ_POSTING_CAP);
 }
+EXPORT_SYMBOL_GPL(kvm_arch_has_irq_bypass);
 
 int kvm_arch_irq_bypass_add_producer(struct irq_bypass_consumer *cons,
 				      struct irq_bypass_producer *prod)
Signature · 1 line
2.49.0.472.ge94155a9ec-goog
author maintainer
#2 lore raw

PATCH v3 2/3 KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled

In reply to Sean Christopherson

Skip IRTE updates if AVIC is disabled/unsupported, as forcing the IRTE into remapped mode (kvm_vcpu_apicv_active() will never be true) is unnecessary and wasteful. The IOMMU driver is responsible for putting IRTEs into remapped mode when an IRQ is allocated by a device, long before that device is assigned to a VM. I.e. the kernel as a whole has major issues if the IRTE isn't already in remapped mode.

Opportunsitically kvm_arch_has_irq_bypass() to query for APICv/AVIC, so so that all checks in KVM x86 incorporate the same information.

---
 arch/x86/kvm/svm/avic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/x86/kvm/svm/avic.c +1 -2
index 65fd245a9953..901d8d2dc169 100644
@@ -898,8 +898,7 @@ int avic_pi_update_irte(struct kvm *kvm, unsigned int host_irq,
 	struct kvm_irq_routing_table *irq_rt;
 	int idx, ret = 0;
 
-	if (!kvm_arch_has_assigned_device(kvm) ||
-	    !irq_remapping_cap(IRQ_POSTING_CAP))
+	if (!kvm_arch_has_assigned_device(kvm) || !kvm_arch_has_irq_bypass())
 		return 0;
 
 	pr_debug("SVM: %s: host_irq=%#x, guest_irq=%#x, set=%#x\n",
Signature · 1 line
2.49.0.472.ge94155a9ec-goog
author maintainer
#3 lore raw

PATCH v3 3/3 KVM: x86: Add module param to control and enumerate device posted IRQs

In reply to Sean Christopherson

Add a module param to each KVM vendor module to allow disabling device posted interrupts without having to sacrifice all of APICv/AVIC, and to also effectively enumerate to userspace whether or not KVM may be utilizing device posted IRQs. Disabling device posted interrupts is very desirable for testing, and can even be desirable for production environments, e.g. if the host kernel wants to interpose on device interrupts.

Put the module param in kvm-{amd,intel}.ko instead of kvm.ko to match the overall APICv/AVIC controls, and to avoid complications with said controls. E.g. if the param is in kvm.ko, KVM needs to be snapshot the original user-defined value to play nice with a vendor module being reloaded with different enable_apicv settings.

---
 arch/x86/include/asm/kvm_host.h | 1 +
 arch/x86/kvm/svm/svm.c          | 2 ++
 arch/x86/kvm/vmx/vmx.c          | 2 ++
 arch/x86/kvm/x86.c              | 8 +++++++-
 4 files changed, 12 insertions(+), 1 deletion(-)
arch/x86/include/asm/kvm_host.h +1 -0
index a884ab544335..6e8be274c089 100644
@@ -1923,6 +1923,7 @@ struct kvm_arch_async_pf {
 extern u32 __read_mostly kvm_nr_uret_msrs;
 extern bool __read_mostly allow_smaller_maxphyaddr;
 extern bool __read_mostly enable_apicv;
+extern bool __read_mostly enable_device_posted_irqs;
 extern struct kvm_x86_ops kvm_x86_ops;
 
 #define kvm_x86_call(func) static_call(kvm_x86_##func)
arch/x86/kvm/svm/svm.c +2 -0
index 8abeab91d329..def76e63562d 100644
@@ -231,6 +231,8 @@ module_param(tsc_scaling, int, 0444);
 static bool avic;
 module_param(avic, bool, 0444);
 
+module_param(enable_device_posted_irqs, bool, 0444);
+
 bool __read_mostly dump_invalid_vmcb;
 module_param(dump_invalid_vmcb, bool, 0644);
 
arch/x86/kvm/vmx/vmx.c +2 -0
index b70ed72c1783..ac7f1df612e8 100644
@@ -115,6 +115,8 @@ module_param(enable_apicv, bool, 0444);
 bool __read_mostly enable_ipiv = true;
 module_param(enable_ipiv, bool, 0444);
 
+module_param(enable_device_posted_irqs, bool, 0444);
+
 /*
  * If nested=1, nested virtualization is supported, i.e., guests may use
  * VMX and be a hypervisor for its own guests. If nested=0, guests may not
arch/x86/kvm/x86.c +7 -1
index a5ea4b4c7036..9211344b20ae 100644
@@ -227,6 +227,9 @@ EXPORT_SYMBOL_GPL(allow_smaller_maxphyaddr);
 bool __read_mostly enable_apicv = true;
 EXPORT_SYMBOL_GPL(enable_apicv);
 
+bool __read_mostly enable_device_posted_irqs = true;
+EXPORT_SYMBOL_GPL(enable_device_posted_irqs);
+
 const struct _kvm_stats_desc kvm_vm_stats_desc[] = {
 	KVM_GENERIC_VM_STATS(),
 	STATS_DESC_COUNTER(VM, mmu_shadow_zapped),
@@ -9784,6 +9787,9 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops)
 	if (r != 0)
 		goto out_mmu_exit;
 
+	enable_device_posted_irqs &= enable_apicv &&
+				     irq_remapping_cap(IRQ_POSTING_CAP);
+
 	kvm_ops_update(ops);
 
 	for_each_online_cpu(cpu) {
@@ -13554,7 +13560,7 @@ EXPORT_SYMBOL_GPL(kvm_arch_has_noncoherent_dma);
 
 bool kvm_arch_has_irq_bypass(void)
 {
-	return enable_apicv && irq_remapping_cap(IRQ_POSTING_CAP);
+	return enable_device_posted_irqs;
 }
 EXPORT_SYMBOL_GPL(kvm_arch_has_irq_bypass);
 
Signature · 1 line
2.49.0.472.ge94155a9ec-goog
author maintainer
#4 lore raw
In reply to Sean Christopherson
Quoted 9 lines · Sean Christopherson

Add a module param, enable_device_posted_irqs, to control and enumerate KVM support for device posted IRQs.

v3:
- Put the module param in vendor code to avoid issue with reloading vendor modules, and to match enable_apicv (and enable_ipiv in the future).
- Fix a shortlog typo. [Jim]

[...]

Applied 1 and 3 to kvm-x86 misc (2 was grabbed by Paolo).

[1/3] KVM: VMX: Don't send UNBLOCK when starting device assignment without APICv

      commit: c364baad3e4f114284581c35d4b9006d59d2629a
[2/3] KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled
      (no commit info)
[3/3] KVM: x86: Add module param to control and enumerate device posted IRQs
      commit: 459074cff66f77af3f327e2c1f9256cdb146d798

--
https://github.com/kvm-x86/linux/tree/next