cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock
Subsystems (2)
PATCH 1/1 cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock
The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking") during cleanup accidentally changed the code to call cgroup_rstat_updated_list() without cgroup_rstat_lock which is required. Fix it.
--- kernel/cgroup/rstat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/cgroup/rstat.c +2 -1
@@ -318,10 +318,11 @@ __bpf_kfunc void cgroup_rstat_flush(struct cgroup *cgrp)might_sleep ();for_each_possible_cpu (cpu) { -struct cgroup *pos =cgroup_rstat_updated_list (cgrp, cpu); +struct cgroup *pos;/* Reacquire for each CPU to avoid disabling IRQs too long */ __cgroup_rstat_lock (cgrp, cpu); + pos =cgroup_rstat_updated_list (cgrp, cpu);for (; pos; pos = pos->rstat_flush_next) {struct cgroup_subsys_state *css;
Signature · 1 line
2.47.1
Quoted 11 lines · Shakeel Butt
The commit
093c8812de2d("cgroup: rstat: Cleanup flushing functions and locking") during cleanup accidentally changed the code to callcgroup_rstat_updated_list()withoutcgroup_rstat_lockwhich is required. Fix it.Fixes 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking")Reported-by Jakub Kicinski <[email protected]>Reported-by Breno Leitao <[email protected]>Reported-by Venkat Rao Bagalkote <[email protected]>Signed-off-by Shakeel Butt <[email protected]>
Applied to cgroup/for-6.15-fixes.
Thanks.
Signature · 1 line
tejun
Quoted 6 lines · Shakeel Butt
The commit
093c8812de2d("cgroup: rstat: Cleanup flushing functions and locking") during cleanup accidentally changed the code to callcgroup_rstat_updated_list()withoutcgroup_rstat_lockwhich is required. Fix it.
Quoted 6 lines
Fixes 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking")Reported-by Jakub Kicinski <[email protected]>Reported-by Breno Leitao <[email protected]>Reported-by Venkat Rao Bagalkote <[email protected]>Signed-off-by Shakeel Butt <[email protected]>
Thanks for fixing this.
Quoted 11 lines · Shakeel Butt
The commit
093c8812de2d("cgroup: rstat: Cleanup flushing functions and locking") during cleanup accidentally changed the code to callcgroup_rstat_updated_list()withoutcgroup_rstat_lockwhich is required. Fix it.Fixes 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking")Reported-by Jakub Kicinski <[email protected]>Reported-by Breno Leitao <[email protected]>Reported-by Venkat Rao Bagalkote <[email protected]>Signed-off-by Shakeel Butt <[email protected]>