Bluetooth: btintel_pcie: Do not generate coredump for diagnostic events
PATCH 1/1 Bluetooth: btintel_pcie: Do not generate coredump for diagnostic events
All Intel diagnostic events are part of HCI traces and there is no need to generate coredump for the same.
--- drivers/bluetooth/btintel.c | 3 +-- drivers/bluetooth/btintel.h | 6 ------ drivers/bluetooth/btintel_pcie.c | 10 ---------- 3 files changed, 1 insertion(+), 18 deletions(-)
drivers/bluetooth/btintel.c +1 -2
@@ -3688,7 +3688,7 @@ int btintel_configure_setup(struct hci_dev *hdev, const char *driver_name) }EXPORT_SYMBOL_GPL (btintel_configure_setup); -int btintel_diagnostics (struct hci_dev *hdev,struct sk_buff *skb) +static int btintel_diagnostics (struct hci_dev *hdev,struct sk_buff *skb) {struct intel_tlv *tlv = (void *)&skb->data[5 ];
@@ -3716,7 +3716,6 @@ int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb) recv_frame:return hci_recv_frame (hdev, skb); } -EXPORT_SYMBOL_GPL (btintel_diagnostics);int btintel_recv_event (struct hci_dev *hdev,struct sk_buff *skb) {
drivers/bluetooth/btintel.h +0 -6
@@ -277,7 +277,6 @@ int btintel_bootloader_setup_tlv(struct hci_dev *hdev,int btintel_shutdown_combined (struct hci_dev *hdev);void btintel_hw_error (struct hci_dev *hdev,u8 code);void btintel_print_fseq_info (struct hci_dev *hdev); -int btintel_diagnostics (struct hci_dev *hdev,struct sk_buff *skb);#else static inline int btintel_check_bdaddr (struct hci_dev *hdev)
@@ -411,9 +410,4 @@ static inline void btintel_hw_error(struct hci_dev *hdev, u8 code)static inline void btintel_print_fseq_info (struct hci_dev *hdev) { } - -static inline int btintel_diagnostics (struct hci_dev *hdev,struct sk_buff *skb) -{ -return -EOPNOTSUPP ; -}#endif
drivers/bluetooth/btintel_pcie.c +0 -10
@@ -889,7 +889,6 @@ static void btintel_pcie_msix_tx_handle(struct btintel_pcie_data *data)static int btintel_pcie_recv_event (struct hci_dev *hdev,struct sk_buff *skb) {struct hci_event_hdr *hdr = (void *)skb->data; -const char diagnostics_hdr[] = {0x87 ,0x80 ,0x03 };struct btintel_pcie_data *data =hci_get_drvdata (hdev); if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff &&
@@ -945,15 +944,6 @@ static int btintel_pcie_recv_event(struct hci_dev *hdev, struct sk_buff *skb) } } -/* Handle all diagnostics events separately. May still call -* hci_recv_frame. -*/ -if (len >=sizeof (diagnostics_hdr) && -memcmp (&skb->data[2 ], diagnostics_hdr, -sizeof (diagnostics_hdr)) ==0 ) { -return btintel_diagnostics (hdev, skb); - } -/* This is a debug event that comes from IML and OP image when it * starts execution. There is no need pass this event to stack. */
Signature · 1 line
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=949141
---Test result---
Test Summary:
CheckPatch PENDING 0.36 seconds GitLint PENDING 0.21 seconds SubjectPrefix PASS 0.09 seconds BuildKernel PASS 24.17 seconds CheckAllWarning PASS 26.69 seconds CheckSparse PASS 30.12 seconds BuildKernel32 PASS 24.67 seconds TestRunnerSetup PASS 429.33 seconds TestRunner_l2cap-tester PASS 21.09 seconds TestRunner_iso-tester PASS 28.56 seconds TestRunner_bnep-tester PASS 4.73 seconds TestRunner_mgmt-tester FAIL 120.25 seconds TestRunner_rfcomm-tester PASS 7.87 seconds TestRunner_sco-tester PASS 12.76 seconds TestRunner_ioctl-tester PASS 8.14 seconds TestRunner_mesh-tester PASS 6.03 seconds TestRunner_smp-tester PASS 7.20 seconds TestRunner_userchan-tester PASS 5.01 seconds IncrementalBuild PENDING 0.86 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
LL Privacy - Set Flags 1 (Add to RL) Failed 0.137 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 9 lines · On Wed, 2 Apr 2025 07:41:48 +0530 you wrote:
All Intel diagnostic events are part of HCI traces and there is no need to generate coredump for the same.
Signed-off-by Kiran K <[email protected]>--- drivers/bluetooth/btintel.c | 3 +-- drivers/bluetooth/btintel.h | 6 ------ drivers/bluetooth/btintel_pcie.c | 10 ---------- 3 files changed, 1 insertion(+), 18 deletions(-)
Here is the summary with links:
- [v1] Bluetooth: btintel_pcie: Do not generate coredump for diagnostic events
https://git.kernel.org/bluetooth/bluetooth-next/c/c00d13bc7c53
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html