Skip to contentSkip to conversation

ARM: at91: Remove at91sama5d3_get_ddram_size() call

PATCH Applied Alexander Shiyan 2 participants 3 messages Apr 2, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: at91: Remove at91sama5d3_get_ddram_size() call

Since all barebox sama5d3 boards now support devicetree, we can remove the separate at91sama5d3_get_ddram_size() call.

---
 arch/arm/mach-at91/ddramc.c      | 2 +-
 include/mach/at91/at91_ddrsdrc.h | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)
arch/arm/mach-at91/ddramc.c +1 -1
index 494a045249..313d0c3325 100644
@@ -31,7 +31,7 @@ void __noreturn sama5d3_barebox_entry(unsigned int r4, void *boarddata)
 {
 	__sama5d3_stashed_bootrom_r4 = r4;
 
-	barebox_arm_entry(SAMA5_DDRCS, at91sama5d3_get_ddram_size(),
+	barebox_arm_entry(SAMA5_DDRCS, sama5_ramsize(IOMEM(SAMA5D3_BASE_MPDDRC)),
 			  boarddata);
 }
 
include/mach/at91/at91_ddrsdrc.h +0 -5
index b9b0eb20b3..b344be4d1f 100644
@@ -357,11 +357,6 @@ static inline u32 at91sam9n12_get_ddram_size(void)
 	return at91_get_ddram_size(IOMEM(AT91SAM9N12_BASE_DDRSDRC0), true);
 }
 
-static inline u32 at91sama5d3_get_ddram_size(void)
-{
-	return at91_get_ddram_size(IOMEM(SAMA5D3_BASE_MPDDRC), true);
-}
-
 static inline u32 at91sama5d4_get_ddram_size(void)
 {
 	return at91_get_ddram_size(IOMEM(SAMA5D4_BASE_MPDDRC), true);
Signature · 1 line
2.39.1
#1 lore raw

PATCH 2/2 ARM: at91: sama5d3_xplained: Fix lowlevel barebox_entry() call

Let's use the sama5d3_barebox_entry() call for the sama5d3_xplained board to properly save bootstrap R4 register.

---
 arch/arm/boards/sama5d3_xplained/lowlevel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boards/sama5d3_xplained/lowlevel.c +1 -1
index d66b10fa8f..2a0fed1141 100644
@@ -59,5 +59,5 @@ SAMA5D3_ENTRY_FUNCTION(start_sama5d3_xplained, r4)
 
 	fdt = __dtb_z_at91_sama5d3_xplained_start + get_runtime_offset();
 
-	barebox_arm_entry(SAMA5_DDRCS, SZ_256M, fdt);
+	sama5d3_barebox_entry(r4, fdt);
 }
Signature · 1 line
2.39.1
Applied
#2 lore raw
In reply to Alexander Shiyan
Quoted 4 lines · Alexander Shiyan

Since all barebox sama5d3 boards now support devicetree, we can remove the separate at91sama5d3_get_ddram_size() call.

Applied, thanks!

[1/2] ARM: at91: Remove at91sama5d3_get_ddram_size() call
https://git.pengutronix.de/cgit/barebox/commit/?id=6e3417abe397 (link may not be stable)
[2/2] ARM: at91: sama5d3_xplained: Fix lowlevel barebox_entry() call
https://git.pengutronix.de/cgit/barebox/commit/?id=6442b9223a4a (link may not be stable)

Best regards,

Signature · 1 line
Sascha Hauer <[email protected]>