perf tools: Fix incorrect --user-regs comments
PATCH 1/1 perf tools: Fix incorrect --user-regs comments
The comment of "--user-regs" option is not correct, fix it.
"on interrupt," -> "on user space,"
--- tools/perf/builtin-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-record.c +1 -1
@@ -3480,7 +3480,7 @@ static struct option __record_options[] = { "sample selected machine registers on interrupt," " use '-I?' to list register names", parse_intr_regs),OPT_CALLBACK_OPTARG (0 ,"user-regs" , &record.opts.sample_user_regs,NULL ,"any register" , -"sample selected machine registers on interrupt," +"sample selected machine registers on user space," " use '--user-regs=?' to list register names" , parse_user_regs),OPT_BOOLEAN (0 ,"running-time" , &record.opts.running_time, "Record running/enabled time of read (:S) events"),
base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
Signature · 1 line
2.40.1
Quoted 4 lines · Dapeng Mi
The comment of "--user-regs" option is not correct, fix it.
"on interrupt," -> "on user space,"
nit: I think "in user space" is more grammatical.
Quoted 11 lines
Fixes 84c417422798 ("perf record: Support direct --user-regs arguments")Signed-off-by Dapeng Mi <[email protected]>--- tools/perf/builtin-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-record.c +0
-0
tools/perf/builtin-record.c static struct option __record_options[] = { · line 3483
Quoted 5 lines
tools/perf/builtin-record.c +1
-1@@ -3480,7 +3480,7 @@ static struct option __record_options[] = { "sample selected machine registers on interrupt," " use '-I?' to list register names", parse_intr_regs),OPT_CALLBACK_OPTARG (0 ,"user-regs" , &record.opts.sample_user_regs,NULL ,"any register" , - "sample selected machine registers on interrupt," + "sample selected machine registers on user space,"
nit: "sample selected machine registers in user space"
Thanks,
Ian
Quoted 8 lines
tools/perf/builtin-record.c +0
-0" use '--user-regs=?' to list register names", parse_user_regs),OPT_BOOLEAN (0 ,"running-time" , &record.opts.running_time, "Record running/enabled time of read (:S) events"),base-commit:
35d13f841a3d8159ef20d5e32a9ed3faa27875bc--
2.40.1
Quoted 5 lines · Ian Rogers
Quoted 3 lines · Dapeng Mi
The comment of "--user-regs" option is not correct, fix it.
"on interrupt," -> "on user space,"
nit: I think "in user space" is more grammatical.
Sure.
Quoted 19 lines
Quoted 12 lines
Fixes 84c417422798 ("perf record: Support direct --user-regs arguments")Signed-off-by Dapeng Mi <[email protected]>--- tools/perf/builtin-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-record.c +0
-0tools/perf/builtin-record.c static struct option __record_options[] = { · line 3483
Quoted 5 lines
tools/perf/builtin-record.c +1
-1@@ -3480,7 +3480,7 @@ static struct option __record_options[] = { "sample selected machine registers on interrupt," " use '-I?' to list register names", parse_intr_regs),OPT_CALLBACK_OPTARG (0 ,"user-regs" , &record.opts.sample_user_regs,NULL ,"any register" , - "sample selected machine registers on interrupt," + "sample selected machine registers on user space,"nit: "sample selected machine registers in user space"
Quoted 1 line
Reviewed-by Ian Rogers <[email protected]>
Sure. Thanks for reviewing.
Quoted 12 lines
Thanks,
IanQuoted 8 lines
tools/perf/builtin-record.c +0
-0" use '--user-regs=?' to list register names", parse_user_regs),OPT_BOOLEAN (0 ,"running-time" , &record.opts.running_time, "Record running/enabled time of read (:S) events"),base-commit:
35d13f841a3d8159ef20d5e32a9ed3faa27875bc--
2.40.1