X1E Asus Zenbook A14 support
Subsystems (4)
v2 cover X1E Asus Zenbook A14 support
Introduce support for the mentioned laptop.
Particular device exists in two model numbers:
* UX3407QA: X1P-42-100 or X1-26-100 (as tested)
* UX3407RA: X1E-78-100
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protected
When comparing device firmware between UX3407QA, UX3407RA, it seems that only ADSP firmware is different, CDSP and GPU firmware appears to be the same. (At least assuming the GPU firmware name in both cases is qcdxkmsuc8380.mbn). Since at least some blobs are different betweeen X1E and X1/X1P, define new firmware directory for qcom/x1p42100. This also makes it easier for distros to automatically extract firmware from Windows and place all blobs for the model under the same path. If/When firmware blobs make it to linux-firmware, same blobs can be easily symlinked between qcom/x1e80100 and qcom/x1p42100.
NVMe SSD depends on [1]. USB Type-A over USB MP controller depends on [2], or equivalent proposed solution.
Qualcomm FastConnect 6900 on UX3407QA did not work out of the box, and additionally required both newer firmware and patches to board-2.bin. I added a short how-to [3], as it is not exactly trivial.
ACPI dumps can be found on aarch64-laptops' github [4]. HWids on dtbloader's github [5].
[1] https://lore.kernel.org/linux-arm-msm/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://github.com/alexVinarskis/linux-x1e80100-zenbook-a14?tab=readme-ov-file#wcn688x-wifi
[4] https://github.com/aarch64-laptops/build/pull/134/files
[5] https://github.com/TravMurav/dtbloader/pull/4/files
Changes to v1:
* Drop PS8833 variant, fallback to PS8830 as they behave the same
* Drop wrong pcie6a_phy compatible revert
* Drop redundant comments, fix order of properties in the device-tree
* Fix device name bindings, express in model names instead of the soc
* Fix GPU firmware name for UX3407QA
* Fix model string, enclose variant in parenthesis
* Added missing new lines before 'status = "okay";'
* Updated cover letter to reflect some of the above changes
* Left SPI10 disabled as it is unknown how/what for to use it as of now Link to v1: https://lore.kernel.org/all/[email protected]/
Aleksandrs Vinarskis (3):
dt-bindings: arm: qcom: Add Asus Zenbook A14
firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14
arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
.../devicetree/bindings/arm/qcom.yaml | 2 + arch/arm64/boot/dts/qcom/Makefile | 2 + arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi | 1258 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 45 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 48 + drivers/firmware/qcom/qcom_scm.c | 2 + 6 files changed, 1357 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts
Signature · 1 line
2.45.2
PATCH v2 1/3 dt-bindings: arm: qcom: Add Asus Zenbook A14
Document the X1E-78-100 and X1P-42-100/X1-26-100 variants.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +2 -0
@@ -1133,6 +1133,7 @@ properties: - items: - enum: - asus,vivobook-s15 + - asus,zenbook-a14-ux3407ra - dell,xps13-9345 - hp,omnibook-x14 - lenovo,yoga-slim7x
@@ -1144,6 +1145,7 @@ properties: - items: - enum: + - asus,zenbook-a14-ux3407qa - qcom,x1p42100-crd - const: qcom,x1p42100
Signature · 1 line
2.45.2
Re: [PATCH v2 1/3] dt-bindings: arm: qcom: Add Asus Zenbook A14
Quoted 3 lines · Aleksandrs Vinarskis
Document the X1E-78-100 and X1P-42-100/X1-26-100 variants.
Signed-off-by Aleksandrs Vinarskis <[email protected]>
Best regards,
Krzysztof
PATCH v2 2/3 firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14
In reply to Aleksandrs VinarskisAllow particular machine accessing eg. efivars.
--- drivers/firmware/qcom/qcom_scm.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/firmware/qcom/qcom_scm.c +2 -0
@@ -1986,6 +1986,8 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send);*/ static const struct of_device_id qcom_scm_qseecom_allowlist[]__maybe_unused = { { .compatible ="asus,vivobook-s15" }, + { .compatible ="asus,zenbook-a14-ux3407qa" }, + { .compatible ="asus,zenbook-a14-ux3407ra" }, { .compatible ="dell,xps13-9345" }, { .compatible ="hp,omnibook-x14" }, { .compatible ="huawei,gaokun3" },
Signature · 1 line
2.45.2
PATCH v2 3/3 arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
In reply to Aleksandrs VinarskisInitial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protected
Working:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resume
Out of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* EC
Add dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
--- arch/arm64/boot/dts/qcom/Makefile | 2 + arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi | 1258 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 45 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 48 + 4 files changed, 1353 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts
arch/arm64/boot/dts/qcom/Makefile +2 -0
@@ -297,6 +297,7 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s-oled.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-zenbook-a14.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-omnibook-x14.dtb
@@ -304,4 +305,5 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus15.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-qcp.dtb +dtb-$(CONFIG_ARCH_QCOM) += x1p42100-asus-zenbook-a14.dtb dtb-$(CONFIG_ARCH_QCOM) += x1p42100-crd.dtb
arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi new file +1258 -0
1,258 lines not on this page · raw message
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts new file +45 -0
45 lines not on this page · raw message
arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts new file +48 -0
48 lines not on this page · raw message
Signature · 1 line
2.45.2
Re: [PATCH v2 3/3] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
Quoted 34 lines · Aleksandrs Vinarskis
Initial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWorking:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resumeOut of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* ECAdd dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
Signed-off-by Aleksandrs Vinarskis <[email protected]>---
[...]
Review
Quoted 3 lines
(quoted diff) +3
-0+ /* Left-side display-adjacent port, PS8833 */ + typec-mux@8 { + compatible = "parade,ps8830";
What Krzysztof referred to with fallback compatible is this:
Documentation/devicetree/bindings/usb/parade,ps8830.yaml +5 -2
@@ -11,8 +11,11 @@ maintainers: properties: compatible: - enum: - - parade,ps8830 + oneOf: + - items: + - const: parade,ps8833 + - const: parade,ps8830 + - const: parade,ps8830
so that in case there are any sw changes down the line, people with older DT receive the fixes, as if "parade,ps8833" is attributed to a driver, it will match (due to being the primary entry) and if it's not (like today), it will fall back to matching the next compatible (and the driver currently looks for just that)
[...]
Quoted 5 lines
(quoted diff) +5
-0+ eusb6_repeater: redriver@4f { + compatible = "nxp,ptn3222"; + reg = <0x4f>; + #phy-cells = <0>; +
Review
Quoted 10 lines
(quoted diff) +10
-0+ vdd3v3-supply = <&vreg_l13b_3p0>; + vdd1v8-supply = <&vreg_l4b_1p8>; + + reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>; + + pinctrl-0 = <&eusb6_reset_n>; + pinctrl-names = "default"; + }; + + /* EC */
It's customary to leave the i2c address to make it slightly easier for the next tinkerer ;)
[...]
Review
Quoted 9 lines
+&uart14 {
(quoted diff) +8
-0+ status = "okay"; + + bluetooth { + compatible = "qcom,wcn7850-bt"; + pinctrl-names = "default"; + pinctrl-0 = <&bt_en_default>; + enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; + max-speed = <3000000>;
You'll need to provide some supplies, coming out of a pwrseq device, see e.g. the QCP
Konrad
Re: [PATCH v2 3/3] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
Quoted 62 lines · Konrad Dybcio
Quoted 34 lines · Aleksandrs Vinarskis
Initial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWorking:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resumeOut of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* ECAdd dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
Signed-off-by Aleksandrs Vinarskis <[email protected]>---
[...]
Review
Quoted 3 lines
(quoted diff) +3
-0+ /* Left-side display-adjacent port, PS8833 */ + typec-mux@8 { + compatible = "parade,ps8830";What Krzysztof referred to with fallback compatible is this:
Documentation/devicetree/bindings/usb/parade,ps8830.yaml +5
-2@@ -11,8 +11,11 @@ maintainers: properties: compatible: - enum: - - parade,ps8830 + oneOf: + - items: + - const: parade,ps8833 + - const: parade,ps8830 + - const: parade,ps8830
Quoted 6 lines
so that in case there are any sw changes down the line, people with older DT receive the fixes, as if "parade,ps8833" is attributed to a driver, it will match (due to being the primary entry) and if it's not (like today), it will fall back to matching the next compatible (and the driver currently looks for just that)
Hi,
Thanks, was not aware of that, found it in the examples now, will update. As Krzysztof suggested to drop the patch adding compatible from driver's code, If I understand correctly I also need the following dts change, could you please confirm:
``` compatible = "parade,ps8833", "parade,ps8830"; ```
Quoted 12 lines
[...]
Quoted 10 lines
(quoted diff) +10
-0+ eusb6_repeater: redriver@4f { + compatible = "nxp,ptn3222"; + reg = <0x4f>; + #phy-cells = <0>; + + vdd3v3-supply = <&vreg_l13b_3p0>; + vdd1v8-supply = <&vreg_l4b_1p8>; + + reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>; +
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ pinctrl-0 = <&eusb6_reset_n>; + pinctrl-names = "default"; + }; + + /* EC */It's customary to leave the i2c address to make it slightly easier for the next tinkerer ;)
I am unsure about the address. There are multiple addresses showing up when discovering the bus, 0x1d, 0x5b, 0x61, 0x6a. Did a quick SMBUS analysis, they all have non-zero registers responding... My best guess right now is its 0x5b, as messing with it enabled backlight and broke the keyboard. Will add that one.
Quoted 13 lines
[...]
Review
Quoted 9 lines
+&uart14 {
(quoted diff) +8
-0+ status = "okay"; + + bluetooth { + compatible = "qcom,wcn7850-bt"; + pinctrl-names = "default"; + pinctrl-0 = <&bt_en_default>; + enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; + max-speed = <3000000>;
Quoted 3 lines
You'll need to provide some supplies, coming out of a pwrseq device, see e.g. the QCP
I assume you are referring to change like this [1]. There were some discussions on whether the supplies are modelled correctly as it seems to be different when using m.2 card, so as I was not sure about this platform I did not add it. At least in the variant that I have, the wcn6855 is soldered onboard, so I would assume so is the wcn7850 variant.
It seems that the two use quite different supplies - are the platform dependent, or only wlan card dependent? Ie. Can I just copy pwrseq for wcn6855 from a different platform?
For wcn7850's pwrseq, I can add similarly to other platforms, but cannot verify it. Should I still add it in this case?
A bit unrelated question: in the meantime I managed to bring-up the sound on Zenbook as well. Would it be more correct to wait for this series to land, and then send it separately, or is it okay to add it in directly on re-spin?
Thank you,
Alex
https://lore.kernel.org/all/[email protected]/
Quoted 1 line
Konrad
Re: [PATCH v2 3/3] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
Quoted 73 lines · Aleksandrs Vinarskis
Quoted 62 lines · Konrad Dybcio
Quoted 34 lines · Aleksandrs Vinarskis
Initial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWorking:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resumeOut of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* ECAdd dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
Signed-off-by Aleksandrs Vinarskis <[email protected]>---
[...]
Review
Quoted 3 lines
(quoted diff) +3
-0+ /* Left-side display-adjacent port, PS8833 */ + typec-mux@8 { + compatible = "parade,ps8830";What Krzysztof referred to with fallback compatible is this:
Documentation/devicetree/bindings/usb/parade,ps8830.yaml +5
-2@@ -11,8 +11,11 @@ maintainers: properties: compatible: - enum: - - parade,ps8830 + oneOf: + - items: + - const: parade,ps8833 + - const: parade,ps8830 + - const: parade,ps8830Quoted 6 lines
so that in case there are any sw changes down the line, people with older DT receive the fixes, as if "parade,ps8833" is attributed to a driver, it will match (due to being the primary entry) and if it's not (like today), it will fall back to matching the next compatible (and the driver currently looks for just that)
Hi,
Quoted 8 lines
Thanks, was not aware of that, found it in the examples now, will update. As Krzysztof suggested to drop the patch adding compatible from driver's code, If I understand correctly I also need the following dts change, could you please confirm:
``` compatible = "parade,ps8833", "parade,ps8830"; ```
Yep!
Quoted 19 lines
Quoted 10 lines
Quoted 10 lines
(quoted diff) +10
-0+ eusb6_repeater: redriver@4f { + compatible = "nxp,ptn3222"; + reg = <0x4f>; + #phy-cells = <0>; + + vdd3v3-supply = <&vreg_l13b_3p0>; + vdd1v8-supply = <&vreg_l4b_1p8>; + + reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>; +Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ pinctrl-0 = <&eusb6_reset_n>; + pinctrl-names = "default"; + }; + + /* EC */It's customary to leave the i2c address to make it slightly easier for the next tinkerer ;)
Quoted 5 lines
I am unsure about the address. There are multiple addresses showing up when discovering the bus,
0x1d,0x5b,0x61,0x6a. Did a quick SMBUS analysis, they all have non-zero registers responding... My best guess right now is its0x5b, as messing with it enabled backlight and broke the keyboard. Will add that one.
It may be that there are also some 'dumb' devices, like program-and-forget regulators or similar components, that aren't even described in your [SD]SDT
Quoted 14 lines
Quoted 10 lines
Review
Quoted 9 lines
+&uart14 {
(quoted diff) +8
-0+ status = "okay"; + + bluetooth { + compatible = "qcom,wcn7850-bt"; + pinctrl-names = "default"; + pinctrl-0 = <&bt_en_default>; + enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; + max-speed = <3000000>;Quoted 3 lines
You'll need to provide some supplies, coming out of a pwrseq device, see e.g. the QCP
Quoted 9 lines
I assume you are referring to change like this [1]. There were some discussions on whether the supplies are modelled correctly as it seems to be different when using m.2 card, so as I was not sure about this platform I did not add it. At least in the variant that I have, the wcn6855 is soldered onboard, so I would assume so is the wcn7850 variant.
It seems that the two use quite different supplies - are the platform dependent, or only wlan card dependent? Ie. Can I just copy pwrseq for wcn6855 from a different platform?
The power sequencer is a description of the hardware that's part of the same die as the wifi logic, IIUC
The inputs are most likely fixed per SoC+PMIC combo for various reasons
Quoted 2 lines
For wcn7850's pwrseq, I can add similarly to other platforms, but cannot verify it. Should I still add it in this case?
Let's not introduce it then
Quoted 4 lines
A bit unrelated question: in the meantime I managed to bring-up the sound on Zenbook as well. Would it be more correct to wait for this series to land, and then send it separately, or is it okay to add it in directly on re-spin?
Let's get what we have merged first
Konrad
Rob Herring (Arm)
maintainerQuoted 67 lines · Aleksandrs Vinarskis
Introduce support for the mentioned laptop.
Particular device exists in two model numbers:
* UX3407QA: X1P-42-100 or X1-26-100 (as tested)
* UX3407RA: X1E-78-100Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWhen comparing device firmware between UX3407QA, UX3407RA, it seems that only ADSP firmware is different, CDSP and GPU firmware appears to be the same. (At least assuming the GPU firmware name in both cases is
qcdxkmsuc8380.mbn). Since at least some blobs are different betweeen X1E and X1/X1P, define new firmware directory forqcom/x1p42100. This also makes it easier for distros to automatically extract firmware from Windows and place all blobs for the model under the same path. If/When firmware blobs make it to linux-firmware, same blobs can be easily symlinked betweenqcom/x1e80100andqcom/x1p42100.NVMe SSD depends on [1]. USB Type-A over USB MP controller depends on [2], or equivalent proposed solution.
Qualcomm FastConnect 6900 on UX3407QA did not work out of the box, and additionally required both newer firmware and patches to
board-2.bin. I added a short how-to [3], as it is not exactly trivial.ACPI dumps can be found on aarch64-laptops' github [4]. HWids on dtbloader's github [5].
[1] https://lore.kernel.org/linux-arm-msm/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://github.com/alexVinarskis/linux-x1e80100-zenbook-a14?tab=readme-ov-file#wcn688x-wifi
[4] https://github.com/aarch64-laptops/build/pull/134/files
[5] https://github.com/TravMurav/dtbloader/pull/4/filesChanges to v1:
* Drop PS8833 variant, fallback to PS8830 as they behave the same
* Drop wrongpcie6a_phycompatible revert
* Drop redundant comments, fix order of properties in the device-tree
* Fix device name bindings, express in model names instead of the soc
* Fix GPU firmware name for UX3407QA
* Fix model string, enclose variant in parenthesis
* Added missing new lines before 'status = "okay";'
* Updated cover letter to reflect some of the above changes
* Left SPI10 disabled as it is unknown how/what for to use it as of now Link to v1: https://lore.kernel.org/all/[email protected]/Aleksandrs Vinarskis (3):
dt-bindings: arm: qcom: Add Asus Zenbook A14
firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14
arm64: dts: qcom: Add support for X1-based Asus Zenbook A14.../devicetree/bindings/arm/qcom.yaml | 2 + arch/arm64/boot/dts/qcom/Makefile | 2 + arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi | 1258 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 45 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 48 + drivers/firmware/qcom/qcom_scm.c | 2 + 6 files changed, 1357 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts
Quoted 5 lines
--
2.45.2
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250401 (exact match)
If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for [email protected]:
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfacmn-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddaon-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddwlcx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddwlmx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa0p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p2-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('bt-en-sleep' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfacmn-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddaon-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddwlcx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddwlmx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddbtcmx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa0p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p2-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('bt-en-sleep' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#